TwigRenderer::render() - Code Metrics - Inspection of "View refactoring" - psiphp/content-type - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Daniel

created 2016-10-14 14:20 UTC

TwigRenderer::render() B

↳ Parent: TwigRenderer

Complexity

Conditions	4
Paths	4

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	18
nc	4
nop	1

<?php

namespace Psi\Bridge\ContentType\Twig;

use Psi\Component\ContentType\View\RendererInterface;
use Psi\Component\ContentType\View\View;

class TwigRenderer implements RendererInterface
{
    private $twig;

    public function __construct(\Twig_Environment $twig)
    {
        $this->twig = $twig;
    }

    /**
     * {@inheritdoc}
     */
    public function render(View $view)
    {
        $templateName = $view->getTemplate();
        $names = [
            $templateName,
            sprintf('%s.html.twig', $templateName),
            sprintf('%s.twig', $templateName),
        ];

        foreach ($names as $name) {
            try {
                $template = $this->twig->loadTemplate($name);
                break;
            } catch (\Twig_Error_Loader $e) {

            }
        }

        if (!$template) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            throw new \InvalidArgumentException(sprintf(
                'Could not load template "%s", tried: "%s"',
                $templateName, implode('", "', $names)
            ));
        }

        return $template->render([
            'vars' => $view->getVars(),
            'value' => $view->getValue(),
        ]);
    }
}


1			<?php
2
3			namespace Psi\Bridge\ContentType\Twig;
4
5			use Psi\Component\ContentType\View\RendererInterface;
6			use Psi\Component\ContentType\View\View;
7
8			class TwigRenderer implements RendererInterface
9			{
10			private $twig;
11
12			public function __construct(\Twig_Environment $twig)
13			{
14			$this->twig = $twig;
15			}
16
17			/**
18			* {@inheritdoc}
19			*/
20			public function render(View $view)
21			{
22			$templateName = $view->getTemplate();
23			$names = [
24			$templateName,
25			sprintf('%s.html.twig', $templateName),
26			sprintf('%s.twig', $templateName),
27			];
28
29			foreach ($names as $name) {
30			try {
31			$template = $this->twig->loadTemplate($name);
32			break;
33			} catch (\Twig_Error_Loader $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-14 14:33 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
34			}
35			}
36
37			if (!$template) {
			0 ignored issues – show Bug introduced 2016-10-14 14:33 UTC by Report Bug Copy Issue Report The variable `$template` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
38			throw new \InvalidArgumentException(sprintf(
39			'Could not load template "%s", tried: "%s"',
40			$templateName, implode('", "', $names)
41			));
42			}
43
44			return $template->render([
45			'vars' => $view->getVars(),
46			'value' => $view->getValue(),
47			]);
48			}
49			}
50

psiphp / content-type

Pull Request — master (#33)

TwigRenderer::render() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like