TwigRendererTest - Code Metrics - Inspection of "Twig templates. fixes." - psiphp/content-type - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Daniel

created 2016-10-18 14:59 UTC

TwigRendererTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	19.32 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	17
loc	88
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	17	17	1
A	testRender()	0	6	1
A	provideViews()	0	53	1

How to fix Duplicated Code

<?php

namespace Psi\Bridge\ContentType\Twig\Tests\Functional;

use Psi\Component\ContentType\Standard\View\CollectionType;
use Psi\Component\ContentType\Standard\View\NullType;
use Psi\Component\ContentType\Standard\View\ObjectType;
use Psi\Component\ContentType\Standard\View\ScalarType;
use Psi\Component\ContentType\Tests\Functional\Example\Model\Article;
use Psi\Component\ContentType\View\View;

class TwigRendererTest extends TestCase
{
    private $renderer;

    public function setUp()

    {
        $container = $this->getContainer([
            'mapping' => [
                Article::class => [
                    'alias' => 'article',
                    'fields' => [
                        'title' => [
                            'type' => 'text',
                        ],
                    ],
                ],
            ],
        ]);
        $this->renderer = $container->get('psi_content_type.view.twig.renderer');
        $this->viewFactory = $container->get('psi_content_type.view.factory');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * It should renderer a views.
     *
     * @dataProvider provideViews
     */
    public function testRender($viewType, $data, array $options, $expected)
    {
        $view = $this->viewFactory->create($viewType, $data, $options);
        $output = $this->renderer->render($view);
        $this->assertEquals($expected, $output);
    }

    public function provideViews()
    {
        $article = new Article();
        $article->title = 'Hello';

        return [
            [
                ScalarType::class,
                'hello',
                [],
                'hello',
            ],
            [
                ObjectType::class,
                $article,
                [],
                <<<'EOT'
    <div>
        Hello
    </div>

EOT
            ],
            [
                CollectionType::class,
                [
                    'hello',
                    'goodbye',
                ],
                [
                    'field_type' => 'text',
                    'field_options' => [],
                ],
                <<<'EOT'
<ul>
            <li>
            hello
        </li>
            <li>
            goodbye
        </li>
    </ul>

EOT
            ],
            [
                NullType::class,
                'nothing',
                [],
                '',
            ],
        ];
    }
}


1		<?php
2
3		namespace Psi\Bridge\ContentType\Twig\Tests\Functional;
4
5		use Psi\Component\ContentType\Standard\View\CollectionType;
6		use Psi\Component\ContentType\Standard\View\NullType;
7		use Psi\Component\ContentType\Standard\View\ObjectType;
8		use Psi\Component\ContentType\Standard\View\ScalarType;
9		use Psi\Component\ContentType\Tests\Functional\Example\Model\Article;
10		use Psi\Component\ContentType\View\View;
11
12		class TwigRendererTest extends TestCase
13		{
14		private $renderer;
15
16	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2016-10-18 15:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		$container = $this->getContainer([
19		'mapping' => [
20		Article::class => [
21		'alias' => 'article',
22		'fields' => [
23		'title' => [
24		'type' => 'text',
25		],
26		],
27		],
28		],
29		]);
30		$this->renderer = $container->get('psi_content_type.view.twig.renderer');
31		$this->viewFactory = $container->get('psi_content_type.view.factory');
		0 ignored issues – show Bug introduced 2016-10-18 15:03 UTC by Report Bug Copy Issue Report The property `viewFactory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32		}
33
34		/**
35		* It should renderer a views.
36		*
37		* @dataProvider provideViews
38		*/
39		public function testRender($viewType, $data, array $options, $expected)
40		{
41		$view = $this->viewFactory->create($viewType, $data, $options);
42		$output = $this->renderer->render($view);
43		$this->assertEquals($expected, $output);
44		}
45
46		public function provideViews()
47		{
48		$article = new Article();
49		$article->title = 'Hello';
50
51		return [
52		[
53		ScalarType::class,
54		'hello',
55		[],
56		'hello',
57		],
58		[
59		ObjectType::class,
60		$article,
61		[],
62		<<<'EOT'
63		<div>
64		Hello
65		</div>
66
67		EOT
68		],
69		[
70		CollectionType::class,
71		[
72		'hello',
73		'goodbye',
74		],
75		[
76		'field_type' => 'text',
77		'field_options' => [],
78		],
79		<<<'EOT'
80		<ul>
81		<li>
82		hello
83		</li>
84		<li>
85		goodbye
86		</li>
87		</ul>
88
89		EOT
90		],
91		[
92		NullType::class,
93		'nothing',
94		[],
95		'',
96		],
97		];
98		}
99		}
100

psiphp / content-type

Pull Request — master (#37)

TwigRendererTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like