FieldExtension::getType() - Code Metrics - psiphp/content-type - Measure and Improve Code Quality continuously with Scrutinizer

FieldExtension::getType() A
last analyzed 2017-01-01 14:12 UTC

↳ Parent: FieldExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0
cc	3
eloc	13
nc	3
nop	1

<?php

namespace Psi\Component\ContentType\Form\Extension;

use Metadata\MetadataFactoryInterface;
use Psi\Component\ContentType\FieldRegistry;
use Psi\Component\ContentType\Form\Extension\Type\SurrogateType;
use Symfony\Component\Form\AbstractExtension;

/**
 * Form type extension to provide form types for user content-type-managed
 * classes in addition to content-type component specific types.
 */
class FieldExtension extends AbstractExtension
{
    /**
     * @var MetadataFactoryInterface
     */
    private $metadataFactory;

    /**
     * @var FieldRegistry
     */
    private $fieldRegistry;

    public function __construct(
        MetadataFactoryInterface $metadataFactory,
        FieldRegistry $fieldRegistry
    ) {
        $this->metadataFactory = $metadataFactory;
        $this->fieldRegistry = $fieldRegistry;
    }

    /**
     * {@inheritdoc}
     */
    public function hasType($type)
    {
        if ($this->metadataFactory->getMetadataForClass($type)) {
            return true;
        }

        return parent::hasType($type);
    }

    /**
     * {@inheritdoc}
     */
    public function loadTypes()
    {
        return [
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function getType($type)
    {
        if (parent::hasType($type)) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            return parent::getType($type);
        }

        $metadata = $this->metadataFactory->getMetadataForClass($type);

        if (!$metadata) {
            throw new \InvalidArgumentException(sprintf(
                'The type "%s" cannot be loaded by this extension',
                $type
            ));
        }

        $surrogateType = new SurrogateType(
            $type,
            $this->fieldRegistry,
            $metadata
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        return $surrogateType;
    }
}


1			<?php
2
3			namespace Psi\Component\ContentType\Form\Extension;
4
5			use Metadata\MetadataFactoryInterface;
6			use Psi\Component\ContentType\FieldRegistry;
7			use Psi\Component\ContentType\Form\Extension\Type\SurrogateType;
8			use Symfony\Component\Form\AbstractExtension;
9
10			/**
11			* Form type extension to provide form types for user content-type-managed
12			* classes in addition to content-type component specific types.
13			*/
14			class FieldExtension extends AbstractExtension
15			{
16			/**
17			* @var MetadataFactoryInterface
18			*/
19			private $metadataFactory;
20
21			/**
22			* @var FieldRegistry
23			*/
24			private $fieldRegistry;
25
26			public function __construct(
27			MetadataFactoryInterface $metadataFactory,
28			FieldRegistry $fieldRegistry
29			) {
30			$this->metadataFactory = $metadataFactory;
31			$this->fieldRegistry = $fieldRegistry;
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37			public function hasType($type)
38			{
39			if ($this->metadataFactory->getMetadataForClass($type)) {
40			return true;
41			}
42
43			return parent::hasType($type);
44			}
45
46			/**
47			* {@inheritdoc}
48			*/
49			public function loadTypes()
50			{
51			return [
52			];
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function getType($type)
59			{
60			if (parent::hasType($type)) {
			0 ignored issues – show Comprehensibility Bug introduced 2016-10-14 14:27 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`hasType()` instead of `getType()`). Are you sure this is correct? If so, you might want to change this to `$this->hasType()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
61			return parent::getType($type);
62			}
63
64			$metadata = $this->metadataFactory->getMetadataForClass($type);
65
66			if (!$metadata) {
67			throw new \InvalidArgumentException(sprintf(
68			'The type "%s" cannot be loaded by this extension',
69			$type
70			));
71			}
72
73			$surrogateType = new SurrogateType(
74			$type,
75			$this->fieldRegistry,
76			$metadata
			0 ignored issues – show Documentation introduced 2016-10-14 14:27 UTC by Report Bug Copy Issue Report `$metadata` is of type `object<Metadata\ClassHie...MergeableClassMetadata>`, but the function expects a `object<Psi\Component\Con...Metadata\ClassMetadata>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77			);
78
79			return $surrogateType;
80			}
81			}
82

psiphp / content-type

FieldExtension::getType() A last analyzed 2017-01-01 14:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FieldExtension::getType() A
last analyzed 2017-01-01 14:12 UTC