PsiContentTypeExtension::load() - Code Metrics - psiphp/content-type-bundle - Measure and Improve Code Quality continuously with Scrutinizer

PsiContentTypeExtension::load() B
last analyzed 2017-01-01 14:12 UTC

↳ Parent: PsiContentTypeExtension

Complexity

Conditions	4
Paths	4

Size

Total Lines	34
Code Lines	22

Duplication

Lines	13
Ratio	38.24 %

Importance

Changes

Metric	Value
dl	13
loc	34
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	22
nc	4
nop	2

<?php

namespace Psi\Bundle\ContentType\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

class PsiContentTypeExtension extends Extension
{
    private $storageLoaders = [];

    public function getConfiguration(array $config, ContainerBuilder $container)
    {
        return new Configuration($this->storageLoaders);
    }

    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $loader->load('metadata.xml');
        $loader->load('form.xml');
        $loader->load('services.xml');
        $loader->load('fields.xml');
        $loader->load('storage-types.xml');
        $loader->load('views.xml');
        $loader->load('console.xml');

        $storages = $config['enabled_storage'];

        if (!$storages) {

            throw new \InvalidArgumentException(sprintf(
                'No storage drivers specified for content-type component. Specify at least one of: "%s"',
                implode('", "', array_keys($this->storageLoaders))
            ));
        }

        foreach ($storages as $storageName) {
            if (!isset($this->storageLoaders[$storageName])) {

                throw new \InvalidArgumentException(sprintf(
                    'Unknown storage "%s", known storages: "%s"',
                    $storageName,
                    implode('", "', array_keys($this->storageLoaders))
                ));
            }

            $this->storageLoaders[$storageName]->load($config['storage'][$storageName]);
        }
    }

    public function addStorageLoader($name, LoaderInterface $loader)
    {
        $this->storageLoaders[$name] = $loader;
    }

    public function getAlias()
    {
        return 'psi_content_type';
    }
}


1		<?php
2
3		namespace Psi\Bundle\ContentType\DependencyInjection;
4
5		use Symfony\Component\Config\FileLocator;
6		use Symfony\Component\DependencyInjection\ContainerBuilder;
7		use Symfony\Component\DependencyInjection\Loader;
8		use Symfony\Component\HttpKernel\DependencyInjection\Extension;
9
10		class PsiContentTypeExtension extends Extension
11		{
12		private $storageLoaders = [];
13
14		public function getConfiguration(array $config, ContainerBuilder $container)
15		{
16		return new Configuration($this->storageLoaders);
17		}
18
19		/**
20		* {@inheritdoc}
21		*/
22		public function load(array $configs, ContainerBuilder $container)
23		{
24		$config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
		0 ignored issues – show Bug introduced 2016-10-14 14:47 UTC by Report Bug Copy Issue Report It seems like `$this->getConfiguration(array(), $container)` can be `null`; however, `processConfiguration()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
25
26		$loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
27		$loader->load('metadata.xml');
28		$loader->load('form.xml');
29		$loader->load('services.xml');
30		$loader->load('fields.xml');
31		$loader->load('storage-types.xml');
32		$loader->load('views.xml');
33		$loader->load('console.xml');
34
35		$storages = $config['enabled_storage'];
36
37	View Code Duplication	if (!$storages) {
		0 ignored issues – show Duplication introduced 2016-10-14 14:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		throw new \InvalidArgumentException(sprintf(
39		'No storage drivers specified for content-type component. Specify at least one of: "%s"',
40		implode('", "', array_keys($this->storageLoaders))
41		));
42		}
43
44		foreach ($storages as $storageName) {
45	View Code Duplication	if (!isset($this->storageLoaders[$storageName])) {
		0 ignored issues – show Duplication introduced 2016-10-14 14:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		throw new \InvalidArgumentException(sprintf(
47		'Unknown storage "%s", known storages: "%s"',
48		$storageName,
49		implode('", "', array_keys($this->storageLoaders))
50		));
51		}
52
53		$this->storageLoaders[$storageName]->load($config['storage'][$storageName]);
54		}
55		}
56
57		public function addStorageLoader($name, LoaderInterface $loader)
58		{
59		$this->storageLoaders[$name] = $loader;
60		}
61
62		public function getAlias()
63		{
64		return 'psi_content_type';
65		}
66		}
67

psiphp / content-type-bundle

PsiContentTypeExtension::load() B last analyzed 2017-01-01 14:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PsiContentTypeExtension::load() B
last analyzed 2017-01-01 14:12 UTC