DtoTest::testDtoBasics() - Code Metrics - Inspection of "Merge pull request #25 from psfs/v2.0.1" - psfs/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a76412...1b7368 )

by Fran

created 2023-06-03 16:08 UTC

DtoTest::testDtoBasics() A

↳ Parent: DtoTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	64
Code Lines	51

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	51
nc	2
nop	0
dl	0
loc	64
rs	9.069
c	0
b	0
f	0

How to fix Long Method

<?php

namespace PSFS\tests\base\dto;

use PHPUnit\Framework\TestCase;
use PSFS\base\dto\Field;
use PSFS\base\dto\Form;
use PSFS\base\dto\FormAction;
use PSFS\base\dto\JsonResponse;
use PSFS\base\dto\Order;
use PSFS\base\dto\ProfilingJsonResponse;
use PSFS\tests\examples\ComplexDto;

/**
 * Class DtoTest
 * @package PSFS\tests\base\dto
 */
class DtoTest extends TestCase
{

    private function getExampleData()
    {
        return [
            'fields' => [
                ['name' => '3.hidden', 'label' => 'Hidden field', 'type' => Field::HIDDEN_TYPE, 'required' => false],
                ['name' => '4.text', 'label' => 'Text field', 'type' => Field::TEXT_TYPE, 'required' => false],
                ['name' => '2.number', 'label' => 'Number field', 'type' => Field::NUMBER_TYPE, 'required' => true],
                ['name' => '5.textarea', 'label' => 'Textarea field', 'type' => Field::TEXTAREA_TYPE, 'required' => false],
                ['name' => '6.date', 'label' => 'Date field', 'type' => Field::DATE, 'required' => false],
                ['name' => '1.test6', 'label' => 'Test 1', 'type' => Field::TEXT_TYPE, 'required' => true],
            ],
            'actions' => [
                ['label' => 'test1', 'url' => 'test1', 'method' => 'test1'],
                ['label' => 'test2', 'url' => 'test2', 'method' => 'test2'],
                ['label' => 'test3', 'url' => 'test3', 'method' => 'test3'],
            ],
            'order' => [
                'test' => Order::ASC,
                'test2' => Order::DESC,
            ],
            'boolean' => true,
            'number' => 5,
            'decimal' => 3.1415,
        ];
    }

    /**
     * Test for Form and Field Dto
     * @throws \PSFS\base\exception\GeneratorException
     * @throws \ReflectionException
     * @covers \PSFS\base\dto\Form
     * @covers \PSFS\base\dto\Field
     */
    public function testFormDto()
    {
        $form1 = new Form(true);
        $form2 = new Form();
        $this->assertEquals($form1->toArray(), $form2->toArray(), 'Error on creation for basic dto');
        $this->assertEquals($form1->actions, $form2->actions, 'Different actions in dto from scratch');
        $this->assertEquals($form1->fieldExists('test'), $form2->fieldExists('test'), 'Different check for fields that not exists');

        $field = new Field('test', 'test');
        $form1->addField($field);
        $this->assertTrue($form1->fieldExists($field->name), 'Error adding new field to a form');
        $this->assertNotEquals($form1->toArray(), $form2->toArray(), 'Bad extraction for form data');

        $reflection = new \ReflectionClass(Field::class);
        foreach ($reflection->getConstants() as $constant) {
            $this->assertNotNull(Form::fieldsOrder(['type' => $constant]));
        }
    }

    /**
     * @return void
     * @throws \ReflectionException
     * @covers \PSFS\base\dto\Form
     * @covers \PSFS\base\dto\FormAction
     * @covers \PSFS\base\dto\Field
     */
    public function testPopulatingDto()
    {
        // Populating data for more testing
        $form1 = new Form(true);
        $form2 = new Form();
        $exampleData = $this->getExampleData();
        $emptyAction = new FormAction(false);
        foreach ($exampleData['actions'] as $actionData) {
            $action = clone $emptyAction;
            $action->fromArray($actionData);
            $form1->actions[] = $action;
            $form2->actions[] = $action;
        }
        foreach ($exampleData['fields'] as $fieldData) {
            $field = new Field($fieldData['name'], $fieldData['label'], $fieldData['type']);
            $field->required = $fieldData['required'];
            $form1->addField($field);
            $form2->addField($field);
            $this->assertEquals($form1->fieldExists($field->name), $form2->fieldExists($field->name), 'Error adding new field');
        }
        $formExportData = $form1->toArray();
        $this->assertEquals($formExportData, $form2->toArray(), 'Error on export for complex dto');
        $this->assertEquals($form1->actions, $form2->actions, 'Different actions in dto with populated data');
        /**
         * Checking order
         * First required, then see into Form dto method
         * In this case, the order is before the field name --> 1.number, 6.test6, 3.hidden, 4.text, 5.textarea, 6.date
         */
        $order = ['1.test6', '2.number', '3.hidden', '4.text', '5.textarea', '6.date'];
        foreach ($order as $index => $field) {
            $this->assertEquals($field, $formExportData['fields'][$index]['name'], 'Order is not right');
        }
    }

    /**
     * Test Dto basics
     * @throws \PSFS\base\exception\GeneratorException
     * @throws \ReflectionException
     * @covers \PSFS\base\dto\Form
     * @covers \PSFS\base\dto\Order
     */
    public function testDtoBasics()
    {
        // Initialize classes to test
        $action = new FormAction(false);
        $action2 = clone $action;
        $emptyAction = clone $action;
        $order = new Order(false);
        $order2 = clone $order;
        $emptyOrder = clone $order;
        $complextDto = new ComplexDto(false);
        $complextDto2 = clone $complextDto;

        $this->assertEquals($action, $action2, 'Error cloning dtos');
        $this->assertEquals($order, $order2, 'Error cloning dtos');
        $this->assertEquals($complextDto, $complextDto2, 'Error cloning dtos');

        // Populate tests
        $exampleData = $this->getExampleData();

        // Manual creation vs hydration
        $action->fromArray($exampleData['actions'][0]);
        $action2->label = 'test1';
        $action2->url = 'test1';
        $action2->method = 'test1';
        $this->assertEquals($action, $action2, 'Different values from hydration');
        $this->assertEquals($action->toArray(), $action2->toArray(), 'Different values on export');

        $order->fromArray($exampleData['order']);
        foreach ($exampleData['order'] as $field => $ord) {
            $order2->addOrder($field, $ord);
        }
        $this->assertEquals($order, $order2, 'Different values from hydration');
        $this->assertEquals($order->toArray(), $order2->toArray(), 'Different values on export');
        $order2->removeOrder('test');
        $this->assertNotEquals($order, $order2, 'Remove field order failed in object');
        $this->assertNotEquals($order->toArray(), $order2->toArray(), 'Remove field order failed as array');

        // Multiple creation for dtos from array to create complex dto
        $action1 = clone $emptyAction;
        $action1->fromArray($exampleData['actions'][0]);
        $complextDto->actions[] = $action1;
        $action2 = clone $emptyAction;
        $action2->fromArray($exampleData['actions'][1]);
        $complextDto->actions[] = $action2;
        $action3 = clone $emptyAction;
        $action3->fromArray($exampleData['actions'][2]);
        $complextDto->actions[] = $action3;
        $emptyOrder->setOrder('test', Order::ASC);
        $this->assertCount(1, $emptyOrder->getOrders(), 'Distinct number or orders created');
        $emptyOrder->addOrder('test2', Order::DESC);
        $this->assertCount(2, $emptyOrder->getOrders(), 'Distinct number or orders added');
        $emptyOrder->addOrder('test3', Order::DESC);
        $this->assertCount(3, $emptyOrder->getOrders(), 'Distinct number or orders added');
        $emptyOrder->removeOrder('test3');
        $this->assertCount(2, $emptyOrder->getOrders(), 'Distinct number or orders removed');
        $complextDto->order = $emptyOrder;
        $complextDto->boolean = $exampleData['boolean'];
        $complextDto->number = $exampleData['number'];
        $complextDto->decimal = $exampleData['decimal'];
        // Creation from import
        $complextDto2->fromArray($exampleData);
        $this->assertEquals($complextDto->jsonSerialize(), $complextDto2->jsonSerialize(), 'Different values on export');
        $this->assertEquals($complextDto->order->jsonSerialize(), $complextDto2->order->jsonSerialize(), 'Different order values on export');
        $this->assertEquals($complextDto->__toString(), $complextDto2->__toString(), 'Different values fot toString');
    }

    /**
     * @throws \PSFS\base\exception\GeneratorException
     * @covers \PSFS\base\dto\JsonResponse
     * @covers \PSFS\base\dto\ProfilingJsonResponse
     */
    public function testJsonResponseDto()
    {
        $jsonResponse = new JsonResponse();
        $profilling = ProfilingJsonResponse::createFromPrevious($jsonResponse, ['test' => true]);
        $this->assertNotEquals($jsonResponse->toArray(), $profilling->toArray(), 'Profilling error creation');
        $this->assertEquals($jsonResponse->data, $profilling->data, 'Error creating profilling dto');
        $this->assertEquals($jsonResponse->success, $profilling->success, 'Error creating profilling dto');
        $this->assertEquals($jsonResponse->message, $profilling->message, 'Error creating profilling dto');
        $this->assertEquals($jsonResponse->total, $profilling->total, 'Error creating profilling dto');
        $this->assertEquals($jsonResponse->pages, $profilling->pages, 'Error creating profilling dto');
        $this->assertNotEmpty($profilling->profiling, 'Error creating profilling dto');
    }
}


1			<?php
2
3			namespace PSFS\tests\base\dto;
4
5			use PHPUnit\Framework\TestCase;
6			use PSFS\base\dto\Field;
7			use PSFS\base\dto\Form;
8			use PSFS\base\dto\FormAction;
9			use PSFS\base\dto\JsonResponse;
10			use PSFS\base\dto\Order;
11			use PSFS\base\dto\ProfilingJsonResponse;
12			use PSFS\tests\examples\ComplexDto;
13
14			/**
15			* Class DtoTest
16			* @package PSFS\tests\base\dto
17			*/
18			class DtoTest extends TestCase
19			{
20
21			private function getExampleData()
22			{
23			return [
24			'fields' => [
25			['name' => '3.hidden', 'label' => 'Hidden field', 'type' => Field::HIDDEN_TYPE, 'required' => false],
26			['name' => '4.text', 'label' => 'Text field', 'type' => Field::TEXT_TYPE, 'required' => false],
27			['name' => '2.number', 'label' => 'Number field', 'type' => Field::NUMBER_TYPE, 'required' => true],
28			['name' => '5.textarea', 'label' => 'Textarea field', 'type' => Field::TEXTAREA_TYPE, 'required' => false],
29			['name' => '6.date', 'label' => 'Date field', 'type' => Field::DATE, 'required' => false],
30			['name' => '1.test6', 'label' => 'Test 1', 'type' => Field::TEXT_TYPE, 'required' => true],
31			],
32			'actions' => [
33			['label' => 'test1', 'url' => 'test1', 'method' => 'test1'],
34			['label' => 'test2', 'url' => 'test2', 'method' => 'test2'],
35			['label' => 'test3', 'url' => 'test3', 'method' => 'test3'],
36			],
37			'order' => [
38			'test' => Order::ASC,
39			'test2' => Order::DESC,
40			],
41			'boolean' => true,
42			'number' => 5,
43			'decimal' => 3.1415,
44			];
45			}
46
47			/**
48			* Test for Form and Field Dto
49			* @throws \PSFS\base\exception\GeneratorException
50			* @throws \ReflectionException
51			* @covers \PSFS\base\dto\Form
52			* @covers \PSFS\base\dto\Field
53			*/
54			public function testFormDto()
55			{
56			$form1 = new Form(true);
57			$form2 = new Form();
58			$this->assertEquals($form1->toArray(), $form2->toArray(), 'Error on creation for basic dto');
59			$this->assertEquals($form1->actions, $form2->actions, 'Different actions in dto from scratch');
60			$this->assertEquals($form1->fieldExists('test'), $form2->fieldExists('test'), 'Different check for fields that not exists');
61
62			$field = new Field('test', 'test');
63			$form1->addField($field);
64			$this->assertTrue($form1->fieldExists($field->name), 'Error adding new field to a form');
65			$this->assertNotEquals($form1->toArray(), $form2->toArray(), 'Bad extraction for form data');
66
67			$reflection = new \ReflectionClass(Field::class);
68			foreach ($reflection->getConstants() as $constant) {
69			$this->assertNotNull(Form::fieldsOrder(['type' => $constant]));
70			}
71			}
72
73			/**
74			* @return void
75			* @throws \ReflectionException
76			* @covers \PSFS\base\dto\Form
77			* @covers \PSFS\base\dto\FormAction
78			* @covers \PSFS\base\dto\Field
79			*/
80			public function testPopulatingDto()
81			{
82			// Populating data for more testing
83			$form1 = new Form(true);
84			$form2 = new Form();
85			$exampleData = $this->getExampleData();
86			$emptyAction = new FormAction(false);
87			foreach ($exampleData['actions'] as $actionData) {
88			$action = clone $emptyAction;
89			$action->fromArray($actionData);
90			$form1->actions[] = $action;
91			$form2->actions[] = $action;
92			}
93			foreach ($exampleData['fields'] as $fieldData) {
94			$field = new Field($fieldData['name'], $fieldData['label'], $fieldData['type']);
95			$field->required = $fieldData['required'];
96			$form1->addField($field);
97			$form2->addField($field);
98			$this->assertEquals($form1->fieldExists($field->name), $form2->fieldExists($field->name), 'Error adding new field');
99			}
100			$formExportData = $form1->toArray();
101			$this->assertEquals($formExportData, $form2->toArray(), 'Error on export for complex dto');
102			$this->assertEquals($form1->actions, $form2->actions, 'Different actions in dto with populated data');
103			/**
104			* Checking order
105			* First required, then see into Form dto method
106			* In this case, the order is before the field name --> 1.number, 6.test6, 3.hidden, 4.text, 5.textarea, 6.date
107			*/
108			$order = ['1.test6', '2.number', '3.hidden', '4.text', '5.textarea', '6.date'];
109			foreach ($order as $index => $field) {
110			$this->assertEquals($field, $formExportData['fields'][$index]['name'], 'Order is not right');
111			}
112			}
113
114			/**
115			* Test Dto basics
116			* @throws \PSFS\base\exception\GeneratorException
117			* @throws \ReflectionException
118			* @covers \PSFS\base\dto\Form
119			* @covers \PSFS\base\dto\Order
120			*/
121			public function testDtoBasics()
122			{
123			// Initialize classes to test
124			$action = new FormAction(false);
125			$action2 = clone $action;
126			$emptyAction = clone $action;
127			$order = new Order(false);
128			$order2 = clone $order;
129			$emptyOrder = clone $order;
130			$complextDto = new ComplexDto(false);
131			$complextDto2 = clone $complextDto;
132
133			$this->assertEquals($action, $action2, 'Error cloning dtos');
134			$this->assertEquals($order, $order2, 'Error cloning dtos');
135			$this->assertEquals($complextDto, $complextDto2, 'Error cloning dtos');
136
137			// Populate tests
138			$exampleData = $this->getExampleData();
139
140			// Manual creation vs hydration
141			$action->fromArray($exampleData['actions'][0]);
142			$action2->label = 'test1';
143			$action2->url = 'test1';
144			$action2->method = 'test1';
145			$this->assertEquals($action, $action2, 'Different values from hydration');
146			$this->assertEquals($action->toArray(), $action2->toArray(), 'Different values on export');
147
148			$order->fromArray($exampleData['order']);
149			foreach ($exampleData['order'] as $field => $ord) {
150			$order2->addOrder($field, $ord);
151			}
152			$this->assertEquals($order, $order2, 'Different values from hydration');
153			$this->assertEquals($order->toArray(), $order2->toArray(), 'Different values on export');
154			$order2->removeOrder('test');
155			$this->assertNotEquals($order, $order2, 'Remove field order failed in object');
156			$this->assertNotEquals($order->toArray(), $order2->toArray(), 'Remove field order failed as array');
157
158			// Multiple creation for dtos from array to create complex dto
159			$action1 = clone $emptyAction;
160			$action1->fromArray($exampleData['actions'][0]);
161			$complextDto->actions[] = $action1;
162			$action2 = clone $emptyAction;
163			$action2->fromArray($exampleData['actions'][1]);
164			$complextDto->actions[] = $action2;
165			$action3 = clone $emptyAction;
166			$action3->fromArray($exampleData['actions'][2]);
167			$complextDto->actions[] = $action3;
168			$emptyOrder->setOrder('test', Order::ASC);
169			$this->assertCount(1, $emptyOrder->getOrders(), 'Distinct number or orders created');
170			$emptyOrder->addOrder('test2', Order::DESC);
171			$this->assertCount(2, $emptyOrder->getOrders(), 'Distinct number or orders added');
172			$emptyOrder->addOrder('test3', Order::DESC);
173			$this->assertCount(3, $emptyOrder->getOrders(), 'Distinct number or orders added');
174			$emptyOrder->removeOrder('test3');
175			$this->assertCount(2, $emptyOrder->getOrders(), 'Distinct number or orders removed');
176			$complextDto->order = $emptyOrder;
177			$complextDto->boolean = $exampleData['boolean'];
178			$complextDto->number = $exampleData['number'];
179			$complextDto->decimal = $exampleData['decimal'];
180			// Creation from import
181			$complextDto2->fromArray($exampleData);
182			$this->assertEquals($complextDto->jsonSerialize(), $complextDto2->jsonSerialize(), 'Different values on export');
183			$this->assertEquals($complextDto->order->jsonSerialize(), $complextDto2->order->jsonSerialize(), 'Different order values on export');
184			$this->assertEquals($complextDto->__toString(), $complextDto2->__toString(), 'Different values fot toString');
185			}
186
187			/**
188			* @throws \PSFS\base\exception\GeneratorException
189			* @covers \PSFS\base\dto\JsonResponse
190			* @covers \PSFS\base\dto\ProfilingJsonResponse
191			*/
192			public function testJsonResponseDto()
193			{
194			$jsonResponse = new JsonResponse();
195			$profilling = ProfilingJsonResponse::createFromPrevious($jsonResponse, ['test' => true]);
196			$this->assertNotEquals($jsonResponse->toArray(), $profilling->toArray(), 'Profilling error creation');
197			$this->assertEquals($jsonResponse->data, $profilling->data, 'Error creating profilling dto');
198			$this->assertEquals($jsonResponse->success, $profilling->success, 'Error creating profilling dto');
199			$this->assertEquals($jsonResponse->message, $profilling->message, 'Error creating profilling dto');
200			$this->assertEquals($jsonResponse->total, $profilling->total, 'Error creating profilling dto');
201			$this->assertEquals($jsonResponse->pages, $profilling->pages, 'Error creating profilling dto');
202			$this->assertNotEmpty($profilling->profiling, 'Error creating profilling dto');
203			}
204			}
205

psfs / core

Push — master ( a76412...1b7368 )

DtoTest::testDtoBasics() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like