psfs / core

src/autoload.php

Spacing +4 added lines, -4 removed lines

@@ -21,11 +21,11 @@
             $path = str_replace("\\", DIRECTORY_SEPARATOR, $class);
 
             // filepath
-            $abs_path = SOURCE_DIR . DIRECTORY_SEPARATOR . $path . ".php";
+            $abs_path = SOURCE_DIR.DIRECTORY_SEPARATOR.$path.".php";
             if (!file_exists($abs_path)) {
-                pre('→ ' . $class);
-                pre('→ ' . $path);
-                pre('→ ' . $abs_path);
+                pre('→ '.$class);
+                pre('→ '.$path);
+                pre('→ '.$abs_path);
             }
 
             // require the file

src/controller/I18nController.php

Spacing +2 added lines, -2 removed lines

@@ -38,8 +38,8 @@
         //Generating the templates translations
         $translations = $this->tpl->regenerateTemplates();
 
-        $locale_path = realpath(BASE_DIR . DIRECTORY_SEPARATOR . 'locale');
-        $locale_path .= DIRECTORY_SEPARATOR . $locale . DIRECTORY_SEPARATOR . 'LC_MESSAGES' . DIRECTORY_SEPARATOR;
+        $locale_path = realpath(BASE_DIR.DIRECTORY_SEPARATOR.'locale');
+        $locale_path .= DIRECTORY_SEPARATOR.$locale.DIRECTORY_SEPARATOR.'LC_MESSAGES'.DIRECTORY_SEPARATOR;
 
         //xgettext localizations
         $translations = array_merge($translations, GeneratorService::findTranslations(SOURCE_DIR, $locale));

Braces +3 added lines, -1 removed lines

@@ -35,7 +35,9 @@
     public function getTranslations($locale)
     {
         //Default locale
-        if (null === $locale) $locale = $this->config->get("default.language", 'es_ES');
+        if (null === $locale) {
+            $locale = $this->config->get("default.language", 'es_ES');
+        }
 
         //Generating the templates translations
         $translations = $this->tpl->regenerateTemplates();

src/base/types/helpers/ResponseHelper.php

Spacing +4 added lines, -4 removed lines

@@ -38,7 +38,7 @@ 
             unset($_SERVER["PHP_AUTH_USER"]);
             unset($_SERVER["PHP_AUTH_PW"]);
             header_remove("Authorization");
-        } else {
+        }else {
             header('Authorization:');
         }
     }
@@ -66,9 +66,9 @@ 
             Logger::log('Adding debug headers to render response');
             $vars["__DEBUG__"]["includes"] = get_included_files();
             $vars["__DEBUG__"]["trace"] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
-            header('X-PSFS-DEBUG-TS: ' . Dispatcher::getInstance()->getTs() . ' s');
-            header('X-PSFS-DEBUG-MEM: ' . Dispatcher::getInstance()->getMem('MBytes') . ' MBytes');
-            header('X-PSFS-DEBUG-FILES: ' . count(get_included_files()) . ' files opened');
+            header('X-PSFS-DEBUG-TS: '.Dispatcher::getInstance()->getTs().' s');
+            header('X-PSFS-DEBUG-MEM: '.Dispatcher::getInstance()->getMem('MBytes').' MBytes');
+            header('X-PSFS-DEBUG-FILES: '.count(get_included_files()).' files opened');
         }
 
         return $vars;

src/base/types/helpers/RouterHelper.php

Doc Comments +2 added lines, -2 removed lines

@@ -140,7 +140,7 @@ 
     /**
      * Método que extrae los parámetros de una función
      *
-     * @param array $sr
+     * @param string[] $sr
      * @param \ReflectionMethod $method
      *
      * @return array
@@ -207,7 +207,7 @@ 
      *
      * @param string $docComments
      *
-     * @return bool
+     * @return string
      */
     public static function extractReflectionCacheability($docComments)
     {

Spacing +12 added lines, -12 removed lines

@@ -22,7 +22,7 @@ 
     public static function getClassToCall($action)
     {
         Logger::log('Getting class to call for executing the request action', LOG_DEBUG, $action);
-        $actionClass = class_exists($action["class"]) ? $action["class"] : "\\" . $action["class"];
+        $actionClass = class_exists($action["class"]) ? $action["class"] : "\\".$action["class"];
         $class = (method_exists($actionClass, "getInstance")) ? $actionClass::getInstance() : new $actionClass;
         return $class;
     }
@@ -108,7 +108,7 @@ 
         $expr = preg_quote($expr, '/');
         $expr = str_replace('###', '(.*)', $expr);
         $expr2 = preg_replace('/\(\.\*\)$/', '', $expr);
-        $matched = preg_match('/^' . $expr . '\/?$/i', $path) || preg_match('/^' . $expr2 . '?$/i', $path);
+        $matched = preg_match('/^'.$expr.'\/?$/i', $path) || preg_match('/^'.$expr2.'?$/i', $path);
         return $matched;
     }
 
@@ -119,8 +119,8 @@ 
      */
     public static function extractDomainInfo(\ReflectionClass $class, $domain)
     {
-        $path = dirname($class->getFileName()) . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR;
-        $path = realpath($path) . DIRECTORY_SEPARATOR;
+        $path = dirname($class->getFileName()).DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR;
+        $path = realpath($path).DIRECTORY_SEPARATOR;
         $tpl_path = "templates";
         $public_path = "public";
         $model_path = "models";
@@ -130,13 +130,13 @@ 
             $model_path = ucfirst($model_path);
         }
         if ($class->hasConstant("TPL")) {
-            $tpl_path .= DIRECTORY_SEPARATOR . $class->getConstant("TPL");
+            $tpl_path .= DIRECTORY_SEPARATOR.$class->getConstant("TPL");
         }
         return [
             "base" => $path,
-            "template" => $path . $tpl_path,
-            "model" => $path . $model_path,
-            "public" => $path . $public_path,
+            "template" => $path.$tpl_path,
+            "model" => $path.$model_path,
+            "public" => $path.$public_path,
         ];
     }
 
@@ -159,11 +159,11 @@ 
         if (count($parameters) > 0) foreach ($parameters as $param) {
             if ($param->isOptional() && !is_array($param->getDefaultValue())) {
                 $params[$param->getName()] = $param->getDefaultValue();
-                $default = str_replace('{' . $param->getName() . '}', $param->getDefaultValue(), $regex);
-            } elseif(!$param->isOptional()) {
+                $default = str_replace('{'.$param->getName().'}', $param->getDefaultValue(), $regex);
+            } elseif (!$param->isOptional()) {
                 $requirements[] = $param->getName();
             }
-        } else $default = $regex;
+        }else $default = $regex;
 
         return [$regex, $default, $params, $requirements];
     }
@@ -243,7 +243,7 @@ 
             $default = str_replace('{__DOMAIN__}', $module, $default);
             $httpMethod = RouterHelper::extractReflectionHttpMethod($docComments);
             $label = RouterHelper::extractReflectionLabel(str_replace('{__API__}', $api, $docComments));
-            $route = $httpMethod . "#|#" . $regex;
+            $route = $httpMethod."#|#".$regex;
             $route = preg_replace('/(\\r|\\f|\\t|\\n)/', '', $route);
             $info = [
                 "method" => $method->getName(),

Braces +9 added lines, -3 removed lines

@@ -59,8 +59,10 @@ 
         $_route = explode("/", $url['path']);
         $_pattern = explode("/", $pattern);
         $get = array();
-        if (!empty($_pattern)) foreach ($_pattern as $index => $component) {
+        if (!empty($_pattern)) {
+            foreach ($_pattern as $index => $component) {
             $_get = array();
+        }
             preg_match_all('/^\{(.*)\}$/i', $component, $_get);
             if (!empty($_get[1]) && isset($_route[$index])) {
                 $get[array_pop($_get[1])] = $_route[$index];
@@ -156,14 +158,18 @@ 
         $parameters = $method->getParameters();
         $requirements = [];
         /** @var \ReflectionParameter $param */
-        if (count($parameters) > 0) foreach ($parameters as $param) {
+        if (count($parameters) > 0) {
+            foreach ($parameters as $param) {
             if ($param->isOptional() && !is_array($param->getDefaultValue())) {
                 $params[$param->getName()] = $param->getDefaultValue();
+        }
                 $default = str_replace('{' . $param->getName() . '}', $param->getDefaultValue(), $regex);
             } elseif(!$param->isOptional()) {
                 $requirements[] = $param->getName();
             }
-        } else $default = $regex;
+        } else {
+            $default = $regex;
+        }
 
         return [$regex, $default, $params, $requirements];
     }

src/controller/ConfigController.php

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * @route /admin/config/params
      * @label Parámetros de configuración de PSGS
      * @visible false
-     * @return mixed
+     * @return string|null
      */
     public function getConfigParams()
     {

Spacing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
         foreach ($domains as $domain => $routes) {
             $pDomain = str_replace('@', '', $domain);
             $pDomain = str_replace('/', '', $pDomain);
-            $response[] = strtolower($pDomain) . '.api.secret';
+            $response[] = strtolower($pDomain).'.api.secret';
         }
         return $this->json($response);
     }
@@ -45,7 +45,7 @@ 
      */
     public function config()
     {
-        Logger::log("Config loaded executed by " . $this->getRequest()->getRequestUri());
+        Logger::log("Config loaded executed by ".$this->getRequest()->getRequestUri());
         /* @var $form \PSFS\base\config\ConfigForm */
         $form = new ConfigForm(Router::getInstance()->getRoute('admin-config'), Config::$required, Config::$optional, Config::getInstance()->dumpConfig());
         $form->build();
@@ -82,7 +82,7 @@ 
                 }
                 Security::getInstance()->setFlash("callback_message", _("Configuración actualizada correctamente"));
                 Security::getInstance()->setFlash("callback_route", $this->getRoute("admin-config", true));
-            } else {
+            }else {
                 throw new \HttpException(_('Error al guardar la configuración, prueba a cambiar los permisos'), 403);
             }
         }

src/controller/RouteController.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
      * @route /admin/routes/show
      * @label Servicio de rutas del sistema
      * @visible false
-     * @return mixed
+     * @return string|null
      */
     public function getRouting()
     {

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
             $router->simpatize();
             Security::getInstance()->setFlash("callback_message", _("Rutas generadas correctamente"));
             Security::getInstance()->setFlash("callback_route", $this->getRoute("admin-routes", true));
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             Logger::log($e->getMessage(), LOG_ERR);
             Security::getInstance()->setFlash("callback_message", _("Algo no ha salido bien, revisa los logs"));
             Security::getInstance()->setFlash("callback_route", $this->getRoute("admin-routes", true));

src/controller/UserController.php

Spacing +4 added lines, -4 removed lines

@@ -63,7 +63,7 @@ 
                 Logger::log('Configuration saved successful');
                 Security::getInstance()->setFlash("callback_message", _("Usuario agregado correctamente"));
                 Security::getInstance()->setFlash("callback_route", Router::getInstance()->getRoute("admin", true));
-            } else {
+            }else {
                 throw new ConfigException(_('Error al guardar los administradores, prueba a cambiar los permisos'));
             }
         }
@@ -99,7 +99,7 @@ 
     {
         if ($this->isAdmin()) {
             return $this->redirect('admin');
-        } else {
+        }else {
             return Admin::staticAdminLogon($route);
         }
     }
@@ -131,7 +131,7 @@ 
                 $cookies = array(
                     array(
                         "name" => Security::getInstance()->getHash(),
-                        "value" => base64_encode($form->getFieldValue("user") . ":" . $form->getFieldValue("pass")),
+                        "value" => base64_encode($form->getFieldValue("user").":".$form->getFieldValue("pass")),
                         "expire" => time() + 3600,
                         "http" => true,
                     )
@@ -142,7 +142,7 @@ 
                     'status_message' => _("Acceso permitido... redirigiendo!!"),
                     'delay' => 1,
                 );
-            } else {
+            }else {
                 $form->setError("user", _("El usuario no tiene acceso a la web"));
             }
         }

src/controller/base/Admin.php

Spacing +3 added lines, -3 removed lines

@@ -48,10 +48,10 @@ 
      */
     public static function staticAdminLogon($route = null)
     {
-        if (file_exists(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json')) {
+        if (file_exists(CONFIG_DIR.DIRECTORY_SEPARATOR.'admins.json')) {
             if ('login' !== Config::getInstance()->get('admin_login')) {
                 return AdminServices::getInstance()->setAdminHeaders();
-            } else {
+            }else {
                 $form = new LoginForm();
                 $form->setData(array("route" => $route));
                 $form->build();
@@ -61,7 +61,7 @@ 
                     'form' => $form,
                 ));
             }
-        } else {
+        }else {
             return UserController::showAdminManager();
         }
     }

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use PSFS\base\config\Config;
 use PSFS\base\config\LoginForm;
-use PSFS\base\Router;
 use PSFS\base\Template;
 use PSFS\base\types\AuthAdminController;
 use PSFS\controller\UserController;

src/base/extension/TemplateFunctions.php

Doc Comments +1 added lines, -1 removed lines

@@ -144,7 +144,7 @@
      * @param string $path
      * @param $domains
      *
-     * @return mixed
+     * @return string
      */
     private static function extractPathname($path, $domains)
     {

Spacing +7 added lines, -7 removed lines

@@ -39,12 +39,12 @@ 
 
         $file_path = "";
         if (!file_exists($file_path)) {
-            $file_path = BASE_DIR . $string;
+            $file_path = BASE_DIR.$string;
         }
         $filename_path = AssetsParser::findDomainPath($string, $file_path);
 
         $file_path = self::processAsset($string, $name, $return, $filename_path);
-        $return_path = (empty($name)) ? Request::getInstance()->getRootUrl() . '/' . $file_path : $name;
+        $return_path = (empty($name)) ? Request::getInstance()->getRootUrl().'/'.$file_path : $name;
         return ($return) ? $return_path : '';
     }
 
@@ -61,7 +61,7 @@ 
         $router = Router::getInstance();
         try {
             return $router->getRoute($path, $absolute, $params);
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             return $router->getRoute('', $absolute, $params);
         }
     }
@@ -187,8 +187,8 @@ 
     private static function putResourceContent($name, $filename_path, $base, $file_path)
     {
         $data = file_get_contents($filename_path);
-        if (!empty($name)) file_put_contents(WEB_DIR . DIRECTORY_SEPARATOR . $name, $data);
-        else file_put_contents($base . $file_path, $data);
+        if (!empty($name)) file_put_contents(WEB_DIR.DIRECTORY_SEPARATOR.$name, $data);
+        else file_put_contents($base.$file_path, $data);
     }
 
     /**
@@ -206,9 +206,9 @@ 
         if (file_exists($filename_path)) {
             list($base, $html_base, $file_path) = AssetsParser::calculateAssetPath($string, $name, $return, $filename_path);
             //Creamos el directorio si no existe
-            GeneratorHelper::createDir($base . $html_base);
+            GeneratorHelper::createDir($base.$html_base);
             //Si se ha modificado
-            if (!file_exists($base . $file_path) || filemtime($base . $file_path) < filemtime($filename_path)) {
+            if (!file_exists($base.$file_path) || filemtime($base.$file_path) < filemtime($filename_path)) {
                 if ($html_base == 'css') {
                     self::processCssLines($filename_path);
                 }

Braces +5 added lines, -2 removed lines

@@ -187,8 +187,11 @@
     private static function putResourceContent($name, $filename_path, $base, $file_path)
     {
         $data = file_get_contents($filename_path);
-        if (!empty($name)) file_put_contents(WEB_DIR . DIRECTORY_SEPARATOR . $name, $data);
-        else file_put_contents($base . $file_path, $data);
+        if (!empty($name)) {
+            file_put_contents(WEB_DIR . DIRECTORY_SEPARATOR . $name, $data);
+        } else {
+            file_put_contents($base . $file_path, $data);
+        }
     }
 
     /**