Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Request |
||
11 | { |
||
12 | use SingletonTrait; |
||
13 | protected $server; |
||
14 | protected $cookies; |
||
15 | protected $upload; |
||
16 | protected $header; |
||
17 | protected $data; |
||
18 | protected $raw = []; |
||
19 | protected $query; |
||
20 | private $isLoaded = false; |
||
21 | 2 | ||
22 | public function init() |
||
33 | 2 | ||
34 | /** |
||
35 | * @return bool |
||
36 | 2 | */ |
|
37 | 2 | public function isLoaded() { |
|
40 | |||
41 | /** |
||
42 | 1 | * Método que devuelve las cabeceras de la petición |
|
43 | 1 | * @return array |
|
44 | */ |
||
45 | private function parseHeaders() |
||
49 | |||
50 | 2 | /** |
|
51 | * Método que verifica si existe una cabecera concreta |
||
52 | 2 | * @param $header |
|
53 | * |
||
54 | * @return boolean |
||
55 | */ |
||
56 | public function hasHeader($header) |
||
60 | |||
61 | 3 | ||
62 | /** |
||
63 | 3 | * Método que indica si una petición tiene cookies |
|
64 | * @return boolean |
||
65 | */ |
||
66 | public function hasCookies() |
||
70 | |||
71 | 1 | /** |
|
72 | * Método que indica si una petición tiene cookies |
||
73 | 1 | * @return boolean |
|
74 | */ |
||
75 | public function hasUpload() |
||
79 | |||
80 | 1 | /** |
|
81 | * Método que devuelve el TimeStamp de la petición |
||
82 | 1 | * |
|
83 | * @param boolean $formatted |
||
84 | * |
||
85 | * @return string |
||
86 | */ |
||
87 | public static function ts($formatted = false) |
||
91 | |||
92 | public function getTs($formatted = false) |
||
96 | |||
97 | 1 | /** |
|
98 | * Método que devuelve el Método HTTP utilizado |
||
99 | 1 | * @return string |
|
100 | */ |
||
101 | public function getMethod() |
||
105 | |||
106 | 4 | /** |
|
107 | * Método que devuelve una cabecera de la petición si existe |
||
108 | 4 | * @param string $name |
|
109 | * @param string $default |
||
110 | * |
||
111 | * @return string|null |
||
112 | */ |
||
113 | public static function header($name, $default = null) |
||
117 | |||
118 | /** |
||
119 | * @param string $name |
||
120 | * @param string $default |
||
121 | * @return string|null |
||
122 | 2 | */ |
|
123 | public function getHeader($name, $default = null) |
||
131 | |||
132 | /** |
||
133 | * Método que devuelve la url solicitada |
||
134 | * @return string|null |
||
135 | 1 | */ |
|
136 | public static function requestUri() |
||
140 | |||
141 | /** |
||
142 | * @return string |
||
143 | 8 | */ |
|
144 | public function getRequestUri() |
||
148 | |||
149 | /** |
||
150 | * Método que devuelve el idioma de la petición |
||
151 | * @return string |
||
152 | */ |
||
153 | public function getLanguage() |
||
157 | |||
158 | /** |
||
159 | * Método que determina si se ha solicitado un fichero |
||
160 | * @return boolean |
||
161 | 4 | */ |
|
162 | public function isFile() |
||
167 | |||
168 | /** |
||
169 | * Get query params |
||
170 | * |
||
171 | * @param string $queryParams |
||
172 | * |
||
173 | * @return mixed |
||
174 | */ |
||
175 | public function getQuery($queryParams) |
||
179 | |||
180 | /** |
||
181 | * Get all query params |
||
182 | * |
||
183 | * @return mixed |
||
184 | 2 | */ |
|
185 | public function getQueryParams() |
||
189 | |||
190 | /** |
||
191 | * Método que devuelve un parámetro de la solicitud |
||
192 | * @param string $param |
||
193 | * |
||
194 | * @return string|null |
||
195 | */ |
||
196 | public function get($param) |
||
200 | |||
201 | /** |
||
202 | * Método que devuelve todos los datos del Request |
||
203 | * @return array |
||
204 | 1 | */ |
|
205 | public function getData() |
||
209 | |||
210 | /** |
||
211 | * @return array |
||
212 | */ |
||
213 | public function getRawData() { |
||
216 | |||
217 | /** |
||
218 | * Método que realiza una redirección a la url dada |
||
219 | * @param string $url |
||
220 | */ |
||
221 | public function redirect($url = null) |
||
230 | |||
231 | 3 | /** |
|
232 | * Devuelve un parámetro de $_SERVER |
||
233 | * @param string $param |
||
234 | * |
||
235 | * @return string|null |
||
236 | */ |
||
237 | public function getServer($param) |
||
241 | |||
242 | /** |
||
243 | * Devuelve el nombre del servidor |
||
244 | * @return string|null |
||
245 | */ |
||
246 | public function getServerName() |
||
250 | |||
251 | /** |
||
252 | * Devuelve el protocolo de la conexión |
||
253 | * @return string |
||
254 | */ |
||
255 | public function getProtocol() |
||
259 | |||
260 | /** |
||
261 | * Devuelve la url completa de base |
||
262 | * @param boolean $protocol |
||
263 | * @return string |
||
264 | */ |
||
265 | public function getRootUrl($protocol = true) |
||
276 | |||
277 | 1 | /** |
|
278 | * Método que devuelve el valor de una cookie en caso de que exista |
||
279 | * @param string $name |
||
280 | * |
||
281 | * @return string |
||
282 | */ |
||
283 | public function getCookie($name) |
||
287 | |||
288 | /** |
||
289 | * Método que devuelve los files subidos por POST |
||
290 | * @param $name |
||
291 | * |
||
292 | * @return array |
||
293 | */ |
||
294 | public function getFile($name) |
||
298 | 1 | ||
299 | /** |
||
300 | * Método que devuelve si la petición es ajax o no |
||
301 | * @return boolean |
||
302 | */ |
||
303 | public function isAjax() |
||
308 | |||
309 | } |
||
310 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: