Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | class Request |
||
23 | { |
||
24 | use SingletonTrait; |
||
25 | protected $server; |
||
26 | protected $cookies; |
||
27 | protected $upload; |
||
28 | protected $header; |
||
29 | protected $data; |
||
30 | protected $query; |
||
31 | private $isLoaded = false; |
||
32 | |||
33 | 2 | public function init() |
|
50 | |||
51 | /** |
||
52 | * @return bool |
||
53 | */ |
||
54 | 1 | public function isLoaded() { |
|
57 | |||
58 | /** |
||
59 | * Método que devuelve las cabeceras de la petición |
||
60 | * @return array |
||
61 | */ |
||
62 | 2 | private function parseHeaders() |
|
66 | |||
67 | /** |
||
68 | * Método que verifica si existe una cabecera concreta |
||
69 | * @param $header |
||
70 | * |
||
71 | * @return boolean |
||
72 | */ |
||
73 | 3 | public function hasHeader($header) |
|
77 | |||
78 | |||
79 | /** |
||
80 | * Método que indica si una petición tiene cookies |
||
81 | * @return boolean |
||
82 | */ |
||
83 | 1 | public function hasCookies() |
|
87 | |||
88 | /** |
||
89 | * Método que indica si una petición tiene cookies |
||
90 | * @return boolean |
||
91 | */ |
||
92 | 1 | public function hasUpload() |
|
96 | |||
97 | /** |
||
98 | * Método que devuelve el TimeStamp de la petición |
||
99 | * |
||
100 | * @param boolean $formatted |
||
101 | * |
||
102 | * @return string |
||
103 | */ |
||
104 | public static function ts($formatted = false) |
||
108 | |||
109 | 1 | public function getTs($formatted = false) |
|
113 | |||
114 | /** |
||
115 | * Método que devuelve el Método HTTP utilizado |
||
116 | * @return string |
||
117 | */ |
||
118 | 3 | public function getMethod() |
|
122 | |||
123 | /** |
||
124 | * Método que devuelve una cabecera de la petición si existe |
||
125 | * @param $name |
||
126 | * |
||
127 | * @return string|null |
||
128 | */ |
||
129 | public static function header($name) |
||
133 | |||
134 | 2 | public function getHeader($name) |
|
142 | |||
143 | /** |
||
144 | * Método que devuelve la url solicitada |
||
145 | * @return string|null |
||
146 | */ |
||
147 | public static function requestUri() |
||
151 | |||
152 | /** |
||
153 | * @return string |
||
154 | */ |
||
155 | 6 | public function getRequestUri() |
|
159 | |||
160 | /** |
||
161 | * Método que devuelve el idioma de la petición |
||
162 | * @return string |
||
163 | */ |
||
164 | public function getLanguage() |
||
168 | |||
169 | /** |
||
170 | * Método que determina si se ha solicitado un fichero |
||
171 | * @return boolean |
||
172 | */ |
||
173 | 4 | public function isFile() |
|
178 | |||
179 | /** |
||
180 | * Get query params |
||
181 | * |
||
182 | * @param string $queryParams |
||
183 | * |
||
184 | * @return mixed |
||
185 | */ |
||
186 | public function getQuery($queryParams) |
||
190 | |||
191 | /** |
||
192 | * Get all query params |
||
193 | * |
||
194 | * @return mixed |
||
195 | */ |
||
196 | public function getQueryParams() |
||
200 | |||
201 | /** |
||
202 | * Método que devuelve un parámetro de la solicitud |
||
203 | * @param string $param |
||
204 | * |
||
205 | * @return string|null |
||
206 | */ |
||
207 | public function get($param) |
||
211 | |||
212 | /** |
||
213 | * Método que devuelve todos los datos del Request |
||
214 | * @return array |
||
215 | */ |
||
216 | public function getData() |
||
220 | |||
221 | /** |
||
222 | * Método que realiza una redirección a la url dada |
||
223 | * @param string $url |
||
224 | */ |
||
225 | public function redirect($url = null) |
||
234 | |||
235 | /** |
||
236 | * Devuelve un parámetro de $_SERVER |
||
237 | * @param string $param |
||
238 | * |
||
239 | * @return string|null |
||
240 | */ |
||
241 | 3 | public function getServer($param) |
|
245 | |||
246 | /** |
||
247 | * Devuelve el nombre del servidor |
||
248 | * @return string|null |
||
249 | */ |
||
250 | public function getServerName() |
||
254 | |||
255 | /** |
||
256 | * Devuelve el protocolo de la conexión |
||
257 | * @return string |
||
258 | */ |
||
259 | public function getProtocol() |
||
263 | |||
264 | /** |
||
265 | * Devuelve la url completa de base |
||
266 | * @param boolean $protocol |
||
267 | * @return string |
||
268 | */ |
||
269 | public function getRootUrl($protocol = true) |
||
280 | |||
281 | /** |
||
282 | * Método que devuelve el valor de una cookie en caso de que exista |
||
283 | * @param string $name |
||
284 | * |
||
285 | * @return string |
||
286 | */ |
||
287 | 1 | public function getCookie($name) |
|
291 | |||
292 | /** |
||
293 | * Método que devuelve los files subidos por POST |
||
294 | * @param $name |
||
295 | * |
||
296 | * @return array |
||
297 | */ |
||
298 | public function getFile($name) |
||
302 | |||
303 | /** |
||
304 | * Método que devuelve si la petición es ajax o no |
||
305 | * @return boolean |
||
306 | */ |
||
307 | 1 | public function isAjax() |
|
312 | |||
313 | } |
||
314 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: