psfs /
core
Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Request |
||
| 11 | { |
||
| 12 | use SingletonTrait; |
||
| 13 | protected $server; |
||
| 14 | protected $cookies; |
||
| 15 | protected $upload; |
||
| 16 | protected $header; |
||
| 17 | protected $data; |
||
| 18 | protected $raw = []; |
||
| 19 | protected $query; |
||
| 20 | private $isLoaded = false; |
||
| 21 | |||
| 22 | 2 | public function init() |
|
| 23 | { |
||
| 24 | 2 | $this->server = $_SERVER or []; |
|
| 25 | 2 | $this->cookies = $_COOKIE or []; |
|
| 26 | 2 | $this->upload = $_FILES or []; |
|
| 27 | 2 | $this->header = $this->parseHeaders(); |
|
| 28 | 2 | $this->data = $_REQUEST or []; |
|
| 29 | 2 | $this->query = $_GET or []; |
|
| 30 | 2 | $this->raw = json_decode(file_get_contents("php://input"), true) ?: []; |
|
| 31 | 2 | $this->isLoaded = true; |
|
| 32 | 2 | } |
|
| 33 | |||
| 34 | /** |
||
| 35 | * @return bool |
||
| 36 | */ |
||
| 37 | 1 | public function isLoaded() { |
|
| 38 | 1 | return $this->isLoaded; |
|
| 39 | } |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Método que devuelve las cabeceras de la petición |
||
| 43 | * @return array |
||
| 44 | */ |
||
| 45 | 2 | private function parseHeaders() |
|
| 46 | { |
||
| 47 | 2 | return getallheaders(); |
|
| 48 | } |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Método que verifica si existe una cabecera concreta |
||
| 52 | * @param $header |
||
| 53 | * |
||
| 54 | * @return boolean |
||
| 55 | */ |
||
| 56 | 3 | public function hasHeader($header) |
|
| 57 | { |
||
| 58 | 3 | return array_key_exists($header, $this->header); |
|
| 59 | } |
||
| 60 | |||
| 61 | |||
| 62 | /** |
||
| 63 | * Método que indica si una petición tiene cookies |
||
| 64 | * @return boolean |
||
| 65 | */ |
||
| 66 | 1 | public function hasCookies() |
|
| 67 | { |
||
| 68 | 1 | return (null !== $this->cookies && 0 !== count($this->cookies)); |
|
| 69 | } |
||
| 70 | |||
| 71 | /** |
||
| 72 | * Método que indica si una petición tiene cookies |
||
| 73 | * @return boolean |
||
| 74 | */ |
||
| 75 | 1 | public function hasUpload() |
|
| 76 | { |
||
| 77 | 1 | return (null !== $this->upload && 0 !== count($this->upload)); |
|
| 78 | } |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Método que devuelve el TimeStamp de la petición |
||
| 82 | * |
||
| 83 | * @param boolean $formatted |
||
| 84 | * |
||
| 85 | * @return string |
||
| 86 | */ |
||
| 87 | public static function ts($formatted = false) |
||
| 88 | { |
||
| 89 | return self::getInstance()->getTs($formatted); |
||
| 90 | } |
||
| 91 | |||
| 92 | 1 | public function getTs($formatted = false) |
|
| 93 | { |
||
| 94 | 1 | return ($formatted) ? date('Y-m-d H:i:s', $this->server['REQUEST_TIME_FLOAT']) : $this->server['REQUEST_TIME_FLOAT']; |
|
| 95 | } |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Método que devuelve el Método HTTP utilizado |
||
| 99 | * @return string |
||
| 100 | */ |
||
| 101 | 4 | public function getMethod() |
|
| 102 | { |
||
| 103 | 4 | return (array_key_exists('REQUEST_METHOD', $this->server)) ? strtoupper($this->server['REQUEST_METHOD']) : 'GET'; |
|
| 104 | } |
||
| 105 | |||
| 106 | /** |
||
| 107 | * Método que devuelve una cabecera de la petición si existe |
||
| 108 | * @param string $name |
||
| 109 | * @param string $default |
||
| 110 | * |
||
| 111 | * @return string|null |
||
| 112 | */ |
||
| 113 | 2 | public static function header($name, $default = null) |
|
| 114 | { |
||
| 115 | 2 | return self::getInstance()->getHeader($name, $default); |
|
| 116 | } |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @param string $name |
||
| 120 | * @param string $default |
||
| 121 | * @return string|null |
||
| 122 | */ |
||
| 123 | 2 | public function getHeader($name, $default = null) |
|
| 124 | { |
||
| 125 | 2 | $header = null; |
|
| 126 | 2 | if ($this->hasHeader($name)) { |
|
| 127 | $header = $this->header[$name]; |
||
| 128 | 2 | } else if(array_key_exists('h_' . strtolower($name), $this->query)) { |
|
| 129 | $header = $this->query['h_' . strtolower($name)]; |
||
| 130 | 2 | } else if(array_key_exists('HTTP_' . strtoupper(str_replace('-', '_', $name)), $this->server)) { |
|
| 131 | $header = $this->server['HTTP_' . strtoupper(str_replace('-', '_', $name))]; |
||
| 132 | } |
||
| 133 | 2 | return $header ?: $default; |
|
| 134 | } |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Método que devuelve la url solicitada |
||
| 138 | * @return string|null |
||
| 139 | */ |
||
| 140 | 1 | public static function requestUri() |
|
| 141 | { |
||
| 142 | 1 | return self::getInstance()->getRequestUri(); |
|
| 143 | } |
||
| 144 | |||
| 145 | /** |
||
| 146 | * @return string |
||
| 147 | */ |
||
| 148 | 7 | public function getRequestUri() |
|
| 149 | { |
||
| 150 | 7 | return array_key_exists('REQUEST_URI', $this->server) ? $this->server['REQUEST_URI'] : ''; |
|
| 151 | } |
||
| 152 | |||
| 153 | /** |
||
| 154 | * Método que devuelve el idioma de la petición |
||
| 155 | * @return string |
||
| 156 | */ |
||
| 157 | public function getLanguage() |
||
| 158 | { |
||
| 159 | return array_key_exists('HTTP_ACCEPT_LANGUAGE', $this->server) ? $this->server['HTTP_ACCEPT_LANGUAGE'] : 'es_ES'; |
||
| 160 | } |
||
| 161 | |||
| 162 | /** |
||
| 163 | * Método que determina si se ha solicitado un fichero |
||
| 164 | * @return boolean |
||
| 165 | */ |
||
| 166 | 4 | public function isFile() |
|
| 167 | { |
||
| 168 | 4 | $file = (preg_match('/\.[a-z0-9]{2,4}$/', $this->getRequestUri()) !== 0); |
|
| 169 | 4 | return $file; |
|
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Get query params |
||
| 174 | * |
||
| 175 | * @param string $queryParams |
||
| 176 | * |
||
| 177 | * @return mixed |
||
| 178 | */ |
||
| 179 | public function getQuery($queryParams) |
||
| 180 | { |
||
| 181 | return (array_key_exists($queryParams, $this->query)) ? $this->query[$queryParams] : null; |
||
| 182 | } |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Get all query params |
||
| 186 | * |
||
| 187 | * @return mixed |
||
| 188 | */ |
||
| 189 | 1 | public function getQueryParams() |
|
| 190 | { |
||
| 191 | 1 | return $this->query; |
|
| 192 | } |
||
| 193 | |||
| 194 | /** |
||
| 195 | * Método que devuelve un parámetro de la solicitud |
||
| 196 | * @param string $param |
||
| 197 | * |
||
| 198 | * @return string|null |
||
| 199 | */ |
||
| 200 | public function get($param) |
||
| 201 | { |
||
| 202 | return (array_key_exists($param, $this->data)) ? $this->data[$param] : null; |
||
| 203 | } |
||
| 204 | |||
| 205 | /** |
||
| 206 | * Método que devuelve todos los datos del Request |
||
| 207 | * @return array |
||
| 208 | */ |
||
| 209 | 1 | public function getData() |
|
| 210 | { |
||
| 211 | 1 | return array_merge($this->data, $this->raw); |
|
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * @return array |
||
| 216 | */ |
||
| 217 | public function getRawData() { |
||
| 218 | return $this->raw; |
||
| 219 | } |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Método que realiza una redirección a la url dada |
||
| 223 | * @param string $url |
||
| 224 | */ |
||
| 225 | public function redirect($url = null) |
||
| 234 | |||
| 235 | /** |
||
| 236 | * Devuelve un parámetro de $_SERVER |
||
| 237 | * @param string $param |
||
| 238 | * |
||
| 239 | * @return string|null |
||
| 240 | */ |
||
| 241 | 5 | public function getServer($param) |
|
| 245 | |||
| 246 | /** |
||
| 247 | * Devuelve el nombre del servidor |
||
| 248 | * @return string|null |
||
| 249 | */ |
||
| 250 | 2 | public function getServerName() |
|
| 251 | { |
||
| 252 | 2 | return $this->getServer("SERVER_NAME"); |
|
| 253 | } |
||
| 254 | |||
| 255 | /** |
||
| 256 | * Devuelve el protocolo de la conexión |
||
| 257 | * @return string |
||
| 258 | */ |
||
| 259 | 2 | public function getProtocol() |
|
| 260 | { |
||
| 261 | 2 | return ($this->getServer("HTTPS") || $this->getServer("https")) ? 'https://' : 'http://'; |
|
| 262 | } |
||
| 263 | |||
| 264 | /** |
||
| 265 | * Devuelve la url completa de base |
||
| 266 | * @param boolean $protocol |
||
| 267 | * @return string |
||
| 268 | */ |
||
| 269 | 2 | public function getRootUrl($protocol = true) |
|
| 279 | |||
| 280 | /** |
||
| 281 | * Método que devuelve el valor de una cookie en caso de que exista |
||
| 282 | * @param string $name |
||
| 283 | * |
||
| 284 | * @return string |
||
| 285 | */ |
||
| 286 | 1 | public function getCookie($name) |
|
| 290 | |||
| 291 | /** |
||
| 292 | * Método que devuelve los files subidos por POST |
||
| 293 | * @param $name |
||
| 294 | * |
||
| 295 | * @return array |
||
| 296 | */ |
||
| 297 | public function getFile($name) |
||
| 301 | |||
| 302 | /** |
||
| 303 | * Método que devuelve si la petición es ajax o no |
||
| 304 | * @return boolean |
||
| 305 | */ |
||
| 306 | 1 | public function isAjax() |
|
| 311 | |||
| 312 | } |
||
| 313 |
Loading history...
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: