Complex classes like Template often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Template, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class Template |
||
| 18 | { |
||
| 19 | use SingletonTrait; |
||
| 20 | use OutputTrait; |
||
| 21 | use RouteTrait; |
||
| 22 | const STATUS_OK = 'HTTP/1.0 200 OK'; |
||
| 23 | /** |
||
| 24 | * @var \Twig_Environment tpl |
||
| 25 | */ |
||
| 26 | protected $tpl; |
||
| 27 | protected $filters = array(); |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Constructor por defecto |
||
| 31 | */ |
||
| 32 | 1 | public function __construct() |
|
| 33 | { |
||
| 34 | 1 | $this->setup(); |
|
| 35 | 1 | $this->addTemplateFunctions(); |
|
| 36 | 1 | $this->addTemplateTokens(); |
|
| 37 | 1 | $this->optimizeTemplates(); |
|
| 38 | 1 | } |
|
| 39 | |||
| 40 | /** |
||
| 41 | * Método que devuelve el loader del Template |
||
| 42 | * @return \Twig_LoaderInterface |
||
| 43 | */ |
||
| 44 | public function getLoader() |
||
| 45 | { |
||
| 46 | return $this->tpl->getLoader(); |
||
| 47 | } |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Método que activa la zona pública |
||
| 51 | * @param bool $public |
||
| 52 | * |
||
| 53 | * @return Template |
||
| 54 | */ |
||
| 55 | public function setPublicZone($public = true) |
||
| 56 | { |
||
| 57 | $this->public_zone = $public; |
||
| 58 | return $this; |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Método que procesa la plantilla |
||
| 63 | * |
||
| 64 | * @param string $tpl |
||
| 65 | * @param array $vars |
||
| 66 | * @param array $cookies |
||
| 67 | * |
||
| 68 | * @return string HTML |
||
|
|
|||
| 69 | */ |
||
| 70 | 1 | public function render($tpl, array $vars = array(), array $cookies = array()) |
|
| 71 | { |
||
| 72 | 1 | Logger::log('Start render response'); |
|
| 73 | 1 | $vars = ResponseHelper::setDebugHeaders($vars); |
|
| 74 | $output = $this->dump($tpl, $vars); |
||
| 75 | |||
| 76 | return $this->output($output, 'text/html', $cookies); |
||
| 77 | } |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Método que añade una nueva ruta al path de Twig |
||
| 81 | * @param $path |
||
| 82 | * @param $domain |
||
| 83 | * |
||
| 84 | * @return Template |
||
| 85 | */ |
||
| 86 | 1 | public function addPath($path, $domain = '') |
|
| 87 | { |
||
| 88 | 1 | $this->tpl->getLoader()->addPath($path, $domain); |
|
| 89 | 1 | return $this; |
|
| 90 | } |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Método que devuelve el contenido de una plantilla |
||
| 94 | * @param string $tpl |
||
| 95 | * @param array $vars |
||
| 96 | * @return string |
||
| 97 | */ |
||
| 98 | public function dump($tpl, array $vars = array()) |
||
| 99 | { |
||
| 100 | $vars["__user__"] = Security::getInstance()->getUser(); |
||
| 101 | $vars["__admin__"] = Security::getInstance()->getAdmin(); |
||
| 102 | $vars["__profiles__"] = Security::getCleanProfiles(); |
||
| 103 | $vars["__flash__"] = Security::getInstance()->getFlashes(); |
||
| 104 | $dump = ''; |
||
| 105 | try { |
||
| 106 | $dump = $this->tpl->render($tpl, $vars); |
||
| 107 | } catch (\Exception $e) { |
||
| 108 | Logger::log($e->getMessage(), LOG_ERR); |
||
| 109 | } |
||
| 110 | return $dump; |
||
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Método que añade una función al motor de plantillas |
||
| 115 | * @param string $templateFunction |
||
| 116 | * @param $functionName |
||
| 117 | * |
||
| 118 | * @return Template |
||
| 119 | */ |
||
| 120 | 1 | protected function addTemplateFunction($templateFunction, $functionName) |
|
| 121 | { |
||
| 122 | 1 | $function = new \Twig_SimpleFunction($templateFunction, $functionName); |
|
| 123 | 1 | $this->tpl->addFunction($function); |
|
| 124 | 1 | return $this; |
|
| 125 | } |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Funcion Twig para los assets en las plantillas |
||
| 129 | * @return Template |
||
| 130 | */ |
||
| 131 | 1 | private function addAssetFunction() |
|
| 132 | { |
||
| 133 | 1 | return $this->addTemplateFunction("asset", TemplateFunctions::ASSETS_FUNCTION); |
|
| 134 | } |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Función que pinta un formulario |
||
| 138 | * @return Template |
||
| 139 | */ |
||
| 140 | 1 | private function addFormsFunction() |
|
| 141 | { |
||
| 142 | 1 | return $this->addTemplateFunction("form", TemplateFunctions::FORM_FUNCTION); |
|
| 143 | } |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Función que pinta un campo de un formulario |
||
| 147 | * @return Template |
||
| 148 | */ |
||
| 149 | 1 | private function addFormWidgetFunction() |
|
| 150 | { |
||
| 151 | 1 | return $this->addTemplateFunction("form_widget", TemplateFunctions::WIDGET_FUNCTION); |
|
| 152 | } |
||
| 153 | |||
| 154 | /** |
||
| 155 | * Función que pinta un botón de un formulario |
||
| 156 | * @return Template |
||
| 157 | */ |
||
| 158 | 1 | private function addFormButtonFunction() |
|
| 159 | { |
||
| 160 | 1 | return $this->addTemplateFunction("form_button", TemplateFunctions::BUTTON_FUNCTION); |
|
| 161 | } |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Método que devuelve un parámetro de configuración en la plantilla |
||
| 165 | * @return Template |
||
| 166 | */ |
||
| 167 | 1 | private function addConfigFunction() |
|
| 168 | { |
||
| 169 | 1 | return $this->addTemplateFunction("get_config", TemplateFunctions::CONFIG_FUNCTION); |
|
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Método que añade la función path a Twig |
||
| 174 | * @return Template |
||
| 175 | */ |
||
| 176 | 1 | private function addRouteFunction() |
|
| 177 | { |
||
| 178 | 1 | return $this->addTemplateFunction("path", TemplateFunctions::ROUTE_FUNCTION); |
|
| 179 | } |
||
| 180 | |||
| 181 | /** |
||
| 182 | * Método que copia directamente el recurso solicitado a la carpeta pública |
||
| 183 | * @return Template |
||
| 184 | */ |
||
| 185 | 1 | private function addResourceFunction() |
|
| 186 | { |
||
| 187 | 1 | return $this->addTemplateFunction("resource", TemplateFunctions::RESOURCE_FUNCTION); |
|
| 188 | } |
||
| 189 | |||
| 190 | /** |
||
| 191 | * @return Template |
||
| 192 | */ |
||
| 193 | 1 | private function addSessionFunction() |
|
| 194 | { |
||
| 195 | 1 | return $this->addTemplateFunction("session", TemplateFunctions::SESSION_FUNCTION); |
|
| 196 | } |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @return Template |
||
| 200 | */ |
||
| 201 | 1 | private function addExistsFlashFunction() |
|
| 202 | { |
||
| 203 | 1 | return $this->addTemplateFunction("existsFlash", TemplateFunctions::EXISTS_FLASH_FUNCTION); |
|
| 204 | } |
||
| 205 | |||
| 206 | /** |
||
| 207 | * @return Template |
||
| 208 | */ |
||
| 209 | 1 | private function addGetFlashFunction() |
|
| 210 | { |
||
| 211 | 1 | return $this->addTemplateFunction("getFlash", TemplateFunctions::GET_FLASH_FUNCTION); |
|
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * Servicio que regenera todas las plantillas |
||
| 216 | * @return array |
||
| 217 | */ |
||
| 218 | public function regenerateTemplates() |
||
| 229 | |||
| 230 | /** |
||
| 231 | * @param $tplDir |
||
| 232 | * @param string $domain |
||
| 233 | * |
||
| 234 | * @return mixed |
||
| 235 | */ |
||
| 236 | protected function generateTemplate($tplDir, $domain = '') |
||
| 237 | { |
||
| 238 | $templatesDir = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($tplDir), \RecursiveIteratorIterator::LEAVES_ONLY); |
||
| 239 | foreach ($templatesDir as $file) { |
||
| 240 | // force compilation |
||
| 241 | if ($file->isFile()) { |
||
| 242 | try { |
||
| 243 | $this->tpl->load(str_replace($tplDir . '/', '', $file)); |
||
| 244 | } catch (\Exception $e) { |
||
| 245 | Logger::log($e->getMessage(), LOG_ERR, ['file' => $e->getFile(), 'line' => $e->getLine()]); |
||
| 246 | } |
||
| 251 | |||
| 252 | /** |
||
| 253 | * Método que extrae el path de un string |
||
| 254 | * @param $path |
||
| 255 | * |
||
| 256 | * @return string |
||
| 257 | */ |
||
| 258 | public static function extractPath($path) |
||
| 267 | |||
| 268 | /** |
||
| 269 | * Método que devuelve los dominios de una plataforma |
||
| 270 | * @param bool $append |
||
| 271 | * @return array |
||
| 272 | */ |
||
| 273 | static public function getDomains($append = false) |
||
| 285 | |||
| 286 | /** |
||
| 287 | * Método que añade todas las funciones de las plantillas |
||
| 288 | */ |
||
| 289 | 1 | private function addTemplateFunctions() |
|
| 303 | |||
| 304 | /** |
||
| 305 | * Método que devuelve el motod de plantillas |
||
| 306 | * @return \Twig_Environment |
||
| 307 | */ |
||
| 308 | public function getTemplateEngine() |
||
| 312 | |||
| 313 | /** |
||
| 314 | * Method that extract all domains for using them with the templates |
||
| 315 | */ |
||
| 316 | 1 | private function loadDomains() |
|
| 325 | |||
| 326 | /** |
||
| 327 | * Método que inicializa el motor de plantillas |
||
| 328 | */ |
||
| 329 | 1 | private function setup() |
|
| 339 | |||
| 340 | /** |
||
| 341 | * Método que inyecta los parseadores |
||
| 342 | */ |
||
| 343 | 1 | private function addTemplateTokens() |
|
| 349 | |||
| 350 | /** |
||
| 351 | * Método que inyecta las optimizaciones al motor de la plantilla |
||
| 352 | */ |
||
| 353 | 1 | private function optimizeTemplates() |
|
| 358 | |||
| 359 | /** |
||
| 360 | * Method that extract all path tag for extracting translations |
||
| 361 | * @param array $domains |
||
| 362 | * |
||
| 363 | * @return array |
||
| 364 | */ |
||
| 365 | private function parsePathTranslations($domains) |
||
| 379 | |||
| 380 | /** |
||
| 381 | * Method that generate all template caches |
||
| 382 | */ |
||
| 383 | private function generateTemplatesCache() |
||
| 394 | } |
||
| 395 |
This check compares the return type specified in the
@returnannotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.