PSFS\base\dto\JsonResponse

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	4

<?php
namespace PSFS\base\dto;

class JsonResponse extends Dto
{
    /**
     * Response message
     * @var string $message
     */
    public $message = 'No message';
    /**
     * Response result
     * @var bool $success
     */
    public $success = false;
    /**
     * Data of response
     * @var array $data
     */
    public $data = null;
    /**
     * Number of total results
     * @var int total
     */
    public $total = 0;
    /**
     * Number of pages availables
     * @var int pages
     */
    public $pages = 1;

    /**
     * JsonResponse constructor.
     * @param array $data
     * @param bool $result
     * @param null $total

Are you sure the doc-type for parameter $total is correct as it would always require null to be passed?

     * @param int $pages
     * @param null $message

Are you sure the doc-type for parameter $message is correct as it would always require null to be passed?

     * @throws \PSFS\base\exception\GeneratorException
     */
    public function __construct($data = array(), $result = false, $total = null, $pages = 1, $message = null)
    {
        parent::__construct(false);
        $this->data = $data;
        $this->success = $result;
        $this->total = $total ?: (is_array($data) ? count($data) : 0);

$total is of type null, thus it always evaluated to false.

The condition is_array($data) is always true.

        $this->pages = $pages;
        if(null !== $message) {

The condition null !== $message is always false.

            $this->message = $message;
        }
    }
}