JsonResponse::__construct() - Code Metrics - Inspection of "master" - psfs/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 43cce1...1a30b3 )

by Fran

created 2025-03-16 07:26 UTC

JsonResponse::__construct() A

↳ Parent: JsonResponse

Complexity

Conditions	4
Paths	4

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	7
c	2
b	0
f	0
nc	4
nop	5
dl	0
loc	9
ccs	8
cts	8
cp	1
crap	4
rs	10

<?php

namespace PSFS\base\dto;

class JsonResponse extends Dto
{
    /**
     * Response message
     * @var string $message
     */
    public $message = 'No message';
    /**
     * Response result
     * @var bool $success
     */
    public $success = false;
    /**
     * Data of response
     * @var array $data
     */
    public $data = null;
    /**
     * Number of total results
     * @var int total
     */
    public $total = 0;
    /**
     * Number of pages availables
     * @var int pages
     */
    public $pages = 1;

    private function parseData($data) {
        if ($data instanceof \Generator) {
            $generatedData = [];
            foreach($data as $datum) {
                $generatedData[] = $datum;
            }
        } else {
            $generatedData = $data;
        }
        return $generatedData;
    }

    /**
     * JsonResponse constructor.
     * @param array $data
     * @param bool $result
     * @param integer $total
     * @param int $pages
     * @param string $message
     * @throws \PSFS\base\exception\GeneratorException
     */
    public function __construct($data = [], $result = false, $total = null, $pages = 1, $message = null)
    {
        parent::__construct(false);
        $this->data = $this->parseData($data);
        $this->success = $result;
        $this->total = $total ?: (is_array($this->data) ? count($this->data) : ($total ?? 0));

        $this->pages = $pages;
        if (null !== $message) {
            $this->message = $message;
        }
    }
}


1		<?php
2
3		namespace PSFS\base\dto;
4
5		class JsonResponse extends Dto
6		{
7		/**
8		* Response message
9		* @var string $message
10		*/
11		public $message = 'No message';
12		/**
13		* Response result
14		* @var bool $success
15		*/
16		public $success = false;
17		/**
18		* Data of response
19		* @var array $data
20		*/
21		public $data = null;
22		/**
23		* Number of total results
24		* @var int total
25		*/
26		public $total = 0;
27		/**
28		* Number of pages availables
29		* @var int pages
30		*/
31		public $pages = 1;
32
33	1	private function parseData($data) {
34	1	if ($data instanceof \Generator) {
35		$generatedData = [];
36		foreach($data as $datum) {
37		$generatedData[] = $datum;
38		}
39		} else {
40	1	$generatedData = $data;
41		}
42	1	return $generatedData;
43		}
44
45		/**
46		* JsonResponse constructor.
47		* @param array $data
48		* @param bool $result
49		* @param integer $total
50		* @param int $pages
51		* @param string $message
52		* @throws \PSFS\base\exception\GeneratorException
53		*/
54	1	public function __construct($data = [], $result = false, $total = null, $pages = 1, $message = null)
55		{
56	1	parent::__construct(false);
57	1	$this->data = $this->parseData($data);
58	1	$this->success = $result;
59	1	$this->total = $total ?: (is_array($this->data) ? count($this->data) : ($total ?? 0));
		0 ignored issues – show introduced 2025-03-16 07:29 UTC by Report Bug Copy Issue Report The condition `is_array($this->data)` is always `true`. Loading history...
60	1	$this->pages = $pages;
61	1	if (null !== $message) {
62	1	$this->message = $message;
63		}
64		}
65		}
66

psfs / core

Push — master ( 43cce1...1a30b3 )

JsonResponse::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like