psfs / core

src/base/dto/Dto.php

Spacing +2 added lines, -2 removed lines

@@ -36,8 +36,8 @@
                     $dto[$property->getName()] = $property->getValue($this);
                 }
             }
-        } catch (\Exception $e) {
-            Logger::log(get_class($this) . ': ' . $e->getMessage(), LOG_ERR);
+        }catch (\Exception $e) {
+            Logger::log(get_class($this).': '.$e->getMessage(), LOG_ERR);
         }
         return $dto;
     }

src/base/dto/Order.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     {
         if (preg_match('/^asc$/i', $direction)) {
             return Order::ASC;
-        } else {
+        }else {
             return Order::DESC;
         }
     }

src/base/types/AuthApi.php

Spacing +2 added lines, -2 removed lines

@@ -26,13 +26,13 @@
     {
         $namespace = explode('\\', $this->getModelTableMap());
         $module = strtolower($namespace[0]);
-        $secret = Config::getInstance()->get($module . '.api.secret');
+        $secret = Config::getInstance()->get($module.'.api.secret');
         if (NULL === $secret) {
             $secret = Config::getInstance()->get("api.secret");
         }
         if (NULL === $secret) {
             $auth = TRUE;
-        } else {
+        }else {
             $token = Request::getInstance()->getHeader('X-API-SEC-TOKEN');
             if (array_key_exists('API_TOKEN', $this->query)) {
                 $token = $this->query['API_TOKEN'];

src/base/types/Api.php

Spacing +26 added lines, -26 removed lines

@@ -180,7 +180,7 @@ 
      *
      * @param ModelCriteria $query
      */
-    private function addOrders(ModelCriteria &$query)
+    private function addOrders(ModelCriteria & $query)
     {
         $orderAdded = FALSE;
         $tableMap = $this->getTableMap();
@@ -189,7 +189,7 @@ 
                 $orderAdded = TRUE;
                 if ($direction === Order::ASC) {
                     $query->addAscendingOrderByColumn($column->getPhpName());
-                } else {
+                }else {
                     $query->addDescendingOrderByColumn($column->getPhpName());
                 }
             }
@@ -209,7 +209,7 @@ 
         if (count($pks) == 1) {
             $pks = array_keys($pks);
             $this->extraColumns[$pks[0]] = self::API_MODEL_KEY_FIELD;
-        } else {
+        }else {
             throw new ApiException(_('El modelo de la API no está debidamente mapeado, no hay Primary Key o es compuesta'));
         }
     }
@@ -231,7 +231,7 @@ 
             }
             if (null !== $column) {
                 $this->extraColumns[$column->getFullyQualifiedName()] = self::API_LIST_NAME_FIELD;
-            } else {
+            }else {
                 $this->addClassListName($tableMap);
             }
         }
@@ -243,7 +243,7 @@ 
      *
      * @param ModelCriteria $query
      */
-    private function addExtraColumns(ModelCriteria &$query)
+    private function addExtraColumns(ModelCriteria & $query)
     {
         if (self::API_ACTION_LIST === $this->action) {
             $this->addDefaultListField();
@@ -261,7 +261,7 @@ 
      *
      * @param ModelCriteria $query
      */
-    protected function joinTables(ModelCriteria &$query)
+    protected function joinTables(ModelCriteria & $query)
     {
         //TODO for specific implementations
     }
@@ -283,14 +283,14 @@ 
      *
      * @param ModelCriteria $query
      */
-    private function addFilters(ModelCriteria &$query)
+    private function addFilters(ModelCriteria & $query)
     {
         if (count($this->query) > 0) {
             $tableMap = $this->getTableMap();
             foreach ($this->query as $field => $value) {
                 if (self::API_COMBO_FIELD === $field) {
                     ApiHelper::composerComboField($tableMap, $query, $this->extraColumns, $value);
-                } else {
+                }else {
                     ApiHelper::addModelField($tableMap, $query, $field, $value);
                 }
             }
@@ -300,7 +300,7 @@ 
     /**
      * @param ModelCriteria $query
      */
-    private function checkReturnFields(ModelCriteria &$query)
+    private function checkReturnFields(ModelCriteria & $query)
     {
         $returnFields = $this->getRequest()->getQuery('__fields');
         if (null !== $returnFields) {
@@ -336,10 +336,10 @@ 
             list($page, $limit) = $this->extractPagination();
             if ($limit == -1) {
                 $this->list = $query->find($this->con);
-            } else {
+            }else {
                 $this->list = $query->paginate($page, $limit, $this->con);
             }
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             Logger::log($e->getMessage(), LOG_ERR);
         }
     }
@@ -356,7 +356,7 @@ 
             $this->joinTables($query);
             $this->addExtraColumns($query);
             $this->model = $query->findPk($pk);
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             Logger::getInstance(get_class($this))->errorLog($e->getMessage());
         }
     }
@@ -447,8 +447,8 @@ 
                 $saved = TRUE;
                 $model = $this->model->toArray();
             }
-        } catch (\Exception $e) {
-            $model = _('Ha ocurrido un error intentando guardar el elemento: ') . $e->getMessage();
+        }catch (\Exception $e) {
+            $model = _('Ha ocurrido un error intentando guardar el elemento: ').$e->getMessage();
             Logger::log($e->getMessage(), LOG_ERR);
         }
 
@@ -478,7 +478,7 @@ 
                     $this->model->delete($this->con);
                     $deleted = TRUE;
                 }
-            } catch (\Exception $e) {
+            }catch (\Exception $e) {
                 $message = _('Ha ocurrido un error intentando eliminar el elemento, por favor verifica que no tenga otros elementos relacionados');
                 Logger::getInstance(get_class($this->model))->errorLog($e->getMessage());
             }
@@ -513,14 +513,14 @@ 
                     $updated = TRUE;
                     $status = 200;
                     $model = $this->model->toArray();
-                } else {
+                }else {
                     $model = _('Ha ocurrido un error intentando actualizar el elemento, por favor revisa los logs');
                 }
-            } catch (\Exception $e) {
+            }catch (\Exception $e) {
                 $model = $e->getMessage();
                 Logger::getInstance(get_class($this->model))->errorLog($e->getMessage());
             }
-        } else {
+        }else {
             $model = _('Ha ocurrido un error intentando actualizar el elemento, por favor revisa los logs');
         }
 
@@ -532,7 +532,7 @@ 
      */
     private function extractQuery()
     {
-        $queryReflector = new \ReflectionClass($this->getModelNamespace() . "Query");
+        $queryReflector = new \ReflectionClass($this->getModelNamespace()."Query");
         /** @var \Propel\Runtime\ActiveQuery\ModelCriteria $query */
         $query = $queryReflector->getMethod('create')->invoke($this->con);
 
@@ -576,7 +576,7 @@ 
         if (null !== $this->con && $this->con->inTransaction()) {
             if ($status === 200) {
                 $this->con->commit();
-            } else {
+            }else {
                 $this->con->rollBack();
             }
         }
@@ -628,8 +628,8 @@ 
             "domain" => $this->getDomain(),
             "listLabel" => self::API_LIST_NAME_FIELD,
             'modelId' => self::API_MODEL_KEY_FIELD,
-            'formUrl' => preg_replace('/\/\{(.*)\}$/i', '', $this->getRoute(strtolower('admin-api-form-' . $this->getDomain() . '-' . $this->getApi()), TRUE)),
-            "url" => preg_replace('/\/\{(.*)\}$/i', '', $this->getRoute(strtolower($this->getDomain() . '-' . 'api-' . $this->getApi() . "-pk"), TRUE)),
+            'formUrl' => preg_replace('/\/\{(.*)\}$/i', '', $this->getRoute(strtolower('admin-api-form-'.$this->getDomain().'-'.$this->getApi()), TRUE)),
+            "url" => preg_replace('/\/\{(.*)\}$/i', '', $this->getRoute(strtolower($this->getDomain().'-'.'api-'.$this->getApi()."-pk"), TRUE)),
         ), [], '');
     }
 
@@ -668,7 +668,7 @@ 
                 $total = $this->list->getNbResults();
                 $pages = $this->list->getLastPage();
             }
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             Logger::getInstance(get_class($this))->errorLog($e->getMessage());
         }
 
@@ -687,7 +687,7 @@ 
         $return = array();
         if (NULL === $model && method_exists($model, 'toArray')) {
             $code = 404;
-        } else {
+        }else {
             $return = $model->toArray();
         }
 
@@ -702,10 +702,10 @@ 
         $pks = '';
         $sep = '';
         foreach ($tableMap->getPrimaryKeys() as $pk) {
-            $pks .= $sep . $pk->getFullyQualifiedName();
+            $pks .= $sep.$pk->getFullyQualifiedName();
             $sep = ', "|", ';
         }
-        $this->extraColumns['CONCAT("' . $tableMap->getPhpName() . ' #", ' . $pks . ')'] = self::API_LIST_NAME_FIELD;
+        $this->extraColumns['CONCAT("'.$tableMap->getPhpName().' #", '.$pks.')'] = self::API_LIST_NAME_FIELD;
     }
 
     /**

Doc Comments +6 added lines

@@ -603,6 +603,9 @@ 
         $this->con->useDebug($this->debug);
     }
 
+    /**
+     * @return string
+     */
     private function getApi()
     {
         $model = explode("\\", $this->getModelNamespace());
@@ -610,6 +613,9 @@ 
         return $model[count($model) - 1];
     }
 
+    /**
+     * @return string
+     */
     public function getDomain()
     {
         $model = explode("\\", $this->getModelNamespace());

Unused Use Statements -2 removed lines

@@ -14,12 +14,10 @@
 use PSFS\base\Request;
 use PSFS\base\Router;
 use PSFS\base\Singleton;
-use PSFS\base\Template;
 use PSFS\base\types\helpers\ApiFormHelper;
 use PSFS\base\types\helpers\ApiHelper;
 use PSFS\base\types\traits\JsonTrait;
 use PSFS\base\types\traits\RouteTrait;
-use PSFS\base\types\traits\SingletonTrait;
 
 /**
  * Class Api

src/base/extension/AssetsNode.php

Spacing +3 added lines, -3 removed lines

@@ -30,16 +30,16 @@
         $scripts = $this->getNode("scripts");
 
         //Creamos el parser
-        $compiler->addDebugInfo($scripts)->write('$parser = new \\PSFS\\base\\extension\\AssetsParser(\'' . $this->type . '\')')
+        $compiler->addDebugInfo($scripts)->write('$parser = new \\PSFS\\base\\extension\\AssetsParser(\''.$this->type.'\')')
             ->raw(";\n");
 
         //Asociamos el hash
-        $compiler->write('$parser->setHash(\'' . $this->hash . '\')')
+        $compiler->write('$parser->setHash(\''.$this->hash.'\')')
             ->raw(";\n");
 
         //Asociamos los ficheros
         foreach ($scripts->getAttribute("value") as $value) {
-            $compiler->write('$parser->addFile(\'' . $value . '\')')->raw(";\n");
+            $compiler->write('$parser->addFile(\''.$value.'\')')->raw(";\n");
         }
 
         //Procesamos los ficheros

src/base/extension/AssetsTokenParser.php

Spacing +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
         $tmp = array();
         if (NULL === $node) {
             $node = $value;
-        } else {
+        }else {
             $tmp = $this->getTmpAttribute($node);
         }
         $tmp[] = $value->getAttribute("value");

src/base/Security.php

Spacing +6 added lines, -6 removed lines

@@ -122,12 +122,12 @@ 
     {
         $saved = true;
         try {
-            $admins = Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true) ?: [];
-            $admins[$user['username']]['hash'] = sha1($user['username'] . $user['password']);
+            $admins = Cache::getInstance()->getDataFromFile(CONFIG_DIR.DIRECTORY_SEPARATOR.'admins.json', Cache::JSONGZ, true) ?: [];
+            $admins[$user['username']]['hash'] = sha1($user['username'].$user['password']);
             $admins[$user['username']]['profile'] = $user['profile'];
 
-            Cache::getInstance()->storeData(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', $admins, Cache::JSONGZ, true);
-        } catch(\Exception $e) {
+            Cache::getInstance()->storeData(CONFIG_DIR.DIRECTORY_SEPARATOR.'admins.json', $admins, Cache::JSONGZ, true);
+        }catch (\Exception $e) {
             Logger::log($e->getMessage(), LOG_ERR);
             $saved = false;
         }
@@ -164,7 +164,7 @@ 
      */
     public function getAdmins()
     {
-        return Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true);
+        return Cache::getInstance()->getDataFromFile(CONFIG_DIR.DIRECTORY_SEPARATOR.'admins.json', Cache::JSONGZ, true);
     }
 
     /**
@@ -191,7 +191,7 @@ 
                 }
                 if (!empty($user) && !empty($admins[$user])) {
                     $auth = $admins[$user]['hash'];
-                    $this->authorized = ($auth == sha1($user . $pass));
+                    $this->authorized = ($auth == sha1($user.$pass));
                     if ($this->authorized) {
                         $this->admin = array(
                             'alias' => $user,

src/base/Service.php

Doc Comments +3 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
     /**
      * Add request param
      *
-     * @param $key
+     * @param integer $key
      * @param null $value
      *
      * @return \PSFS\base\Service
@@ -153,8 +153,8 @@ 
     }
 
     /**
-     * @param $header
-     * @param null $content
+     * @param string $header
+     * @param string $content
      *
      * @return $this
      */

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
     protected $cache;
 
     private function closeConnection() {
-        if(null !== $this->con) {
+        if (null !== $this->con) {
             curl_close($this->con);
         }
     }
@@ -220,7 +220,7 @@ 
         $this->url = NULL;
         $this->params = array();
         $this->headers = array();
-        Logger::log("Context service for " . get_called_class() . " cleared!");
+        Logger::log("Context service for ".get_called_class()." cleared!");
         $this->closeConnection();
     }
 

src/base/types/helpers/SecurityHelper.php

Spacing +21 added lines, -21 removed lines

@@ -29,7 +29,7 @@ 
         if (!Config::getInstance()->checkTryToSaveConfig()
             && (preg_match('/^\/(admin|setup\-admin)/i', $route) || NULL !== Config::getInstance()->get('restricted'))
         ) {
-            if (null === Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true)) {
+            if (null === Cache::getInstance()->getDataFromFile(CONFIG_DIR.DIRECTORY_SEPARATOR.'admins.json', Cache::JSONGZ, true)) {
                 throw new AdminCredentialsException();
             }
             if (!Security::getInstance()->checkAdmin()) {
@@ -49,8 +49,8 @@ 
         $token = '';
         $ct = strlen($ts);
         for ($i = 0; $i < $ct; $i++) {
-            $token = substr($hash, $i, 1) .
-                    substr($ts, $i, 1) .
+            $token = substr($hash, $i, 1).
+                    substr($ts, $i, 1).
                     $token;
         }
         return $token;
@@ -68,16 +68,16 @@ 
         $charsLength = strlen(self::RAND_SEP) - 1;
         $tsLength = strlen($ts);
         $i = 0;
-        $ct = ceil($hashRest / 4);
-        $part = substr($hash, $tsLength + $ct * $i, $ct);
-        while(false !== $part) {
-            $mixedToken .= $part .
-                substr(self::RAND_SEP, round(rand(0, $charsLength), 0, PHP_ROUND_HALF_DOWN), 1) .
+        $ct = ceil($hashRest/4);
+        $part = substr($hash, $tsLength + $ct*$i, $ct);
+        while (false !== $part) {
+            $mixedToken .= $part.
+                substr(self::RAND_SEP, round(rand(0, $charsLength), 0, PHP_ROUND_HALF_DOWN), 1).
                 substr(self::RAND_SEP, round(rand(0, $charsLength), 0, PHP_ROUND_HALF_DOWN), 1);
-            $part = substr($hash, $tsLength + $ct * $i, $ct);
+            $part = substr($hash, $tsLength + $ct*$i, $ct);
             $i++;
         }
-        return $mixedToken . $token;
+        return $mixedToken.$token;
     }
 
     /**
@@ -86,10 +86,10 @@ 
      */
     private static function getTs($isOdd = null) {
         $ts = time();
-        $tsIsOdd = (bool)((int)substr($ts, -1) % 2);
-        if(false === $isOdd && !$tsIsOdd) {
+        $tsIsOdd = (bool)((int)substr($ts, -1)%2);
+        if (false === $isOdd && !$tsIsOdd) {
             $ts--;
-        } elseif(true === $isOdd && !$tsIsOdd) {
+        } elseif (true === $isOdd && !$tsIsOdd) {
             $ts--;
         }
         return $ts;
@@ -121,10 +121,10 @@ 
         $partToken = '';
         $ts = '';
         $part = strrev($part);
-        for($i = 0, $ct = strlen($part); $i < $ct; $i++) {
-            if($i % 2 == 0) {
+        for ($i = 0, $ct = strlen($part); $i < $ct; $i++) {
+            if ($i%2 == 0) {
                 $ts .= substr($part, $i, 1);
-            } else {
+            }else {
                 $partToken .= substr($part, $i, 1);
             }
         }
@@ -139,11 +139,11 @@ 
     private static function parseTokenParts(array $parts) {
         $token = '';
         list($partToken, $ts) = self::extractTs(array_pop($parts));
-        if($ts > 0) {
-            foreach($parts as $part) {
+        if ($ts > 0) {
+            foreach ($parts as $part) {
                 $token .= $part;
             }
-            $token = $partToken . $token;
+            $token = $partToken.$token;
         }
         return [$token, $ts];
     }
@@ -171,8 +171,8 @@ 
      * @return array
      */
     private static function extractTokenParts($token) {
-        for($i = 0, $ct = strlen(self::RAND_SEP); $i < $ct; $i++) {
-            $token = str_replace(substr(self::RAND_SEP,$i,1), "|", $token);
+        for ($i = 0, $ct = strlen(self::RAND_SEP); $i < $ct; $i++) {
+            $token = str_replace(substr(self::RAND_SEP, $i, 1), "|", $token);
         }
         return array_unique(explode('||', $token));
     }