psfs / core

src/base/types/interfaces/ControllerInterface.php

Doc Comments +6 added lines

@@ -8,7 +8,13 @@
  */
 interface ControllerInterface
 {
+    /**
+     * @return string|null
+     */
     public function render($template, array $vars = [], $cookies = []);
 
+    /**
+     * @return void
+     */
     public function response($response, $type = 'text/html');
 }

src/services/AdminServices.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use PSFS\base\config\Config;
 use PSFS\base\Security;
 use PSFS\base\Service;
-use PSFS\controller\Admin;
 use Symfony\Component\Finder\Finder;
 
 class AdminServices extends Service

Spacing +5 added lines, -5 removed lines

@@ -34,7 +34,7 @@ 
     {
         $platform = trim(Config::getInstance()->get("platform_name"));
         header('HTTP/1.1 401 Unauthorized');
-        header('WWW-Authenticate: Basic Realm="' . $platform . '"');
+        header('WWW-Authenticate: Basic Realm="'.$platform.'"');
         echo _("Zona restringida");
         exit();
     }
@@ -75,7 +75,7 @@ 
                         $admin['class'] = 'primary';
                         break;
                 }
-            } else {
+            }else {
                 $admin["class"] = "primary";
             }
         }
@@ -92,7 +92,7 @@ 
         $logs = array();
         /** @var \SplFileInfo $file */
         foreach ($files as $file) {
-            $size = $file->getSize() / 8 / 1024;
+            $size = $file->getSize()/8/1024;
             $time = date("c", $file->getMTime());
             $dateTime = new \DateTime($time);
             if (!isset($logs[$dateTime->format("Y")])) $logs[$dateTime->format("Y")] = array();
@@ -128,7 +128,7 @@ 
             $time = date("c", $file->getMTime());
             $dateTime = new \DateTime($time);
             $monthOpen = $dateTime->format("m");
-            $content = file($file->getPath() . DIRECTORY_SEPARATOR . $file->getFilename());
+            $content = file($file->getPath().DIRECTORY_SEPARATOR.$file->getFilename());
             krsort($content);
             $detailLog = array();
             foreach ($content as &$line) {
@@ -181,7 +181,7 @@ 
                     break;
             }
 
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             $detail = array(
                 "type" => "danger",
             );

Braces +12 added lines, -4 removed lines

@@ -61,11 +61,13 @@ 
      */
     private function parseAdmins(&$admins)
     {
-        if (!empty($admins)) foreach ($admins as &$admin) {
+        if (!empty($admins)) {
+            foreach ($admins as &$admin) {
             if (isset($admin["profile"])) {
                 switch ($admin["profile"]) {
                     case Security::MANAGER_ID_TOKEN:
                         $admin['class'] = 'warning';
+        }
                         break;
                     case Security::ADMIN_ID_TOKEN:
                         $admin['class'] = 'info';
@@ -95,7 +97,9 @@ 
             $size = $file->getSize() / 8 / 1024;
             $time = date("c", $file->getMTime());
             $dateTime = new \DateTime($time);
-            if (!isset($logs[$dateTime->format("Y")])) $logs[$dateTime->format("Y")] = array();
+            if (!isset($logs[$dateTime->format("Y")])) {
+                $logs[$dateTime->format("Y")] = array();
+            }
             $logs[$dateTime->format("Y")][$dateTime->format("m")][$time] = array(
                 "filename" => $file->getFilename(),
                 "size" => round($size, 3)
@@ -136,7 +140,9 @@ 
                 $detailLog[] = array_merge(array(
                     "log" => $line,
                 ), $detail);
-                if (count($detailLog) >= 1000) break;
+                if (count($detailLog) >= 1000) {
+                    break;
+                }
             }
             $log = $detailLog;
         }
@@ -160,7 +166,9 @@ 
 
                 $detail = json_decode($match[0][0], TRUE);
             }
-            if (empty($detail)) $detail = array();
+            if (empty($detail)) {
+                $detail = array();
+            }
             preg_match_all('/\>\ (.*):/i', $line, $match);
 
             $type = (isset($match[1][0])) ? $match[1][0] : '';

src/services/DocumentorService.php

Doc Comments +1 added lines, -1 removed lines

@@ -360,7 +360,7 @@
      * Translator from php types to swagger types
      * @param string $format
      *
-     * @return array
+     * @return string[]
      */
     public static function translateSwaggerFormats($format)
     {

Spacing +11 added lines, -11 removed lines

@@ -39,10 +39,10 @@ 
                     if (!preg_match('/^ROOT/i', $module)) {
                         $modules[] = [
                             'name' => $module,
-                            'path' => realpath($info['template'] . DIRECTORY_SEPARATOR . '..'),
+                            'path' => realpath($info['template'].DIRECTORY_SEPARATOR.'..'),
                         ];
                     }
-                } catch (\Exception $e) {
+                }catch (\Exception $e) {
                     $modules[] = $e->getMessage();
                 }
             }
@@ -60,7 +60,7 @@ 
      */
     public function extractApiEndpoints(array $module)
     {
-        $module_path = $module['path'] . DIRECTORY_SEPARATOR . 'Api';
+        $module_path = $module['path'].DIRECTORY_SEPARATOR.'Api';
         $module_name = $module['name'];
         $endpoints = [];
         if (file_exists($module_path)) {
@@ -69,7 +69,7 @@ 
             if (count($finder)) {
                 /** @var \SplFileInfo $file */
                 foreach ($finder as $file) {
-                    $namespace = "\\{$module_name}\\Api\\" . str_replace('.php', '', $file->getFilename());
+                    $namespace = "\\{$module_name}\\Api\\".str_replace('.php', '', $file->getFilename());
                     $info = $this->extractApiInfo($namespace, $module_name);
                     if (!empty($info)) {
                         $endpoints[$namespace] = $info;
@@ -98,7 +98,7 @@ 
                     if (NULL !== $mInfo) {
                         $info[] = $mInfo;
                     }
-                } catch (\Exception $e) {
+                }catch (\Exception $e) {
                     Logger::getInstance()->errorLog($e->getMessage());
                 }
             }
@@ -309,7 +309,7 @@ 
             } elseif (null !== $reflector && $reflector->isSubclassOf(self::DTO_INTERFACE)) {
                 $payload = $this->extractDtoProperties($namespace);
             }
-        } catch (\Exception $e) {
+        }catch (\Exception $e) {
             Logger::getInstance()->errorLog($e->getMessage());
         }
 
@@ -346,7 +346,7 @@ 
                     if (in_array($methodInfo['method'], ['POST', 'PUT'])) {
                         $methodInfo['payload'] = $this->extractPayload($modelNamespace, $docComments);
                     }
-                } catch (\Exception $e) {
+                }catch (\Exception $e) {
                     jpre($e->getMessage());
                     Logger::getInstance()->errorLog($e->getMessage());
                 }
@@ -425,13 +425,13 @@ 
                         ]]);
                         if (array_key_exists($subDtoName, $subDto)) {
                             $definitions = $subDto;
-                        } else {
+                        }else {
                             $definitions[$subDtoName] = $subDto;
                         }
                         $dto['properties'][$field] = [
-                            '$ref' => "#/definitions/" . $subDtoName,
+                            '$ref' => "#/definitions/".$subDtoName,
                         ];
-                    } else {
+                    }else {
                         list($type, $format) = self::translateSwaggerFormats($format);
                         $dto['properties'][$field] = [
                             "type" => $type,
@@ -489,7 +489,7 @@ 
     protected function extractDtoName($dto, $isArray = false)
     {
         $dto = explode('\\', $dto);
-        $modelDto = array_pop($dto) . "Dto";
+        $modelDto = array_pop($dto)."Dto";
         if ($isArray) {
             $modelDto .= "List";
         }

src/base/config/LoginForm.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
             ))
             ->addButton('submit', _("Acceder como {{username}}"))
             ->addButton("cancel", _("Cancelar"), "button", array(
-                "onclick" => "javacript:location.href = \"" . Router::getInstance()->getRoute('') . "\";",
+                "onclick" => "javacript:location.href = \"".Router::getInstance()->getRoute('')."\";",
                 "class" => "btn-link",
             ));
     }

src/base/config/ConfigForm.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
             "class" => "btn-success col-md-offset-2"
         ))
             ->addButton('add_field', _('Añadir nuevo parámetro'), 'button', array(
-                "onclick" => "javascript:addNewField(document.getElementById('" . $this->getName() . "'));",
+                "onclick" => "javascript:addNewField(document.getElementById('".$this->getName()."'));",
                 "class" => "btn-warning",
             ));
     }

src/base/dto/Dto.php

Spacing +2 added lines, -2 removed lines

@@ -36,8 +36,8 @@
                     $dto[$property->getName()] = $property->getValue($this);
                 }
             }
-        } catch (\Exception $e) {
-            Logger::log(get_class($this) . ': ' . $e->getMessage(), LOG_ERR);
+        }catch (\Exception $e) {
+            Logger::log(get_class($this).': '.$e->getMessage(), LOG_ERR);
         }
         return $dto;
     }

src/base/dto/Order.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     {
         if (preg_match('/^asc$/i', $direction)) {
             return Order::ASC;
-        } else {
+        }else {
             return Order::DESC;
         }
     }

src/base/types/Controller.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
     {
         $vars['__menu__'] = $this->getMenu();
         $domain = (null === $domain) ? $this->getDomain() : $domain;
-        return $this->tpl->render($domain . $template, $vars, $cookies);
+        return $this->tpl->render($domain.$template, $vars, $cookies);
     }
 
     /**
@@ -67,7 +67,7 @@ 
     {
         $vars['__menu__'] = $this->getMenu();
         $domain = $domain ?: $this->getDomain();
-        return $this->tpl->dump($domain . $template, $vars);
+        return $this->tpl->dump($domain.$template, $vars);
     }
 
     /**
@@ -96,15 +96,15 @@ 
         /////////////////////////////////////////////////////////////
         // Date in the past sets the value to already have been expired.
         header("Expires: Sat, 26 Jul 1997 05:00:00 GMT");
-        header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
+        header('Last-Modified: '.gmdate('D, d M Y H:i:s').' GMT');
         header('Cache-Control: no-store, no-cache, must-revalidate'); // HTTP/1.1
         header('Cache-Control: pre-check=0, post-check=0, max-age=0'); // HTTP/1.1
         header("Pragma: no-cache");
         header("Expires: 0");
         header('Content-Transfer-Encoding: none');
-        header("Content-type: " . $content);
-        header("Content-length: " . strlen($data));
-        header('Content-Disposition: attachment; filename="' . $filename . '"');
+        header("Content-type: ".$content);
+        header("Content-length: ".strlen($data));
+        header('Content-Disposition: attachment; filename="'.$filename.'"');
         echo $data;
         ob_flush();
         ob_end_clean();

src/base/types/AuthApi.php

Spacing +2 added lines, -2 removed lines

@@ -26,13 +26,13 @@
     {
         $namespace = explode('\\', $this->getModelTableMap());
         $module = strtolower($namespace[0]);
-        $secret = Config::getInstance()->get($module . '.api.secret');
+        $secret = Config::getInstance()->get($module.'.api.secret');
         if (NULL === $secret) {
             $secret = Config::getInstance()->get("api.secret");
         }
         if (NULL === $secret) {
             $auth = TRUE;
-        } else {
+        }else {
             $token = Request::getInstance()->getHeader('X-API-SEC-TOKEN');
             if (array_key_exists('API_TOKEN', $this->query)) {
                 $token = $this->query['API_TOKEN'];