Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | class Request |
||
23 | { |
||
24 | use SingletonTrait; |
||
25 | protected $server; |
||
26 | protected $cookies; |
||
27 | protected $upload; |
||
28 | protected $header; |
||
29 | protected $data; |
||
30 | protected $query; |
||
31 | private $isLoaded = false; |
||
32 | |||
33 | 2 | public function init() |
|
47 | |||
48 | /** |
||
49 | * @return bool |
||
50 | */ |
||
51 | 1 | public function isLoaded() { |
|
54 | |||
55 | /** |
||
56 | * Método que devuelve las cabeceras de la petición |
||
57 | * @return array |
||
58 | */ |
||
59 | 2 | private function parseHeaders() |
|
63 | |||
64 | /** |
||
65 | * Método que verifica si existe una cabecera concreta |
||
66 | * @param $header |
||
67 | * |
||
68 | * @return boolean |
||
69 | */ |
||
70 | 1 | public function hasHeader($header) |
|
74 | |||
75 | |||
76 | /** |
||
77 | * Método que indica si una petición tiene cookies |
||
78 | * @return boolean |
||
79 | */ |
||
80 | 1 | public function hasCookies() |
|
84 | |||
85 | /** |
||
86 | * Método que indica si una petición tiene cookies |
||
87 | * @return boolean |
||
88 | */ |
||
89 | 1 | public function hasUpload() |
|
93 | |||
94 | /** |
||
95 | * Método que devuelve el TimeStamp de la petición |
||
96 | * |
||
97 | * @param boolean $formatted |
||
98 | * |
||
99 | * @return string |
||
100 | */ |
||
101 | public static function ts($formatted = false) |
||
105 | |||
106 | 1 | public function getTs($formatted = false) |
|
110 | |||
111 | /** |
||
112 | * Método que devuelve el Método HTTP utilizado |
||
113 | * @return string |
||
114 | */ |
||
115 | 3 | public function getMethod() |
|
119 | |||
120 | /** |
||
121 | * Método que devuelve una cabecera de la petición si existe |
||
122 | * @param $name |
||
123 | * |
||
124 | * @return string|null |
||
125 | */ |
||
126 | public static function header($name) |
||
130 | |||
131 | public function getHeader($name) |
||
139 | |||
140 | /** |
||
141 | * Método que devuelve la url solicitada |
||
142 | * @return string|null |
||
143 | */ |
||
144 | public static function requestUri() |
||
148 | |||
149 | /** |
||
150 | * @return string |
||
151 | */ |
||
152 | 6 | public function getRequestUri() |
|
156 | |||
157 | /** |
||
158 | * Método que devuelve el idioma de la petición |
||
159 | * @return string |
||
160 | */ |
||
161 | public function getLanguage() |
||
165 | |||
166 | /** |
||
167 | * Método que determina si se ha solicitado un fichero |
||
168 | * @return boolean |
||
169 | */ |
||
170 | 4 | public function isFile() |
|
175 | |||
176 | /** |
||
177 | * Get query params |
||
178 | * |
||
179 | * @param string $queryParams |
||
180 | * |
||
181 | * @return mixed |
||
182 | */ |
||
183 | public function getQuery($queryParams) |
||
187 | |||
188 | /** |
||
189 | * Get all query params |
||
190 | * |
||
191 | * @return mixed |
||
192 | */ |
||
193 | public function getQueryParams() |
||
197 | |||
198 | /** |
||
199 | * Método que devuelve un parámetro de la solicitud |
||
200 | * @param string $param |
||
201 | * |
||
202 | * @return string|null |
||
203 | */ |
||
204 | public function get($param) |
||
208 | |||
209 | /** |
||
210 | * Método que devuelve todos los datos del Request |
||
211 | * @return array |
||
212 | */ |
||
213 | public function getData() |
||
217 | |||
218 | /** |
||
219 | * Método que realiza una redirección a la url dada |
||
220 | * @param string $url |
||
221 | */ |
||
222 | public function redirect($url = null) |
||
231 | |||
232 | /** |
||
233 | * Devuelve un parámetro de $_SERVER |
||
234 | * @param string $param |
||
235 | * |
||
236 | * @return string|null |
||
237 | */ |
||
238 | 3 | public function getServer($param) |
|
242 | |||
243 | /** |
||
244 | * Devuelve el nombre del servidor |
||
245 | * @return string|null |
||
246 | */ |
||
247 | public function getServerName() |
||
251 | |||
252 | /** |
||
253 | * Devuelve el protocolo de la conexión |
||
254 | * @return string |
||
255 | */ |
||
256 | public function getProtocol() |
||
260 | |||
261 | /** |
||
262 | * Devuelve la url completa de base |
||
263 | * @param boolean $protocol |
||
264 | * @return string |
||
265 | */ |
||
266 | public function getRootUrl($protocol = true) |
||
277 | |||
278 | /** |
||
279 | * Método que devuelve el valor de una cookie en caso de que exista |
||
280 | * @param string $name |
||
281 | * |
||
282 | * @return string |
||
283 | */ |
||
284 | 1 | public function getCookie($name) |
|
288 | |||
289 | /** |
||
290 | * Método que devuelve los files subidos por POST |
||
291 | * @param $name |
||
292 | * |
||
293 | * @return array |
||
294 | */ |
||
295 | public function getFile($name) |
||
299 | |||
300 | /** |
||
301 | * Método que devuelve si la petición es ajax o no |
||
302 | * @return boolean |
||
303 | */ |
||
304 | 1 | public function isAjax() |
|
309 | |||
310 | } |
||
311 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: