Security - Code Metrics - Inspection of "Improvements in security" - psfs/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6df67e...d71c1b )

by Fran

created 2017-08-22 22:01 UTC

Security C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	413
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

93.43%

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	413
ccs	128
cts	137
cp	0.9343
rs	6.3005
c	1
b	1
f	0
wmc	58
lcom	1
cbo	6

26 Methods

Rating	Name	Size	Complexity
B	init()	15	6
A	initSession()	9	4
A	getProfiles()	8	1
A	getAdminProfiles()	4	1
A	getCleanProfiles()	8	1
A	getAdminCleanProfiles()	4	1
A	save()	15	3
A	saveUser()	8	2
A	updateUser()	4	1
A	getAdmins()	4	1
C	checkAdmin()	33	13
A	getAdminFromCookie()	10	2
A	getHash()	4	1
A	getUser()	4	1
A	getAdmin()	4	1
A	canAccessRestrictedAdmin()	4	2
A	notAuthorized()	6	1
A	isSuperAdmin()	11	2
A	getSessionKey()	9	2
A	setSessionKey()	6	1
A	getFlashes()	6	2
A	clearFlashes()	6	1
A	setFlash()	9	2
A	getFlash()	6	3
A	updateSession()	14	2
A	closeSession()	7	1

How to fix Complexity

<?php
namespace PSFS\base;

use PSFS\base\types\traits\SecureTrait;
use PSFS\base\types\traits\SingletonTrait;

/**
 * Class Security
 * @package PSFS
 */
class Security
{
    // sha1('user')
    const USER_ID_TOKEN = '12dea96fec20593566ab75692c9949596833adc9';
    // sha1('admin')
    const MANAGER_ID_TOKEN = 'd033e22ae348aeb5660fc2140aec35850c4da997';
    // sha1('superadmin')
    const ADMIN_ID_TOKEN = '889a3a791b3875cfae413574b53da4bb8a90d53e';
    // sha1('FLASHES')
    const FLASH_MESSAGE_TOKEN = '4680c68435db1bfbf17c3fcc4f7b39d2c6122504';

    use SecureTrait;
    use SingletonTrait;
    /**
     * @var array $user
     */
    private $user = null;

    /**
     * @var array $admin
     */
    private $admin = null;

    /**
     * @var bool $authorized
     */
    private $authorized = FALSE;

    /**
     * @var bool $checked
     */
    private $checked = false;

    /**
     * @var array $session
     */
    protected $session;

    /**
     * Constructor por defecto
     */
    public function init()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->initSession();
        $this->session = (is_null($_SESSION)) ? array() : $_SESSION;
        if (NULL === $this->getSessionKey('__FLASH_CLEAR__')) {
            $this->clearFlashes();
            $this->setSessionKey('__FLASH_CLEAR__', microtime(TRUE));
        }
        $this->user = (array_key_exists(self::USER_ID_TOKEN, $this->session)) ? unserialize($this->session[self::USER_ID_TOKEN]) : NULL;

        $this->admin = (array_key_exists(self::ADMIN_ID_TOKEN, $this->session)) ? unserialize($this->session[self::ADMIN_ID_TOKEN]) : NULL;

        if (null === $this->admin) {
            $this->checkAdmin();
        }
        $this->setLoaded(true);
    }

    /**
     * Initializator for SESSION
     */
    private function initSession() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        if (PHP_SESSION_NONE === session_status() && !headers_sent()) {
            session_start();
        }
        // Fix for phpunits
        if(!isset($_SESSION)) {
            $_SESSION = [];
        }
    }

    /**
     * Método estático que devuelve los perfiles de la plataforma
     * @return array
     */
    public static function getProfiles()
    {
        return array(
            self::ADMIN_ID_TOKEN => _('Administrador'),
            self::MANAGER_ID_TOKEN => _('Gestor'),
            self::USER_ID_TOKEN => _('Usuario'),
        );
    }

    /**
     * Method that returns all the available profiles
     * @return array
     */
    public function getAdminProfiles()
    {
        return static::getProfiles();
    }

    /**
     * Método estático que devuelve los perfiles disponibles
     * @return array

     */
    public static function getCleanProfiles()
    {
        return array(
            '__SUPER_ADMIN__' => self::ADMIN_ID_TOKEN,
            '__ADMIN__' => self::MANAGER_ID_TOKEN,
            '__USER__' => self::USER_ID_TOKEN,
        );
    }

    /**
     * Método estático que devuelve los perfiles disponibles
     * @return array

     */
    public function getAdminCleanProfiles()
    {
        return static::getCleanProfiles();
    }

    /**
     * Método que guarda los administradores
     *
     * @param array $user
     *
     * @return bool
     */
    public static function save($user)
    {
        $saved = true;
        try {
            $admins = Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true) ?: [];

            $admins[$user['username']]['hash'] = sha1($user['username'] . $user['password']);
            $admins[$user['username']]['profile'] = $user['profile'];

            Cache::getInstance()->storeData(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', $admins, Cache::JSONGZ, true);

        } catch(\Exception $e) {
            Logger::log($e->getMessage(), LOG_ERR);
            $saved = false;
        }
        return $saved;
    }

    /**
     * Method to save a new admin user
     * @param array $user
     * @return bool
     */
    public function saveUser($user)
    {
        $saved = false;
        if (!empty($user)) {
            $saved = static::save($user);
        }
        return $saved;
    }

    /**
     * Servicio que actualiza los datos del usuario
     *
     * @param $user
     */
    public function updateUser($user)
    {
        $this->user = $user;
    }

    /**
     * Método que devuelve los administradores de una plataforma
     * @return array|null

     */
    public function getAdmins()
    {
        return Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true);

    }

    /**
     * Método que devuelve si un usuario tiene privilegios para acceder a la zona de administración
     *
     * @param null $user
     * @param null $pass
     * @param boolean $force
     *
     * @return bool
     * @throws \HttpException
     */
    public function checkAdmin($user = NULL, $pass = NULL, $force = false)
    {
        Logger::log('Checking admin session');
        if ((!$this->authorized && !$this->checked) || $force) {
            $admins = $this->getAdmins();
            if (null !== $admins) {
                $request = Request::getInstance();
                //Sacamos las credenciales de la petición
                $user = $user ?: $request->getServer('PHP_AUTH_USER');
                $pass = $pass ?: $request->getServer('PHP_AUTH_PW');
                if (NULL === $user || (array_key_exists($user, $admins) && empty($admins[$user]))) {
                    list($user, $pass) = $this->getAdminFromCookie();
                }
                if (!empty($user) && !empty($admins[$user])) {
                    $auth = $admins[$user]['hash'];
                    $this->authorized = ($auth == sha1($user . $pass));
                    if ($this->authorized) {
                        $this->admin = array(
                            'alias' => $user,
                            'profile' => $admins[$user]['profile'],
                        );
                        $this->setSessionKey(self::ADMIN_ID_TOKEN, serialize($this->admin));
                    }
                } else {
                    $this->admin = null;
                    $this->setSessionKey(self::ADMIN_ID_TOKEN, null);
                }
                $this->checked = true;
            }
        }

        return $this->authorized;
    }

    /**
     * Método que obtiene el usuario y contraseña de la cookie de sesión de administración
     * @return array
     */
    protected function getAdminFromCookie()
    {
        $auth_cookie = Request::getInstance()->getCookie($this->getHash());
        $user = $pass = array();
        if (!empty($auth_cookie)) {
            list($user, $pass) = explode(':', base64_decode($auth_cookie));
        }

        return array($user, $pass);
    }

    /**
     * Método privado para la generación del hash de la cookie de administración
     * @return string
     */
    public function getHash()
    {
        return substr(self::MANAGER_ID_TOKEN, 0, 8);
    }

    /**
     * Método que devuelve el usuario logado
     * @return array
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * Método que devuelve el usuario administrador logado
     * @return array
     */
    public function getAdmin()
    {
        return $this->admin;
    }

    /**
     * Método que calcula si se está logado o para acceder a administración
     * @return bool
     */
    public function canAccessRestrictedAdmin()
    {
        return null !== $this->admin && !preg_match('/^\/admin\/login/i', Request::requestUri());
    }

    /**
     * Servicio que devuelve una pantalla de error porque se necesita estar authenticado
     *
     * @param string|null $route
     *
     * @return string|null
     */
    public function notAuthorized($route)
    {
        return Template::getInstance()->render('notauthorized.html.twig', array(
            'route' => $route,
        ));
    }

    /**
     * Servicio que chequea si un usuario es super administrador o no
     * @return bool
     */
    public function isSuperAdmin()
    {
        $users = $this->getAdmins();
        $logged = $this->getAdmin();
        if ($users[$logged['alias']]) {
            $security = $users[$logged['alias']]['profile'];
            return self::ADMIN_ID_TOKEN === $security;
        }

        return FALSE;
    }

    /**
     * Servicio que devuelve un dato de sesión
     *
     * @param string $key
     *
     * @return mixed
     */
    public function getSessionKey($key)
    {
        $data = NULL;
        if (array_key_exists($key, $this->session)) {
            $data = $this->session[$key];
        }

        return $data;
    }

    /**
     * Servicio que setea una variable de sesión
     *
     * @param string $key
     * @param mixed $data
     *
     * @return Security
     */
    public function setSessionKey($key, $data = NULL)
    {
        $this->session[$key] = $data;

        return $this;
    }

    /**
     * Servicio que devuelve los mensajes flash de sesiones
     * @return mixed
     */
    public function getFlashes()
    {
        $flashes = $this->getSessionKey(self::FLASH_MESSAGE_TOKEN);

        return (NULL !== $flashes) ? $flashes : array();
    }

    /**
     * Servicio que limpia los mensajes flash
     * @return $this
     */
    public function clearFlashes()
    {
        $this->setSessionKey(self::FLASH_MESSAGE_TOKEN, NULL);

        return $this;
    }

    /**
     * Servicio que inserta un flash en sesión
     *
     * @param string $key
     * @param mixed $data
     */
    public function setFlash($key, $data = NULL)
    {
        $flashes = $this->getFlashes();
        if (!is_array($flashes)) {
            $flashes = array();
        }
        $flashes[$key] = $data;
        $this->setSessionKey(self::FLASH_MESSAGE_TOKEN, $flashes);
    }

    /**
     * Servicio que devuelve un flash de sesión
     *
     * @param string $key
     *
     * @return mixed
     */
    public function getFlash($key)
    {
        $flashes = $this->getFlashes();

        return (NULL !== $key && array_key_exists($key, $flashes)) ? $flashes[$key] : NULL;
    }

    /**
     * Servicio que actualiza
     *
     * @param boolean $closeSession
     *
     * @return Security
     */
    public function updateSession($closeSession = FALSE)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        Logger::log('Update session');
        $_SESSION = $this->session;
        $_SESSION[self::USER_ID_TOKEN] = serialize($this->user);
        $_SESSION[self::ADMIN_ID_TOKEN] = serialize($this->admin);
        if ($closeSession) {
            Logger::log('Close session');
            @session_write_close();
            @session_start();
        }
        Logger::log('Session updated');
        return $this;
    }

    /**
     * Servicio que limpia la sesión
     */
    public function closeSession()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        unset($_SESSION);
        @session_destroy();
        @session_regenerate_id(TRUE);
        @session_start();
    }

}


1		<?php
2		namespace PSFS\base;
3
4		use PSFS\base\types\traits\SecureTrait;
5		use PSFS\base\types\traits\SingletonTrait;
6
7		/**
8		* Class Security
9		* @package PSFS
10		*/
11		class Security
12		{
13		// sha1('user')
14		const USER_ID_TOKEN = '12dea96fec20593566ab75692c9949596833adc9';
15		// sha1('admin')
16		const MANAGER_ID_TOKEN = 'd033e22ae348aeb5660fc2140aec35850c4da997';
17		// sha1('superadmin')
18		const ADMIN_ID_TOKEN = '889a3a791b3875cfae413574b53da4bb8a90d53e';
19		// sha1('FLASHES')
20		const FLASH_MESSAGE_TOKEN = '4680c68435db1bfbf17c3fcc4f7b39d2c6122504';
21
22		use SecureTrait;
23		use SingletonTrait;
24		/**
25		* @var array $user
26		*/
27		private $user = null;
28
29		/**
30		* @var array $admin
31		*/
32		private $admin = null;
33
34		/**
35		* @var bool $authorized
36		*/
37		private $authorized = FALSE;
38
39		/**
40		* @var bool $checked
41		*/
42		private $checked = false;
43
44		/**
45		* @var array $session
46		*/
47		protected $session;
48
49		/**
50		* Constructor por defecto
51		*/
52	2	public function init()
		0 ignored issues – show Coding Style introduced 2017-08-03 10:43 UTC by Report Bug Copy Issue Report `init` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
53		{
54	2	$this->initSession();
55	2	$this->session = (is_null($_SESSION)) ? array() : $_SESSION;
56	2	if (NULL === $this->getSessionKey('__FLASH_CLEAR__')) {
57	2	$this->clearFlashes();
58	2	$this->setSessionKey('__FLASH_CLEAR__', microtime(TRUE));
59		}
60	2	$this->user = (array_key_exists(self::USER_ID_TOKEN, $this->session)) ? unserialize($this->session[self::USER_ID_TOKEN]) : NULL;
		0 ignored issues – show Coding Style introduced 2016-08-18 23:39 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 136 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
61	2	$this->admin = (array_key_exists(self::ADMIN_ID_TOKEN, $this->session)) ? unserialize($this->session[self::ADMIN_ID_TOKEN]) : NULL;
		0 ignored issues – show Coding Style introduced 2016-08-18 23:39 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 139 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
62	2	if (null === $this->admin) {
63	2	$this->checkAdmin();
64		}
65	2	$this->setLoaded(true);
66	2	}
67
68		/**
69		* Initializator for SESSION
70		*/
71	2	private function initSession() {
		0 ignored issues – show Coding Style introduced 2017-08-03 10:43 UTC by Report Bug Copy Issue Report `initSession` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
72	2	if (PHP_SESSION_NONE === session_status() && !headers_sent()) {
73		session_start();
74		}
75		// Fix for phpunits
76	2	if(!isset($_SESSION)) {
77	1	$_SESSION = [];
78		}
79	2	}
80
81		/**
82		* Método estático que devuelve los perfiles de la plataforma
83		* @return array
84		*/
85	2	public static function getProfiles()
86		{
87		return array(
88	2	self::ADMIN_ID_TOKEN => _('Administrador'),
89	2	self::MANAGER_ID_TOKEN => _('Gestor'),
90	2	self::USER_ID_TOKEN => _('Usuario'),
91		);
92		}
93
94		/**
95		* Method that returns all the available profiles
96		* @return array
97		*/
98	1	public function getAdminProfiles()
99		{
100	1	return static::getProfiles();
101		}
102
103		/**
104		* Método estático que devuelve los perfiles disponibles
105		* @return array
		0 ignored issues – show Documentation introduced 2017-04-26 14:48 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
106		*/
107	2	public static function getCleanProfiles()
108		{
109		return array(
110	2	'__SUPER_ADMIN__' => self::ADMIN_ID_TOKEN,
111	2	'__ADMIN__' => self::MANAGER_ID_TOKEN,
112	2	'__USER__' => self::USER_ID_TOKEN,
113		);
114		}
115
116		/**
117		* Método estático que devuelve los perfiles disponibles
118		* @return array
		0 ignored issues – show Documentation introduced 2016-08-18 21:22 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
119		*/
120	1	public function getAdminCleanProfiles()
121		{
122	1	return static::getCleanProfiles();
123		}
124
125		/**
126		* Método que guarda los administradores
127		*
128		* @param array $user
129		*
130		* @return bool
131		*/
132	1	public static function save($user)
133		{
134	1	$saved = true;
135		try {
136	1	$admins = Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true) ?: [];
		0 ignored issues – show Coding Style introduced 2017-02-17 23:01 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 137 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
137	1	$admins[$user['username']]['hash'] = sha1($user['username'] . $user['password']);
138	1	$admins[$user['username']]['profile'] = $user['profile'];
139
140	1	Cache::getInstance()->storeData(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', $admins, Cache::JSONGZ, true);
		0 ignored issues – show Coding Style introduced 2016-05-07 10:58 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 124 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
141		} catch(\Exception $e) {
142		Logger::log($e->getMessage(), LOG_ERR);
143		$saved = false;
144		}
145	1	return $saved;
146		}
147
148		/**
149		* Method to save a new admin user
150		* @param array $user
151		* @return bool
152		*/
153	1	public function saveUser($user)
154		{
155	1	$saved = false;
156	1	if (!empty($user)) {
157	1	$saved = static::save($user);
158		}
159	1	return $saved;
160		}
161
162		/**
163		* Servicio que actualiza los datos del usuario
164		*
165		* @param $user
166		*/
167	1	public function updateUser($user)
168		{
169	1	$this->user = $user;
170	1	}
171
172		/**
173		* Método que devuelve los administradores de una plataforma
174		* @return array\|null
		0 ignored issues – show Documentation introduced 2017-02-17 23:01 UTC by Report Bug Copy Issue Report Should the return type not be `array\|string\|null`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
175		*/
176	4	public function getAdmins()
177		{
178	4	return Cache::getInstance()->getDataFromFile(CONFIG_DIR . DIRECTORY_SEPARATOR . 'admins.json', Cache::JSONGZ, true);
		0 ignored issues – show Coding Style introduced 2017-02-17 23:01 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 124 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
179		}
180
181		/**
182		* Método que devuelve si un usuario tiene privilegios para acceder a la zona de administración
183		*
184		* @param null $user
185		* @param null $pass
186		* @param boolean $force
187		*
188		* @return bool
189		* @throws \HttpException
190		*/
191	3	public function checkAdmin($user = NULL, $pass = NULL, $force = false)
192		{
193	3	Logger::log('Checking admin session');
194	3	if ((!$this->authorized && !$this->checked) \|\| $force) {
195	3	$admins = $this->getAdmins();
196	3	if (null !== $admins) {
197	1	$request = Request::getInstance();
198		//Sacamos las credenciales de la petición
199	1	$user = $user ?: $request->getServer('PHP_AUTH_USER');
200	1	$pass = $pass ?: $request->getServer('PHP_AUTH_PW');
201	1	if (NULL === $user \|\| (array_key_exists($user, $admins) && empty($admins[$user]))) {
202	1	list($user, $pass) = $this->getAdminFromCookie();
203		}
204	1	if (!empty($user) && !empty($admins[$user])) {
205	1	$auth = $admins[$user]['hash'];
206	1	$this->authorized = ($auth == sha1($user . $pass));
207	1	if ($this->authorized) {
208	1	$this->admin = array(
209	1	'alias' => $user,
210	1	'profile' => $admins[$user]['profile'],
211		);
212	1	$this->setSessionKey(self::ADMIN_ID_TOKEN, serialize($this->admin));
213		}
214		} else {
215	1	$this->admin = null;
216	1	$this->setSessionKey(self::ADMIN_ID_TOKEN, null);
217		}
218	1	$this->checked = true;
219		}
220		}
221
222	3	return $this->authorized;
223		}
224
225		/**
226		* Método que obtiene el usuario y contraseña de la cookie de sesión de administración
227		* @return array
228		*/
229	1	protected function getAdminFromCookie()
230		{
231	1	$auth_cookie = Request::getInstance()->getCookie($this->getHash());
232	1	$user = $pass = array();
233	1	if (!empty($auth_cookie)) {
234	1	list($user, $pass) = explode(':', base64_decode($auth_cookie));
235		}
236
237	1	return array($user, $pass);
238		}
239
240		/**
241		* Método privado para la generación del hash de la cookie de administración
242		* @return string
243		*/
244	1	public function getHash()
245		{
246	1	return substr(self::MANAGER_ID_TOKEN, 0, 8);
247		}
248
249		/**
250		* Método que devuelve el usuario logado
251		* @return array
252		*/
253	2	public function getUser()
254		{
255	2	return $this->user;
256		}
257
258		/**
259		* Método que devuelve el usuario administrador logado
260		* @return array
261		*/
262	2	public function getAdmin()
263		{
264	2	return $this->admin;
265		}
266
267		/**
268		* Método que calcula si se está logado o para acceder a administración
269		* @return bool
270		*/
271	3	public function canAccessRestrictedAdmin()
272		{
273	3	return null !== $this->admin && !preg_match('/^\/admin\/login/i', Request::requestUri());
274		}
275
276		/**
277		* Servicio que devuelve una pantalla de error porque se necesita estar authenticado
278		*
279		* @param string\|null $route
280		*
281		* @return string\|null
282		*/
283		public function notAuthorized($route)
284		{
285		return Template::getInstance()->render('notauthorized.html.twig', array(
286		'route' => $route,
287		));
288		}
289
290		/**
291		* Servicio que chequea si un usuario es super administrador o no
292		* @return bool
293		*/
294	1	public function isSuperAdmin()
295		{
296	1	$users = $this->getAdmins();
297	1	$logged = $this->getAdmin();
298	1	if ($users[$logged['alias']]) {
299	1	$security = $users[$logged['alias']]['profile'];
300	1	return self::ADMIN_ID_TOKEN === $security;
301		}
302
303		return FALSE;
304		}
305
306		/**
307		* Servicio que devuelve un dato de sesión
308		*
309		* @param string $key
310		*
311		* @return mixed
312		*/
313	6	public function getSessionKey($key)
314		{
315	6	$data = NULL;
316	6	if (array_key_exists($key, $this->session)) {
317	4	$data = $this->session[$key];
318		}
319
320	6	return $data;
321		}
322
323		/**
324		* Servicio que setea una variable de sesión
325		*
326		* @param string $key
327		* @param mixed $data
328		*
329		* @return Security
330		*/
331	5	public function setSessionKey($key, $data = NULL)
332		{
333	5	$this->session[$key] = $data;
334
335	5	return $this;
336		}
337
338		/**
339		* Servicio que devuelve los mensajes flash de sesiones
340		* @return mixed
341		*/
342	2	public function getFlashes()
343		{
344	2	$flashes = $this->getSessionKey(self::FLASH_MESSAGE_TOKEN);
345
346	2	return (NULL !== $flashes) ? $flashes : array();
347		}
348
349		/**
350		* Servicio que limpia los mensajes flash
351		* @return $this
352		*/
353	3	public function clearFlashes()
354		{
355	3	$this->setSessionKey(self::FLASH_MESSAGE_TOKEN, NULL);
356
357	3	return $this;
358		}
359
360		/**
361		* Servicio que inserta un flash en sesión
362		*
363		* @param string $key
364		* @param mixed $data
365		*/
366	1	public function setFlash($key, $data = NULL)
367		{
368	1	$flashes = $this->getFlashes();
369	1	if (!is_array($flashes)) {
370		$flashes = array();
371		}
372	1	$flashes[$key] = $data;
373	1	$this->setSessionKey(self::FLASH_MESSAGE_TOKEN, $flashes);
374	1	}
375
376		/**
377		* Servicio que devuelve un flash de sesión
378		*
379		* @param string $key
380		*
381		* @return mixed
382		*/
383	2	public function getFlash($key)
384		{
385	2	$flashes = $this->getFlashes();
386
387	2	return (NULL !== $key && array_key_exists($key, $flashes)) ? $flashes[$key] : NULL;
388		}
389
390		/**
391		* Servicio que actualiza
392		*
393		* @param boolean $closeSession
394		*
395		* @return Security
396		*/
397	2	public function updateSession($closeSession = FALSE)
		0 ignored issues – show Coding Style introduced 2017-08-03 10:43 UTC by Report Bug Copy Issue Report `updateSession` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
398		{
399	2	Logger::log('Update session');
400	2	$_SESSION = $this->session;
401	2	$_SESSION[self::USER_ID_TOKEN] = serialize($this->user);
402	2	$_SESSION[self::ADMIN_ID_TOKEN] = serialize($this->admin);
403	2	if ($closeSession) {
404	1	Logger::log('Close session');
405	1	@session_write_close();
406	1	@session_start();
407		}
408	2	Logger::log('Session updated');
409	2	return $this;
410		}
411
412		/**
413		* Servicio que limpia la sesión
414		*/
415	1	public function closeSession()
		0 ignored issues – show Coding Style introduced 2017-08-03 10:43 UTC by Report Bug Copy Issue Report `closeSession` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
416		{
417	1	unset($_SESSION);
418	1	@session_destroy();
419	1	@session_regenerate_id(TRUE);
420	1	@session_start();
421	1	}
422
423		}
424

psfs / core

Push — master ( 6df67e...d71c1b )

Security C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

26 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like