Form::fieldsOrder() - Code Metrics - Inspection of "- Solved issue with custom fields in api response" - psfs/core - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 306f11...77481f )

by Fran

created 2024-04-03 22:15 UTC

Form::fieldsOrder() C

↳ Parent: Form

Complexity

Conditions	15
Paths	15

Size

Total Lines	30
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	240

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	15
eloc	27
c	1
b	0
f	0
nc	15
nop	1
dl	0
loc	30
ccs	0
cts	27
cp	0
crap	240
rs	5.9166

How to fix Complexity

<?php

namespace PSFS\base\dto;

/**
 * Class Form
 * @package PSFS\base\dto
 */
class Form extends Dto
{
    /**
     * @var \PSFS\base\dto\Field[]
     */
    private $fields = [];
    /**
     * @var \PSFS\base\dto\FormAction[]
     */
    public $actions = [];

    /**
     * @param Field $field
     */
    public function addField(Field $field)
    {
        $this->fields[$field->name] = $field;
    }

    /**
     * @param string $name
     * @return bool
     */
    public function fieldExists($name)
    {
        return array_key_exists($name, $this->fields);
    }

    /**
     * @return array
     */
    public function __toArray()
    {
        $array = [
            'fields' => [],
            'actions' => [],
        ];
        foreach ($this->fields as $field) {
            $array['fields'][] = $field->__toArray();
        }
        usort($array['fields'], function ($fieldA, $fieldB) {
            if ((bool)$fieldA['required'] !== (bool)$fieldB['required']) {
                if ((bool)$fieldA['required']) {
                    return -1;
                } else {
                    return 1;
                }
            }
            $aOrder = Form::fieldsOrder($fieldA);
            $bOrder = Form::fieldsOrder($fieldB);
            if ($aOrder === $bOrder) {
                return strcmp($fieldA['name'], $fieldB['name']);
            }
            return ($aOrder < $bOrder) ? -1 : 1;
        });
        foreach ($this->actions as $action) {
            $array['actions'][] = $action->__toArray();
        }
        return $array;
    }

    /**
     * @param array $field
     * @return int
     */
    public static function fieldsOrder(array $field)
    {
        switch ($field['type']) {
            case Field::HIDDEN_TYPE:
                $order = 0;
                break;
            case Field::TEXT_TYPE:
            case Field::PHONE_TYPE:
            case Field::URL_TYPE:
            case Field::PASSWORD_FIELD:
            case Field::SEARCH_TYPE:
                $order = 1;
                break;
            case Field::CHECK_TYPE:
            case Field::RADIO_TYPE:
            case Field::COMBO_TYPE:
            case Field::NUMBER_TYPE:
            case Field::SWITCH_TYPE:
                $order = 2;
                break;
            case Field::TEXTAREA_TYPE:
                $order = 3;
                break;
            default:
            case Field::DATE:
            case Field::TIMESTAMP:
                $order = 4;
                break;
        }
        return $order;
    }
}


1			<?php
2
3			namespace PSFS\base\dto;
4
5			/**
6			* Class Form
7			* @package PSFS\base\dto
8			*/
9			class Form extends Dto
10			{
11			/**
12			* @var \PSFS\base\dto\Field[]
13			*/
14			private $fields = [];
15			/**
16			* @var \PSFS\base\dto\FormAction[]
17			*/
18			public $actions = [];
19
20			/**
21			* @param Field $field
22			*/
23			public function addField(Field $field)
24			{
25			$this->fields[$field->name] = $field;
26			}
27
28			/**
29			* @param string $name
30			* @return bool
31			*/
32			public function fieldExists($name)
33			{
34			return array_key_exists($name, $this->fields);
35			}
36
37			/**
38			* @return array
39			*/
40			public function __toArray()
41			{
42			$array = [
43			'fields' => [],
44			'actions' => [],
45			];
46			foreach ($this->fields as $field) {
47			$array['fields'][] = $field->__toArray();
48			}
49			usort($array['fields'], function ($fieldA, $fieldB) {
50			if ((bool)$fieldA['required'] !== (bool)$fieldB['required']) {
51			if ((bool)$fieldA['required']) {
52			return -1;
53			} else {
54			return 1;
55			}
56			}
57			$aOrder = Form::fieldsOrder($fieldA);
58			$bOrder = Form::fieldsOrder($fieldB);
59			if ($aOrder === $bOrder) {
60			return strcmp($fieldA['name'], $fieldB['name']);
61			}
62			return ($aOrder < $bOrder) ? -1 : 1;
63			});
64			foreach ($this->actions as $action) {
65			$array['actions'][] = $action->__toArray();
66			}
67			return $array;
68			}
69
70			/**
71			* @param array $field
72			* @return int
73			*/
74			public static function fieldsOrder(array $field)
75			{
76			switch ($field['type']) {
77			case Field::HIDDEN_TYPE:
78			$order = 0;
79			break;
80			case Field::TEXT_TYPE:
81			case Field::PHONE_TYPE:
82			case Field::URL_TYPE:
83			case Field::PASSWORD_FIELD:
84			case Field::SEARCH_TYPE:
85			$order = 1;
86			break;
87			case Field::CHECK_TYPE:
88			case Field::RADIO_TYPE:
89			case Field::COMBO_TYPE:
90			case Field::NUMBER_TYPE:
91			case Field::SWITCH_TYPE:
92			$order = 2;
93			break;
94			case Field::TEXTAREA_TYPE:
95			$order = 3;
96			break;
97			default:
98			case Field::DATE:
99			case Field::TIMESTAMP:
100			$order = 4;
101			break;
102			}
103			return $order;
104			}
105			}
106

psfs / core

Push — master ( 306f11...77481f )

Form::fieldsOrder() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like