psfs /
core
Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Request |
||
| 11 | { |
||
| 12 | use SingletonTrait; |
||
| 13 | protected $server; |
||
| 14 | protected $cookies; |
||
| 15 | protected $upload; |
||
| 16 | protected $header; |
||
| 17 | protected $data; |
||
| 18 | protected $raw = []; |
||
| 19 | protected $query; |
||
| 20 | private $isLoaded = false; |
||
| 21 | |||
| 22 | 2 | public function init() |
|
| 33 | |||
| 34 | /** |
||
| 35 | * @return bool |
||
| 36 | */ |
||
| 37 | 1 | public function isLoaded() { |
|
| 40 | |||
| 41 | /** |
||
| 42 | * Método que devuelve las cabeceras de la petición |
||
| 43 | * @return array |
||
| 44 | */ |
||
| 45 | 2 | private function parseHeaders() |
|
| 49 | |||
| 50 | /** |
||
| 51 | * Método que verifica si existe una cabecera concreta |
||
| 52 | * @param $header |
||
| 53 | * |
||
| 54 | * @return boolean |
||
| 55 | */ |
||
| 56 | 2 | public function hasHeader($header) |
|
| 60 | |||
| 61 | |||
| 62 | /** |
||
| 63 | * Método que indica si una petición tiene cookies |
||
| 64 | * @return boolean |
||
| 65 | */ |
||
| 66 | 1 | public function hasCookies() |
|
| 70 | |||
| 71 | /** |
||
| 72 | * Método que indica si una petición tiene cookies |
||
| 73 | * @return boolean |
||
| 74 | */ |
||
| 75 | 1 | public function hasUpload() |
|
| 79 | |||
| 80 | /** |
||
| 81 | * Método que devuelve el TimeStamp de la petición |
||
| 82 | * |
||
| 83 | * @param boolean $formatted |
||
| 84 | * |
||
| 85 | * @return string |
||
| 86 | */ |
||
| 87 | public static function ts($formatted = false) |
||
| 91 | |||
| 92 | 1 | public function getTs($formatted = false) |
|
| 96 | |||
| 97 | /** |
||
| 98 | * Método que devuelve el Método HTTP utilizado |
||
| 99 | * @return string |
||
| 100 | */ |
||
| 101 | 3 | public function getMethod() |
|
| 105 | |||
| 106 | /** |
||
| 107 | * Método que devuelve una cabecera de la petición si existe |
||
| 108 | * @param string $name |
||
| 109 | * @param string $default |
||
| 110 | * |
||
| 111 | * @return string|null |
||
| 112 | */ |
||
| 113 | 1 | public static function header($name, $default = null) |
|
| 117 | |||
| 118 | /** |
||
| 119 | * @param string $name |
||
| 120 | * @param string $default |
||
| 121 | * @return string|null |
||
| 122 | */ |
||
| 123 | 1 | public function getHeader($name, $default = null) |
|
| 133 | |||
| 134 | /** |
||
| 135 | * Método que devuelve la url solicitada |
||
| 136 | * @return string|null |
||
| 137 | */ |
||
| 138 | 1 | public static function requestUri() |
|
| 142 | |||
| 143 | /** |
||
| 144 | * @return string |
||
| 145 | */ |
||
| 146 | 3 | public function getRequestUri() |
|
| 150 | |||
| 151 | /** |
||
| 152 | * Método que devuelve el idioma de la petición |
||
| 153 | * @return string |
||
| 154 | */ |
||
| 155 | public function getLanguage() |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Método que determina si se ha solicitado un fichero |
||
| 162 | * @return boolean |
||
| 163 | */ |
||
| 164 | public function isFile() |
||
| 165 | { |
||
| 166 | $file = (preg_match('/\.[a-z0-9]{2,4}$/', $this->getRequestUri()) !== 0); |
||
| 167 | return $file; |
||
| 168 | } |
||
| 169 | |||
| 170 | /** |
||
| 171 | * Get query params |
||
| 172 | * |
||
| 173 | * @param string $queryParams |
||
| 174 | * |
||
| 175 | * @return mixed |
||
| 176 | */ |
||
| 177 | public function getQuery($queryParams) |
||
| 181 | |||
| 182 | /** |
||
| 183 | * Get all query params |
||
| 184 | * |
||
| 185 | * @return mixed |
||
| 186 | */ |
||
| 187 | 1 | public function getQueryParams() |
|
| 191 | |||
| 192 | /** |
||
| 193 | * Método que devuelve un parámetro de la solicitud |
||
| 194 | * @param string $param |
||
| 195 | * |
||
| 196 | * @return string|null |
||
| 197 | */ |
||
| 198 | public function get($param) |
||
| 202 | |||
| 203 | /** |
||
| 204 | * Método que devuelve todos los datos del Request |
||
| 205 | * @return array |
||
| 206 | */ |
||
| 207 | 1 | public function getData() |
|
| 211 | |||
| 212 | /** |
||
| 213 | * @return array |
||
| 214 | */ |
||
| 215 | public function getRawData() { |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Método que realiza una redirección a la url dada |
||
| 221 | * @param string $url |
||
| 222 | */ |
||
| 223 | public function redirect($url = null) |
||
| 232 | |||
| 233 | /** |
||
| 234 | * Devuelve un parámetro de $_SERVER |
||
| 235 | * @param string $param |
||
| 236 | * |
||
| 237 | * @return string|null |
||
| 238 | */ |
||
| 239 | 3 | public function getServer($param) |
|
| 243 | |||
| 244 | /** |
||
| 245 | * Devuelve el nombre del servidor |
||
| 246 | * @return string|null |
||
| 247 | */ |
||
| 248 | 1 | public function getServerName() |
|
| 249 | { |
||
| 250 | 1 | return $this->getServer("SERVER_NAME"); |
|
| 251 | } |
||
| 252 | |||
| 253 | /** |
||
| 254 | * Devuelve el protocolo de la conexión |
||
| 255 | * @return string |
||
| 256 | */ |
||
| 257 | 1 | public function getProtocol() |
|
| 258 | { |
||
| 259 | 1 | return ($this->getServer("HTTPS") || $this->getServer("https")) ? 'https://' : 'http://'; |
|
| 260 | } |
||
| 261 | |||
| 262 | /** |
||
| 263 | * Devuelve la url completa de base |
||
| 264 | * @param boolean $protocol |
||
| 265 | * @return string |
||
| 266 | */ |
||
| 267 | 1 | public function getRootUrl($protocol = true) |
|
| 268 | { |
||
| 269 | 1 | $host = $this->getServerName(); |
|
| 270 | 1 | $protocol = $protocol ? $this->getProtocol() : ''; |
|
| 271 | 1 | $url = ''; |
|
| 272 | 1 | if (!empty($host) && !empty($protocol)) $url = $protocol . $host; |
|
| 273 | 1 | if (!in_array($this->getServer('SERVER_PORT'), [80, 443])) { |
|
| 274 | 1 | $url .= ':' . $this->getServer('SERVER_PORT'); |
|
| 275 | } |
||
| 276 | 1 | return $url; |
|
| 277 | } |
||
| 278 | |||
| 279 | /** |
||
| 280 | * Método que devuelve el valor de una cookie en caso de que exista |
||
| 281 | * @param string $name |
||
| 282 | * |
||
| 283 | * @return string |
||
| 284 | */ |
||
| 285 | 1 | public function getCookie($name) |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Método que devuelve los files subidos por POST |
||
| 292 | * @param $name |
||
| 293 | * |
||
| 294 | * @return array |
||
| 295 | */ |
||
| 296 | public function getFile($name) |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Método que devuelve si la petición es ajax o no |
||
| 303 | * @return boolean |
||
| 304 | */ |
||
| 305 | 1 | public function isAjax() |
|
| 310 | |||
| 311 | } |
||
| 312 |
Loading history...
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: