Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class Service extends Singleton |
||
10 | { |
||
11 | /** |
||
12 | * @var String Url de destino de la llamada |
||
13 | */ |
||
14 | private $url; |
||
15 | /** |
||
16 | * @var Array Parámetros de la llamada |
||
17 | */ |
||
18 | private $params; |
||
19 | /** |
||
20 | * @var Array Cabeceras de la llamada |
||
21 | */ |
||
22 | private $headers; |
||
23 | /** |
||
24 | * @var string type |
||
25 | */ |
||
26 | private $type; |
||
27 | /** |
||
28 | * @var resource $con |
||
29 | */ |
||
30 | private $con; |
||
31 | /** |
||
32 | * @var string $result |
||
33 | */ |
||
34 | private $result; |
||
35 | |||
36 | /** |
||
37 | * @Inyectable |
||
38 | * @var \PSFS\base\Logger Log de las llamadas |
||
39 | */ |
||
40 | protected $log; |
||
41 | /** |
||
42 | * @Inyectable |
||
43 | * @var \PSFS\base\Cache $cache |
||
44 | */ |
||
45 | protected $cache; |
||
46 | |||
47 | /** |
||
48 | * @return String |
||
49 | */ |
||
50 | public function getUrl() |
||
54 | |||
55 | /** |
||
56 | * @param String $url |
||
57 | */ |
||
58 | public function setUrl($url) |
||
63 | |||
64 | /** |
||
65 | * @return string |
||
66 | */ |
||
67 | public function getResult() |
||
71 | |||
72 | /** |
||
73 | * @param string $result |
||
74 | */ |
||
75 | public function setResult($result) |
||
79 | |||
80 | /** |
||
81 | * @return Array |
||
82 | */ |
||
83 | public function getParams() |
||
87 | |||
88 | /** |
||
89 | * Add request param |
||
90 | * |
||
91 | * @param $key |
||
92 | * @param null $value |
||
93 | * |
||
94 | * @return \PSFS\base\Service |
||
95 | */ |
||
96 | public function addParam($key, $value = NULL) |
||
102 | |||
103 | /** |
||
104 | * @param Array $params |
||
105 | */ |
||
106 | public function setParams($params) |
||
110 | |||
111 | /** |
||
112 | * @return Array |
||
113 | */ |
||
114 | public function getHeaders() |
||
118 | |||
119 | /** |
||
120 | * @param Array $headers |
||
121 | */ |
||
122 | public function setHeaders($headers) |
||
126 | |||
127 | /** |
||
128 | * @param $header |
||
129 | * @param null $content |
||
130 | * |
||
131 | * @return $this |
||
132 | */ |
||
133 | public function addHeader($header, $content = NULL) |
||
139 | |||
140 | /** |
||
141 | * @return string |
||
142 | */ |
||
143 | public function getType() |
||
147 | |||
148 | /** |
||
149 | * @param string $type |
||
150 | */ |
||
151 | public function setType($type) |
||
155 | |||
156 | /** |
||
157 | * @return Logger |
||
158 | */ |
||
159 | public function getLog() |
||
163 | |||
164 | /** |
||
165 | * @param Logger $log |
||
166 | */ |
||
167 | 1 | public function setLog($log) |
|
168 | { |
||
169 | 1 | $this->log = $log; |
|
170 | 1 | } |
|
171 | |||
172 | /** |
||
173 | * Método que limpia el contexto de la llamada |
||
174 | */ |
||
175 | 1 | private function clearContext() |
|
176 | { |
||
177 | 1 | $this->url = NULL; |
|
178 | 1 | $this->params = array(); |
|
179 | 1 | $this->headers = array(); |
|
180 | 1 | Logger::log("Context service for " . get_called_class() . " cleared!"); |
|
181 | 1 | } |
|
182 | |||
183 | /** |
||
184 | * Constructor por defecto |
||
185 | */ |
||
186 | 1 | public function __construct() |
|
187 | { |
||
188 | 1 | parent::__construct(); |
|
189 | 1 | $this->clearContext(); |
|
190 | 1 | } |
|
191 | |||
192 | /** |
||
193 | * Initialize CURL |
||
194 | */ |
||
195 | private function initialize() |
||
199 | |||
200 | /** |
||
201 | * Generate auth header |
||
202 | * @param string $secret |
||
203 | */ |
||
204 | protected function addRequestToken($secret) |
||
208 | |||
209 | protected function setOpts() |
||
232 | |||
233 | public function callSrv() |
||
239 | } |
||
240 |