Resource - Code Metrics - psecio/invoke - Measure and Improve Code Quality continuously with Scrutinizer

Resource A
last analyzed 2018-08-18 17:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	0
dl	0
loc	88
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	9	3
A	setHttpMethod()	4	1
A	getHttpMethod()	4	1
A	setUri()	4	1
A	getUri()	4	2
A	getParams()	15	3

<?php

namespace Psecio\Invoke;

class Resource
{
	/**
	 * Curernt URI location
	 * @var string
	 */
	protected $uri;

	/**
	 * Current HTTP method/verb
	 * @var string
	 */
	protected $method;

	/**
	 * Create the resource, set the URL and HTTP method manually if desired
	 * 	URI will default to REQUEST_URI
	 *  HTTP method will default to REQUEST_METHOD
	 *
	 * @param string $uri URI for the resource
	 * @param string $httpMethod HTTP method for the resource
	 */
	public function __construct($uri = null, $httpMethod = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$this->setUri(
			($uri !== null) ? $uri : $_SERVER['REQUEST_URI']
		);
		$this->setHttpMethod(
			($httpMethod !== null) ? $httpMethod : $_SERVER['REQUEST_METHOD']
		);
	}

	/**
	 * Set the curren tHTTP method
	 *
	 * @param string $method HTTP method (ex: GET, POST)
	 */
	public function setHttpMethod($method)
	{
		$this->method = strtoupper($method);
	}

	/**
	 * Get the current HTTP method
	 *
	 * @return string HTTP method currently set
	 */
	public function getHttpMethod()
	{
		return $this->method;
	}

	/**
	 * Set the current URI for the resource
	 *
	 * @param string $uri URI path
	 */
	public function setUri($uri)
	{
		$this->uri = $uri;
	}

	/**
	 * Get the curent URI setting
	 *
	 * @return string Current URI setting
	 */
	public function getUri($parsed = false)
	{
		return ($parsed === true) ? parse_url($this->uri) : $this->uri;
	}

	public function getParams()
	{
		$result = [];
		$parse = parse_url($this->uri);

		if (isset($parse['query'])) {
			$params = explode('&', $parse['query']);
			foreach ($params as $param) {
				list($key, $value) = explode('=', $param);
				$result[$key] = $value;
			}
		}

		return $result;
	}
}

1			<?php
2
3			namespace Psecio\Invoke;
4
5			class Resource
6			{
7			/**
8			* Curernt URI location
9			* @var string
10			*/
11			protected $uri;
12
13			/**
14			* Current HTTP method/verb
15			* @var string
16			*/
17			protected $method;
18
19			/**
20			* Create the resource, set the URL and HTTP method manually if desired
21			* URI will default to REQUEST_URI
22			* HTTP method will default to REQUEST_METHOD
23			*
24			* @param string $uri URI for the resource
25			* @param string $httpMethod HTTP method for the resource
26			*/
27			public function __construct($uri = null, $httpMethod = null)
			0 ignored issues – show Coding Style introduced 2018-08-18 17:29 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
28			{
29			$this->setUri(
30			($uri !== null) ? $uri : $_SERVER['REQUEST_URI']
31			);
32			$this->setHttpMethod(
33			($httpMethod !== null) ? $httpMethod : $_SERVER['REQUEST_METHOD']
34			);
35			}
36
37			/**
38			* Set the curren tHTTP method
39			*
40			* @param string $method HTTP method (ex: GET, POST)
41			*/
42			public function setHttpMethod($method)
43			{
44			$this->method = strtoupper($method);
45			}
46
47			/**
48			* Get the current HTTP method
49			*
50			* @return string HTTP method currently set
51			*/
52			public function getHttpMethod()
53			{
54			return $this->method;
55			}
56
57			/**
58			* Set the current URI for the resource
59			*
60			* @param string $uri URI path
61			*/
62			public function setUri($uri)
63			{
64			$this->uri = $uri;
65			}
66
67			/**
68			* Get the curent URI setting
69			*
70			* @return string Current URI setting
71			*/
72			public function getUri($parsed = false)
73			{
74			return ($parsed === true) ? parse_url($this->uri) : $this->uri;
75			}
76
77			public function getParams()
78			{
79			$result = [];
80			$parse = parse_url($this->uri);
81
82			if (isset($parse['query'])) {
83			$params = explode('&', $parse['query']);
84			foreach ($params as $param) {
85			list($key, $value) = explode('=', $param);
86			$result[$key] = $value;
87			}
88			}
89
90			return $result;
91			}
92			}

psecio / invoke

Resource A last analyzed 2018-08-18 17:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

Resource A
last analyzed 2018-08-18 17:42 UTC