MatchInstance   A
last analyzed

Complexity

Total Complexity 9

Size/Duplication

Total Lines 76
Duplicated Lines 10.53 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
wmc 9
lcom 1
cbo 0
dl 8
loc 76
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
A setConfig() 0 4 1
A getConfig() 8 8 3
A getError() 0 11 4
evaluate() 0 1 ?

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Psecio\Invoke;
4
5
abstract class MatchInstance
6
{
7
	/**
8
	 * Current configuration details
9
	 * @var array
10
	 */
11
	protected $config = array();
12
13
	/**
14
	 * Flag to negate the check
15
	 * @var boolean
16
	 */
17
	protected $negate = false;
18
19
	/**
20
	 * Init the object with the given confgiuration and negation flag
21
	 *
22
	 * @param array $config Configuration information
23
	 * @param boolean $negate Negation flag, default false [optional]
24
	 */
25
	public function __construct(array $config = array(), $negate = false)
0 ignored issues
show
Unused Code introduced by
The parameter $negate is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
26
	{
27
		$this->setConfig($config);
28
	}
29
30
	/**
31
	 * Set the current configuration values
32
	 *
33
	 * @param array $config Configuration information
34
	 */
35
	public function setConfig(array $config)
36
	{
37
		$this->config = $config;
38
	}
39
40
	/**
41
	 * Get the current configuration, or if a key is provided
42
	 * 	try to locate that one value
43
	 *
44
	 * @param string $key Key to locate [optional]
45
	 * @return mixed Either entire config or key is found
46
	 */
47 View Code Duplication
	public function getConfig($key = null)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
48
	{
49
		if ($key !== null) {
50
			return (isset($this->config[$key])) ? $this->config[$key] : null;
51
		} else {
52
			return $this->config;
53
		}
54
	}
55
56
	/**
57
	 * Get the current formatted error message
58
	 *
59
	 * @return string Error message contents
60
	 */
61
	public function getError()
62
	{
63
		$config = $this->getConfig()['data'];
64
		$message = (isset($this->error)) ? $this->error : 'There was an error on match for '.__CLASS__;
0 ignored issues
show
Bug introduced by
The property error does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
65
		if (strpos($message, ':data') !== false) {
66
			$data = '';
0 ignored issues
show
Unused Code introduced by
$data is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
67
			$data = (is_array($config)) ? '['.implode(',', array_values($config)).']' : $config;
68
			$message = str_replace(':data', $data, $message);
69
		}
70
		return $message;
71
	}
72
73
	/**
74
	 * Evaluate the match
75
	 *
76
	 * @param \Psecio\Invoke\Data $data Object instance
77
	 * @return boolean Result of evaluation
78
	 */
79
	abstract public function evaluate($data);
80
}