Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | abstract class MatchInstance |
||
6 | { |
||
7 | /** |
||
8 | * Current configuration details |
||
9 | * @var array |
||
10 | */ |
||
11 | protected $config = array(); |
||
12 | |||
13 | /** |
||
14 | * Flag to negate the check |
||
15 | * @var boolean |
||
16 | */ |
||
17 | protected $negate = false; |
||
18 | |||
19 | /** |
||
20 | * Init the object with the given confgiuration and negation flag |
||
21 | * |
||
22 | * @param array $config Configuration information |
||
23 | * @param boolean $negate Negation flag, default false [optional] |
||
24 | */ |
||
25 | public function __construct(array $config = array(), $negate = false) |
||
29 | |||
30 | /** |
||
31 | * Set the current configuration values |
||
32 | * |
||
33 | * @param array $config Configuration information |
||
34 | */ |
||
35 | public function setConfig(array $config) |
||
39 | |||
40 | /** |
||
41 | * Get the current configuration, or if a key is provided |
||
42 | * try to locate that one value |
||
43 | * |
||
44 | * @param string $key Key to locate [optional] |
||
45 | * @return mixed Either entire config or key is found |
||
46 | */ |
||
47 | View Code Duplication | public function getConfig($key = null) |
|
55 | |||
56 | /** |
||
57 | * Get the current formatted error message |
||
58 | * |
||
59 | * @return string Error message contents |
||
60 | */ |
||
61 | public function getError() |
||
72 | |||
73 | /** |
||
74 | * Evaluate the match |
||
75 | * |
||
76 | * @param \Psecio\Invoke\Data $data Object instance |
||
77 | * @return boolean Result of evaluation |
||
78 | */ |
||
79 | abstract public function evaluate($data); |
||
80 | } |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.