pryley / site-reviews

plugin/Database/ShortcodeOptionManager.php

<?php

namespace GeminiLabs\SiteReviews\Database;

use GeminiLabs\SiteReviews\Arguments;
use GeminiLabs\SiteReviews\Contracts\ShortcodeContract;
use GeminiLabs\SiteReviews\Database;
use GeminiLabs\SiteReviews\Defaults\ShortcodeApiFetchDefaults;
use GeminiLabs\SiteReviews\Helper;
use GeminiLabs\SiteReviews\Helpers\Arr;
use GeminiLabs\SiteReviews\Helpers\Str;

class ShortcodeOptionManager
{
    /**
     * The parameter passed to the called method can be either a shortcode tag,
     * an instantiated shortcode class, or an array with key/values found in
     * ShortcodeApiFetchDefaults::class
     * 
     * @return array
     */
    public function __call(string $name, array $arguments)
    {
        $name = Str::snakeCase($name);
        $shortcode = array_shift($arguments);
        if (is_string($shortcode)) {
            $shortcode = glsr()->shortcode($shortcode);
        }
        if ($shortcode instanceof ShortcodeContract) {
            $args = [
                'option' => $name,
                'shortcode' => $shortcode->tag,

Accessing tag on the interface GeminiLabs\SiteReviews\Contracts\ShortcodeContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            ];
        } else {
            $args = Arr::consolidate($shortcode);
        }
        $args = glsr()->args(glsr(ShortcodeApiFetchDefaults::class)->merge($args));
        try {
            $method = Helper::buildMethodName($name);
            $reflection = new \ReflectionMethod($this, $method);
            $results = $reflection->isProtected()
                ? call_user_func([$this, $method], $args)
                : [];
        } catch (\ReflectionException $e) {
            $results = [];
        }
        $results = glsr()->filterArray("shortcode/options/{$name}", $results, $args);
        if (!empty($results) && !empty($args->placeholder)) {
            $results = Arr::prepend($results, esc_attr($args->placeholder), '');
        }
        return $results;
    }

    protected function assignedPosts(Arguments $args): array
    {
        $results = [];
        if (!empty($args->search)
            && !in_array($args->search, ['post_id', 'parent_id'])) {
            $results += glsr(Database::class)->posts([
                // @see MainController::parseAssignedPostTypesInQuery
                'post_type' => glsr()->prefix.'assigned_posts',
                'posts_per_page' => $args->per_page,
                's' => $args->search,
            ]);
        }
        $include = array_filter($args->include, fn ($id) => !array_key_exists($id, $results));
        if (!empty($include)) {
            $results += glsr(Database::class)->posts([
                'post__in' => $include,
            ]);
        }
        return [
            'post_id' => esc_html_x('The Current Page', 'admin-text', 'site-reviews'),
            'parent_id' => esc_html_x('The Parent Page', 'admin-text', 'site-reviews'),
        ] + $results;
    }

    protected function assignedTerms(Arguments $args): array
    {
        $query = [
            'number' => $args->per_page,
        ];
        if (!empty($args->search)) {
            $query['search'] = $args->search;
        }
        $results = glsr(Database::class)->terms($query);
        $include = array_filter($args->include, fn ($id) => !array_key_exists($id, $results));
        if (!empty($include)) {
            $results += glsr(Database::class)->terms([
                'term_taxonomy_id' => $include,
            ]);
        }
        return $results;
    }

    protected function assignedUsers(Arguments $args): array
    {
        $query = [
            'number' => $args->per_page,
        ];
        if (!empty($args->search)
            && !in_array($args->search, ['author_id', 'profile_id', 'user_id'])) {
            $query['search_wild'] = $args->search;
        }
        $results = glsr(Database::class)->users($query);
        $include = array_filter($args->include, fn ($id) => !array_key_exists($id, $results));
        if (!empty($include)) {
            $results += glsr(Database::class)->users([
                'include' => $include,
            ]);
        }
        return [
            'user_id' => esc_html_x('The Logged In User', 'admin-text', 'site-reviews'),
            'author_id' => esc_html_x('The Page Author', 'admin-text', 'site-reviews'),
            'profile_id' => esc_html_x('The Profile User', 'admin-text', 'site-reviews'),
        ] + $results;
    }

    protected function author(Arguments $args): array
    {
        $query = [
            'number' => $args->per_page,
        ];
        if (!empty($args->search) && !in_array($args->search, ['user_id'])) {
            $query['search_wild'] = $args->search;
        }
        $results = glsr(Database::class)->users($query);
        $include = array_filter($args->include, fn ($id) => !array_key_exists($id, $results));
        if (!empty($include)) {
            $results += glsr(Database::class)->users([
                'include' => $include,
            ]);
        }
        return [
            'user_id' => esc_html_x('The Logged In User', 'admin-text', 'site-reviews'),
        ] + $results;
    }

    protected function hide(Arguments $args): array
    {
        if ($shortcode = glsr()->shortcode($args->shortcode)) {
            $fn = fn () => $this->hideOptions(); // @phpstan-ignore-line

The method hideOptions() does not exist on GeminiLabs\SiteReviews\Database\ShortcodeOptionManager. Since you implemented __call, consider adding a @method annotation.

            return $fn->bindTo($shortcode, $shortcode)();
        }
        return [];
    }

    protected function pagination(): array
    {
        return [ // order is intentional
            'loadmore' => _x('Load More Button', 'admin-text', 'site-reviews'),
            'ajax' => _x('Pagination Links (AJAX)', 'admin-text', 'site-reviews'),
            'true' => _x('Pagination Links', 'admin-text', 'site-reviews'),
        ];
    }

    protected function postId(Arguments $args): array
    {
        $results = [];
        if (!empty($args->search)) {
            $results += glsr(Database::class)->posts([
                'post_type' => glsr()->post_type,
                'posts_per_page' => $args->per_page,
                's' => $args->search,
            ]);
        }
        $include = array_filter($args->include, fn ($id) => !array_key_exists($id, $results));
        if (!empty($include)) {
            $results += glsr(Database::class)->posts([
                'post_type' => glsr()->post_type,
                'post__in' => $include,
            ]);
        }
        return $results;
    }

    protected function schema(): array
    {
        return [
            'true' => _x('Enable rich snippets', 'admin-text', 'site-reviews'),
            'false' => _x('Disable rich snippets', 'admin-text', 'site-reviews'),
        ];
    }

    protected function terms(): array
    {
        return [
            'true' => _x('Terms were accepted', 'admin-text', 'site-reviews'),
            'false' => _x('Terms were not accepted', 'admin-text', 'site-reviews'),
        ];
    }

    protected function type(): array
    {
        $types = glsr()->retrieveAs('array', 'review_types', []);
        return 1 < count($types) ? $types : [];
    }
}