pryley /
site-reviews
| Conditions | 10 |
| Paths | 32 |
| Total Lines | 32 |
| Code Lines | 24 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | protected function finalize(array $values = []): array |
||
| 23 | { |
||
| 24 | $types = [ |
||
| 25 | 'checkbox' => Controls_Manager::SWITCHER, |
||
| 26 | 'number' => Controls_Manager::NUMBER, |
||
| 27 | 'radio' => Controls_Manager::CHOOSE, |
||
| 28 | 'select' => Controls_Manager::SELECT2, |
||
| 29 | 'text' => Controls_Manager::TEXT, |
||
| 30 | 'textarea' => Controls_Manager::TEXTAREA, |
||
| 31 | ]; |
||
| 32 | if (array_key_exists($values['type'], $types)) { |
||
| 33 | $values['type'] = $types[$values['type']]; |
||
| 34 | } |
||
| 35 | if (Controls_Manager::SWITCHER === $values['type'] && !empty($values['options'])) { |
||
| 36 | $values['type'] = 'multi_switcher'; |
||
| 37 | } |
||
| 38 | if (!in_array($values['type'], [ |
||
| 39 | Controls_Manager::CHOOSE, |
||
| 40 | Controls_Manager::COLOR, |
||
| 41 | Controls_Manager::NUMBER, |
||
| 42 | Controls_Manager::SWITCHER, |
||
| 43 | ]) && !isset($values['label_block'])) { |
||
| 44 | $values['label_block'] = true; |
||
| 45 | } |
||
| 46 | if (Controls_Manager::SELECT2 === $values['type'] && !empty($values['placeholder'])) { |
||
| 47 | $values['select2options'] ??= []; |
||
| 48 | $values['select2options']['placeholder'] = $values['placeholder']; |
||
| 49 | } |
||
| 50 | if (Controls_Manager::SELECT2 === $values['type'] && !isset($values['options'])) { |
||
| 51 | $values['type'] = 'select2_ajax'; |
||
| 52 | } |
||
| 53 | return $values; |
||
| 54 | } |
||
| 56 |
