Passed
Push — master ( 85ec42...1dac3a )
by Paul
06:37
created
plugin/Database/CountsManager.php 1 patch
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -73,7 +73,9 @@  discard block
 block discarded – undo
73 73
 	 */
74 74
 	public function decreasePostCounts( Review $review )
75 75
 	{
76
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
76
+		if( empty( $counts = $this->getPostCounts( $review->assigned_to ))) {
77
+			return;
78
+		}
77 79
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
78 80
 		$this->setPostCounts( $review->assigned_to, $counts );
79 81
 	}
@@ -84,7 +86,9 @@  discard block
 block discarded – undo
84 86
 	public function decreaseTermCounts( Review $review )
85 87
 	{
86 88
 		foreach( $review->term_ids as $termId ) {
87
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
89
+			if( empty( $counts = $this->getTermCounts( $termId ))) {
90
+				continue;
91
+			}
88 92
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
89 93
 			$this->setTermCounts( $termId, $counts );
90 94
 		}
@@ -106,7 +110,9 @@  discard block
 block discarded – undo
106 110
 			'min' => Rating::MIN_RATING,
107 111
 		]);
108 112
 		foreach( $counts as $index => &$num ) {
109
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
113
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] )) {
114
+				continue;
115
+			}
110 116
 			$num = 0;
111 117
 		}
112 118
 		return $counts;
@@ -191,7 +197,9 @@  discard block
 block discarded – undo
191 197
 	 */
192 198
 	public function increasePostCounts( Review $review )
193 199
 	{
194
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
200
+		if( !( get_post( $review->assigned_to ) instanceof WP_Post )) {
201
+			return;
202
+		}
195 203
 		$counts = $this->getPostCounts( $review->assigned_to );
196 204
 		$counts = empty( $counts )
197 205
 			? $this->buildPostCounts( $review->assigned_to )
@@ -240,7 +248,9 @@  discard block
 block discarded – undo
240 248
 	 */
241 249
 	public function setTermCounts( $termId, array $reviewCounts )
242 250
 	{
243
-		if( !term_exists( $termId ))return;
251
+		if( !term_exists( $termId )) {
252
+			return;
253
+		}
244 254
 		$ratingCounts = glsr( CountsManager::class )->flatten( $reviewCounts );
245 255
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
246 256
 		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
@@ -258,7 +268,9 @@  discard block
 block discarded – undo
258 268
 		while( $reviews = $this->queryReviews( $args, $lastPostId, $limit )) {
259 269
 			$types = array_keys( array_flip( array_column( $reviews, 'type' )));
260 270
 			foreach( $types as $type ) {
261
-				if( isset( $counts[$type] ))continue;
271
+				if( isset( $counts[$type] )) {
272
+					continue;
273
+				}
262 274
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
263 275
 			}
264 276
 			foreach( $reviews as $review ) {
@@ -307,7 +319,9 @@  discard block
 block discarded – undo
307 319
 	{
308 320
 		foreach( $reviewCounts as &$counts ) {
309 321
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
310
-				if( isset( $counts[$index] ))continue;
322
+				if( isset( $counts[$index] )) {
323
+					continue;
324
+				}
311 325
 				$counts[$index] = 0;
312 326
 			}
313 327
 			ksort( $counts );
Please login to merge, or discard this patch.
plugin/Database/ReviewManager.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -111,7 +111,9 @@  discard block
 block discarded – undo
111 111
 		$termIds = array_filter( array_map( 'trim', explode( ',', $commaSeparatedTermIds )));
112 112
 		foreach( $termIds as $termId ) {
113 113
 			$term = get_term( $termId, Application::TAXONOMY );
114
-			if( !isset( $term->term_id ))continue;
114
+			if( !isset( $term->term_id )) {
115
+				continue;
116
+			}
115 117
 			$terms[] = $term->term_id;
116 118
 		}
117 119
 		return $terms;
@@ -123,7 +125,9 @@  discard block
 block discarded – undo
123 125
 	 */
124 126
 	public function revert( $postId )
125 127
 	{
126
-		if( get_post_field( 'post_type', $postId ) != Application::POST_TYPE )return;
128
+		if( get_post_field( 'post_type', $postId ) != Application::POST_TYPE ) {
129
+			return;
130
+		}
127 131
 		delete_post_meta( $postId, '_edit_last' );
128 132
 		$result = wp_update_post([
129 133
 			'ID' => $postId,
@@ -141,7 +145,9 @@  discard block
 block discarded – undo
141 145
 	 */
142 146
 	public function single( WP_Post $post )
143 147
 	{
144
-		if( $post->post_type != Application::POST_TYPE )return;
148
+		if( $post->post_type != Application::POST_TYPE ) {
149
+			return;
150
+		}
145 151
 		$review = new Review( $post );
146 152
 		return apply_filters( 'site-reviews/get/review', $review, $post );
147 153
 	}
@@ -166,7 +172,9 @@  discard block
 block discarded – undo
166 172
 	protected function setTerms( $postId, $termIds )
167 173
 	{
168 174
 		$terms = $this->normalizeTerms( $termIds );
169
-		if( empty( $terms ))return;
175
+		if( empty( $terms )) {
176
+			return;
177
+		}
170 178
 		$result = wp_set_object_terms( $postId, $terms, Application::TAXONOMY );
171 179
 		if( is_wp_error( $result )) {
172 180
 			glsr_log()->error( $result->get_error_message() );
Please login to merge, or discard this patch.
plugin/Controllers/ReviewController.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,7 +25,9 @@  discard block
 block discarded – undo
25 25
 	{
26 26
 		sort( $termIds );
27 27
 		sort( $oldTermIds );
28
-		if( $termIds === $oldTermIds || !$this->isReviewPostId( $postId ))return;
28
+		if( $termIds === $oldTermIds || !$this->isReviewPostId( $postId )) {
29
+			return;
30
+		}
29 31
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
30 32
 		$ignoredTerms = array_intersect( $oldTermIds, $termIds );
31 33
 		if( $review->term_ids = array_diff( $oldTermIds, $ignoredTerms )) {
@@ -45,7 +47,9 @@  discard block
 block discarded – undo
45 47
 	 */
46 48
 	public function onAfterCreate( $postData, $meta, $postId )
47 49
 	{
48
-		if( !$this->isReviewPostId( $postId ))return;
50
+		if( !$this->isReviewPostId( $postId )) {
51
+			return;
52
+		}
49 53
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
50 54
 		glsr( CountsManager::class )->increase( $review );
51 55
 	}
@@ -57,7 +61,9 @@  discard block
 block discarded – undo
57 61
 	 */
58 62
 	public function onBeforeDelete( $postId )
59 63
 	{
60
-		if( !$this->isReviewPostId( $postId ))return;
64
+		if( !$this->isReviewPostId( $postId )) {
65
+			return;
66
+		}
61 67
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
62 68
 		glsr( CountsManager::class )->decrease( $review );
63 69
 	}
@@ -74,9 +80,13 @@  discard block
 block discarded – undo
74 80
 	{
75 81
 		if( !$this->isReviewPostId( $postId )
76 82
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
77
-		)return;
83
+		) {
84
+			return;
85
+		}
78 86
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
79
-		if( $review->$metaKey == $metaValue )return;
87
+		if( $review->$metaKey == $metaValue ) {
88
+			return;
89
+		}
80 90
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
81 91
 		call_user_func( [$this, $method], $review, $metaValue );
82 92
 	}
@@ -122,7 +132,9 @@  discard block
 block discarded – undo
122 132
 	 */
123 133
 	public function onChangeStatus( $newStatus, $oldStatus, WP_Post $post )
124 134
 	{
125
-		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
135
+		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] )) {
136
+			return;
137
+		}
126 138
 		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ));
127 139
 		if( $post->post_status == 'publish' ) {
128 140
 			glsr( CountsManager::class )->increase( $review );
Please login to merge, or discard this patch.
plugin/Modules/Html/Partials/SiteReviewsSummary.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -40,7 +40,9 @@  discard block
 block discarded – undo
40 40
 		$this->ratingCounts = glsr( CountsManager::class )->flatten( $counts, [
41 41
 			'min' => $args['rating'],
42 42
 		]);
43
-		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' ))return;
43
+		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' )) {
44
+			return;
45
+		}
44 46
 		$this->averageRating = glsr( Rating::class )->getAverage( $this->ratingCounts );
45 47
 		$this->generateSchema();
46 48
 		return glsr( Template::class )->build( 'templates/reviews-summary', [
@@ -60,7 +62,9 @@  discard block
 block discarded – undo
60 62
 	 */
61 63
 	protected function buildPercentage()
62 64
 	{
63
-		if( $this->isHidden( 'bars' ))return;
65
+		if( $this->isHidden( 'bars' )) {
66
+			return;
67
+		}
64 68
 		$range = range( Rating::MAX_RATING, 1 );
65 69
 		$percentages = preg_filter( '/$/', '%', glsr( Rating::class )->getPercentages( $this->ratingCounts ));
66 70
 		$bars = array_reduce( $range, function( $carry, $level ) use( $percentages ) {
@@ -110,7 +114,9 @@  discard block
 block discarded – undo
110 114
 	 */
111 115
 	protected function buildRating()
112 116
 	{
113
-		if( $this->isHidden( 'rating' ))return;
117
+		if( $this->isHidden( 'rating' )) {
118
+			return;
119
+		}
114 120
 		return $this->wrap( 'rating', '<span>'.$this->averageRating.'</span>' );
115 121
 	}
116 122
 
@@ -119,7 +125,9 @@  discard block
 block discarded – undo
119 125
 	 */
120 126
 	protected function buildStars()
121 127
 	{
122
-		if( $this->isHidden( 'stars' ))return;
128
+		if( $this->isHidden( 'stars' )) {
129
+			return;
130
+		}
123 131
 		$stars = glsr( Partial::class )->build( 'star-rating', ['rating' => $this->averageRating] );
124 132
 		return $this->wrap( 'stars', $stars );
125 133
 	}
@@ -129,7 +137,9 @@  discard block
 block discarded – undo
129 137
 	 */
130 138
 	protected function buildText()
131 139
 	{
132
-		if( $this->isHidden( 'summary' ))return;
140
+		if( $this->isHidden( 'summary' )) {
141
+			return;
142
+		}
133 143
 		$count = intval( array_sum( $this->ratingCounts ));
134 144
 		if( empty( $this->args['text'] )) {
135 145
 			// @todo document this change
@@ -154,7 +164,9 @@  discard block
 block discarded – undo
154 164
 	 */
155 165
 	protected function generateSchema()
156 166
 	{
157
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
167
+		if( !wp_validate_boolean( $this->args['schema'] )) {
168
+			return;
169
+		}
158 170
 		glsr( Schema::class )->store(
159 171
 			glsr( Schema::class )->buildSummary( $this->args )
160 172
 		);
Please login to merge, or discard this patch.
plugin/Modules/Style.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,9 @@  discard block
 block discarded – undo
47 47
 		}
48 48
 		$views = $this->generatePossibleViews( $view );
49 49
 		foreach( $views as $possibleView ) {
50
-			if( !file_exists( glsr()->path( 'views/'.$possibleView.'.php' )))continue;
50
+			if( !file_exists( glsr()->path( 'views/'.$possibleView.'.php' ))) {
51
+				continue;
52
+			}
51 53
 			return $possibleView;
52 54
 		}
53 55
 		return $view;
@@ -84,7 +86,9 @@  discard block
 block discarded – undo
84 86
 	 */
85 87
 	public function modifyField( Builder $instance )
86 88
 	{
87
-		if( !$this->isPublicInstance( $instance ) || empty( array_filter( $this->fields )))return;
89
+		if( !$this->isPublicInstance( $instance ) || empty( array_filter( $this->fields ))) {
90
+			return;
91
+		}
88 92
 		call_user_func_array( [$this, 'customize'], [&$instance] );
89 93
 	}
90 94
 
Please login to merge, or discard this patch.
plugin/Modules/Validator.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -93,7 +93,9 @@  discard block
 block discarded – undo
93 93
 		foreach( $this->rules as $attribute => $rules ) {
94 94
 			foreach( $rules as $rule ) {
95 95
 				$this->validateAttribute( $attribute, $rule );
96
-				if( $this->shouldStopValidating( $attribute ))break;
96
+				if( $this->shouldStopValidating( $attribute )) {
97
+					break;
98
+				}
97 99
 			}
98 100
 		}
99 101
 		return $this->errors;
@@ -109,7 +111,9 @@  discard block
 block discarded – undo
109 111
 	public function validateAttribute( $attribute, $rule )
110 112
 	{
111 113
 		list( $rule, $parameters ) = $this->parseRule( $rule );
112
-		if( $rule == '' )return;
114
+		if( $rule == '' ) {
115
+			return;
116
+		}
113 117
 		$value = $this->getValue( $attribute );
114 118
 		if( !method_exists( $this, $method = 'validate'.$rule )) {
115 119
 			throw new BadMethodCallException( "Method [$method] does not exist." );
@@ -178,7 +182,9 @@  discard block
 block discarded – undo
178 182
 	 */
179 183
 	protected function getRule( $attribute, $rules )
180 184
 	{
181
-		if( !array_key_exists( $attribute, $this->rules ))return;
185
+		if( !array_key_exists( $attribute, $this->rules )) {
186
+			return;
187
+		}
182 188
 		$rules = (array)$rules;
183 189
 		foreach( $this->rules[$attribute] as $rule ) {
184 190
 			list( $rule, $parameters ) = $this->parseRule( $rule );
Please login to merge, or discard this patch.
plugin/Handlers/EnqueuePublicAssets.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,7 +55,9 @@  discard block
 block discarded – undo
55 55
 	 */
56 56
 	public function enqueuePolyfillService()
57 57
 	{
58
-		if( !apply_filters( 'site-reviews/assets/polyfill', true ))return;
58
+		if( !apply_filters( 'site-reviews/assets/polyfill', true )) {
59
+			return;
60
+		}
59 61
 		wp_enqueue_script( Application::ID.'/polyfill', add_query_arg([
60 62
 			'features' => 'CustomEvent,Element.prototype.closest,Element.prototype.dataset,Event',
61 63
 			'flags' => 'gated',
@@ -70,7 +72,9 @@  discard block
 block discarded – undo
70 72
 		// wpforms-recaptcha
71 73
 		// google-recaptcha
72 74
 		// nf-google-recaptcha
73
-		if( !glsr( OptionManager::class )->isRecaptchaEnabled() )return;
75
+		if( !glsr( OptionManager::class )->isRecaptchaEnabled() ) {
76
+			return;
77
+		}
74 78
 		$language = apply_filters( 'site-reviews/recaptcha/language', get_locale() );
75 79
 		wp_enqueue_script( Application::ID.'/google-recaptcha', add_query_arg([
76 80
 			'hl' => $language,
@@ -84,7 +88,9 @@  discard block
 block discarded – undo
84 88
 	public function inlineStyles()
85 89
 	{
86 90
 		$inlineStylesheetPath = glsr()->path( 'assets/styles/inline-styles.css' );
87
-		if( !apply_filters( 'site-reviews/assets/css', true ))return;
91
+		if( !apply_filters( 'site-reviews/assets/css', true )) {
92
+			return;
93
+		}
88 94
 		if( !file_exists( $inlineStylesheetPath )) {
89 95
 			glsr_log()->error( 'Inline stylesheet is missing: '.$inlineStylesheetPath );
90 96
 			return;
Please login to merge, or discard this patch.
plugin/Defaults/DefaultsAbstract.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,9 @@
 block discarded – undo
13 13
 	 */
14 14
 	public function __call( $name, array $args = [] )
15 15
 	{
16
-		if( !method_exists( $this, $name ))return;
16
+		if( !method_exists( $this, $name )) {
17
+			return;
18
+		}
17 19
 		$defaults = call_user_func_array( [$this, $name], $args );
18 20
 		$className = (new ReflectionClass( $this ))->getShortName();
19 21
 		$className = str_replace( 'Defaults', '', $className );
Please login to merge, or discard this patch.
plugin/Modules/Validator/ValidateReview.php 1 patch
Braces   +27 added lines, -9 removed lines patch added patch discarded remove patch
@@ -166,8 +166,12 @@  discard block
 block discarded – undo
166 166
 	 */
167 167
 	protected function validateAkismet()
168 168
 	{
169
-		if( !empty( $this->error ))return;
170
-		if( !glsr( Akismet::class )->isSpam( $this->request ))return;
169
+		if( !empty( $this->error )) {
170
+			return;
171
+		}
172
+		if( !glsr( Akismet::class )->isSpam( $this->request )) {
173
+			return;
174
+		}
171 175
 		$this->setSessionValues( 'errors', [], 'Akismet caught a spam submission:' );
172 176
 		$this->error = __( 'Your review cannot be submitted at this time. Please try again later.', 'site-reviews' );
173 177
 	}
@@ -177,8 +181,12 @@  discard block
 block discarded – undo
177 181
 	 */
178 182
 	protected function validateBlacklist()
179 183
 	{
180
-		if( !empty( $this->error ))return;
181
-		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ))return;
184
+		if( !empty( $this->error )) {
185
+			return;
186
+		}
187
+		if( !glsr( Blacklist::class )->isBlacklisted( $this->request )) {
188
+			return;
189
+		}
182 190
 		$blacklistAction = $this->getOption( 'settings.submissions.blacklist.action' );
183 191
 		if( $blacklistAction == 'reject' ) {
184 192
 			$this->setSessionValues( 'errors', [], 'Blacklisted submission detected:' );
@@ -193,9 +201,13 @@  discard block
 block discarded – undo
193 201
 	 */
194 202
 	protected function validateCustom()
195 203
 	{
196
-		if( !empty( $this->error ))return;
204
+		if( !empty( $this->error )) {
205
+			return;
206
+		}
197 207
 		$validated = apply_filters( 'site-reviews/validate/review/submission', true, $this->request );
198
-		if( $validated === true )return;
208
+		if( $validated === true ) {
209
+			return;
210
+		}
199 211
 		$this->setSessionValues( 'errors', [] );
200 212
 		$this->setSessionValues( 'values', $this->request );
201 213
 		$this->error = is_string( $validated )
@@ -208,8 +220,12 @@  discard block
 block discarded – undo
208 220
 	 */
209 221
 	protected function validateHoneyPot()
210 222
 	{
211
-		if( !empty( $this->error ))return;
212
-		if( empty( $this->request['gotcha'] ))return;
223
+		if( !empty( $this->error )) {
224
+			return;
225
+		}
226
+		if( empty( $this->request['gotcha'] )) {
227
+			return;
228
+		}
213 229
 		$this->setSessionValues( 'errors', [], 'The Honeypot caught a bad submission:' );
214 230
 		$this->error = __( 'The review submission failed. Please notify the site administrator.', 'site-reviews' );
215 231
 	}
@@ -219,7 +235,9 @@  discard block
 block discarded – undo
219 235
 	 */
220 236
 	protected function validateRecaptcha()
221 237
 	{
222
-		if( !empty( $this->error ))return;
238
+		if( !empty( $this->error )) {
239
+			return;
240
+		}
223 241
 		$isValid = $this->isRecaptchaResponseValid();
224 242
 		if( is_null( $isValid )) {
225 243
 			$this->setSessionValues( 'recaptcha', 'unset' );
Please login to merge, or discard this patch.