Passed
Push — master ( 7f2931...8eca98 )
by Paul
08:06 queued 03:49
created
plugin/Modules/Html/Partials/SiteReviewsSummary.php 2 patches
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,7 +41,9 @@  discard block
 block discarded – undo
41 41
 		$this->ratingCounts = glsr( CountsManager::class )->flatten( $counts, [
42 42
 			'min' => $args['rating'],
43 43
 		]);
44
-		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' ))return;
44
+		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' )) {
45
+			return;
46
+		}
45 47
 		$this->averageRating = glsr( Rating::class )->getAverage( $this->ratingCounts );
46 48
 		$this->generateSchema();
47 49
 		return glsr( Template::class )->build( 'templates/reviews-summary', [
@@ -61,7 +63,9 @@  discard block
 block discarded – undo
61 63
 	 */
62 64
 	protected function buildPercentage()
63 65
 	{
64
-		if( $this->isHidden( 'bars' ))return;
66
+		if( $this->isHidden( 'bars' )) {
67
+			return;
68
+		}
65 69
 		$percentages = preg_filter( '/$/', '%', glsr( Rating::class )->getPercentages( $this->ratingCounts ));
66 70
 		$bars = array_reduce( range( Rating::MAX_RATING, 1 ), function( $carry, $level ) use( $percentages ) {
67 71
 			$label = $this->buildPercentageLabel( $this->args['labels'][$level] );
@@ -110,7 +114,9 @@  discard block
 block discarded – undo
110 114
 	 */
111 115
 	protected function buildRating()
112 116
 	{
113
-		if( $this->isHidden( 'rating' ))return;
117
+		if( $this->isHidden( 'rating' )) {
118
+			return;
119
+		}
114 120
 		return $this->wrap( 'rating', '<span>'.$this->averageRating.'</span>' );
115 121
 	}
116 122
 
@@ -119,7 +125,9 @@  discard block
 block discarded – undo
119 125
 	 */
120 126
 	protected function buildStars()
121 127
 	{
122
-		if( $this->isHidden( 'stars' ))return;
128
+		if( $this->isHidden( 'stars' )) {
129
+			return;
130
+		}
123 131
 		$stars = glsr( Partial::class )->build( 'star-rating', ['rating' => $this->averageRating] );
124 132
 		return $this->wrap( 'stars', $stars );
125 133
 	}
@@ -129,7 +137,9 @@  discard block
 block discarded – undo
129 137
 	 */
130 138
 	protected function buildText()
131 139
 	{
132
-		if( $this->isHidden( 'summary' ))return;
140
+		if( $this->isHidden( 'summary' )) {
141
+			return;
142
+		}
133 143
 		$count = intval( array_sum( $this->ratingCounts ));
134 144
 		if( empty( $this->args['text'] )) {
135 145
 			// @todo document this change
@@ -154,7 +164,9 @@  discard block
 block discarded – undo
154 164
 	 */
155 165
 	protected function generateSchema()
156 166
 	{
157
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
167
+		if( !wp_validate_boolean( $this->args['schema'] )) {
168
+			return;
169
+		}
158 170
 		glsr( Schema::class )->store(
159 171
 			glsr( Schema::class )->buildSummary( $this->args )
160 172
 		);
Please login to merge, or discard this patch.
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -35,15 +35,15 @@  discard block
 block discarded – undo
35 35
 	public function build( array $args = [] )
36 36
 	{
37 37
 		$this->args = $args;
38
-		$counts = glsr( CountsManager::class )->get([
38
+		$counts = glsr( CountsManager::class )->get( [
39 39
 			'post_ids' => glsr( Helper::class )->convertStringToArray( $args['assigned_to'] ),
40 40
 			'term_ids' => glsr( ReviewManager::class )->normalizeTermIds( $args['category'] ),
41 41
 			'type' => $args['type'],
42
-		]);
42
+		] );
43 43
 		$this->ratingCounts = glsr( CountsManager::class )->flatten( $counts, [
44 44
 			'min' => $args['rating'],
45
-		]);
46
-		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' ))return;
45
+		] );
46
+		if( !array_sum( $this->ratingCounts ) && $this->isHidden( 'if_empty' ) )return;
47 47
 		$this->averageRating = glsr( Rating::class )->getAverage( $this->ratingCounts );
48 48
 		$this->generateSchema();
49 49
 		return glsr( Template::class )->build( 'templates/reviews-summary', [
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 				'stars' => $this->buildStars(),
57 57
 				'text' => $this->buildText(),
58 58
 			],
59
-		]);
59
+		] );
60 60
 	}
61 61
 
62 62
 	/**
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
 	 */
65 65
 	protected function buildPercentage()
66 66
 	{
67
-		if( $this->isHidden( 'bars' ))return;
68
-		$percentages = preg_filter( '/$/', '%', glsr( Rating::class )->getPercentages( $this->ratingCounts ));
69
-		$bars = array_reduce( range( Rating::MAX_RATING, 1 ), function( $carry, $level ) use( $percentages ) {
67
+		if( $this->isHidden( 'bars' ) )return;
68
+		$percentages = preg_filter( '/$/', '%', glsr( Rating::class )->getPercentages( $this->ratingCounts ) );
69
+		$bars = array_reduce( range( Rating::MAX_RATING, 1 ), function( $carry, $level ) use($percentages) {
70 70
 			$label = $this->buildPercentageLabel( $this->args['labels'][$level] );
71 71
 			$background = $this->buildPercentageBackground( $percentages[$level] );
72 72
 			$count = apply_filters( 'site-reviews/summary/counts',
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 			$percent = $this->buildPercentageCount( $count );
77 77
 			return $carry.glsr( Builder::class )->div( $label.$background.$percent, [
78 78
 				'class' => 'glsr-bar',
79
-			]);
79
+			] );
80 80
 		});
81 81
 		return $this->wrap( 'percentage', $bars );
82 82
 	}
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
87 87
 	 */
88 88
 	protected function buildPercentageBackground( $percent )
89 89
 	{
90
-		$backgroundPercent = glsr( Builder::class )->span([
90
+		$backgroundPercent = glsr( Builder::class )->span( [
91 91
 			'class' => 'glsr-bar-background-percent',
92 92
 			'style' => 'width:'.$percent,
93
-		]);
93
+		] );
94 94
 		return '<span class="glsr-bar-background">'.$backgroundPercent.'</span>';
95 95
 	}
96 96
 
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 	 */
118 118
 	protected function buildRating()
119 119
 	{
120
-		if( $this->isHidden( 'rating' ))return;
120
+		if( $this->isHidden( 'rating' ) )return;
121 121
 		return $this->wrap( 'rating', '<span>'.$this->averageRating.'</span>' );
122 122
 	}
123 123
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 */
127 127
 	protected function buildStars()
128 128
 	{
129
-		if( $this->isHidden( 'stars' ))return;
129
+		if( $this->isHidden( 'stars' ) )return;
130 130
 		$stars = glsr( Partial::class )->build( 'star-rating', ['rating' => $this->averageRating] );
131 131
 		return $this->wrap( 'stars', $stars );
132 132
 	}
@@ -136,9 +136,9 @@  discard block
 block discarded – undo
136 136
 	 */
137 137
 	protected function buildText()
138 138
 	{
139
-		if( $this->isHidden( 'summary' ))return;
140
-		$count = intval( array_sum( $this->ratingCounts ));
141
-		if( empty( $this->args['text'] )) {
139
+		if( $this->isHidden( 'summary' ) )return;
140
+		$count = intval( array_sum( $this->ratingCounts ) );
141
+		if( empty($this->args['text']) ) {
142 142
 			// @todo document this change
143 143
 			 $this->args['text'] = _nx(
144 144
 				'{rating} out of {max} stars (based on {num} review)',
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 			);
150 150
 		}
151 151
 		$summary = str_replace(
152
-			['{rating}','{max}', '{num}'],
152
+			['{rating}', '{max}', '{num}'],
153 153
 			[$this->averageRating, Rating::MAX_RATING, $count],
154 154
 			$this->args['text']
155 155
 		);
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 	 */
162 162
 	protected function generateSchema()
163 163
 	{
164
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
164
+		if( !wp_validate_boolean( $this->args['schema'] ) )return;
165 165
 		glsr( Schema::class )->store(
166 166
 			glsr( Schema::class )->buildSummary( $this->args )
167 167
 		);
@@ -193,6 +193,6 @@  discard block
 block discarded – undo
193 193
 	{
194 194
 		return glsr( Builder::class )->div( $value, [
195 195
 			'class' => 'glsr-summary-'.$key,
196
-		]);
196
+		] );
197 197
 	}
198 198
 }
Please login to merge, or discard this patch.
plugin/Modules/Html/Partials/Pagination.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,9 @@
 block discarded – undo
20 20
 	public function build( array $args = [] )
21 21
 	{
22 22
 		$this->args = $this->normalize( $args );
23
-		if( $this->args['total'] < 2 )return;
23
+		if( $this->args['total'] < 2 ) {
24
+			return;
25
+		}
24 26
 		return glsr( Template::class )->build( 'templates/pagination', [
25 27
 			'context' => [
26 28
 				'links' => apply_filters( 'site-reviews/paginate_links', $this->buildLinks(), $this->args ),
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 				'loader' => '<div class="glsr-loader"></div>',
28 28
 				'screen_reader_text' => __( 'Site Reviews navigation', 'site-reviews' ),
29 29
 			],
30
-		]);
30
+		] );
31 31
 	}
32 32
 
33 33
 	/**
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	protected function buildLinks()
37 37
 	{
38
-		$args = glsr( Style::class )->paginationArgs([
38
+		$args = glsr( Style::class )->paginationArgs( [
39 39
 			'current' => $this->args['paged'],
40 40
 			'total' => $this->args['total'],
41
-		]);
41
+		] );
42 42
 		if( is_front_page() ) {
43
-			unset( $args['format'] );
43
+			unset($args['format']);
44 44
 		}
45 45
 		if( $args['type'] == 'array' ) {
46 46
 			$args['type'] = 'plain';
@@ -56,6 +56,6 @@  discard block
 block discarded – undo
56 56
 		return wp_parse_args( $args, [
57 57
 			'paged' => glsr( QueryBuilder::class )->getPaged(),
58 58
 			'total' => 1,
59
-		]);
59
+		] );
60 60
 	}
61 61
 }
Please login to merge, or discard this patch.
plugin/Handlers/CreateReview.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -17,13 +17,13 @@  discard block
 block discarded – undo
17 17
 		$review = glsr( ReviewManager::class )->create( $command );
18 18
 		if( !$review ) {
19 19
 			glsr( Session::class )->set( $command->form_id.'errors', [] );
20
-			glsr( Session::class )->set( $command->form_id.'message', __( 'Your review could not be submitted and the error has been logged. Please notify the site admin.', 'site-reviews' ));
20
+			glsr( Session::class )->set( $command->form_id.'message', __( 'Your review could not be submitted and the error has been logged. Please notify the site admin.', 'site-reviews' ) );
21 21
 			return;
22 22
 		}
23
-		glsr( Session::class )->set( $command->form_id.'message', __( 'Your review has been submitted!', 'site-reviews' ));
23
+		glsr( Session::class )->set( $command->form_id.'message', __( 'Your review has been submitted!', 'site-reviews' ) );
24 24
 		glsr( Notification::class )->send( $review );
25 25
 		if( $command->ajax_request )return;
26
-		wp_safe_redirect( $this->getReferer( $command ));
26
+		wp_safe_redirect( $this->getReferer( $command ) );
27 27
 		exit;
28 28
 	}
29 29
 
@@ -32,11 +32,11 @@  discard block
 block discarded – undo
32 32
 	 */
33 33
 	protected function getReferer( Command $command )
34 34
 	{
35
-		$referer = trim( strval( get_post_meta( $command->post_id, 'redirect_to', true )));
36
-		if( empty( $referer )) {
35
+		$referer = trim( strval( get_post_meta( $command->post_id, 'redirect_to', true ) ) );
36
+		if( empty($referer) ) {
37 37
 			$referer = $command->referer;
38 38
 		}
39
-		if( empty( $referer )) {
39
+		if( empty($referer) ) {
40 40
 			glsr_log()->warning( 'The form referer ($_SERVER[REQUEST_URI]) was empty.' )->info( $command );
41 41
 			$referer = home_url();
42 42
 		}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,9 @@
 block discarded – undo
22 22
 		}
23 23
 		glsr( Session::class )->set( $command->form_id.'message', __( 'Your review has been submitted!', 'site-reviews' ));
24 24
 		glsr( Notification::class )->send( $review );
25
-		if( $command->ajax_request )return;
25
+		if( $command->ajax_request ) {
26
+			return;
27
+		}
26 28
 		wp_safe_redirect( $this->getReferer( $command ));
27 29
 		exit;
28 30
 	}
Please login to merge, or discard this patch.
plugin/Modules/Html/Form.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 	{
29 29
 		$fields = [];
30 30
 		foreach( glsr()->config( 'forms/'.$id ) as $name => $field ) {
31
-			$fields[] = new Field( wp_parse_args( $field, ['name' => $name] ));
31
+			$fields[] = new Field( wp_parse_args( $field, ['name' => $name] ) );
32 32
 		}
33 33
 		return $fields;
34 34
 	}
Please login to merge, or discard this patch.
views/partials/translations/single.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 			<p>{{ data.s1 }}</p>
8 8
 		</div>
9 9
 		<p class="row-actions">
10
-			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
10
+			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
11 11
 		</p>
12 12
 	</td>
13 13
 	<td class="glsr-string-td2">
Please login to merge, or discard this patch.
views/partials/translations/plural.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 			<p>{{ data.p1 }}</p>
9 9
 		</div>
10 10
 		<p class="row-actions">
11
-			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
11
+			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
12 12
 		</p>
13 13
 	</td>
14 14
 	<td class="glsr-string-td2">
Please login to merge, or discard this patch.
plugin/Modules/Upgrader.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,7 +20,9 @@  discard block
 block discarded – undo
20 20
 		$filenames = [];
21 21
 		$iterator = new DirectoryIterator( dirname( __FILE__ ).'/Upgrader' );
22 22
 		foreach( $iterator as $fileinfo ) {
23
-			if( !$fileinfo->isFile() )continue;
23
+			if( !$fileinfo->isFile() ) {
24
+				continue;
25
+			}
24 26
 			$filenames[] = $fileinfo->getFilename();
25 27
 		}
26 28
 		natsort( $filenames );
@@ -28,7 +30,9 @@  discard block
 block discarded – undo
28 30
 			$className = str_replace( '.php', '', $file );
29 31
 			$version = str_replace( ['Upgrade_', '_'], ['', '.'], $className );
30 32
 			$versionSuffix = preg_replace( '/[\d.]+(.+)?/', '${1}', glsr()->version ); // allow alpha/beta versions
31
-			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' ))return;
33
+			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' )) {
34
+				return;
35
+			}
32 36
 			glsr( 'Modules\\Upgrader\\'.$className );
33 37
 			glsr_log()->info( 'Completed Upgrade for v'.$version.$versionSuffix );
34 38
 		});
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 			$className = str_replace( '.php', '', $file );
25 25
 			$version = str_replace( ['Upgrade_', '_'], ['', '.'], $className );
26 26
 			$versionSuffix = preg_replace( '/[\d.]+(.+)?/', '${1}', glsr()->version ); // allow alpha/beta versions
27
-			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' ))return;
27
+			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' ) )return;
28 28
 			glsr( 'Modules\\Upgrader\\'.$className );
29 29
 			glsr_log()->info( 'Completed Upgrade for v'.$version.$versionSuffix );
30 30
 		});
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 			$this->setReviewCounts();
42 42
 			$this->updateVersionFrom( $version );
43 43
 		}
44
-		else if( !glsr( OptionManager::class )->get( 'last_review_count', false )) {
44
+		else if( !glsr( OptionManager::class )->get( 'last_review_count', false ) ) {
45 45
 			$this->setReviewCounts();
46 46
 		}
47 47
 	}
Please login to merge, or discard this patch.
plugin/Modules/Html/Attributes.php 2 patches
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 */
123 123
 	protected function filterAttributes( array $allowedAttributeKeys )
124 124
 	{
125
-		return array_intersect_key( $this->attributes, array_flip( $allowedAttributeKeys ));
125
+		return array_intersect_key( $this->attributes, array_flip( $allowedAttributeKeys ) );
126 126
 	}
127 127
 
128 128
 	/**
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$globalAttributes = $this->filterAttributes( static::GLOBAL_ATTRIBUTES );
134 134
 		$wildcards = [];
135 135
 		foreach( static::GLOBAL_WILDCARD_ATTRIBUTES as $wildcard ) {
136
-			$newWildcards = array_filter( $this->attributes, function( $key ) use( $wildcard ) {
136
+			$newWildcards = array_filter( $this->attributes, function( $key ) use($wildcard) {
137 137
 				return glsr( Helper::class )->startsWith( $wildcard, $key );
138 138
 			}, ARRAY_FILTER_USE_KEY );
139 139
 			$wildcards = array_merge( $wildcards, $newWildcards );
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 	protected function getPermanentAttributes()
148 148
 	{
149 149
 		$permanentAttributes = [];
150
-		if( array_key_exists( 'value', $this->attributes )) {
150
+		if( array_key_exists( 'value', $this->attributes ) ) {
151 151
 			$permanentAttributes['value'] = $this->attributes['value'];
152 152
 		}
153 153
 		return $permanentAttributes;
@@ -199,11 +199,11 @@  discard block
 block discarded – undo
199 199
 	protected function normalizeBooleanAttributes()
200 200
 	{
201 201
 		foreach( $this->attributes as $key => $value ) {
202
-			if( $this->isAttributeKeyNumeric( $key, $value )) {
202
+			if( $this->isAttributeKeyNumeric( $key, $value ) ) {
203 203
 				$key = $value;
204 204
 				$value = true;
205 205
 			}
206
-			if( !in_array( $key, static::BOOLEAN_ATTRIBUTES ))continue;
206
+			if( !in_array( $key, static::BOOLEAN_ATTRIBUTES ) )continue;
207 207
 			$this->attributes[$key] = wp_validate_boolean( $value );
208 208
 		}
209 209
 	}
@@ -214,13 +214,13 @@  discard block
 block discarded – undo
214 214
 	protected function normalizeDataAttributes()
215 215
 	{
216 216
 		foreach( $this->attributes as $key => $value ) {
217
-			if( $this->isAttributeKeyNumeric( $key, $value )) {
217
+			if( $this->isAttributeKeyNumeric( $key, $value ) ) {
218 218
 				$key = $value;
219 219
 				$value = '';
220 220
 			}
221
-			if( !glsr( Helper::class )->startsWith( 'data-', $key ))continue;
222
-			if( is_array( $value )) {
223
-				$value = json_encode( $value, JSON_HEX_APOS|JSON_NUMERIC_CHECK|JSON_UNESCAPED_SLASHES|JSON_UNESCAPED_UNICODE );
221
+			if( !glsr( Helper::class )->startsWith( 'data-', $key ) )continue;
222
+			if( is_array( $value ) ) {
223
+				$value = json_encode( $value, JSON_HEX_APOS | JSON_NUMERIC_CHECK | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
224 224
 			}
225 225
 			$this->attributes[$key] = $value;
226 226
 		}
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 	protected function normalizeStringAttributes()
233 233
 	{
234 234
 		foreach( $this->attributes as $key => $value ) {
235
-			if( !is_string( $value ))continue;
235
+			if( !is_string( $value ) )continue;
236 236
 			$this->attributes[$key] = trim( $value );
237 237
 		}
238 238
 	}
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
 	{
246 246
 		if( $method != 'input' )return;
247 247
 		$attributes = wp_parse_args( $this->attributes, ['type' => ''] );
248
-		if( !in_array( $attributes['type'], static::INPUT_TYPES )) {
248
+		if( !in_array( $attributes['type'], static::INPUT_TYPES ) ) {
249 249
 			$this->attributes['type'] = 'text';
250 250
 		}
251 251
 	}
@@ -259,11 +259,11 @@  discard block
 block discarded – undo
259 259
 		$permanentAttributes = $this->getPermanentAttributes();
260 260
 		foreach( $this->attributes as $key => $value ) {
261 261
 			if( in_array( $key, static::BOOLEAN_ATTRIBUTES ) && !$value ) {
262
-				unset( $attributes[$key] );
262
+				unset($attributes[$key]);
263 263
 			}
264
-			if( glsr( Helper::class )->startsWith( 'data-', $key )) {
264
+			if( glsr( Helper::class )->startsWith( 'data-', $key ) ) {
265 265
 				$permanentAttributes[$key] = $value;
266
-				unset( $attributes[$key] );
266
+				unset($attributes[$key]);
267 267
 			}
268 268
 		}
269 269
 		$this->attributes = array_merge( array_filter( $attributes ), $permanentAttributes );
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -203,7 +203,9 @@  discard block
 block discarded – undo
203 203
 				$key = $value;
204 204
 				$value = true;
205 205
 			}
206
-			if( !in_array( $key, static::BOOLEAN_ATTRIBUTES ))continue;
206
+			if( !in_array( $key, static::BOOLEAN_ATTRIBUTES )) {
207
+				continue;
208
+			}
207 209
 			$this->attributes[$key] = wp_validate_boolean( $value );
208 210
 		}
209 211
 	}
@@ -218,7 +220,9 @@  discard block
 block discarded – undo
218 220
 				$key = $value;
219 221
 				$value = '';
220 222
 			}
221
-			if( !glsr( Helper::class )->startsWith( 'data-', $key ))continue;
223
+			if( !glsr( Helper::class )->startsWith( 'data-', $key )) {
224
+				continue;
225
+			}
222 226
 			if( is_array( $value )) {
223 227
 				$value = json_encode( $value, JSON_HEX_APOS|JSON_NUMERIC_CHECK|JSON_UNESCAPED_SLASHES|JSON_UNESCAPED_UNICODE );
224 228
 			}
@@ -232,7 +236,9 @@  discard block
 block discarded – undo
232 236
 	protected function normalizeStringAttributes()
233 237
 	{
234 238
 		foreach( $this->attributes as $key => $value ) {
235
-			if( !is_string( $value ))continue;
239
+			if( !is_string( $value )) {
240
+				continue;
241
+			}
236 242
 			$this->attributes[$key] = trim( $value );
237 243
 		}
238 244
 	}
@@ -243,7 +249,9 @@  discard block
 block discarded – undo
243 249
 	 */
244 250
 	protected function normalizeInputType( $method )
245 251
 	{
246
-		if( $method != 'input' )return;
252
+		if( $method != 'input' ) {
253
+			return;
254
+		}
247 255
 		$attributes = wp_parse_args( $this->attributes, ['type' => ''] );
248 256
 		if( !in_array( $attributes['type'], static::INPUT_TYPES )) {
249 257
 			$this->attributes['type'] = 'text';
Please login to merge, or discard this patch.
plugin/Modules/Upgrader/Upgrade_3_0_0.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -74,9 +74,9 @@  discard block
 block discarded – undo
74 74
 	{
75 75
 		$this->newSettings = $this->getNewSettings();
76 76
 		$this->oldSettings = $this->getOldSettings();
77
-		if( empty( $this->oldSettings ))return;
77
+		if( empty($this->oldSettings) )return;
78 78
 		foreach( static::MAPPED_SETTINGS as $old => $new ) {
79
-			if( empty( $this->oldSettings[$old] ))continue;
79
+			if( empty($this->oldSettings[$old]) )continue;
80 80
 			$this->newSettings[$new] = $this->oldSettings[$old];
81 81
 		}
82 82
 		$this->migrateNotificationSettings();
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 		$this->migrateRequiredSettings();
85 85
 		$oldSettings = glsr( Helper::class )->convertDotNotationArray( $this->oldSettings );
86 86
 		$newSettings = glsr( Helper::class )->convertDotNotationArray( $this->newSettings );
87
-		if( isset( $oldSettings['settings']['strings'] ) && is_array( $oldSettings['settings']['strings'] )) {
87
+		if( isset($oldSettings['settings']['strings']) && is_array( $oldSettings['settings']['strings'] ) ) {
88 88
 			$newSettings['settings']['strings'] = $oldSettings['settings']['strings'];
89 89
 		}
90 90
 		glsr( OptionManager::class )->set( $newSettings );
@@ -117,8 +117,8 @@  discard block
 block discarded – undo
117 117
 	protected function getOldSettings()
118 118
 	{
119 119
 		$defaults = array_fill_keys( array_keys( static::MAPPED_SETTINGS ), '' );
120
-		$settings = glsr( Helper::class )->flattenArray( get_option( 'geminilabs_site_reviews-v2', [] ));
121
-		if( !empty( $settings )) {
120
+		$settings = glsr( Helper::class )->flattenArray( get_option( 'geminilabs_site_reviews-v2', [] ) );
121
+		if( !empty($settings) ) {
122 122
 			$settings = wp_parse_args( $settings, $defaults );
123 123
 		}
124 124
 		return $settings;
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 			'SecretKey' => $this->oldSettings['settings.reviews-form.recaptcha.secret'],
152 152
 			'SiteKey' => $this->oldSettings['settings.reviews-form.recaptcha.key'],
153 153
 		];
154
-		if( in_array( $this->oldSettings['settings.reviews-form.recaptcha.integration'], ['custom', 'invisible-recaptcha'] )) {
154
+		if( in_array( $this->oldSettings['settings.reviews-form.recaptcha.integration'], ['custom', 'invisible-recaptcha'] ) ) {
155 155
 			$this->newSettings['settings.submissions.recaptcha.integration'] = 'all';
156 156
 		}
157 157
 		if( $this->oldSettings['settings.reviews-form.recaptcha.integration'] == 'invisible-recaptcha' ) {
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -74,9 +74,13 @@  discard block
 block discarded – undo
74 74
 	{
75 75
 		$this->newSettings = $this->getNewSettings();
76 76
 		$this->oldSettings = $this->getOldSettings();
77
-		if( empty( $this->oldSettings ))return;
77
+		if( empty( $this->oldSettings )) {
78
+			return;
79
+		}
78 80
 		foreach( static::MAPPED_SETTINGS as $old => $new ) {
79
-			if( empty( $this->oldSettings[$old] ))continue;
81
+			if( empty( $this->oldSettings[$old] )) {
82
+				continue;
83
+			}
80 84
 			$this->newSettings[$new] = $this->oldSettings[$old];
81 85
 		}
82 86
 		$this->migrateNotificationSettings();
@@ -136,7 +140,9 @@  discard block
 block discarded – undo
136 140
 		];
137 141
 		$this->newSettings['settings.general.notifications'] = [];
138 142
 		foreach( $notifications as $old => $new ) {
139
-			if( $this->oldSettings['settings.general.notification'] != $old )continue;
143
+			if( $this->oldSettings['settings.general.notification'] != $old ) {
144
+				continue;
145
+			}
140 146
 			$this->newSettings['settings.general.notifications'][] = $new;
141 147
 		}
142 148
 	}
Please login to merge, or discard this patch.