Passed
Push — master ( 999d23...fe5b90 )
by Paul
04:24
created
plugin/Modules/Validator/ValidateReview.php 1 patch
Braces   +27 added lines, -9 removed lines patch added patch discarded remove patch
@@ -166,8 +166,12 @@  discard block
 block discarded – undo
166 166
 	 */
167 167
 	protected function validateAkismet()
168 168
 	{
169
-		if( !empty( $this->error ))return;
170
-		if( !glsr( Akismet::class )->isSpam( $this->request ))return;
169
+		if( !empty( $this->error )) {
170
+			return;
171
+		}
172
+		if( !glsr( Akismet::class )->isSpam( $this->request )) {
173
+			return;
174
+		}
171 175
 		$this->setSessionValues( 'errors', [], 'Akismet caught a spam submission:' );
172 176
 		$this->error = __( 'Your review cannot be submitted at this time. Please try again later.', 'site-reviews' );
173 177
 	}
@@ -177,8 +181,12 @@  discard block
 block discarded – undo
177 181
 	 */
178 182
 	protected function validateBlacklist()
179 183
 	{
180
-		if( !empty( $this->error ))return;
181
-		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ))return;
184
+		if( !empty( $this->error )) {
185
+			return;
186
+		}
187
+		if( !glsr( Blacklist::class )->isBlacklisted( $this->request )) {
188
+			return;
189
+		}
182 190
 		$blacklistAction = $this->getOption( 'settings.submissions.blacklist.action' );
183 191
 		if( $blacklistAction == 'reject' ) {
184 192
 			$this->setSessionValues( 'errors', [], 'Blacklisted submission detected:' );
@@ -193,9 +201,13 @@  discard block
 block discarded – undo
193 201
 	 */
194 202
 	protected function validateCustom()
195 203
 	{
196
-		if( !empty( $this->error ))return;
204
+		if( !empty( $this->error )) {
205
+			return;
206
+		}
197 207
 		$validated = apply_filters( 'site-reviews/validate/review/submission', true, $this->request );
198
-		if( $validated === true )return;
208
+		if( $validated === true ) {
209
+			return;
210
+		}
199 211
 		$this->setSessionValues( 'errors', [] );
200 212
 		$this->setSessionValues( 'values', $this->request );
201 213
 		$this->error = is_string( $validated )
@@ -208,8 +220,12 @@  discard block
 block discarded – undo
208 220
 	 */
209 221
 	protected function validateHoneyPot()
210 222
 	{
211
-		if( !empty( $this->error ))return;
212
-		if( empty( $this->request['gotcha'] ))return;
223
+		if( !empty( $this->error )) {
224
+			return;
225
+		}
226
+		if( empty( $this->request['gotcha'] )) {
227
+			return;
228
+		}
213 229
 		$this->setSessionValues( 'errors', [], 'The Honeypot caught a bad submission:' );
214 230
 		$this->error = __( 'The review submission failed. Please notify the site administrator.', 'site-reviews' );
215 231
 	}
@@ -219,7 +235,9 @@  discard block
 block discarded – undo
219 235
 	 */
220 236
 	protected function validateRecaptcha()
221 237
 	{
222
-		if( !empty( $this->error ))return;
238
+		if( !empty( $this->error )) {
239
+			return;
240
+		}
223 241
 		$isValid = $this->isRecaptchaResponseValid();
224 242
 		if( is_null( $isValid )) {
225 243
 			$this->setSessionValues( 'recaptcha', 'unset' );
Please login to merge, or discard this patch.
plugin/Router.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -17,7 +17,9 @@  discard block
 block discarded – undo
17 17
 	public function routeAdminPostRequest()
18 18
 	{
19 19
 		$request = $this->getRequest();
20
-		if( !$this->isValidPostRequest( $request ))return;
20
+		if( !$this->isValidPostRequest( $request )) {
21
+			return;
22
+		}
21 23
 		check_admin_referer( $request['action'] );
22 24
 		$this->routeRequest( 'admin', $request['action'], $request );
23 25
 	}
@@ -39,10 +41,16 @@  discard block
 block discarded – undo
39 41
 	 */
40 42
 	public function routePublicPostRequest()
41 43
 	{
42
-		if( is_admin() )return;
44
+		if( is_admin() ) {
45
+			return;
46
+		}
43 47
 		$request = $this->getRequest();
44
-		if( !$this->isValidPostRequest( $request ))return;
45
-		if( !$this->isValidPublicNonce( $request ))return;
48
+		if( !$this->isValidPostRequest( $request )) {
49
+			return;
50
+		}
51
+		if( !$this->isValidPublicNonce( $request )) {
52
+			return;
53
+		}
46 54
 		$this->routeRequest( 'public', $request['action'], $request );
47 55
 	}
48 56
 
@@ -51,7 +59,9 @@  discard block
 block discarded – undo
51 59
 	 */
52 60
 	protected function checkAjaxNonce( array $request )
53 61
 	{
54
-		if( !is_user_logged_in() )return;
62
+		if( !is_user_logged_in() ) {
63
+			return;
64
+		}
55 65
 		if( !isset( $request['nonce'] )) {
56 66
 			$this->sendAjaxError( 'request is missing a nonce', $request );
57 67
 		}
Please login to merge, or discard this patch.
plugin/Modules/Slack.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,9 @@
 block discarded – undo
35 35
 	 */
36 36
 	public function compose( Review $review, array $notification )
37 37
 	{
38
-		if( empty( $this->endpoint ))return;
38
+		if( empty( $this->endpoint )) {
39
+			return;
40
+		}
39 41
 		$args = shortcode_atts( glsr( SlackDefaults::class )->defaults(), $notification );
40 42
 		$this->review = $review;
41 43
 		$notification = [
Please login to merge, or discard this patch.
plugin/Modules/Html/Partials/SiteReviewsForm.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -85,7 +85,9 @@  discard block
 block discarded – undo
85 85
 	 */
86 86
 	protected function buildRecaptcha()
87 87
 	{
88
-		if( !glsr( OptionManager::class )->isRecaptchaEnabled() )return;
88
+		if( !glsr( OptionManager::class )->isRecaptchaEnabled() ) {
89
+			return;
90
+		}
89 91
 		return glsr( Builder::class )->div([
90 92
 			'class' => 'glsr-recaptcha-holder',
91 93
 			'data-badge' => glsr( OptionManager::class )->get( 'settings.submissions.recaptcha.position' ),
@@ -161,7 +163,9 @@  discard block
 block discarded – undo
161 163
 	 */
162 164
 	protected function getRegisterText()
163 165
 	{
164
-		if( !get_option( 'users_can_register' ) || glsr( OptionManager::class )->get( 'settings.general.require.login' ) != 'yes' )return;
166
+		if( !get_option( 'users_can_register' ) || glsr( OptionManager::class )->get( 'settings.general.require.login' ) != 'yes' ) {
167
+			return;
168
+		}
165 169
 		$registerLink = glsr( Builder::class )->a([
166 170
 			'href' => wp_registration_url(),
167 171
 			'text' => __( 'register', 'site-reviews' ),
@@ -217,7 +221,9 @@  discard block
 block discarded – undo
217 221
 	 */
218 222
 	protected function normalizeFieldErrors( Field &$field )
219 223
 	{
220
-		if( !array_key_exists( $field->field['path'], $this->errors ))return;
224
+		if( !array_key_exists( $field->field['path'], $this->errors )) {
225
+			return;
226
+		}
221 227
 		$field->field['errors'] = $this->errors[$field->field['path']];
222 228
 	}
223 229
 
@@ -226,7 +232,9 @@  discard block
 block discarded – undo
226 232
 	 */
227 233
 	protected function normalizeFieldRequired( Field &$field )
228 234
 	{
229
-		if( !in_array( $field->field['path'], $this->required ))return;
235
+		if( !in_array( $field->field['path'], $this->required )) {
236
+			return;
237
+		}
230 238
 		$field->field['required'] = true;
231 239
 	}
232 240
 
@@ -249,7 +257,9 @@  discard block
 block discarded – undo
249 257
 	 */
250 258
 	protected function normalizeFieldValue( Field &$field )
251 259
 	{
252
-		if( !array_key_exists( $field->field['path'], $this->values ))return;
260
+		if( !array_key_exists( $field->field['path'], $this->values )) {
261
+			return;
262
+		}
253 263
 		if( in_array( $field->field['type'], ['radio', 'checkbox'] )) {
254 264
 			$field->field['checked'] = $field->field['value'] == $this->values[$field->field['path']];
255 265
 		}
Please login to merge, or discard this patch.
site-reviews.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,9 @@
 block discarded – undo
21 21
 if( !class_exists( 'GL_Plugin_Check_v3' )) {
22 22
 	require_once __DIR__.'/activate.php';
23 23
 }
24
-if( !(new GL_Plugin_Check_v3( __FILE__ ))->canProceed() )return;
24
+if( !(new GL_Plugin_Check_v3( __FILE__ ))->canProceed() ) {
25
+	return;
26
+}
25 27
 require_once __DIR__.'/autoload.php';
26 28
 require_once __DIR__.'/compatibility.php';
27 29
 require_once __DIR__.'/deprecated.php';
Please login to merge, or discard this patch.
plugin/Modules/Notification.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
 	 */
44 44
 	public function send( Review $review )
45 45
 	{
46
-		if( empty( $this->types ))return;
46
+		if( empty( $this->types )) {
47
+			return;
48
+		}
47 49
 		$this->review = $review;
48 50
 		$args = [
49 51
 			'link' => $this->getLink(),
@@ -146,7 +148,9 @@  discard block
 block discarded – undo
146 148
 	protected function sendToEmail( array $args )
147 149
 	{
148 150
 		$email = $this->buildEmail( $args );
149
-		if( !$this->email )return;
151
+		if( !$this->email ) {
152
+			return;
153
+		}
150 154
 		if( empty( $email->to )) {
151 155
 			glsr_log()->error( 'Email notification was not sent: missing email address' );
152 156
 			return;
@@ -161,7 +165,9 @@  discard block
 block discarded – undo
161 165
 	 */
162 166
 	protected function sendToSlack( array $args )
163 167
 	{
164
-		if( !$this->slack )return;
168
+		if( !$this->slack ) {
169
+			return;
170
+		}
165 171
 		$notification = $this->buildSlackNotification( $args );
166 172
 		$result = $notification->send();
167 173
 		if( is_wp_error( $result )) {
Please login to merge, or discard this patch.
plugin/Modules/Blacklist.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,9 @@
 block discarded – undo
37 37
 		$lines = explode( "\n", $blacklist );
38 38
 		foreach( (array)$lines as $line ) {
39 39
 			$line = trim( $line );
40
-			if( empty( $line ) || 256 < strlen( $line ))continue;
40
+			if( empty( $line ) || 256 < strlen( $line )) {
41
+				continue;
42
+			}
41 43
 			$pattern = sprintf( '#%s#i', preg_quote( $line, '#' ));
42 44
 			if( preg_match( $pattern, $target )) {
43 45
 				return true;
Please login to merge, or discard this patch.
plugin/Modules/Html/Partials/SiteReviews.php 1 patch
Braces   +39 added lines, -13 removed lines patch added patch discarded remove patch
@@ -82,7 +82,9 @@  discard block
 block discarded – undo
82 82
 		$reviewValues = [];
83 83
 		foreach( $review as $key => $value ) {
84 84
 			$method = glsr( Helper::class )->buildMethodName( $key, 'buildOption' );
85
-			if( !method_exists( $this, $method ))continue;
85
+			if( !method_exists( $this, $method )) {
86
+				continue;
87
+			}
86 88
 			$reviewValues[$key] = $this->$method( $key, $value );
87 89
 		}
88 90
 		$reviewValues = apply_filters( 'site-reviews/review/build/after', (array)$reviewValues );
@@ -96,9 +98,13 @@  discard block
 block discarded – undo
96 98
 	 */
97 99
 	protected function buildOptionAssignedTo( $key, $value )
98 100
 	{
99
-		if( $this->isHidden( $key, 'settings.reviews.assigned_links' ))return;
101
+		if( $this->isHidden( $key, 'settings.reviews.assigned_links' )) {
102
+			return;
103
+		}
100 104
 		$post = get_post( intval( $value ));
101
-		if( !( $post instanceof WP_Post ))return;
105
+		if( !( $post instanceof WP_Post )) {
106
+			return;
107
+		}
102 108
 		$permalink = glsr( Builder::class )->a( get_the_title( $post->ID ), [
103 109
 			'href' => get_the_permalink( $post->ID ),
104 110
 		]);
@@ -113,7 +119,9 @@  discard block
 block discarded – undo
113 119
 	 */
114 120
 	protected function buildOptionAuthor( $key, $value )
115 121
 	{
116
-		if( $this->isHidden( $key ))return;
122
+		if( $this->isHidden( $key )) {
123
+			return;
124
+		}
117 125
 		$prefix = !$this->isOptionEnabled( 'settings.reviews.avatars' )
118 126
 			? apply_filters( 'site-reviews/review/author/prefix', '&mdash;' )
119 127
 			: '';
@@ -127,7 +135,9 @@  discard block
 block discarded – undo
127 135
 	 */
128 136
 	protected function buildOptionAvatar( $key, $value )
129 137
 	{
130
-		if( $this->isHidden( $key, 'settings.reviews.avatars' ))return;
138
+		if( $this->isHidden( $key, 'settings.reviews.avatars' )) {
139
+			return;
140
+		}
131 141
 		$size = $this->getOption( 'settings.reviews.avatars_size', 40 );
132 142
 		return $this->wrap( $key, glsr( Builder::class )->img([
133 143
 			'src' => $this->generateAvatar( $value ),
@@ -144,7 +154,9 @@  discard block
 block discarded – undo
144 154
 	protected function buildOptionContent( $key, $value )
145 155
 	{
146 156
 		$text = $this->normalizeText( $value );
147
-		if( $this->isHiddenOrEmpty( $key, $text ))return;
157
+		if( $this->isHiddenOrEmpty( $key, $text )) {
158
+			return;
159
+		}
148 160
 		return $this->wrap( $key, '<p>'.$text.'</p>' );
149 161
 	}
150 162
 
@@ -155,7 +167,9 @@  discard block
 block discarded – undo
155 167
 	 */
156 168
 	protected function buildOptionDate( $key, $value )
157 169
 	{
158
-		if( $this->isHidden( $key ))return;
170
+		if( $this->isHidden( $key )) {
171
+			return;
172
+		}
159 173
 		$dateFormat = $this->getOption( 'settings.reviews.date.format', 'default' );
160 174
 		if( $dateFormat == 'relative' ) {
161 175
 			$date = glsr( Date::class )->relative( $value );
@@ -176,7 +190,9 @@  discard block
 block discarded – undo
176 190
 	 */
177 191
 	protected function buildOptionRating( $key, $value )
178 192
 	{
179
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
193
+		if( $this->isHiddenOrEmpty( $key, $value )) {
194
+			return;
195
+		}
180 196
 		$rating = glsr( Partial::class )->build( 'star-rating', [
181 197
 			'rating' => $value,
182 198
 		]);
@@ -190,7 +206,9 @@  discard block
 block discarded – undo
190 206
 	 */
191 207
 	protected function buildOptionResponse( $key, $value )
192 208
 	{
193
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
209
+		if( $this->isHiddenOrEmpty( $key, $value )) {
210
+			return;
211
+		}
194 212
 		$title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ));
195 213
 		$text = $this->normalizeText( $value );
196 214
 		$text = '<p><strong>'.$title.'</strong></p><p>'.$text.'</p>';
@@ -207,7 +225,9 @@  discard block
 block discarded – undo
207 225
 	 */
208 226
 	protected function buildOptionTitle( $key, $value )
209 227
 	{
210
-		if( $this->isHidden( $key ))return;
228
+		if( $this->isHidden( $key )) {
229
+			return;
230
+		}
211 231
 		if( empty( $value )) {
212 232
 			$value = __( 'No Title', 'site-reviews' );
213 233
 		}
@@ -239,7 +259,9 @@  discard block
 block discarded – undo
239 259
 	 */
240 260
 	protected function generateSchema()
241 261
 	{
242
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
262
+		if( !wp_validate_boolean( $this->args['schema'] )) {
263
+			return;
264
+		}
243 265
 		glsr( Schema::class )->store(
244 266
 			glsr( Schema::class )->build( $this->args )
245 267
 		);
@@ -289,9 +311,13 @@  discard block
 block discarded – undo
289 311
 		$words->setText( $text );
290 312
 		$count = 0;
291 313
 		foreach( $words as $offset ){
292
-			if( $words->getRuleStatus() === IntlRuleBasedBreakIterator::WORD_NONE )continue;
314
+			if( $words->getRuleStatus() === IntlRuleBasedBreakIterator::WORD_NONE ) {
315
+				continue;
316
+			}
293 317
 			$count++;
294
-			if( $count != $limit )continue;
318
+			if( $count != $limit ) {
319
+				continue;
320
+			}
295 321
 			return $offset;
296 322
 		}
297 323
 		return strlen( $text );
Please login to merge, or discard this patch.
plugin/Review.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,9 @@  discard block
 block discarded – undo
69 69
 		$properties = glsr( CreateReviewDefaults::class )->restrict( array_merge( $defaults, $meta ));
70 70
 		$this->modified = $this->isModified( $properties );
71 71
 		array_walk( $properties, function( $value, $key ) {
72
-			if( !property_exists( $this, $key ) || isset( $this->$key ))return;
72
+			if( !property_exists( $this, $key ) || isset( $this->$key )) {
73
+				return;
74
+			}
73 75
 			$this->$key = maybe_unserialize( $value );
74 76
 		});
75 77
 	}
@@ -80,7 +82,9 @@  discard block
 block discarded – undo
80 82
 	protected function setTermIds( WP_Post $post )
81 83
 	{
82 84
 		$this->term_ids = [];
83
-		if( !is_array( $terms = get_the_terms( $post, Application::TAXONOMY )))return;
85
+		if( !is_array( $terms = get_the_terms( $post, Application::TAXONOMY ))) {
86
+			return;
87
+		}
84 88
 		foreach( $terms as $term ) {
85 89
 			$this->term_ids[] = $term->term_id;
86 90
 		}
Please login to merge, or discard this patch.