+/scripts/public/recaptcha.js - Code Metrics - Inspection of "rewrite public scripts" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b15b71...ab24e8 )

by Paul

created 2018-06-10 19:55 UTC

+/scripts/public/recaptcha.js B

↳ Parent: Project

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	96
rs	8.3859

9 Functions

Rating	Name	Size	Complexity
B	Recaptcha.search_	14	5
A	Recaptcha.onKeyup_	5	2
A	Recaptcha.getOverlay_	12	1
A	recaptcha.js ➔ Recaptcha	6	1
A	Recaptcha.addListeners_	6	2
A	Recaptcha.getId_	8	1
A	Recaptcha.execute_	9	2
A	Recaptcha.removeListeners_	4	1
A	Recaptcha.reset_	6	2

How to fix Long Method

/** global: GLSR, grecaptcha */
;(function() {

	'use strict';

	var Recaptcha = function( form ) { // Form object
		this.Form = form;
		this.addListeners = this.addListeners_;
		this.execute = this.execute_;
		this.reset = this.reset_;
	};

	Recaptcha.prototype = {

		/** @return void */
		addListeners_: function() {
			var overlayEl = this.getOverlay_();
			if( overlayEl === -1 )return;
			overlayEl.addEventListener( 'click', this.Form.enableButton );
			window.addEventListener( 'keyup', this.onKeyup_.bind( this, overlayEl ));
		},

		/** @return void */
		execute_: function() {
			var recaptchaId = this.getId_();
			if( recaptchaId !== -1 ) {
				grecaptcha.execute( recaptchaId );
				return;
			}
			// recaptcha ID not found so pass through an error
			this.Form.submitForm_( false );
		},

		/** @return string|int (-1) */
		getId_: function() {
			return this.search_( function( value, id ) {
				if( Object.prototype.toString.call( value ) !== '[object HTMLDivElement]' )return;
				if( value.closest( 'form' ) === this.Form.form ) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
					return id;
				}
			});
		},

		/** @return HTMLDivElement|int (-1) */
		getOverlay_: function() {
			return this.search_( function( value ) {
				if( Object.prototype.toString.call( value ) !== '[object Object]' )return;
				for( var obj in value) {
					if( !value.hasOwnProperty( obj ) || Object.prototype.toString.call( value[obj] ) !== '[object HTMLDivElement]' )continue;
					if( value[obj].className === '' ) {
						return value[obj].firstChild;
					}
				}
				return false;
			});
		},

		/** @return void */
		onKeyup_: function( ev ) { // KeyboardEvent
			if( ev.keyCode !== 27 )return;
			this.Form.enableButton();
			this.removeListeners_( ev.target );
		},

		/** @return void */
		removeListeners_: function( overlayEl ) { // HTMLDivElement
			overlayEl.removeEventListener( 'click', this.Form.enableButton );
			window.removeEventListener( 'keyup', this.onKeyup_ );
		},

		/** @return void */
		reset_: function() {
			var recaptchaId = this.getId_();
			if( recaptchaId !== -1 ) {
				grecaptcha.reset( recaptchaId );
			}
		},

		/** @return mixed|int (-1) */
		search_: function( callback ) { // function
			var result = -1;
			if( window.hasOwnProperty( '___grecaptcha_cfg' )) {
				var clients = window.___grecaptcha_cfg.clients;
				var i, key;
				for( i in clients ) {
					for( key in clients[i] ) {
						if( !( result = callback( clients[i][key], i ).bind( this )))continue;
						return result;
					}
				}
			}
			return result;
		},
	};

	GLSR.Recaptcha = Recaptcha;
})();


1			/** global: GLSR, grecaptcha */
2			;(function() {
3
4			'use strict';
5
6			var Recaptcha = function( form ) { // Form object
7			this.Form = form;
8			this.addListeners = this.addListeners_;
9			this.execute = this.execute_;
10			this.reset = this.reset_;
11			};
12
13			Recaptcha.prototype = {
14
15			/** @return void */
16			addListeners_: function() {
17			var overlayEl = this.getOverlay_();
18			if( overlayEl === -1 )return;
19			overlayEl.addEventListener( 'click', this.Form.enableButton );
20			window.addEventListener( 'keyup', this.onKeyup_.bind( this, overlayEl ));
21			},
22
23			/** @return void */
24			execute_: function() {
25			var recaptchaId = this.getId_();
26			if( recaptchaId !== -1 ) {
27			grecaptcha.execute( recaptchaId );
28			return;
29			}
30			// recaptcha ID not found so pass through an error
31			this.Form.submitForm_( false );
32			},
33
34			/** @return string\|int (-1) */
35			getId_: function() {
36			return this.search_( function( value, id ) {
37			if( Object.prototype.toString.call( value ) !== '[object HTMLDivElement]' )return;
38			if( value.closest( 'form' ) === this.Form.form ) {
			1 ignored issue – show Complexity Best Practice introduced 2018-06-10 20:00 UTC by Report Bug Copy Issue Report There is no return statement if `value.closest("form") === this.Form.form` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
39			return id;
40			}
41			});
42			},
43
44			/** @return HTMLDivElement\|int (-1) */
45			getOverlay_: function() {
46			return this.search_( function( value ) {
47			if( Object.prototype.toString.call( value ) !== '[object Object]' )return;
48			for( var obj in value) {
49			if( !value.hasOwnProperty( obj ) \|\| Object.prototype.toString.call( value[obj] ) !== '[object HTMLDivElement]' )continue;
50			if( value[obj].className === '' ) {
51			return value[obj].firstChild;
52			}
53			}
54			return false;
55			});
56			},
57
58			/** @return void */
59			onKeyup_: function( ev ) { // KeyboardEvent
60			if( ev.keyCode !== 27 )return;
61			this.Form.enableButton();
62			this.removeListeners_( ev.target );
63			},
64
65			/** @return void */
66			removeListeners_: function( overlayEl ) { // HTMLDivElement
67			overlayEl.removeEventListener( 'click', this.Form.enableButton );
68			window.removeEventListener( 'keyup', this.onKeyup_ );
69			},
70
71			/** @return void */
72			reset_: function() {
73			var recaptchaId = this.getId_();
74			if( recaptchaId !== -1 ) {
75			grecaptcha.reset( recaptchaId );
76			}
77			},
78
79			/** @return mixed\|int (-1) */
80			search_: function( callback ) { // function
81			var result = -1;
82			if( window.hasOwnProperty( '___grecaptcha_cfg' )) {
83			var clients = window.___grecaptcha_cfg.clients;
84			var i, key;
85			for( i in clients ) {
86			for( key in clients[i] ) {
87			if( !( result = callback( clients[i][key], i ).bind( this )))continue;
88			return result;
89			}
90			}
91			}
92			return result;
93			},
94			};
95
96			GLSR.Recaptcha = Recaptcha;
97			})();
98

pryley / site-reviews

Push — master ( b15b71...ab24e8 )

+/scripts/public/recaptcha.js B

Complexity

Size

Duplication

Importance

9 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like