Passed
Push — hotfix/fix-counts ( 87b43a...93ec32 )
by Paul
06:17
created
plugin/Controllers/ReviewController.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,7 +26,9 @@  discard block
 block discarded – undo
26 26
 	{
27 27
 		sort( $termTaxonomyIds );
28 28
 		sort( $oldTermTaxonomyIds );
29
-		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId ))return;
29
+		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId )) {
30
+			return;
31
+		}
30 32
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
31 33
 		$ignoredIds = array_intersect( $oldTermTaxonomyIds, $termTaxonomyIds );
32 34
 		$decreasedIds = array_diff( $oldTermTaxonomyIds, $ignoredIds );
@@ -48,7 +50,9 @@  discard block
 block discarded – undo
48 50
 	 */
49 51
 	public function onAfterChangeStatus( $newStatus, $oldStatus, $post )
50 52
 	{
51
-		if( glsr_get( $post, 'post_type') != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
53
+		if( glsr_get( $post, 'post_type') != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] )) {
54
+			return;
55
+		}
52 56
 		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ));
53 57
 		if( $post->post_status == 'publish' ) {
54 58
 			glsr( CountsManager::class )->increase( $review );
@@ -64,7 +68,9 @@  discard block
 block discarded – undo
64 68
 	 */
65 69
 	public function onAfterCreate( Review $review )
66 70
 	{
67
-		if( $review->status !== 'publish' )return;
71
+		if( $review->status !== 'publish' ) {
72
+			return;
73
+		}
68 74
 		glsr( CountsManager::class )->increase( $review );
69 75
 	}
70 76
 
@@ -75,7 +81,9 @@  discard block
 block discarded – undo
75 81
 	 */
76 82
 	public function onBeforeDelete( $postId )
77 83
 	{
78
-		if( !$this->isReviewPostId( $postId ))return;
84
+		if( !$this->isReviewPostId( $postId )) {
85
+			return;
86
+		}
79 87
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
80 88
 		glsr( CountsManager::class )->decrease( $review );
81 89
 	}
@@ -92,9 +100,13 @@  discard block
 block discarded – undo
92 100
 	{
93 101
 		if( !$this->isReviewPostId( $postId )
94 102
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
95
-		)return;
103
+		) {
104
+			return;
105
+		}
96 106
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
97
-		if( $review->$metaKey == $metaValue )return;
107
+		if( $review->$metaKey == $metaValue ) {
108
+			return;
109
+		}
98 110
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
99 111
 		call_user_func( [$this, $method], $review, $metaValue );
100 112
 	}
Please login to merge, or discard this patch.
plugin/Controllers/ListTableController.php 1 patch
Braces   +26 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,7 +21,9 @@  discard block
 block discarded – undo
21 21
 	 */
22 22
 	public function approve()
23 23
 	{
24
-		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID )return;
24
+		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID ) {
25
+			return;
26
+		}
25 27
 		check_admin_referer( 'approve-review_'.( $postId = $this->getPostId() ));
26 28
 		wp_update_post([
27 29
 			'ID' => $postId,
@@ -59,7 +61,9 @@  discard block
 block discarded – undo
59 61
 		$columns = glsr( Helper::class )->consolidateArray( $columns );
60 62
 		$postTypeColumns = glsr()->postTypeColumns[Application::POST_TYPE];
61 63
 		foreach( $postTypeColumns as $key => &$value ) {
62
-			if( !array_key_exists( $key, $columns ) || !empty( $value ))continue;
64
+			if( !array_key_exists( $key, $columns ) || !empty( $value )) {
65
+				continue;
66
+			}
63 67
 			$value = $columns[$key];
64 68
 		}
65 69
 		if( count( glsr( Database::class )->getReviewsMeta( 'review_type' )) < 2 ) {
@@ -103,7 +107,8 @@  discard block
 block discarded – undo
103 107
 	 * @return array
104 108
 	 * @filter display_post_states
105 109
 	 */
106
-	public function filterPostStates( $postStates, $post ) {
110
+	public function filterPostStates( $postStates, $post )
111
+	{
107 112
 		$postStates = glsr( Helper::class )->consolidateArray( $postStates );
108 113
 		if( glsr_get( $post, 'post_type' ) == Application::POST_TYPE && array_key_exists( 'pending', $postStates )) {
109 114
 			$postStates['pending'] = __( 'Unapproved', 'site-reviews' );
@@ -152,7 +157,9 @@  discard block
 block discarded – undo
152 157
 		$postTypeColumns = glsr()->postTypeColumns[Application::POST_TYPE];
153 158
 		unset( $postTypeColumns['cb'] );
154 159
 		foreach( $postTypeColumns as $key => $value ) {
155
-			if( glsr( Helper::class )->startsWith( 'taxonomy', $key ))continue;
160
+			if( glsr( Helper::class )->startsWith( 'taxonomy', $key )) {
161
+				continue;
162
+			}
156 163
 			$columns[$key] = $key;
157 164
 		}
158 165
 		return $columns;
@@ -176,7 +183,9 @@  discard block
 block discarded – undo
176 183
 				'Pending' => __( 'Unapproved', 'site-reviews' ),
177 184
 			];
178 185
 			foreach( $strings as $search => $replace ) {
179
-				if( strpos( $single, $search ) === false )continue;
186
+				if( strpos( $single, $search ) === false ) {
187
+					continue;
188
+				}
180 189
 				$translation = $this->getTranslation([
181 190
 					'number' => $number,
182 191
 					'plural' => str_replace( $search, $replace, $plural ),
@@ -228,7 +237,9 @@  discard block
 block discarded – undo
228 237
 	 */
229 238
 	public function saveBulkEditFields( $postId )
230 239
 	{
231
-		if( !current_user_can( 'edit_posts' ))return;
240
+		if( !current_user_can( 'edit_posts' )) {
241
+			return;
242
+		}
232 243
 		$assignedTo = filter_input( INPUT_GET, 'assigned_to' );
233 244
 		if( $assignedTo && get_post( $assignedTo )) {
234 245
 			update_post_meta( $postId, 'assigned_to', $assignedTo );
@@ -241,7 +252,9 @@  discard block
 block discarded – undo
241 252
 	 */
242 253
 	public function setQueryForColumn( WP_Query $query )
243 254
 	{
244
-		if( !$this->hasPermission( $query ))return;
255
+		if( !$this->hasPermission( $query )) {
256
+			return;
257
+		}
245 258
 		$this->setMetaQuery( $query, [
246 259
 			'rating', 'review_type',
247 260
 		]);
@@ -254,7 +267,9 @@  discard block
 block discarded – undo
254 267
 	 */
255 268
 	public function unapprove()
256 269
 	{
257
-		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID )return;
270
+		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID ) {
271
+			return;
272
+		}
258 273
 		check_admin_referer( 'unapprove-review_'.( $postId = $this->getPostId() ));
259 274
 		wp_update_post([
260 275
 			'ID' => $postId,
@@ -314,7 +329,9 @@  discard block
 block discarded – undo
314 329
 	protected function setMetaQuery( WP_Query $query, array $metaKeys )
315 330
 	{
316 331
 		foreach( $metaKeys as $key ) {
317
-			if( !( $value = filter_input( INPUT_GET, $key )))continue;
332
+			if( !( $value = filter_input( INPUT_GET, $key ))) {
333
+				continue;
334
+			}
318 335
 			$metaQuery = (array)$query->get( 'meta_query' );
319 336
 			$metaQuery[] = [
320 337
 				'key' => $key,
Please login to merge, or discard this patch.
plugin/Controllers/EditorController.php 1 patch
Braces   +36 added lines, -12 removed lines patch added patch discarded remove patch
@@ -96,7 +96,9 @@  discard block
 block discarded – undo
96 96
 	{
97 97
 		add_meta_box( Application::ID.'_assigned_to', __( 'Assigned To', 'site-reviews' ), [$this, 'renderAssignedToMetabox'], null, 'side' );
98 98
 		add_meta_box( Application::ID.'_review', __( 'Details', 'site-reviews' ), [$this, 'renderDetailsMetaBox'], null, 'side' );
99
-		if( get_post_meta( $post->ID, 'review_type', true ) != 'local' )return;
99
+		if( get_post_meta( $post->ID, 'review_type', true ) != 'local' ) {
100
+			return;
101
+		}
100 102
 		add_meta_box( Application::ID.'_response', __( 'Respond Publicly', 'site-reviews' ), [$this, 'renderResponseMetaBox'], null, 'normal' );
101 103
 	}
102 104
 
@@ -133,7 +135,9 @@  discard block
 block discarded – undo
133 135
 	 */
134 136
 	public function renderAssignedToMetabox( $post )
135 137
 	{
136
-		if( !$this->isReviewPostType( $post ))return;
138
+		if( !$this->isReviewPostType( $post )) {
139
+			return;
140
+		}
137 141
 		$assignedTo = (string)get_post_meta( $post->ID, 'assigned_to', true );
138 142
 		wp_nonce_field( 'assigned_to', '_nonce-assigned-to', false );
139 143
 		glsr()->render( 'partials/editor/metabox-assigned-to', [
@@ -149,7 +153,9 @@  discard block
 block discarded – undo
149 153
 	 */
150 154
 	public function renderDetailsMetaBox( $post )
151 155
 	{
152
-		if( !$this->isReviewPostType( $post ))return;
156
+		if( !$this->isReviewPostType( $post )) {
157
+			return;
158
+		}
153 159
 		$review = glsr( ReviewManager::class )->single( $post );
154 160
 		glsr()->render( 'partials/editor/metabox-details', [
155 161
 			'button' => $this->buildDetailsMetaBoxRevertButton( $review, $post ),
@@ -163,7 +169,9 @@  discard block
 block discarded – undo
163 169
 	 */
164 170
 	public function renderPinnedInPublishMetaBox()
165 171
 	{
166
-		if( !$this->isReviewPostType( get_post() ))return;
172
+		if( !$this->isReviewPostType( get_post() )) {
173
+			return;
174
+		}
167 175
 		glsr( Template::class )->render( 'partials/editor/pinned', [
168 176
 			'context' => [
169 177
 				'no' => __( 'No', 'site-reviews' ),
@@ -180,7 +188,9 @@  discard block
 block discarded – undo
180 188
 	 */
181 189
 	public function renderResponseMetaBox( $post )
182 190
 	{
183
-		if( !$this->isReviewPostType( $post ))return;
191
+		if( !$this->isReviewPostType( $post )) {
192
+			return;
193
+		}
184 194
 		wp_nonce_field( 'response', '_nonce-response', false );
185 195
 		glsr()->render( 'partials/editor/metabox-response', [
186 196
 			'response' => get_post_meta( $post->ID, 'response', true ),
@@ -194,7 +204,9 @@  discard block
 block discarded – undo
194 204
 	 */
195 205
 	public function renderReviewEditor( $post )
196 206
 	{
197
-		if( !$this->isReviewPostType( $post ) || $this->isReviewEditable( $post ))return;
207
+		if( !$this->isReviewPostType( $post ) || $this->isReviewEditable( $post )) {
208
+			return;
209
+		}
198 210
 		glsr()->render( 'partials/editor/review', [
199 211
 			'post' => $post,
200 212
 			'response' => get_post_meta( $post->ID, 'response', true ),
@@ -208,7 +220,9 @@  discard block
 block discarded – undo
208 220
 	public function renderReviewFields()
209 221
 	{
210 222
 		$screen = glsr_current_screen();
211
-		if( $screen->base != 'post' || $screen->post_type != Application::POST_TYPE )return;
223
+		if( $screen->base != 'post' || $screen->post_type != Application::POST_TYPE ) {
224
+			return;
225
+		}
212 226
 		add_action( 'edit_form_after_title', [$this, 'renderReviewEditor'] );
213 227
 		add_action( 'edit_form_top',         [$this, 'renderReviewNotice'] );
214 228
 	}
@@ -220,7 +234,9 @@  discard block
 block discarded – undo
220 234
 	 */
221 235
 	public function renderReviewNotice( $post )
222 236
 	{
223
-		if( !$this->isReviewPostType( $post ) || $this->isReviewEditable( $post ))return;
237
+		if( !$this->isReviewPostType( $post ) || $this->isReviewEditable( $post )) {
238
+			return;
239
+		}
224 240
 		glsr( Notice::class )->addWarning( sprintf(
225 241
 			__( '%s reviews are read-only.', 'site-reviews' ),
226 242
 			glsr( Columns::class )->buildColumnReviewType( $post->ID )
@@ -240,7 +256,9 @@  discard block
 block discarded – undo
240 256
 	 */
241 257
 	public function renderTaxonomyMetabox( $post )
242 258
 	{
243
-		if( !$this->isReviewPostType( $post ))return;
259
+		if( !$this->isReviewPostType( $post )) {
260
+			return;
261
+		}
244 262
 		glsr()->render( 'partials/editor/metabox-categories', [
245 263
 			'post' => $post,
246 264
 			'tax_name' => Application::TAXONOMY,
@@ -255,7 +273,9 @@  discard block
 block discarded – undo
255 273
 	 */
256 274
 	public function revertReview()
257 275
 	{
258
-		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID )return;
276
+		if( filter_input( INPUT_GET, 'plugin' ) != Application::ID ) {
277
+			return;
278
+		}
259 279
 		check_admin_referer( 'revert-review_'.( $postId = $this->getPostId() ));
260 280
 		glsr( ReviewManager::class )->revert( $postId );
261 281
 		$this->redirect( $postId, 52 );
@@ -279,7 +299,9 @@  discard block
 block discarded – undo
279 299
 	protected function buildAssignedToTemplate( $assignedTo, WP_Post $post )
280 300
 	{
281 301
 		$assignedPost = glsr( Database::class )->getAssignedToPost( $post->ID, $assignedTo );
282
-		if( !( $assignedPost instanceof WP_Post ))return;
302
+		if( !( $assignedPost instanceof WP_Post )) {
303
+			return;
304
+		}
283 305
 		return glsr( Template::class )->build( 'partials/editor/assigned-post', [
284 306
 			'context' => [
285 307
 				'data.url' => (string)get_permalink( $assignedPost ),
@@ -325,7 +347,9 @@  discard block
 block discarded – undo
325 347
 	 */
326 348
 	protected function getReviewType( $review )
327 349
 	{
328
-		if( count( glsr()->reviewTypes ) < 2 )return;
350
+		if( count( glsr()->reviewTypes ) < 2 ) {
351
+			return;
352
+		}
329 353
 		$reviewType = array_key_exists( $review->review_type, glsr()->reviewTypes )
330 354
 			? glsr()->reviewTypes[$review->review_type]
331 355
 			: __( 'Unknown', 'site-reviews' );
Please login to merge, or discard this patch.