Passed
Push — hotfix/fix-counts ( 0ee906...e9420b )
by Paul
03:57
created
plugin/Controllers/RestReviewController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 		register_rest_route( $this->namespace, '/types', [
29 29
 			'callback' => [$this, 'get_types'],
30 30
 			'methods' => Server::READABLE,
31
-		]);
31
+		] );
32 32
 	}
33 33
 
34 34
 	/**
Please login to merge, or discard this patch.
plugin/Controllers/RestCategoryController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,6 +33,6 @@
 block discarded – undo
33 33
 				'permission_callback' => [$this, 'get_items_permissions_check'],
34 34
 			],
35 35
 			'schema' => [$this, 'get_public_item_schema'],
36
-		]);
36
+		] );
37 37
 	}
38 38
 }
Please login to merge, or discard this patch.
views/pages/addons/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 				'title' => 'Images',
18 18
 			],
19 19
 			'plugin' => 'site-reviews-images/site-reviews-images.php',
20
-		]);
20
+		] );
21 21
 		$template->render( 'partials/addons/addon', [
22 22
 			'context' => [
23 23
 				'description' => __( 'Sync your Tripadvisor reviews to your website and manage them with Site Reviews.', 'site-reviews' ),
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 				'title' => 'Tripadvisor Reviews',
27 27
 			],
28 28
 			'plugin' => 'site-reviews-tripadvisor/site-reviews-tripadvisor.php',
29
-		]);
29
+		] );
30 30
 	?>
31 31
 	</div>
32 32
 </div>
Please login to merge, or discard this patch.
plugin/Controllers/TaxonomyController.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,9 @@
 block discarded – undo
35 35
 	 */
36 36
 	public function renderTaxonomyFilter()
37 37
 	{
38
-		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY ))return;
38
+		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY )) {
39
+			return;
40
+		}
39 41
 		echo glsr( Builder::class )->label( __( 'Filter by category', 'site-reviews' ), [
40 42
 			'class' => 'screen-reader-text',
41 43
 			'for' => Application::TAXONOMY,
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	public function renderTaxonomyFilter()
37 37
 	{
38
-		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY ))return;
38
+		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY ) )return;
39 39
 		echo glsr( Builder::class )->label( __( 'Filter by category', 'site-reviews' ), [
40 40
 			'class' => 'screen-reader-text',
41 41
 			'for' => Application::TAXONOMY,
42
-		]);
43
-		wp_dropdown_categories([
42
+		] );
43
+		wp_dropdown_categories( [
44 44
 			'depth' => 3,
45 45
 			'hide_empty' => true,
46 46
 			'hide_if_empty' => true,
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 			'show_option_all' => $this->getShowOptionAll(),
53 53
 			'taxonomy' => Application::TAXONOMY,
54 54
 			'value_field' => 'slug',
55
-		]);
55
+		] );
56 56
 	}
57 57
 
58 58
 	/**
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	{
72 72
 		$taxonomy = get_taxonomy( Application::TAXONOMY );
73 73
 		return $taxonomy
74
-			? ucfirst( strtolower( $taxonomy->labels->all_items ))
74
+			? ucfirst( strtolower( $taxonomy->labels->all_items ) )
75 75
 			: '';
76 76
 	}
77 77
 }
Please login to merge, or discard this patch.
plugin/Controllers/AdminController.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,12 +108,16 @@
 block discarded – undo
108 108
 	public function renderTinymceButton( $editorId )
109 109
 	{
110 110
 		$allowedEditors = apply_filters( 'site-reviews/tinymce/editor-ids', ['content'], $editorId );
111
-		if( glsr_current_screen()->base != 'post' || !in_array( $editorId, $allowedEditors ))return;
111
+		if( glsr_current_screen()->base != 'post' || !in_array( $editorId, $allowedEditors )) {
112
+			return;
113
+		}
112 114
 		$shortcodes = [];
113 115
 		foreach( glsr()->mceShortcodes as $shortcode => $values ) {
114 116
 			$shortcodes[$shortcode] = $values;
115 117
 		}
116
-		if( empty( $shortcodes ))return;
118
+		if( empty( $shortcodes )) {
119
+			return;
120
+		}
117 121
 		glsr()->render( 'partials/editor/tinymce', [
118 122
 			'shortcodes' => $shortcodes,
119 123
 		]);
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 	 */
25 25
 	public function enqueueAssets()
26 26
 	{
27
-		$command = new EnqueueAdminAssets([
27
+		$command = new EnqueueAdminAssets( [
28 28
 			'pointers' => [[
29 29
 				'content' => __( 'You can pin exceptional reviews so that they are always shown first.', 'site-reviews' ),
30 30
 				'id' => 'glsr-pointer-pinned',
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 				'target' => '#misc-pub-pinned',
37 37
 				'title' => __( 'Pin Your Reviews', 'site-reviews' ),
38 38
 			]],
39
-		]);
39
+		] );
40 40
 		$this->execute( $command );
41 41
 	}
42 42
 
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	{
49 49
 		$links['settings'] = glsr( Builder::class )->a( __( 'Settings', 'site-reviews' ), [
50 50
 			'href' => admin_url( 'edit.php?post_type='.Application::POST_TYPE.'&page=settings' ),
51
-		]);
51
+		] );
52 52
 		return $links;
53 53
 	}
54 54
 
@@ -60,20 +60,20 @@  discard block
 block discarded – undo
60 60
 	public function filterDashboardGlanceItems( $items )
61 61
 	{
62 62
 		$postCount = wp_count_posts( Application::POST_TYPE );
63
-		if( empty( $postCount->publish )) {
63
+		if( empty($postCount->publish) ) {
64 64
 			return $items;
65 65
 		}
66 66
 		$text = _n( '%s Review', '%s Reviews', $postCount->publish, 'site-reviews' );
67
-		$text = sprintf( $text, number_format_i18n( $postCount->publish ));
67
+		$text = sprintf( $text, number_format_i18n( $postCount->publish ) );
68 68
 		$items = glsr( Helper::class )->consolidateArray( $items );
69 69
 		$items[] = current_user_can( get_post_type_object( Application::POST_TYPE )->cap->edit_posts )
70 70
 			? glsr( Builder::class )->a( $text, [
71 71
 				'class' => 'glsr-review-count',
72 72
 				'href' => 'edit.php?post_type='.Application::POST_TYPE,
73
-			])
73
+			] )
74 74
 			: glsr( Builder::class )->span( $text, [
75 75
 				'class' => 'glsr-review-count',
76
-			]);
76
+			] );
77 77
 		return $items;
78 78
 	}
79 79
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	 */
85 85
 	public function filterTinymcePlugins( $plugins )
86 86
 	{
87
-		if( current_user_can( 'edit_posts' ) || current_user_can( 'edit_pages' )) {
87
+		if( current_user_can( 'edit_posts' ) || current_user_can( 'edit_pages' ) ) {
88 88
 			$plugins = glsr( Helper::class )->consolidateArray( $plugins );
89 89
 			$plugins['glsr_shortcode'] = glsr()->url( 'assets/scripts/mce-plugin.js' );
90 90
 		}
@@ -97,11 +97,11 @@  discard block
 block discarded – undo
97 97
 	 */
98 98
 	public function registerTinymcePopups()
99 99
 	{
100
-		$command = new RegisterTinymcePopups([
100
+		$command = new RegisterTinymcePopups( [
101 101
 			'site_reviews' => esc_html__( 'Recent Reviews', 'site-reviews' ),
102 102
 			'site_reviews_form' => esc_html__( 'Submit a Review', 'site-reviews' ),
103 103
 			'site_reviews_summary' => esc_html__( 'Summary of Reviews', 'site-reviews' ),
104
-		]);
104
+		] );
105 105
 		$this->execute( $command );
106 106
 	}
107 107
 
@@ -113,15 +113,15 @@  discard block
 block discarded – undo
113 113
 	public function renderTinymceButton( $editorId )
114 114
 	{
115 115
 		$allowedEditors = apply_filters( 'site-reviews/tinymce/editor-ids', ['content'], $editorId );
116
-		if( glsr_current_screen()->base != 'post' || !in_array( $editorId, $allowedEditors ))return;
116
+		if( glsr_current_screen()->base != 'post' || !in_array( $editorId, $allowedEditors ) )return;
117 117
 		$shortcodes = [];
118 118
 		foreach( glsr()->mceShortcodes as $shortcode => $values ) {
119 119
 			$shortcodes[$shortcode] = $values;
120 120
 		}
121
-		if( empty( $shortcodes ))return;
121
+		if( empty($shortcodes) )return;
122 122
 		glsr()->render( 'partials/editor/tinymce', [
123 123
 			'shortcodes' => $shortcodes,
124
-		]);
124
+		] );
125 125
 	}
126 126
 
127 127
 	/**
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
 	public function routerClearConsole()
131 131
 	{
132 132
 		glsr( Console::class )->clear();
133
-		glsr( Notice::class )->addSuccess( __( 'Console cleared.', 'site-reviews' ));
133
+		glsr( Notice::class )->addSuccess( __( 'Console cleared.', 'site-reviews' ) );
134 134
 	}
135 135
 
136 136
 	/**
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	 */
139 139
 	public function routerFetchConsole()
140 140
 	{
141
-		glsr( Notice::class )->addSuccess( __( 'Console reloaded.', 'site-reviews' ));
141
+		glsr( Notice::class )->addSuccess( __( 'Console reloaded.', 'site-reviews' ) );
142 142
 	}
143 143
 
144 144
 	/**
@@ -157,13 +157,13 @@  discard block
 block discarded – undo
157 157
 		}
158 158
 		$postIds = glsr( SqlQueries::class )->getReviewsMeta( 'assigned_to' );
159 159
 		foreach( $postIds as $postId ) {
160
-			$countManager->setPostCounts( $postId, $countManager->buildPostCounts( $postId ));
160
+			$countManager->setPostCounts( $postId, $countManager->buildPostCounts( $postId ) );
161 161
 		}
162 162
 		$countManager->setCounts( $countManager->buildCounts() );
163 163
 		if( $showNotice ) {
164
-			glsr( Notice::class )->clear()->addSuccess( __( 'Recalculated rating counts.', 'site-reviews' ));
164
+			glsr( Notice::class )->clear()->addSuccess( __( 'Recalculated rating counts.', 'site-reviews' ) );
165 165
 		}
166
-		glsr( OptionManager::class )->set( 'last_review_count', current_time( 'timestamp' ));
166
+		glsr( OptionManager::class )->set( 'last_review_count', current_time( 'timestamp' ) );
167 167
 	}
168 168
 
169 169
 	/**
@@ -197,17 +197,17 @@  discard block
 block discarded – undo
197 197
 	{
198 198
 		$file = $_FILES['import-file'];
199 199
 		if( $file['error'] !== UPLOAD_ERR_OK ) {
200
-			return glsr( Notice::class )->addError( $this->getUploadError( $file['error'] ));
200
+			return glsr( Notice::class )->addError( $this->getUploadError( $file['error'] ) );
201 201
 		}
202
-		if( $file['type'] !== 'application/json' || !glsr( Helper::class )->endsWith( '.json', $file['name'] )) {
203
-			return glsr( Notice::class )->addError( __( 'Please use a valid Site Reviews settings file.', 'site-reviews' ));
202
+		if( $file['type'] !== 'application/json' || !glsr( Helper::class )->endsWith( '.json', $file['name'] ) ) {
203
+			return glsr( Notice::class )->addError( __( 'Please use a valid Site Reviews settings file.', 'site-reviews' ) );
204 204
 		}
205 205
 		$settings = json_decode( file_get_contents( $file['tmp_name'] ), true );
206
-		if( empty( $settings )) {
207
-			return glsr( Notice::class )->addWarning( __( 'There were no settings found to import.', 'site-reviews' ));
206
+		if( empty($settings) ) {
207
+			return glsr( Notice::class )->addWarning( __( 'There were no settings found to import.', 'site-reviews' ) );
208 208
 		}
209
-		glsr( OptionManager::class )->set( glsr( OptionManager::class )->normalize( $settings ));
210
-		glsr( Notice::class )->addSuccess( __( 'Settings imported.', 'site-reviews' ));
209
+		glsr( OptionManager::class )->set( glsr( OptionManager::class )->normalize( $settings ) );
210
+		glsr( Notice::class )->addSuccess( __( 'Settings imported.', 'site-reviews' ) );
211 211
 	}
212 212
 
213 213
 	/**
@@ -225,6 +225,6 @@  discard block
 block discarded – undo
225 225
 			UPLOAD_ERR_CANT_WRITE => __( 'Failed to write file to disk.', 'site-reviews' ),
226 226
 			UPLOAD_ERR_EXTENSION => __( 'A PHP extension stopped the file upload.', 'site-reviews' ),
227 227
 		];
228
-		return glsr_get( $errors, $errorCode, __( 'Unknown upload error.', 'site-reviews' ));
228
+		return glsr_get( $errors, $errorCode, __( 'Unknown upload error.', 'site-reviews' ) );
229 229
 	}
230 230
 }
Please login to merge, or discard this patch.
plugin/Handlers/ChangeStatus.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -13,11 +13,11 @@  discard block
 block discarded – undo
13 13
 	 */
14 14
 	public function handle( Command $command )
15 15
 	{
16
-		$postId = wp_update_post([
16
+		$postId = wp_update_post( [
17 17
 			'ID' => $command->id,
18 18
 			'post_status' => $command->status,
19
-		]);
20
-		if( is_wp_error( $postId )) {
19
+		] );
20
+		if( is_wp_error( $postId ) ) {
21 21
 			glsr_log()->error( $postId->get_error_message() );
22 22
 			return [];
23 23
 		}
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 			'aria-label' => '&#8220;'.esc_attr( $title ).'&#8221; ('.__( 'Edit', 'site-reviews' ).')',
40 40
 			'class' => 'row-title',
41 41
 			'href' => get_edit_post_link( $postId ),
42
-		]);
42
+		] );
43 43
 	}
44 44
 
45 45
 	/**
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 	protected function getPostState( $postId )
50 50
 	{
51 51
 		ob_start();
52
-		_post_states( get_post( $postId ));
52
+		_post_states( get_post( $postId ) );
53 53
 		return ob_get_clean();
54 54
 	}
55 55
 
@@ -59,13 +59,13 @@  discard block
 block discarded – undo
59 59
 	protected function getStatusLinks()
60 60
 	{
61 61
 		global $avail_post_stati;
62
-		require_once( ABSPATH.'wp-admin/includes/class-wp-posts-list-table.php' );
62
+		require_once(ABSPATH.'wp-admin/includes/class-wp-posts-list-table.php');
63 63
 		$hookName = 'edit-'.Application::POST_TYPE;
64 64
 		set_current_screen( $hookName );
65 65
 		$avail_post_stati = get_available_post_statuses( Application::POST_TYPE );
66 66
 		$table = new \WP_Posts_List_Table( ['screen' => $hookName] );
67 67
 		$views = apply_filters( 'views_'.$hookName, $table->get_views() ); // uses compat get_views()
68
-		if( empty( $views ))return;
68
+		if( empty($views) )return;
69 69
 		foreach( $views as $class => $view ) {
70 70
 			$views[$class] = "\t<li class='$class'>$view";
71 71
 		}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,9 @@
 block discarded – undo
65 65
 		$avail_post_stati = get_available_post_statuses( Application::POST_TYPE );
66 66
 		$table = new \WP_Posts_List_Table( ['screen' => $hookName] );
67 67
 		$views = apply_filters( 'views_'.$hookName, $table->get_views() ); // uses compat get_views()
68
-		if( empty( $views ))return;
68
+		if( empty( $views )) {
69
+			return;
70
+		}
69 71
 		foreach( $views as $class => $view ) {
70 72
 			$views[$class] = "\t<li class='$class'>$view";
71 73
 		}
Please login to merge, or discard this patch.
compatibility.php 2 patches
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,7 +8,9 @@  discard block
 block discarded – undo
8 8
  * @see https://www.elegantthemes.com/gallery/divi/
9 9
  */
10 10
 add_action( 'site-reviews/customize/divi', function( $instance ) {
11
-	if( $instance->tag != 'label' || $instance->args['type'] != 'checkbox' )return;
11
+	if( $instance->tag != 'label' || $instance->args['type'] != 'checkbox' ) {
12
+		return;
13
+	}
12 14
 	$instance->args['text'] = '<i></i>'.$instance->args['text'];
13 15
 });
14 16
 
@@ -20,9 +22,13 @@  discard block
 block discarded – undo
20 22
  * @see https://wordpress.org/plugins/wp-super-cache/
21 23
  */
22 24
 add_action( 'site-reviews/review/created', function( $review, $request ) {
23
-	if( !function_exists( 'wp_cache_post_change' ))return;
25
+	if( !function_exists( 'wp_cache_post_change' )) {
26
+		return;
27
+	}
24 28
 	wp_cache_post_change( $request->post_id );
25
-	if( empty( $review->assigned_to ) || $review->assigned_to == $request->post_id )return;
29
+	if( empty( $review->assigned_to ) || $review->assigned_to == $request->post_id ) {
30
+		return;
31
+	}
26 32
 	wp_cache_post_change( $review->assigned_to );
27 33
 }, 10, 2 );
28 34
 
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  * @see https://wordpress.org/plugins/wp-super-cache/
21 21
  */
22 22
 add_action( 'site-reviews/review/created', function( $review, $request ) {
23
-	if( !function_exists( 'wp_cache_post_change' ))return;
23
+	if( !function_exists( 'wp_cache_post_change' ) )return;
24 24
 	wp_cache_post_change( $request->post_id );
25
-	if( empty( $review->assigned_to ) || $review->assigned_to == $request->post_id )return;
25
+	if( empty($review->assigned_to) || $review->assigned_to == $request->post_id )return;
26 26
 	wp_cache_post_change( $review->assigned_to );
27 27
 }, 10, 2 );
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
  */
34 34
 add_filter( 'sbp_exclude_defer_scripts', function( $scriptHandles ) {
35 35
 	$scriptHandles[] = 'site-reviews/google-recaptcha';
36
-	return array_keys( array_flip( $scriptHandles ));
36
+	return array_keys( array_flip( $scriptHandles ) );
37 37
 });
38 38
 
39 39
 /**
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
  * @see https://searchandfilter.com/
44 44
  */
45 45
 add_filter( 'sf_edit_query_args', function( $query ) {
46
-	if( !empty( $query['meta_key'] ) && $query['meta_key'] == '_glsr_ranking' ) {
47
-		unset( $query['meta_key'] );
46
+	if( !empty($query['meta_key']) && $query['meta_key'] == '_glsr_ranking' ) {
47
+		unset($query['meta_key']);
48 48
 		$query['meta_query'] = [
49 49
 			'relation' => 'OR',
50 50
 			['key' => '_glsr_ranking', 'compare' => 'NOT EXISTS'], // this comes first!
Please login to merge, or discard this patch.
plugin/Shortcodes/TinymcePopupGenerator.php 2 patches
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -56,9 +56,13 @@  discard block
 block discarded – undo
56 56
 	protected function generateFields( array $fields )
57 57
 	{
58 58
 		$generatedFields = array_map( function( $field ) {
59
-			if( empty( $field ))return;
59
+			if( empty( $field )) {
60
+				return;
61
+			}
60 62
 			$field = $this->normalize( $field );
61
-			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] )))return;
63
+			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] ))) {
64
+				return;
65
+			}
62 66
 			return $this->$method( $field );
63 67
 		}, $fields );
64 68
 		return array_values( array_filter( $generatedFields ));
@@ -73,7 +77,9 @@  discard block
 block discarded – undo
73 77
 		if( !empty( $this->errors )) {
74 78
 			$errors = [];
75 79
 			foreach( $this->required as $name => $alert ) {
76
-				if( false !== array_search( $name, glsr_array_column( $fields, 'name' )))continue;
80
+				if( false !== array_search( $name, glsr_array_column( $fields, 'name' ))) {
81
+					continue;
82
+				}
77 83
 				$errors[] = $this->errors[$name];
78 84
 			}
79 85
 			$this->errors = $errors;
@@ -117,7 +123,9 @@  discard block
 block discarded – undo
117 123
 	 */
118 124
 	protected function normalizeContainer( array $field )
119 125
 	{
120
-		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ))return;
126
+		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field )) {
127
+			return;
128
+		}
121 129
 		$field['items'] = $this->generateFields( $field['items'] );
122 130
 		return $field;
123 131
 	}
@@ -127,7 +135,9 @@  discard block
 block discarded – undo
127 135
 	 */
128 136
 	protected function normalizeField( array $field, array $defaults )
129 137
 	{
130
-		if( !$this->validate( $field ))return;
138
+		if( !$this->validate( $field )) {
139
+			return;
140
+		}
131 141
 		return array_filter( shortcode_atts( $defaults, $field ), function( $value ) {
132 142
 			return $value !== '';
133 143
 		});
@@ -148,7 +158,9 @@  discard block
 block discarded – undo
148 158
 			'type' => '',
149 159
 			'value' => '',
150 160
 		]);
151
-		if( !is_array( $listbox ))return;
161
+		if( !is_array( $listbox )) {
162
+			return;
163
+		}
152 164
 		if( !array_key_exists( '', $listbox['options'] )) {
153 165
 			$listbox['options'] = ['' => $listbox['placeholder']] + $listbox['options'];
154 166
 		}
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 			'label' => '['.$tag.']',
49 49
 			'required' => $this->required,
50 50
 			'title' => esc_html__( 'Shortcode', 'site-reviews' ),
51
-		]);
51
+		] );
52 52
 		return $this;
53 53
 	}
54 54
 
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
 	protected function generateFields( array $fields )
59 59
 	{
60 60
 		$generatedFields = array_map( function( $field ) {
61
-			if( empty( $field ))return;
61
+			if( empty($field) )return;
62 62
 			$field = $this->normalize( $field );
63
-			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] )))return;
63
+			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] ) ) )return;
64 64
 			return $this->$method( $field );
65 65
 		}, $fields );
66
-		return array_values( array_filter( $generatedFields ));
66
+		return array_values( array_filter( $generatedFields ) );
67 67
 	}
68 68
 
69 69
 	/**
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	protected function getCategories( $tooltip = '' )
74 74
 	{
75 75
 		$terms = glsr( Database::class )->getTerms();
76
-		if( empty( $terms )) {
76
+		if( empty($terms) ) {
77 77
 			return [];
78 78
 		}
79 79
 		return [
@@ -91,15 +91,15 @@  discard block
 block discarded – undo
91 91
 	protected function getFields()
92 92
 	{
93 93
 		$fields = $this->generateFields( $this->fields() );
94
-		if( !empty( $this->errors )) {
94
+		if( !empty($this->errors) ) {
95 95
 			$errors = [];
96 96
 			foreach( $this->required as $name => $alert ) {
97
-				if( false !== array_search( $name, glsr_array_column( $fields, 'name' )))continue;
97
+				if( false !== array_search( $name, glsr_array_column( $fields, 'name' ) ) )continue;
98 98
 				$errors[] = $this->errors[$name];
99 99
 			}
100 100
 			$this->errors = $errors;
101 101
 		}
102
-		return empty( $this->errors )
102
+		return empty($this->errors)
103 103
 			? $fields
104 104
 			: $this->errors;
105 105
 	}
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 */
110 110
 	protected function getHideOptions()
111 111
 	{
112
-		$classname = str_replace( 'Popup', 'Shortcode', get_class( $this ));
112
+		$classname = str_replace( 'Popup', 'Shortcode', get_class( $this ) );
113 113
 		$hideOptions = glsr( $classname )->getHideOptions();
114 114
 		$options = [];
115 115
 		foreach( $hideOptions as $name => $tooltip ) {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 		return wp_parse_args( $field, [
150 150
 			'items' => [],
151 151
 			'type' => '',
152
-		]);
152
+		] );
153 153
 	}
154 154
 
155 155
 	/**
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 			'tooltip' => '',
168 168
 			'type' => '',
169 169
 			'value' => '',
170
-		]);
170
+		] );
171 171
 	}
172 172
 
173 173
 	/**
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 */
176 176
 	protected function normalizeContainer( array $field )
177 177
 	{
178
-		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ))return;
178
+		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ) )return;
179 179
 		$field['items'] = $this->generateFields( $field['items'] );
180 180
 		return $field;
181 181
 	}
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	 */
186 186
 	protected function normalizeField( array $field, array $defaults )
187 187
 	{
188
-		if( !$this->validate( $field ))return;
188
+		if( !$this->validate( $field ) )return;
189 189
 		return array_filter( shortcode_atts( $defaults, $field ), function( $value ) {
190 190
 			return $value !== '';
191 191
 		});
@@ -205,9 +205,9 @@  discard block
 block discarded – undo
205 205
 			'tooltip' => '',
206 206
 			'type' => '',
207 207
 			'value' => '',
208
-		]);
209
-		if( !is_array( $listbox ))return;
210
-		if( !array_key_exists( '', $listbox['options'] )) {
208
+		] );
209
+		if( !is_array( $listbox ) )return;
210
+		if( !array_key_exists( '', $listbox['options'] ) ) {
211 211
 			$listbox['options'] = ['' => $listbox['placeholder']] + $listbox['options'];
212 212
 		}
213 213
 		foreach( $listbox['options'] as $value => $text ) {
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	protected function normalizePost( array $field )
226 226
 	{
227
-		if( !is_array( $field['query_args'] )) {
227
+		if( !is_array( $field['query_args'] ) ) {
228 228
 			$field['query_args'] = [];
229 229
 		}
230 230
 		$posts = get_posts( wp_parse_args( $field['query_args'], [
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
 			'orderby' => 'title',
233 233
 			'post_type' => 'post',
234 234
 			'posts_per_page' => 30,
235
-		]));
236
-		if( !empty( $posts )) {
235
+		] ) );
236
+		if( !empty($posts) ) {
237 237
 			$options = [];
238 238
 			foreach( $posts as $post ) {
239 239
 				$options[$post->ID] = esc_html( $post->post_title );
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 			'tooltip' => '',
264 264
 			'type' => '',
265 265
 			'value' => '',
266
-		]);
266
+		] );
267 267
 	}
268 268
 
269 269
 	/**
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 	 */
272 272
 	protected function validate( array $field )
273 273
 	{
274
-		$args = shortcode_atts([
274
+		$args = shortcode_atts( [
275 275
 			'label' => '',
276 276
 			'name' => false,
277 277
 			'required' => false,
@@ -287,13 +287,13 @@  discard block
 block discarded – undo
287 287
 	 */
288 288
 	protected function validateErrors( array $args )
289 289
 	{
290
-		if( !isset( $args['required']['error'] )) {
290
+		if( !isset($args['required']['error']) ) {
291 291
 			return true;
292 292
 		}
293
-		$this->errors[$args['name']] = $this->normalizeContainer([
293
+		$this->errors[$args['name']] = $this->normalizeContainer( [
294 294
 			'html' => $args['required']['error'],
295 295
 			'type' => 'container',
296
-		]);
296
+		] );
297 297
 		return false;
298 298
 	}
299 299
 
@@ -306,10 +306,10 @@  discard block
 block discarded – undo
306 306
 			return true;
307 307
 		}
308 308
 		$alert = esc_html__( 'Some of the shortcode options are required.', 'site-reviews' );
309
-		if( isset( $args['required']['alert'] )) {
309
+		if( isset($args['required']['alert']) ) {
310 310
 			$alert = $args['required']['alert'];
311 311
 		}
312
-		else if( !empty( $args['label'] )) {
312
+		else if( !empty($args['label']) ) {
313 313
 			$alert = sprintf(
314 314
 				esc_html_x( 'The "%s" option is required.', 'the option label', 'site-reviews' ),
315 315
 				str_replace( ':', '', $args['label'] )
Please login to merge, or discard this patch.
plugin/Database/CountsManager.php 2 patches
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -74,7 +74,9 @@  discard block
 block discarded – undo
74 74
 	 */
75 75
 	public function decreasePostCounts( Review $review )
76 76
 	{
77
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
77
+		if( empty( $counts = $this->getPostCounts( $review->assigned_to ))) {
78
+			return;
79
+		}
78 80
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
79 81
 		$this->setPostCounts( $review->assigned_to, $counts );
80 82
 	}
@@ -85,7 +87,9 @@  discard block
 block discarded – undo
85 87
 	public function decreaseTermCounts( Review $review )
86 88
 	{
87 89
 		foreach( $review->term_ids as $termId ) {
88
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
90
+			if( empty( $counts = $this->getTermCounts( $termId ))) {
91
+				continue;
92
+			}
89 93
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
90 94
 			$this->setTermCounts( $termId, $counts );
91 95
 		}
@@ -107,7 +111,9 @@  discard block
 block discarded – undo
107 111
 			'min' => Rating::MIN_RATING,
108 112
 		]);
109 113
 		foreach( $counts as $index => &$num ) {
110
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
114
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] )) {
115
+				continue;
116
+			}
111 117
 			$num = 0;
112 118
 		}
113 119
 		return $counts;
@@ -199,7 +205,9 @@  discard block
 block discarded – undo
199 205
 	 */
200 206
 	public function increasePostCounts( Review $review )
201 207
 	{
202
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
208
+		if( !( get_post( $review->assigned_to ) instanceof WP_Post )) {
209
+			return;
210
+		}
203 211
 		$counts = $this->getPostCounts( $review->assigned_to );
204 212
 		$counts = empty( $counts )
205 213
 			? $this->buildPostCounts( $review->assigned_to )
@@ -249,7 +257,9 @@  discard block
 block discarded – undo
249 257
 	public function setTermCounts( $termId, array $reviewCounts )
250 258
 	{
251 259
 		$term = get_term( $termId, Application::TAXONOMY );
252
-		if( !isset( $term->term_id ))return;
260
+		if( !isset( $term->term_id )) {
261
+			return;
262
+		}
253 263
 		$ratingCounts = $this->flatten( $reviewCounts );
254 264
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
255 265
 		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
@@ -270,7 +280,9 @@  discard block
 block discarded – undo
270 280
 			$types = array_unique( array_merge( ['local'], $types ));
271 281
 			foreach( $types as $type ) {
272 282
 				$type = $this->normalizeType( $type );
273
-				if( isset( $counts[$type] ))continue;
283
+				if( isset( $counts[$type] )) {
284
+					continue;
285
+				}
274 286
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
275 287
 			}
276 288
 			foreach( $reviews as $review ) {
@@ -323,7 +335,9 @@  discard block
 block discarded – undo
323 335
 		}
324 336
 		foreach( $reviewCounts as &$counts ) {
325 337
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
326
-				if( isset( $counts[$index] ))continue;
338
+				if( isset( $counts[$index] )) {
339
+					continue;
340
+				}
327 341
 				$counts[$index] = 0;
328 342
 			}
329 343
 			ksort( $counts );
Please login to merge, or discard this patch.
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 			$this->getCounts(),
65 65
 			$review->review_type,
66 66
 			$review->rating
67
-		));
67
+		) );
68 68
 	}
69 69
 
70 70
 	/**
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 */
73 73
 	public function decreasePostCounts( Review $review )
74 74
 	{
75
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
75
+		if( empty($counts = $this->getPostCounts( $review->assigned_to )) )return;
76 76
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
77 77
 		$this->setPostCounts( $review->assigned_to, $counts );
78 78
 	}
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	public function decreaseTermCounts( Review $review )
84 84
 	{
85 85
 		foreach( $review->term_ids as $termId ) {
86
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
86
+			if( empty($counts = $this->getTermCounts( $termId )) )continue;
87 87
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
88 88
 			$this->setTermCounts( $termId, $counts );
89 89
 		}
@@ -95,15 +95,15 @@  discard block
 block discarded – undo
95 95
 	public function flatten( array $reviewCounts, array $args = [] )
96 96
 	{
97 97
 		$counts = [];
98
-		array_walk_recursive( $reviewCounts, function( $num, $index ) use( &$counts ) {
99
-			$counts[$index] = $num + intval( glsr_get( $counts, $index, 0 ));
98
+		array_walk_recursive( $reviewCounts, function( $num, $index ) use(&$counts) {
99
+			$counts[$index] = $num + intval( glsr_get( $counts, $index, 0 ) );
100 100
 		});
101 101
 		$args = wp_parse_args( $args, [
102 102
 			'max' => Rating::MAX_RATING,
103 103
 			'min' => Rating::MIN_RATING,
104
-		]);
104
+		] );
105 105
 		foreach( $counts as $index => &$num ) {
106
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
106
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ) )continue;
107 107
 			$num = 0;
108 108
 		}
109 109
 		return $counts;
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 	{
117 117
 		$args = $this->normalizeArgs( $args );
118 118
 
119
-		if( !empty( $args['post_ids'] ) && !empty( $args['term_ids'] )) {
119
+		if( !empty($args['post_ids']) && !empty($args['term_ids']) ) {
120 120
 			$counts = [$this->build( $args )];
121 121
 		}
122 122
 		else {
@@ -130,13 +130,13 @@  discard block
 block discarded – undo
130 130
 				// @todo if multiple ids are provided, a query must be used!
131 131
 				$counts[] = $this->getTermCounts( $termId );
132 132
 			}
133
-			if( empty( $counts )) {
133
+			if( empty($counts) ) {
134 134
 				$counts[] = $this->getCounts();
135 135
 			}
136 136
 		}
137 137
 		return in_array( $args['type'], ['', 'all'] )
138 138
 			? $this->normalize( [$this->flatten( $counts )] )
139
-			: $this->normalize( glsr_array_column( $counts, $args['type'] ));
139
+			: $this->normalize( glsr_array_column( $counts, $args['type'] ) );
140 140
 	}
141 141
 
142 142
 	/**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	public function getCounts()
146 146
 	{
147 147
 		$counts = glsr( OptionManager::class )->get( 'counts', [] );
148
-		if( !is_array( $counts )) {
148
+		if( !is_array( $counts ) ) {
149 149
 			glsr_log()->error( '$counts is not an array' )->debug( $counts );
150 150
 			return [];
151 151
 		}
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	 */
159 159
 	public function getPostCounts( $postId )
160 160
 	{
161
-		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ));
161
+		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ) );
162 162
 	}
163 163
 
164 164
 	/**
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	public function getTermCounts( $termId )
169 169
 	{
170
-		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ));
170
+		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ) );
171 171
 	}
172 172
 
173 173
 	/**
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
185 185
 	 */
186 186
 	public function increaseCounts( Review $review )
187 187
 	{
188
-		if( empty( $counts = $this->getCounts() )) {
188
+		if( empty($counts = $this->getCounts()) ) {
189 189
 			$counts = $this->buildCounts();
190 190
 		}
191
-		$this->setCounts( $this->increaseRating( $counts, $review->review_type, $review->rating ));
191
+		$this->setCounts( $this->increaseRating( $counts, $review->review_type, $review->rating ) );
192 192
 	}
193 193
 
194 194
 	/**
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 	 */
197 197
 	public function increasePostCounts( Review $review )
198 198
 	{
199
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
199
+		if( !(get_post( $review->assigned_to ) instanceof WP_Post) )return;
200 200
 		$counts = $this->getPostCounts( $review->assigned_to );
201
-		$counts = empty( $counts )
201
+		$counts = empty($counts)
202 202
 			? $this->buildPostCounts( $review->assigned_to )
203 203
 			: $this->increaseRating( $counts, $review->review_type, $review->rating );
204 204
 		$this->setPostCounts( $review->assigned_to, $counts );
@@ -209,10 +209,10 @@  discard block
 block discarded – undo
209 209
 	 */
210 210
 	public function increaseTermCounts( Review $review )
211 211
 	{
212
-		$terms = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ));
212
+		$terms = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ) );
213 213
 		foreach( $terms as $term ) {
214 214
 			$counts = $this->getTermCounts( $term['term_id'] );
215
-			$counts = empty( $counts )
215
+			$counts = empty($counts)
216 216
 				? $this->buildTermCounts( $term['term_taxonomy_id'] )
217 217
 				: $this->increaseRating( $counts, $review->review_type, $review->rating );
218 218
 			$this->setTermCounts( $term['term_id'], $counts );
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
 	{
236 236
 		$ratingCounts = $this->flatten( $reviewCounts );
237 237
 		update_post_meta( $postId, static::META_COUNT, $reviewCounts );
238
-		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
239
-		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
238
+		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
239
+		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
240 240
 	}
241 241
 
242 242
 	/**
@@ -246,11 +246,11 @@  discard block
 block discarded – undo
246 246
 	public function setTermCounts( $termId, array $reviewCounts )
247 247
 	{
248 248
 		$term = get_term( $termId, Application::TAXONOMY );
249
-		if( !isset( $term->term_id ))return;
249
+		if( !isset($term->term_id) )return;
250 250
 		$ratingCounts = $this->flatten( $reviewCounts );
251 251
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
252
-		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
253
-		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
252
+		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
253
+		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
254 254
 	}
255 255
 
256 256
 	/**
@@ -262,12 +262,12 @@  discard block
 block discarded – undo
262 262
 	{
263 263
 		$counts = [];
264 264
 		$lastPostId = 0;
265
-		while( $reviews = $this->queryReviews( $args, $lastPostId )) {
266
-			$types = array_keys( array_flip( glsr_array_column( $reviews, 'type' )));
267
-			$types = array_unique( array_merge( ['local'], $types ));
265
+		while( $reviews = $this->queryReviews( $args, $lastPostId ) ) {
266
+			$types = array_keys( array_flip( glsr_array_column( $reviews, 'type' ) ) );
267
+			$types = array_unique( array_merge( ['local'], $types ) );
268 268
 			foreach( $types as $type ) {
269 269
 				$type = $this->normalizeType( $type );
270
-				if( isset( $counts[$type] ))continue;
270
+				if( isset($counts[$type]) )continue;
271 271
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
272 272
 			}
273 273
 			foreach( $reviews as $review ) {
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 	 */
287 287
 	protected function decreaseRating( array $reviewCounts, $type, $rating )
288 288
 	{
289
-		if( isset( $reviewCounts[$type][$rating] )) {
289
+		if( isset($reviewCounts[$type][$rating]) ) {
290 290
 			$reviewCounts[$type][$rating] = max( 0, $reviewCounts[$type][$rating] - 1 );
291 291
 		}
292 292
 		return $reviewCounts;
@@ -299,10 +299,10 @@  discard block
 block discarded – undo
299 299
 	 */
300 300
 	protected function increaseRating( array $reviewCounts, $type, $rating )
301 301
 	{
302
-		if( !array_key_exists( $type, glsr()->reviewTypes )) {
302
+		if( !array_key_exists( $type, glsr()->reviewTypes ) ) {
303 303
 			return $reviewCounts;
304 304
 		}
305
-		if( !array_key_exists( $type, $reviewCounts )) {
305
+		if( !array_key_exists( $type, $reviewCounts ) ) {
306 306
 			$reviewCounts[$type] = [];
307 307
 		}
308 308
 		$reviewCounts = $this->normalize( $reviewCounts );
@@ -315,12 +315,12 @@  discard block
 block discarded – undo
315 315
 	 */
316 316
 	protected function normalize( array $reviewCounts )
317 317
 	{
318
-		if( empty( $reviewCounts )) {
318
+		if( empty($reviewCounts) ) {
319 319
 			$reviewCounts = [[]];
320 320
 		}
321 321
 		foreach( $reviewCounts as &$counts ) {
322 322
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
323
-				if( isset( $counts[$index] ))continue;
323
+				if( isset($counts[$index]) )continue;
324 324
 				$counts[$index] = 0;
325 325
 			}
326 326
 			ksort( $counts );
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
 			'post_ids' => [],
338 338
 			'term_ids' => [],
339 339
 			'type' => 'local',
340
-		]);
340
+		] );
341 341
 		$args['post_ids'] = glsr( Polylang::class )->getPostIds( $args['post_ids'] );
342 342
 		$args['type'] = $this->normalizeType( $args['type'] );
343 343
 		return $args;
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
 	 */
350 350
 	protected function normalizeType( $type )
351 351
 	{
352
-		return empty( $type ) || !is_string( $type )
352
+		return empty($type) || !is_string( $type )
353 353
 			? 'local'
354 354
 			: $type;
355 355
 	}
Please login to merge, or discard this patch.