Test Failed
Push — master ( 3b4aec...d6370d )
by Paul
03:25
created
plugin/Database/CountsManager.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -71,7 +71,9 @@  discard block
 block discarded – undo
71 71
 	 */
72 72
 	public function decreasePostCounts( Review $review )
73 73
 	{
74
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
74
+		if( empty( $counts = $this->getPostCounts( $review->assigned_to ))) {
75
+			return;
76
+		}
75 77
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
76 78
 		$this->setPostCounts( $review->assigned_to, $counts );
77 79
 	}
@@ -82,7 +84,9 @@  discard block
 block discarded – undo
82 84
 	public function decreaseTermCounts( Review $review )
83 85
 	{
84 86
 		foreach( $review->term_ids as $termId ) {
85
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
87
+			if( empty( $counts = $this->getTermCounts( $termId ))) {
88
+				continue;
89
+			}
86 90
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
87 91
 			$this->setTermCounts( $termId, $counts );
88 92
 		}
@@ -158,7 +162,9 @@  discard block
 block discarded – undo
158 162
 	 */
159 163
 	public function increasePostCounts( Review $review )
160 164
 	{
161
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
165
+		if( !( get_post( $review->assigned_to ) instanceof WP_Post )) {
166
+			return;
167
+		}
162 168
 		if( empty( $counts = $this->getPostCounts( $review->assigned_to ))) {
163 169
 			$counts = $this->buildPostCounts( $review->assigned_to );
164 170
 		}
@@ -172,7 +178,9 @@  discard block
 block discarded – undo
172 178
 	public function increaseTermCounts( Review $review )
173 179
 	{
174 180
 		foreach( $review->term_ids as $termId ) {
175
-			if( !( get_term( $termId, Application::TAXONOMY ) instanceof WP_Term ))continue;
181
+			if( !( get_term( $termId, Application::TAXONOMY ) instanceof WP_Term )) {
182
+				continue;
183
+			}
176 184
 			if( empty( $counts = $this->getTermCounts( $termId ))) {
177 185
 				$counts = $this->buildTermCounts( $termId );
178 186
 			}
@@ -224,7 +232,9 @@  discard block
 block discarded – undo
224 232
 		while( $reviews = $this->queryReviews( $args, $lastPostId, $limit )) {
225 233
 			$types = array_keys( array_flip( array_column( $reviews, 'type' )));
226 234
 			foreach( $types as $type ) {
227
-				if( isset( $counts[$type] ))continue;
235
+				if( isset( $counts[$type] )) {
236
+					continue;
237
+				}
228 238
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
229 239
 			}
230 240
 			foreach( $reviews as $review ) {
@@ -273,7 +283,9 @@  discard block
 block discarded – undo
273 283
 	{
274 284
 		foreach( $reviewCounts as &$counts ) {
275 285
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
276
-				if( isset( $counts[$index] ))continue;
286
+				if( isset( $counts[$index] )) {
287
+					continue;
288
+				}
277 289
 				$counts[$index] = 0;
278 290
 			}
279 291
 			ksort( $counts );
Please login to merge, or discard this patch.
plugin/Controllers/ReviewController.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,9 @@  discard block
 block discarded – undo
22 22
 	 */
23 23
 	public function onAfterChangeCategory( $postId, $terms, $termIds, $taxonomySlug, $append, $oldTermIds )
24 24
 	{
25
-		if( !$this->isReviewPostType( $postId ))return;
25
+		if( !$this->isReviewPostType( $postId )) {
26
+			return;
27
+		}
26 28
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
27 29
 		$ignoredTerms = array_intersect( $oldTermIds, $termIds );
28 30
 		$review->term_ids = array_diff( $oldTermIds, $ignoredTerms );
@@ -40,7 +42,9 @@  discard block
 block discarded – undo
40 42
 	 */
41 43
 	public function onAfterCreate( $postData, $meta, $postId )
42 44
 	{
43
-		if( !$this->isReviewPostType( $postId ))return;
45
+		if( !$this->isReviewPostType( $postId )) {
46
+			return;
47
+		}
44 48
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
45 49
 		glsr( CountsManager::class )->increase( $review );
46 50
 	}
@@ -52,7 +56,9 @@  discard block
 block discarded – undo
52 56
 	 */
53 57
 	public function onBeforeDelete( $postId )
54 58
 	{
55
-		if( !$this->isReviewPostType( $postId ))return;
59
+		if( !$this->isReviewPostType( $postId )) {
60
+			return;
61
+		}
56 62
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
57 63
 		glsr( CountsManager::class )->decrease( $review );
58 64
 	}
@@ -69,9 +75,13 @@  discard block
 block discarded – undo
69 75
 	{
70 76
 		if( !$this->isReviewPostType( $postId )
71 77
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
72
-		)return;
78
+		) {
79
+			return;
80
+		}
73 81
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
74
-		if( $review->$metaKey == $metaValue )return;
82
+		if( $review->$metaKey == $metaValue ) {
83
+			return;
84
+		}
75 85
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
76 86
 		call_user_func( [$this, $method], $review, $metaValue );
77 87
 	}
@@ -96,7 +106,9 @@  discard block
 block discarded – undo
96 106
 	 */
97 107
 	public function onChangeStatus( $newStatus, $oldStatus, WP_Post $post )
98 108
 	{
99
-		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
109
+		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] )) {
110
+			return;
111
+		}
100 112
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
101 113
 		if( $status == 'publish' ) {
102 114
 			glsr( CountsManager::class )->increase( $review );
Please login to merge, or discard this patch.
plugin/Controllers/EditorController.php 1 patch
Braces   +24 added lines, -8 removed lines patch added patch discarded remove patch
@@ -88,7 +88,9 @@  discard block
 block discarded – undo
88 88
 	 */
89 89
 	public function registerMetaBoxes( $postType )
90 90
 	{
91
-		if( $postType != Application::POST_TYPE )return;
91
+		if( $postType != Application::POST_TYPE ) {
92
+			return;
93
+		}
92 94
 		add_meta_box( Application::ID.'_assigned_to', __( 'Assigned To', 'site-reviews' ), [$this, 'renderAssignedToMetabox'], null, 'side' );
93 95
 		add_meta_box( Application::ID.'_review', __( 'Details', 'site-reviews' ), [$this, 'renderDetailsMetaBox'], null, 'side' );
94 96
 		add_meta_box( Application::ID.'_response', __( 'Respond Publicly', 'site-reviews' ), [$this, 'renderResponseMetaBox'], null, 'normal' );
@@ -118,7 +120,9 @@  discard block
 block discarded – undo
118 120
 	 */
119 121
 	public function renderAssignedToMetabox( WP_Post $post )
120 122
 	{
121
-		if( !$this->isReviewPostType( $post ))return;
123
+		if( !$this->isReviewPostType( $post )) {
124
+			return;
125
+		}
122 126
 		$assignedTo = (string)get_post_meta( $post->ID, 'assigned_to', true );
123 127
 		wp_nonce_field( 'assigned_to', '_nonce-assigned-to', false );
124 128
 		glsr()->render( 'partials/editor/metabox-assigned-to', [
@@ -133,7 +137,9 @@  discard block
 block discarded – undo
133 137
 	 */
134 138
 	public function renderDetailsMetaBox( WP_Post $post )
135 139
 	{
136
-		if( !$this->isReviewPostType( $post ))return;
140
+		if( !$this->isReviewPostType( $post )) {
141
+			return;
142
+		}
137 143
 		$review = glsr( ReviewManager::class )->single( $post );
138 144
 		glsr()->render( 'partials/editor/metabox-details', [
139 145
 			'button' => $this->buildDetailsMetaBoxRevertButton( $review, $post ),
@@ -147,7 +153,9 @@  discard block
 block discarded – undo
147 153
 	 */
148 154
 	public function renderPinnedInPublishMetaBox()
149 155
 	{
150
-		if( !$this->isReviewPostType( get_post() ))return;
156
+		if( !$this->isReviewPostType( get_post() )) {
157
+			return;
158
+		}
151 159
 		glsr( Html::class )->renderTemplate( 'partials/editor/pinned', [
152 160
 			'context' => [
153 161
 				'no' => __( 'No', 'site-reviews' ),
@@ -163,7 +171,9 @@  discard block
 block discarded – undo
163 171
 	 */
164 172
 	public function renderResponseMetaBox( WP_Post $post )
165 173
 	{
166
-		if( !$this->isReviewPostType( $post ))return;
174
+		if( !$this->isReviewPostType( $post )) {
175
+			return;
176
+		}
167 177
 		wp_nonce_field( 'response', '_nonce-response', false );
168 178
 		glsr()->render( 'partials/editor/metabox-response', [
169 179
 			'response' => get_post_meta( $post->ID, 'response', true ),
@@ -177,7 +187,9 @@  discard block
 block discarded – undo
177 187
 	 */
178 188
 	public function renderTaxonomyMetabox( WP_Post $post )
179 189
 	{
180
-		if( !$this->isReviewPostType( $post ))return;
190
+		if( !$this->isReviewPostType( $post )) {
191
+			return;
192
+		}
181 193
 		glsr()->render( 'partials/editor/metabox-categories', [
182 194
 			'post' => $post,
183 195
 			'tax_name' => Application::TAXONOMY,
@@ -215,7 +227,9 @@  discard block
 block discarded – undo
215 227
 	protected function buildAssignedToTemplate( $assignedTo, WP_Post $post )
216 228
 	{
217 229
 		$assignedPost = glsr( Database::class )->getAssignedToPost( $post->ID, $assignedTo );
218
-		if( !( $assignedPost instanceof WP_Post ))return;
230
+		if( !( $assignedPost instanceof WP_Post )) {
231
+			return;
232
+		}
219 233
 		return glsr( Html::class )->buildTemplate( 'partials/editor/assigned-post', [
220 234
 			'context' => [
221 235
 				'data.url' => (string)get_permalink( $assignedPost ),
@@ -256,7 +270,9 @@  discard block
 block discarded – undo
256 270
 	 */
257 271
 	protected function getReviewType( $review )
258 272
 	{
259
-		if( count( glsr()->reviewTypes ) < 2 )return;
273
+		if( count( glsr()->reviewTypes ) < 2 ) {
274
+			return;
275
+		}
260 276
 		$reviewType = array_key_exists( $review->review_type, glsr()->reviewTypes )
261 277
 			? glsr()->reviewTypes[$review->review_type]
262 278
 			: __( 'Unknown', 'site-reviews' );
Please login to merge, or discard this patch.
plugin/Controllers/EditorController/Metaboxes.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,9 @@  discard block
 block discarded – undo
13 13
 	 */
14 14
 	public function saveAssignedToMetabox( $postId )
15 15
 	{
16
-		if( !wp_verify_nonce( glsr( Helper::class )->filterInput( '_nonce-assigned-to' ), 'assigned_to' ))return;
16
+		if( !wp_verify_nonce( glsr( Helper::class )->filterInput( '_nonce-assigned-to' ), 'assigned_to' )) {
17
+			return;
18
+		}
17 19
 		$assignedTo = strval( glsr( Helper::class )->filterInput( 'assigned_to' ));
18 20
 		if( get_post_meta( $postId, 'assigned_to', true ) != $assignedTo ) {
19 21
 			$review = glsr( ReviewManager::class )->single( get_post( $postId ));
@@ -28,7 +30,9 @@  discard block
 block discarded – undo
28 30
 	 */
29 31
 	public function saveResponseMetabox( $postId )
30 32
 	{
31
-		if( !wp_verify_nonce( glsr( Helper::class )->filterInput( '_nonce-response' ), 'response' ))return;
33
+		if( !wp_verify_nonce( glsr( Helper::class )->filterInput( '_nonce-response' ), 'response' )) {
34
+			return;
35
+		}
32 36
 		$response = strval( glsr( Helper::class )->filterInput( 'response' ))c;
33 37
 		update_post_meta( $postId, 'response', trim( wp_kses( $response, [
34 38
 			'a' => ['href' => [], 'title' => []],
Please login to merge, or discard this patch.