| Total Complexity | 43 |
| Total Lines | 272 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like ProductController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ProductController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | class ProductController implements ControllerContract |
||
| 17 | { |
||
| 18 | use HookProxy; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * @filter render_block_core/shortcode |
||
| 22 | */ |
||
| 23 | public function filterAssignedPostsPostId(string $content, array $parsedBlock, ?\WP_Block $parentBlock): string |
||
| 44 | } |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @filter block_type_metadata_settings |
||
| 48 | */ |
||
| 49 | public function filterBlockRenderCallback(array $settings, array $metadata): array |
||
| 50 | { |
||
| 51 | $name = $metadata['name'] ?? ''; |
||
| 52 | $targets = [ |
||
| 53 | 'surecart/product-list-sort', |
||
| 54 | 'surecart/product-list-sort-radio-group-template', |
||
| 55 | ]; |
||
| 56 | if (!in_array($name, $targets)) { |
||
| 57 | return $settings; |
||
| 58 | } |
||
| 59 | $controllerPath = wp_normalize_path( |
||
| 60 | realpath(dirname($metadata['file']).'/'.remove_block_asset_path_prefix('file:./controller.php')) |
||
| 61 | ); |
||
| 62 | if (!file_exists($controllerPath)) { |
||
| 63 | return $settings; |
||
| 64 | } |
||
| 65 | $settings['render_callback'] = static function ($attributes, $content, $block) use ($controllerPath, $metadata) { |
||
| 66 | $view = require $controllerPath; |
||
| 67 | $templatePath = wp_normalize_path( |
||
| 68 | realpath(dirname($metadata['file']).'/'.remove_block_asset_path_prefix($view)) |
||
| 69 | ); |
||
| 70 | if (isset($options) |
||
|
1 ignored issue
–
show
|
|||
| 71 | && isset($params) |
||
|
1 ignored issue
–
show
|
|||
| 72 | && isset($query_order) |
||
|
1 ignored issue
–
show
|
|||
| 73 | && isset($query_order_by)) { |
||
|
1 ignored issue
–
show
|
|||
| 74 | $options[] = [ |
||
| 75 | 'checked' => 'asc' === $query_order && 'rating' === $query_order_by, |
||
| 76 | 'href' => $params->addArg('order', 'asc')->addArg('orderby', 'rating')->url(), |
||
| 77 | 'label' => esc_html__('Rating, low to high', 'site-reviews'), |
||
| 78 | 'value' => 'rating:asc', |
||
| 79 | ]; |
||
| 80 | $options[] = [ |
||
| 81 | 'checked' => 'desc' === $query_order && 'rating' === $query_order_by, |
||
| 82 | 'href' => $params->addArg('order', 'desc')->addArg('orderby', 'rating')->url(), |
||
| 83 | 'label' => esc_html__('Rating, high to low', 'site-reviews'), |
||
| 84 | 'value' => 'rating:desc', |
||
| 85 | ]; |
||
| 86 | } |
||
| 87 | ob_start(); |
||
| 88 | require $templatePath; |
||
| 89 | return ob_get_clean(); |
||
| 90 | }; |
||
| 91 | return $settings; |
||
| 92 | } |
||
| 93 | |||
| 94 | /** |
||
| 95 | * @filter site-reviews/review/value/author |
||
| 96 | */ |
||
| 97 | public function filterReviewAuthorTagValue(string $value, ReviewTag $tag): string |
||
| 98 | { |
||
| 99 | $ownership = glsr_get_option('integrations.surecart.ownership', [], 'array'); |
||
| 100 | if (!in_array('labeled', $ownership)) { |
||
| 101 | return $value; |
||
| 102 | } |
||
| 103 | if ($tag->review->hasProductOwner()) { |
||
|
1 ignored issue
–
show
|
|||
| 104 | $text = esc_attr__('verified owner', 'site-reviews'); |
||
| 105 | $value = sprintf('%s <em data-verified-owner="1">(%s)</em>', $value, $text); |
||
| 106 | } |
||
| 107 | return $value; |
||
| 108 | } |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @filter site-reviews/review/call/hasProductOwner |
||
| 112 | */ |
||
| 113 | public function filterReviewCallbackHasProductOwner(Review $review): bool |
||
| 114 | { |
||
| 115 | $verified = get_post_meta($review->ID, '_sc_verified', true); |
||
| 116 | if ('' !== $verified) { |
||
| 117 | return (bool) $verified; |
||
| 118 | } |
||
| 119 | $review->refresh(); // refresh the review first! |
||
| 120 | $verified = false; |
||
| 121 | foreach ($review->assigned_posts as $postId) { |
||
| 122 | if ('sc_product' === get_post_type($postId)) { |
||
| 123 | $verified = $this->isProductOwner($review->author_id, $postId); |
||
| 124 | break; // only check the first product |
||
| 125 | } |
||
| 126 | } |
||
| 127 | update_post_meta($review->ID, '_sc_verified', (int) $verified); |
||
| 128 | return $verified; |
||
| 129 | } |
||
| 130 | |||
| 131 | /** |
||
| 132 | * @filter site-reviews/build/template/reviews-form |
||
| 133 | */ |
||
| 134 | public function filterReviewFormBuild(string $template, array $data): string |
||
|
1 ignored issue
–
show
|
|||
| 135 | { |
||
| 136 | if ('sc_product' !== get_post_type()) { |
||
| 137 | return $template; |
||
| 138 | } |
||
| 139 | $ownership = glsr_get_option('integrations.surecart.ownership', [], 'array'); |
||
| 140 | if (!in_array('restricted', $ownership)) { |
||
| 141 | return $template; |
||
| 142 | } |
||
| 143 | if ($this->isProductOwner(get_current_user_id(), get_the_ID())) { |
||
| 144 | return $template; |
||
| 145 | } |
||
| 146 | return glsr(Builder::class)->p([ |
||
| 147 | 'text' => esc_html__('Only logged in customers who have purchased this product may leave a review.', 'woocommerce'), |
||
| 148 | ]); |
||
| 149 | } |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @filter site-reviews/shortcode/site_reviews/attributes |
||
| 153 | * @filter site-reviews/shortcode/site_reviews_form/attributes |
||
| 154 | * @filter site-reviews/shortcode/site_reviews_summary/attributes |
||
| 155 | */ |
||
| 156 | public function filterShortcodeAttributes(array $attributes, ShortcodeContract $shortcode): array |
||
| 167 | } |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @action parse_query |
||
| 171 | */ |
||
| 172 | public function parseProductQuery(\WP_Query $query): void |
||
| 173 | { |
||
| 174 | if ('sc_product' !== $query->get('post_type')) { |
||
| 175 | return; |
||
| 176 | } |
||
| 177 | if ('rating' !== $query->get('orderby')) { |
||
| 178 | return; |
||
| 179 | } |
||
| 180 | $metaQuery = $query->get('meta_query', []); |
||
| 181 | $order = $query->get('order', 'desc'); |
||
| 182 | if ('bayesian' === glsr_get_option('integrations.surecart.sorting')) { |
||
| 183 | $metaQuery[] = $this->buildMetaQuery('glsr_ranking', CountManager::META_RANKING); |
||
| 184 | $query->set('meta_query', $metaQuery); |
||
| 185 | $query->set('orderby', ['glsr_ranking' => $order]); |
||
| 186 | } else { |
||
| 187 | $metaQuery[] = $this->buildMetaQuery('glsr_average', CountManager::META_AVERAGE); |
||
| 188 | $metaQuery[] = $this->buildMetaQuery('glsr_reviews', CountManager::META_REVIEWS); |
||
| 189 | $query->set('meta_query', $metaQuery); |
||
| 190 | $query->set('orderby', ['glsr_average' => $order, 'glsr_reviews' => $order]); |
||
| 191 | } |
||
| 192 | } |
||
| 193 | |||
| 194 | /** |
||
| 195 | * @action init:11 |
||
| 196 | */ |
||
| 197 | public function registerBlocks(): void |
||
| 198 | { |
||
| 199 | register_block_type_from_metadata(glsr()->path('assets/blocks/surecart_product_rating')); |
||
| 200 | register_block_type_from_metadata(glsr()->path('assets/blocks/surecart_product_reviews')); |
||
| 201 | } |
||
| 202 | |||
| 203 | /** |
||
| 204 | * @action init |
||
| 205 | */ |
||
| 206 | public function registerBlockPatterns(): void |
||
| 207 | { |
||
| 208 | register_block_pattern(glsr()->id.'/surecart-product-reviews', [ |
||
| 209 | 'title' => _x('Product Reviews', 'admin-text', 'site-reviews'), |
||
| 210 | 'categories' => ['surecart_product_page'], |
||
| 211 | 'blockTypes' => ['surecart/product-page'], |
||
| 212 | 'priority' => 2, |
||
| 213 | 'content' => ' |
||
| 214 | <!-- wp:group {"layout":{"type":"constrained"}} --> |
||
| 215 | <div class="wp-block-group"> |
||
| 216 | <!-- wp:columns {"align":"wide"} --> |
||
| 217 | <div class="wp-block-columns alignwide"> |
||
| 218 | <!-- wp:column {"width":"100%","className":"is-style-default","layout":{"type":"default"}} --> |
||
| 219 | <div class="wp-block-column is-style-default" style="flex-basis:100%"> |
||
| 220 | <!-- wp:heading {"className":"is-style-text-subtitle"} --> |
||
| 221 | <h2 class="wp-block-heading is-style-text-subtitle">Reviews</h2> |
||
| 222 | <!-- /wp:heading --> |
||
| 223 | <!-- wp:site-reviews/reviews {"assigned_posts":["post_id"],"hide":["title"],"id":"reviews","pagination":"ajax","schema":1} /--> |
||
| 224 | <!-- wp:heading {"className":"is-style-text-subtitle"} --> |
||
| 225 | <h2 class="wp-block-heading is-style-text-subtitle">Submit a Review</h2> |
||
| 226 | <!-- /wp:heading --> |
||
| 227 | <!-- wp:site-reviews/form {"assigned_posts":["post_id"],"hide":["name","email","title"],"reviews_id":"reviews"} /--></div> |
||
| 228 | <!-- /wp:column --> |
||
| 229 | </div> |
||
| 230 | <!-- /wp:columns --> |
||
| 231 | </div> |
||
| 232 | <!-- /wp:group -->', |
||
| 233 | // 'postTypes' => ['sc_product'], |
||
| 234 | // 'templateTypes' => ['sc_product'], |
||
| 235 | ]); |
||
| 236 | } |
||
| 237 | |||
| 238 | /** |
||
| 239 | * @filter surecart/product/attributes_set |
||
| 240 | */ |
||
| 241 | public function registerProductAttributes(Product $product): void |
||
| 242 | { |
||
| 243 | $postId = $product->post->ID ?? 0; |
||
| 244 | if (0 === $postId) { |
||
| 245 | return; |
||
| 246 | } |
||
| 247 | $ratingInfo = glsr_get_ratings([ |
||
| 248 | 'assigned_posts' => $postId, |
||
| 249 | ]); |
||
| 250 | $product->setAttribute('rating', $ratingInfo->average); |
||
| 251 | $product->setAttribute('reviews', $ratingInfo->reviews); |
||
| 252 | $product->setAttribute('ranking', $ratingInfo->ranking); |
||
| 253 | } |
||
| 254 | |||
| 255 | /** |
||
| 256 | * @action site-reviews/review/created |
||
| 257 | */ |
||
| 258 | public function verifyProductOwner(Review $review): void |
||
| 259 | { |
||
| 260 | $review->hasProductOwner(); |
||
| 261 | } |
||
| 262 | |||
| 263 | protected function buildMetaQuery(string $orderbyKey, string $metaKey): array |
||
| 269 | ]; |
||
| 270 | } |
||
| 271 | |||
| 272 | protected function isProductOwner(int $userId, int $productId): bool |
||
| 273 | { |
||
| 274 | if (!$user = User::getUserBy('id', $userId)) { // @phpstan-ignore-line |
||
| 275 | return false; |
||
| 276 | } |
||
| 277 | if (!$customer = $user->customer()) { // @phpstan-ignore-line |
||
| 278 | return false; |
||
| 290 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths