Passed
Push — master ( 36c2a1...ae1d0b )
by Paul
05:48
created
plugin/Controllers/RestCategoryController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,6 +33,6 @@
 block discarded – undo
33 33
 				'permission_callback' => [$this, 'get_items_permissions_check'],
34 34
 			],
35 35
 			'schema' => [$this, 'get_public_item_schema'],
36
-		]);
36
+		] );
37 37
 	}
38 38
 }
Please login to merge, or discard this patch.
views/pages/addons/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 				'title' => 'Images',
18 18
 			],
19 19
 			'plugin' => 'site-reviews-images/site-reviews-images.php',
20
-		]);
20
+		] );
21 21
 		$template->render( 'partials/addons/addon', [
22 22
 			'context' => [
23 23
 				'description' => __( 'Sync your Tripadvisor reviews to your website and manage them with Site Reviews.', 'site-reviews' ),
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 				'title' => 'Tripadvisor Reviews',
27 27
 			],
28 28
 			'plugin' => 'site-reviews-tripadvisor/site-reviews-tripadvisor.php',
29
-		]);
29
+		] );
30 30
 	?>
31 31
 	</div>
32 32
 </div>
Please login to merge, or discard this patch.
plugin/Controllers/TaxonomyController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	 */
36 36
 	public function renderTaxonomyFilter()
37 37
 	{
38
-		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY ))return;
38
+		if( !is_object_in_taxonomy( glsr_current_screen()->post_type, Application::TAXONOMY ) )return;
39 39
 		echo glsr( Builder::class )->label( __( 'Filter by category', 'site-reviews' ), [
40 40
 			'class' => 'screen-reader-text',
41 41
 			'for' => Application::TAXONOMY,
42
-		]);
43
-		wp_dropdown_categories([
42
+		] );
43
+		wp_dropdown_categories( [
44 44
 			'depth' => 3,
45 45
 			'hide_empty' => true,
46 46
 			'hide_if_empty' => true,
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 			'show_option_all' => $this->getShowOptionAll(),
53 53
 			'taxonomy' => Application::TAXONOMY,
54 54
 			'value_field' => 'slug',
55
-		]);
55
+		] );
56 56
 	}
57 57
 
58 58
 	/**
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 	protected function getSelected()
62 62
 	{
63 63
 		global $wp_query;
64
-		return isset( $wp_query->query[Application::TAXONOMY] )
64
+		return isset($wp_query->query[Application::TAXONOMY])
65 65
 			? $wp_query->query[Application::TAXONOMY]
66 66
 			: '';
67 67
 	}
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	{
74 74
 		$taxonomy = get_taxonomy( Application::TAXONOMY );
75 75
 		return $taxonomy
76
-			? ucfirst( strtolower( $taxonomy->labels->all_items ))
76
+			? ucfirst( strtolower( $taxonomy->labels->all_items ) )
77 77
 			: '';
78 78
 	}
79 79
 }
Please login to merge, or discard this patch.
plugin/Controllers/EditorController/Labels.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 			'savePending' => __( 'Save as Unapproved', 'site-reviews' ),
18 18
 			'published' => __( 'Approved', 'site-reviews' ),
19 19
 		];
20
-		if( $this->canModifyTranslation() && isset( $wp_scripts->registered['post']->extra['data'] )) {
20
+		if( $this->canModifyTranslation() && isset($wp_scripts->registered['post']->extra['data']) ) {
21 21
 			$l10n = &$wp_scripts->registered['post']->extra['data'];
22 22
 			foreach( $strings as $search => $replace ) {
23 23
 				$l10n = preg_replace( '/("'.$search.'":")([^"]+)/', "$1".$replace, $l10n );
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 	 */
34 34
 	public function filterPostStatusLabels( $translation, $text, $domain )
35 35
 	{
36
-		if( $this->canModifyTranslation( $domain )) {
36
+		if( $this->canModifyTranslation( $domain ) ) {
37 37
 			$replacements = $this->getStatusLabels();
38
-			if( array_key_exists( $text, $replacements )) {
38
+			if( array_key_exists( $text, $replacements ) ) {
39 39
 				$translation = $replacements[$text];
40 40
 			}
41 41
 		}
@@ -48,14 +48,14 @@  discard block
 block discarded – undo
48 48
 	public function filterUpdateMessages( array $messages )
49 49
 	{
50 50
 		$post = get_post();
51
-		if( !( $post instanceof WP_Post ))return;
51
+		if( !($post instanceof WP_Post) )return;
52 52
 		$strings = $this->getReviewLabels();
53 53
 		$restored = filter_input( INPUT_GET, 'revision' );
54
-		if( $revisionTitle = wp_post_revision_title( intval( $restored ), false )) {
54
+		if( $revisionTitle = wp_post_revision_title( intval( $restored ), false ) ) {
55 55
 			$restored = sprintf( $strings['restored'], $revisionTitle );
56 56
 		}
57
-		$scheduled_date = date_i18n( 'M j, Y @ H:i', strtotime( $post->post_date ));
58
-		$messages[ Application::POST_TYPE ] = [
57
+		$scheduled_date = date_i18n( 'M j, Y @ H:i', strtotime( $post->post_date ) );
58
+		$messages[Application::POST_TYPE] = [
59 59
 			 1 => $strings['updated'],
60 60
 			 4 => $strings['updated'],
61 61
 			 5 => $restored,
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 */
78 78
 	protected function canModifyTranslation( $domain = 'default' )
79 79
 	{
80
-		if( $domain != 'default' || empty( glsr_current_screen()->base )) {
80
+		if( $domain != 'default' || empty(glsr_current_screen()->base) ) {
81 81
 			return false;
82 82
 		}
83 83
 		return glsr_current_screen()->post_type == Application::POST_TYPE
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	protected function getStatusLabels()
113 113
 	{
114 114
 		static $labels;
115
-		if( empty( $labels )) {
115
+		if( empty($labels) ) {
116 116
 			$labels = [
117 117
 				'Pending' => __( 'Unapproved', 'site-reviews' ),
118 118
 				'Pending Review' => __( 'Unapproved', 'site-reviews' ),
Please login to merge, or discard this patch.
plugin/Controllers/MenuController.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@  discard block
 block discarded – undo
22 22
 	{
23 23
 		global $menu, $typenow;
24 24
 		foreach( $menu as $key => $value ) {
25
-			if( !isset( $value[2] ) || $value[2] != 'edit.php?post_type='.Application::POST_TYPE )continue;
25
+			if( !isset($value[2]) || $value[2] != 'edit.php?post_type='.Application::POST_TYPE )continue;
26 26
 			$postCount = wp_count_posts( Application::POST_TYPE );
27 27
 			$pendingCount = glsr( Builder::class )->span( number_format_i18n( $postCount->pending ), [
28 28
 				'class' => 'pending-count',
29
-			]);
29
+			] );
30 30
 			$awaitingModeration = glsr( Builder::class )->span( $pendingCount, [
31 31
 				'class' => 'awaiting-mod count-'.$postCount->pending,
32
-			]);
32
+			] );
33 33
 			$menu[$key][0] .= ' '.$awaitingModeration;
34 34
 			if( $typenow === Application::POST_TYPE ) {
35
-				$menu[$key][4].= ' current';
35
+				$menu[$key][4] .= ' current';
36 36
 			}
37 37
 			break;
38 38
 		}
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
 			'tools' => __( 'Tools', 'site-reviews' ),
50 50
 			'addons' => __( 'Add-ons', 'site-reviews' ),
51 51
 			'documentation' => __( 'Documentation', 'site-reviews' ),
52
-		]);
52
+		] );
53 53
 		foreach( $pages as $slug => $title ) {
54 54
 			$method = glsr( Helper::class )->buildMethodName( 'render-'.$slug.'-menu' );
55 55
 			$callback = apply_filters( 'site-reviews/addon/submenu/callback', [$this, $method], $slug );
56
-			if( !is_callable( $callback ))continue;
56
+			if( !is_callable( $callback ) )continue;
57 57
 			add_submenu_page( 'edit.php?post_type='.Application::POST_TYPE, $title, $title, glsr()->constant( 'CAPABILITY' ), $slug, $callback );
58 58
 		}
59 59
 	}
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 	{
68 68
 		$this->renderPage( 'addons', [
69 69
 			'template' => glsr( Template::class ),
70
-		]);
70
+		] );
71 71
 	}
72 72
 
73 73
 	/**
@@ -84,16 +84,16 @@  discard block
 block discarded – undo
84 84
 			'hooks' => __( 'Hooks', 'site-reviews' ),
85 85
 			'functions' => __( 'Functions', 'site-reviews' ),
86 86
 			'addons' => __( 'Addons', 'site-reviews' ),
87
-		]);
87
+		] );
88 88
 		$addons = apply_filters( 'site-reviews/addon/documentation', [] );
89 89
 		ksort( $addons );
90
-		if( empty( $addons )) {
91
-			unset( $tabs['addons'] );
90
+		if( empty($addons) ) {
91
+			unset($tabs['addons']);
92 92
 		}
93 93
 		$this->renderPage( 'documentation', [
94 94
 			'addons' => $addons,
95 95
 			'tabs' => $tabs,
96
-		]);
96
+		] );
97 97
 	}
98 98
 
99 99
 	/**
@@ -111,18 +111,18 @@  discard block
 block discarded – undo
111 111
 			'translations' => __( 'Translations', 'site-reviews' ),
112 112
 			'addons' => __( 'Addons', 'site-reviews' ),
113 113
 			'licenses' => __( 'Licenses', 'site-reviews' ),
114
-		]);
115
-		if( empty( glsr( Helper::class )->getPathValue( 'settings.addons', glsr()->defaults ))) {
116
-			unset( $tabs['addons'] );
114
+		] );
115
+		if( empty(glsr( Helper::class )->getPathValue( 'settings.addons', glsr()->defaults )) ) {
116
+			unset($tabs['addons']);
117 117
 		}
118
-		if( empty( glsr( Helper::class )->getPathValue( 'settings.licenses', glsr()->defaults ))) {
119
-			unset( $tabs['licenses'] );
118
+		if( empty(glsr( Helper::class )->getPathValue( 'settings.licenses', glsr()->defaults )) ) {
119
+			unset($tabs['licenses']);
120 120
 		}
121 121
 		$this->renderPage( 'settings', [
122 122
 			'notices' => $this->getNotices(),
123 123
 			'settings' => glsr( Settings::class ),
124 124
 			'tabs' => $tabs,
125
-		]);
125
+		] );
126 126
 	}
127 127
 
128 128
 	/**
@@ -137,24 +137,24 @@  discard block
 block discarded – undo
137 137
 			'sync' => __( 'Sync Reviews', 'site-reviews' ),
138 138
 			'console' => __( 'Console', 'site-reviews' ),
139 139
 			'system-info' => __( 'System Info', 'site-reviews' ),
140
-		]);
141
-		if( !apply_filters( 'site-reviews/addon/sync/enable', false )) {
142
-			unset( $tabs['sync'] );
140
+		] );
141
+		if( !apply_filters( 'site-reviews/addon/sync/enable', false ) ) {
142
+			unset($tabs['sync']);
143 143
 		}
144 144
 		$this->renderPage( 'tools', [
145 145
 			'data' => [
146 146
 				'context' => [
147 147
 					'base_url' => admin_url( 'edit.php?post_type='.Application::POST_TYPE ),
148
-					'console' => strval( glsr( Console::class )),
148
+					'console' => strval( glsr( Console::class ) ),
149 149
 					'id' => Application::ID,
150
-					'system' => strval( glsr( System::class )),
150
+					'system' => strval( glsr( System::class ) ),
151 151
 				],
152 152
 				'services' => apply_filters( 'site-reviews/addon/sync/services', [] ),
153 153
 			],
154 154
 			'notices' => $this->getNotices(),
155 155
 			'tabs' => $tabs,
156 156
 			'template' => glsr( Template::class ),
157
-		]);
157
+		] );
158 158
 	}
159 159
 
160 160
 	/**
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	{
176 176
 		return glsr( Builder::class )->div( glsr( Notice::class )->get(), [
177 177
 			'id' => 'glsr-notices',
178
-		]);
178
+		] );
179 179
 	}
180 180
 
181 181
 	/**
Please login to merge, or discard this patch.
plugin/Handlers/ChangeStatus.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -13,11 +13,11 @@  discard block
 block discarded – undo
13 13
 	 */
14 14
 	public function handle( Command $command )
15 15
 	{
16
-		$postId = wp_update_post([
16
+		$postId = wp_update_post( [
17 17
 			'ID' => $command->id,
18 18
 			'post_status' => $command->status,
19
-		]);
20
-		if( is_wp_error( $postId )) {
19
+		] );
20
+		if( is_wp_error( $postId ) ) {
21 21
 			glsr_log()->error( $postId->get_error_message() );
22 22
 			return [];
23 23
 		}
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 			'aria-label' => '&#8220;'.esc_attr( $title ).'&#8221; ('.__( 'Edit', 'site-reviews' ).')',
40 40
 			'class' => 'row-title',
41 41
 			'href' => get_edit_post_link( $postId ),
42
-		]);
42
+		] );
43 43
 	}
44 44
 
45 45
 	/**
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 	protected function getPostState( $postId )
50 50
 	{
51 51
 		ob_start();
52
-		_post_states( get_post( $postId ));
52
+		_post_states( get_post( $postId ) );
53 53
 		return ob_get_clean();
54 54
 	}
55 55
 
@@ -59,13 +59,13 @@  discard block
 block discarded – undo
59 59
 	protected function getStatusLinks()
60 60
 	{
61 61
 		global $avail_post_stati;
62
-		require_once( ABSPATH.'wp-admin/includes/class-wp-posts-list-table.php' );
62
+		require_once(ABSPATH.'wp-admin/includes/class-wp-posts-list-table.php');
63 63
 		$hookName = 'edit-'.Application::POST_TYPE;
64 64
 		set_current_screen( $hookName );
65 65
 		$avail_post_stati = get_available_post_statuses( Application::POST_TYPE );
66 66
 		$table = new \WP_Posts_List_Table( ['screen' => $hookName] );
67 67
 		$views = apply_filters( 'views_'.$hookName, $table->get_views() ); // uses compat get_views()
68
-		if( empty( $views ))return;
68
+		if( empty($views) )return;
69 69
 		foreach( $views as $class => $view ) {
70 70
 			$views[$class] = "\t<li class='$class'>$view";
71 71
 		}
Please login to merge, or discard this patch.
compatibility.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,9 +20,9 @@  discard block
 block discarded – undo
20 20
  * @see https://wordpress.org/plugins/wp-super-cache/
21 21
  */
22 22
 add_action( 'site-reviews/review/created', function( $review, $request ) {
23
-	if( !function_exists( 'wp_cache_post_change' ))return;
23
+	if( !function_exists( 'wp_cache_post_change' ) )return;
24 24
 	wp_cache_post_change( $request->post_id );
25
-	if( empty( $review->assigned_to ) || $review->assigned_to == $request->post_id )return;
25
+	if( empty($review->assigned_to) || $review->assigned_to == $request->post_id )return;
26 26
 	wp_cache_post_change( $review->assigned_to );
27 27
 }, 10, 2 );
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
  */
34 34
 add_filter( 'sbp_exclude_defer_scripts', function( $scriptHandles ) {
35 35
 	$scriptHandles[] = 'site-reviews/google-recaptcha';
36
-	return array_keys( array_flip( $scriptHandles ));
36
+	return array_keys( array_flip( $scriptHandles ) );
37 37
 });
38 38
 
39 39
 /**
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
  * @see https://searchandfilter.com/
44 44
  */
45 45
 add_filter( 'sf_edit_query_args', function( $query ) {
46
-	if( !empty( $query['meta_key'] ) && $query['meta_key'] == '_glsr_ranking' ) {
47
-		unset( $query['meta_key'] );
46
+	if( !empty($query['meta_key']) && $query['meta_key'] == '_glsr_ranking' ) {
47
+		unset($query['meta_key']);
48 48
 		$query['meta_query'] = [
49 49
 			'relation' => 'OR',
50 50
 			['key' => '_glsr_ranking', 'compare' => 'EXISTS'],
Please login to merge, or discard this patch.
plugin/Modules/Upgrader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 			$className = str_replace( '.php', '', $file );
25 25
 			$version = str_replace( ['Upgrade_', '_'], ['', '.'], $className );
26 26
 			$versionSuffix = preg_replace( '/[\d.]+(.+)?/', '${1}', glsr()->version ); // allow alpha/beta versions
27
-			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' ))return;
27
+			if( version_compare( $this->currentVersion(), $version.$versionSuffix, '>=' ) )return;
28 28
 			glsr( 'Modules\\Upgrader\\'.$className );
29 29
 			glsr_log()->info( 'Completed Upgrade for v'.$version.$versionSuffix );
30 30
 		});
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 			$this->setReviewCounts();
42 42
 			$this->updateVersionFrom( $version );
43 43
 		}
44
-		else if( !glsr( OptionManager::class )->get( 'last_review_count', false )) {
44
+		else if( !glsr( OptionManager::class )->get( 'last_review_count', false ) ) {
45 45
 			$this->setReviewCounts();
46 46
 		}
47 47
 	}
Please login to merge, or discard this patch.
plugin/Modules/Validator.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 		foreach( $this->rules as $attribute => $rules ) {
75 75
 			foreach( $rules as $rule ) {
76 76
 				$this->validateAttribute( $attribute, $rule );
77
-				if( $this->shouldStopValidating( $attribute ))break;
77
+				if( $this->shouldStopValidating( $attribute ) )break;
78 78
 			}
79 79
 		}
80 80
 		return $this->errors;
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
 	 */
90 90
 	public function validateAttribute( $attribute, $rule )
91 91
 	{
92
-		list( $rule, $parameters ) = $this->parseRule( $rule );
92
+		list($rule, $parameters) = $this->parseRule( $rule );
93 93
 		if( $rule == '' )return;
94 94
 		$value = $this->getValue( $attribute );
95
-		if( !method_exists( $this, $method = 'validate'.$rule )) {
95
+		if( !method_exists( $this, $method = 'validate'.$rule ) ) {
96 96
 			throw new BadMethodCallException( "Method [$method] does not exist." );
97 97
 		}
98
-		if( !$this->$method( $value, $attribute, $parameters )) {
98
+		if( !$this->$method( $value, $attribute, $parameters ) ) {
99 99
 			$this->addFailure( $attribute, $rule, $parameters );
100 100
 		}
101 101
 	}
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	protected function getMessage( $attribute, $rule, array $parameters )
146 146
 	{
147
-		if( in_array( $rule, $this->sizeRules )) {
147
+		if( in_array( $rule, $this->sizeRules ) ) {
148 148
 			return $this->getSizeMessage( $attribute, $rule, $parameters );
149 149
 		}
150 150
 		$lowerRule = glsr( Helper::class )->snakeCase( $rule );
@@ -159,11 +159,11 @@  discard block
 block discarded – undo
159 159
 	 */
160 160
 	protected function getRule( $attribute, $rules )
161 161
 	{
162
-		if( !array_key_exists( $attribute, $this->rules ))return;
162
+		if( !array_key_exists( $attribute, $this->rules ) )return;
163 163
 		$rules = (array)$rules;
164 164
 		foreach( $this->rules[$attribute] as $rule ) {
165
-			list( $rule, $parameters ) = $this->parseRule( $rule );
166
-			if( in_array( $rule, $rules )) {
165
+			list($rule, $parameters) = $this->parseRule( $rule );
166
+			if( in_array( $rule, $rules ) ) {
167 167
 				return [$rule, $parameters];
168 168
 			}
169 169
 		}
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 		if( is_numeric( $value ) && $hasNumeric ) {
182 182
 			return $value;
183 183
 		}
184
-		else if( is_array( $value )) {
184
+		else if( is_array( $value ) ) {
185 185
 			return count( $value );
186 186
 		}
187 187
 		return function_exists( 'mb_strlen' )
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 	 */
210 210
 	protected function getValue( $attribute )
211 211
 	{
212
-		if( isset( $this->data[$attribute] )) {
212
+		if( isset($this->data[$attribute]) ) {
213 213
 			return $this->data[$attribute];
214 214
 		}
215 215
 	}
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	 */
223 223
 	protected function hasRule( $attribute, $rules )
224 224
 	{
225
-		return !is_null( $this->getRule( $attribute, $rules ));
225
+		return !is_null( $this->getRule( $attribute, $rules ) );
226 226
 	}
227 227
 
228 228
 	/**
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 	{
261 261
 		$parameters = [];
262 262
 		if( strpos( $rule, ':' ) !== false ) {
263
-			list( $rule, $parameter ) = explode( ':', $rule, 2 );
263
+			list($rule, $parameter) = explode( ':', $rule, 2 );
264 264
 			$parameters = $this->parseParameters( $rule, $parameter );
265 265
 		}
266 266
 		$rule = glsr( Helper::class )->camelCase( $rule );
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
 	protected function shouldStopValidating( $attribute )
290 290
 	{
291 291
 		return $this->hasRule( $attribute, $this->implicitRules )
292
-			&& isset( $this->failedRules[$attribute] )
292
+			&& isset($this->failedRules[$attribute])
293 293
 			&& array_intersect( array_keys( $this->failedRules[$attribute] ), $this->implicitRules );
294 294
 	}
295 295
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	protected function translator( $key, array $parameters )
303 303
 	{
304 304
 		$strings = glsr( ValidationStringsDefaults::class )->defaults();
305
-		if( isset( $strings[$key] )) {
305
+		if( isset($strings[$key]) ) {
306 306
 			return $this->replace( $strings[$key], $parameters );
307 307
 		}
308 308
 		return "error";
Please login to merge, or discard this patch.