pryley / site-reviews

plugin/Modules/Notification.php

Spacing +16 added lines, -16 removed lines

@@ -33,7 +33,7 @@ 
 	public function __construct()
 	{
 		$types = glsr( OptionManager::class )->get( 'settings.general.notifications', [] );
-		$this->email = count( array_intersect( ['admin', 'custom'], $types )) > 0;
+		$this->email = count( array_intersect( ['admin', 'custom'], $types ) ) > 0;
 		$this->slack = in_array( 'slack', $types );
 		$this->types = $types;
 	}
@@ -43,7 +43,7 @@ 
 	 */
 	public function send( Review $review )
 	{
-		if( empty( $this->types ))return;
+		if( empty($this->types) )return;
 		$this->review = $review;
 		$args = [
 			'link' => $this->getLink(),
@@ -58,7 +58,7 @@ 
 	 */
 	protected function buildEmail( array $args )
 	{
-		return glsr( Email::class )->compose([
+		return glsr( Email::class )->compose( [
 			'to' => $this->getEmailAddresses(),
 			'subject' => $args['title'],
 			'template' => 'email-notification',
@@ -71,7 +71,7 @@ 
 				'review_rating' => $this->review->rating,
 				'review_title' => $this->review->title,
 			],
-		]);
+		] );
 	}
 
 	/**
@@ -83,7 +83,7 @@ 
 			'button_url' => $args['link'],
 			'fallback' => $this->buildEmail( $args )->read( 'plaintext' ),
 			'pretext' => $args['title'],
-		]);
+		] );
 	}
 
 	/**
@@ -92,23 +92,23 @@ 
 	protected function getEmailAddresses()
 	{
 		$emails = [];
-		if( in_array( 'admin', $this->types )) {
+		if( in_array( 'admin', $this->types ) ) {
 			$emails[] = get_option( 'admin_email' );
 		}
-		if( in_array( 'author', $this->types )) {
-			$assignedPost = get_post( intval( $this->review->assigned_to ));
+		if( in_array( 'author', $this->types ) ) {
+			$assignedPost = get_post( intval( $this->review->assigned_to ) );
 			if( $assignedPost instanceof WP_Post ) {
 				$this->email = true;
-				$emails[] = get_the_author_meta( 'user_email', intval( $assignedPost->post_author ));
+				$emails[] = get_the_author_meta( 'user_email', intval( $assignedPost->post_author ) );
 			}
 		}
-		if( in_array( 'custom', $this->types )) {
+		if( in_array( 'custom', $this->types ) ) {
 			$customEmails = glsr( OptionManager::class )->get( 'settings.general.notification_email' );
 			$customEmails = str_replace( [' ', ',', ';'], ',', $customEmails );
 			$customEmails = explode( ',', $customEmails );
 			$emails = array_merge( $emails, $customEmails );
 		}
-		$emails = array_filter( array_keys( array_flip( $emails )));
+		$emails = array_filter( array_keys( array_flip( $emails ) ) );
 		return apply_filters( 'site-reviews/notification/emails', $emails, $this->review );
 	}
 
@@ -125,16 +125,16 @@ 
 	 */
 	protected function getTitle()
 	{
-		$assignedTitle = get_the_title( intval( $this->review->assigned_to ));
+		$assignedTitle = get_the_title( intval( $this->review->assigned_to ) );
 		$title = _nx(
 			'New %s-star review',
 			'New %s-star review of: %s',
-			intval( empty( $assignedTitle )),
+			intval( empty($assignedTitle) ),
 			'This string differs depending on whether or not the review has been assigned to a post.',
 			'site-reviews'
 		);
 		$title = sprintf( '[%s] %s',
-			wp_specialchars_decode( strval( get_option( 'blogname' )), ENT_QUOTES ),
+			wp_specialchars_decode( strval( get_option( 'blogname' ) ), ENT_QUOTES ),
 			sprintf( $title, $this->review->rating, $assignedTitle )
 		);
 		return apply_filters( 'site-reviews/notification/title', $title, $this->review );
@@ -147,7 +147,7 @@ 
 	{
 		$email = $this->buildEmail( $args );
 		if( !$this->email )return;
-		if( empty( $email->to )) {
+		if( empty($email->to) ) {
 			glsr_log()->error( 'Email notification was not sent (missing email address)' );
 			return;
 		}
@@ -164,7 +164,7 @@ 
 		if( !$this->slack )return;
 		$notification = $this->buildSlackNotification( $args );
 		$result = $notification->send();
-		if( is_wp_error( $result )) {
+		if( is_wp_error( $result ) ) {
 			$notification->review = null;
 			glsr_log()->error( $result->get_error_message() )->debug( $notification );
 		}

Braces +9 added lines, -3 removed lines

@@ -43,7 +43,9 @@ 
 	 */
 	public function send( Review $review )
 	{
-		if( empty( $this->types ))return;
+		if( empty( $this->types )) {
+			return;
+		}
 		$this->review = $review;
 		$args = [
 			'link' => $this->getLink(),
@@ -146,7 +148,9 @@ 
 	protected function sendToEmail( array $args )
 	{
 		$email = $this->buildEmail( $args );
-		if( !$this->email )return;
+		if( !$this->email ) {
+			return;
+		}
 		if( empty( $email->to )) {
 			glsr_log()->error( 'Email notification was not sent (missing email address)' );
 			return;
@@ -161,7 +165,9 @@ 
 	 */
 	protected function sendToSlack( array $args )
 	{
-		if( !$this->slack )return;
+		if( !$this->slack ) {
+			return;
+		}
 		$notification = $this->buildSlackNotification( $args );
 		$result = $notification->send();
 		if( is_wp_error( $result )) {

plugin/Modules/Validator/ValidateReview.php

Spacing +23 added lines, -23 removed lines

@@ -67,7 +67,7 @@ 
 		$this->validateBlacklist();
 		$this->validateAkismet();
 		$this->validateRecaptcha();
-		if( !empty( $this->error )) {
+		if( !empty($this->error) ) {
 			$this->setSessionValues( 'message', $this->error );
 		}
 		return $this;
@@ -91,8 +91,8 @@ 
 		if( !glsr( OptionManager::class )->isRecaptchaEnabled() ) {
 			return static::RECAPTCHA_DISABLED;
 		}
-		if( empty( $this->request['_recaptcha-token'] )) {
-			return $this->request['_counter'] < intval( apply_filters( 'site-reviews/recaptcha/timeout', 5 ))
+		if( empty($this->request['_recaptcha-token']) ) {
+			return $this->request['_counter'] < intval( apply_filters( 'site-reviews/recaptcha/timeout', 5 ) )
 				? static::RECAPTCHA_EMPTY
 				: static::RECAPTCHA_FAILED;
 		}
@@ -104,17 +104,17 @@ 
 	 */
 	protected function getRecaptchaTokenStatus()
 	{
-		$endpoint = add_query_arg([
+		$endpoint = add_query_arg( [
 			'remoteip' => glsr( Helper::class )->getIpAddress(),
 			'response' => $this->request['_recaptcha-token'],
 			'secret' => $this->getOption( 'settings.submissions.recaptcha.secret' ),
 		], static::RECAPTCHA_ENDPOINT );
-		if( is_wp_error( $response = wp_remote_get( $endpoint ))) {
+		if( is_wp_error( $response = wp_remote_get( $endpoint ) ) ) {
 			glsr_log()->error( $response->get_error_message() );
 			return static::RECAPTCHA_FAILED;
 		}
-		$response = json_decode( wp_remote_retrieve_body( $response ));
-		if( !empty( $response->success )) {
+		$response = json_decode( wp_remote_retrieve_body( $response ) );
+		if( !empty($response->success) ) {
 			return boolval( $response->success )
 				? static::RECAPTCHA_VALID
 				: static::RECAPTCHA_INVALID;
@@ -132,12 +132,12 @@ 
 	{
 		$rules = array_intersect_key(
 			apply_filters( 'site-reviews/validation/rules', static::VALIDATION_RULES, $request ),
-			array_flip( $this->getOption( 'settings.submissions.required', [] ))
+			array_flip( $this->getOption( 'settings.submissions.required', [] ) )
 		);
-		$excluded = isset( $request['excluded'] )
+		$excluded = isset($request['excluded'])
 			? explode( ',', $request['excluded'] )
 			: [];
-		return array_diff_key( $rules, array_flip( $excluded ));
+		return array_diff_key( $rules, array_flip( $excluded ) );
 	}
 
 	/**
@@ -147,7 +147,7 @@ 
 	{
 		$rules = $this->getValidationRules( $request );
 		$errors = glsr( Validator::class )->validate( $request, $rules );
-		if( empty( $errors )) {
+		if( empty($errors) ) {
 			return true;
 		}
 		$this->setSessionValues( 'errors', $errors );
@@ -164,7 +164,7 @@ 
 	protected function setSessionValues( $type, $value, $loggedMessage = '' )
 	{
 		glsr( Session::class )->set( $this->form_id.$type, $value );
-		if( !empty( $loggedMessage )) {
+		if( !empty($loggedMessage) ) {
 			glsr_log()->warning( $loggedMessage );
 			glsr_log()->warning( $this->request );
 		}
@@ -175,8 +175,8 @@ 
 	 */
 	protected function validateAkismet()
 	{
-		if( !empty( $this->error ))return;
-		if( !glsr( Akismet::class )->isSpam( $this->request ))return;
+		if( !empty($this->error) )return;
+		if( !glsr( Akismet::class )->isSpam( $this->request ) )return;
 		$this->setSessionValues( 'errors', [], 'Akismet caught a spam submission (consider adding the IP address to the blacklist):' );
 		$this->error = __( 'This review has been flagged as possible spam and cannot be submitted.', 'site-reviews' );
 	}
@@ -186,8 +186,8 @@ 
 	 */
 	protected function validateBlacklist()
 	{
-		if( !empty( $this->error ))return;
-		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ))return;
+		if( !empty($this->error) )return;
+		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ) )return;
 		$blacklistAction = $this->getOption( 'settings.submissions.blacklist.action' );
 		if( $blacklistAction == 'reject' ) {
 			$this->setSessionValues( 'errors', [], 'Blacklisted submission detected:' );
@@ -202,7 +202,7 @@ 
 	 */
 	protected function validateCustom()
 	{
-		if( !empty( $this->error ))return;
+		if( !empty($this->error) )return;
 		$validated = apply_filters( 'site-reviews/validate/custom', true, $this->request );
 		if( $validated === true )return;
 		$this->setSessionValues( 'errors', [] );
@@ -217,8 +217,8 @@ 
 	 */
 	protected function validateHoneyPot()
 	{
-		if( !empty( $this->error ))return;
-		if( empty( $this->request['gotcha'] ))return;
+		if( !empty($this->error) )return;
+		if( empty($this->request['gotcha']) )return;
 		$this->setSessionValues( 'errors', [], 'The Honeypot caught a bad submission:' );
 		$this->error = __( 'The review submission failed. Please notify the site administrator.', 'site-reviews' );
 	}
@@ -228,9 +228,9 @@ 
 	 */
 	protected function validateRecaptcha()
 	{
-		if( !empty( $this->error ))return;
+		if( !empty($this->error) )return;
 		$status = $this->getRecaptchaStatus();
-		if( in_array( $status, [static::RECAPTCHA_DISABLED, static::RECAPTCHA_VALID] ))return;
+		if( in_array( $status, [static::RECAPTCHA_DISABLED, static::RECAPTCHA_VALID] ) )return;
 		if( $status == static::RECAPTCHA_EMPTY ) {
 			$this->setSessionValues( 'recaptcha', 'unset' );
 			$this->recaptchaIsUnset = true;
@@ -250,11 +250,11 @@ 
 	 */
 	protected function validateRequest( array $request )
 	{
-		if( !$this->isRequestValid( $request )) {
+		if( !$this->isRequestValid( $request ) ) {
 			$this->error = __( 'Please fix the submission errors.', 'site-reviews' );
 			return $request;
 		}
-		if( empty( $request['title'] )) {
+		if( empty($request['title']) ) {
 			$request['title'] = __( 'No Title', 'site-reviews' );
 		}
 		return array_merge( glsr( ValidateReviewDefaults::class )->defaults(), $request );

Braces +30 added lines, -10 removed lines

@@ -175,8 +175,12 @@ 
 	 */
 	protected function validateAkismet()
 	{
-		if( !empty( $this->error ))return;
-		if( !glsr( Akismet::class )->isSpam( $this->request ))return;
+		if( !empty( $this->error )) {
+			return;
+		}
+		if( !glsr( Akismet::class )->isSpam( $this->request )) {
+			return;
+		}
 		$this->setSessionValues( 'errors', [], 'Akismet caught a spam submission (consider adding the IP address to the blacklist):' );
 		$this->error = __( 'This review has been flagged as possible spam and cannot be submitted.', 'site-reviews' );
 	}
@@ -186,8 +190,12 @@ 
 	 */
 	protected function validateBlacklist()
 	{
-		if( !empty( $this->error ))return;
-		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ))return;
+		if( !empty( $this->error )) {
+			return;
+		}
+		if( !glsr( Blacklist::class )->isBlacklisted( $this->request )) {
+			return;
+		}
 		$blacklistAction = $this->getOption( 'settings.submissions.blacklist.action' );
 		if( $blacklistAction == 'reject' ) {
 			$this->setSessionValues( 'errors', [], 'Blacklisted submission detected:' );
@@ -202,9 +210,13 @@ 
 	 */
 	protected function validateCustom()
 	{
-		if( !empty( $this->error ))return;
+		if( !empty( $this->error )) {
+			return;
+		}
 		$validated = apply_filters( 'site-reviews/validate/custom', true, $this->request );
-		if( $validated === true )return;
+		if( $validated === true ) {
+			return;
+		}
 		$this->setSessionValues( 'errors', [] );
 		$this->setSessionValues( 'values', $this->request );
 		$this->error = is_string( $validated )
@@ -217,8 +229,12 @@ 
 	 */
 	protected function validateHoneyPot()
 	{
-		if( !empty( $this->error ))return;
-		if( empty( $this->request['gotcha'] ))return;
+		if( !empty( $this->error )) {
+			return;
+		}
+		if( empty( $this->request['gotcha'] )) {
+			return;
+		}
 		$this->setSessionValues( 'errors', [], 'The Honeypot caught a bad submission:' );
 		$this->error = __( 'The review submission failed. Please notify the site administrator.', 'site-reviews' );
 	}
@@ -228,9 +244,13 @@ 
 	 */
 	protected function validateRecaptcha()
 	{
-		if( !empty( $this->error ))return;
+		if( !empty( $this->error )) {
+			return;
+		}
 		$status = $this->getRecaptchaStatus();
-		if( in_array( $status, [static::RECAPTCHA_DISABLED, static::RECAPTCHA_VALID] ))return;
+		if( in_array( $status, [static::RECAPTCHA_DISABLED, static::RECAPTCHA_VALID] )) {
+			return;
+		}
 		if( $status == static::RECAPTCHA_EMPTY ) {
 			$this->setSessionValues( 'recaptcha', 'unset' );
 			$this->recaptchaIsUnset = true;