pryley /
site-reviews
| Total Lines | 63 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 9 | add_action('plugins_loaded', function () { |
||
|
Bug
introduced
by
|
|||
| 10 | if (!glsr()->filterBool('support/deprecated/v5', true)) { |
||
| 11 | return; |
||
| 12 | } |
||
| 13 | /** |
||
| 14 | * Review meta data has been deprecated |
||
| 15 | * @since 5.0.0 |
||
| 16 | */ |
||
| 17 | add_filter('get_post_metadata', function ($data, $postId, $metaKey) { |
||
| 18 | if (glsr()->post_type !== get_post_type($postId)) { |
||
| 19 | return $data; |
||
| 20 | } |
||
| 21 | $metaKey = Str::removePrefix($metaKey, '_'); |
||
| 22 | $metaKeys = [ |
||
| 23 | 'assigned_to', 'author', 'avatar', 'content', 'date', 'email', |
||
| 24 | 'ip_address', 'pinned', 'rating', 'review_id', 'review_type', |
||
| 25 | 'title', 'url', |
||
| 26 | ]; |
||
| 27 | if (!in_array($metaKey, $metaKeys)) { |
||
| 28 | return $data; |
||
| 29 | } |
||
| 30 | $message = 'Site Reviews no longer stores the "'.$metaKey.'" review value as meta data. Please use the glsr_get_review() helper function instead.'; |
||
| 31 | glsr()->append('deprecated', $message); |
||
| 32 | return glsr_get_review($postId)->{$metaKey}; |
||
| 33 | }, 10, 3); |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Application |
||
| 37 | * @since 5.0.0 |
||
| 38 | */ |
||
| 39 | add_filter('site-reviews/config/forms/review-form', function ($config) { |
||
| 40 | if (has_filter('site-reviews/config/forms/submission-form')) { |
||
| 41 | $message = 'The "site-reviews/config/forms/submission-form" hook has been deprecated. Please use the "site-reviews/config/forms/review-form" hook instead.'; |
||
| 42 | glsr()->append('deprecated', $message); |
||
| 43 | return apply_filters('site-reviews/config/forms/submission-form', $config); |
||
| 44 | } |
||
| 45 | return $config; |
||
| 46 | }, 9); |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Modules\Html\ReviewsHtml |
||
| 50 | * @since 5.0.0 |
||
| 51 | */ |
||
| 52 | add_filter('site-reviews/rendered/template/reviews', function ($html) { |
||
| 53 | if (has_filter('site-reviews/reviews/reviews-wrapper')) { |
||
| 54 | $message = 'The "site-reviews/reviews/reviews-wrapper" hook has been removed. Please use a custom "reviews.php" template instead.'; |
||
| 55 | glsr()->append('deprecated', $message); |
||
| 56 | } |
||
| 57 | return $html; |
||
| 58 | }); |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Controllers\PublicController |
||
| 62 | * @since 5.0.0 |
||
| 63 | */ |
||
| 64 | add_filter('site-reviews/review-form/order', function ($order) { |
||
| 65 | if (has_filter('site-reviews/submission-form/order')) { |
||
| 66 | $message = 'The "site-reviews/submission-form/order" hook has been deprecated. Please use the "site-reviews/review-form/order" hook instead.'; |
||
| 67 | glsr()->append('deprecated', $message); |
||
| 68 | return apply_filters('site-reviews/submission-form/order', $order); |
||
| 69 | } |
||
| 70 | return $order; |
||
| 71 | }, 9); |
||
| 72 | }); |
||
| 113 |
Loading history...