GeminiLabs\SiteReviews\Integrations\IntegrationHooks

Complexity

Total Complexity

7

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	version()	0	3	1
A	supportedVersion()	0	3	1
A	notify()	0	5	1
A	isInstalled()	0	3	1
A	isVersionSupported()	0	8	2
A	isEnabled()	0	3	1

<?php

namespace GeminiLabs\SiteReviews\Integrations;

use GeminiLabs\SiteReviews\Hooks\AbstractHooks;
use GeminiLabs\SiteReviews\Modules\Notice;
use GeminiLabs\SiteReviews\Modules\Sanitizer;

abstract class IntegrationHooks extends AbstractHooks
{
    protected function isEnabled(): bool
    {
        return true;
    }

    protected function isInstalled(): bool
    {
        return true;
    }

    protected function isVersionSupported(): bool
    {
        $version = glsr(Sanitizer::class)->sanitizeVersion($this->version());
        $supportedVersion = glsr(Sanitizer::class)->sanitizeVersion($this->supportedVersion());
        if (empty($supportedVersion)) {
            return true;
        }
        return version_compare($version, $supportedVersion, '>=');

The expression return version_compare($version, $supportedVersion, '>=') could return the type integer which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    protected function notify(string $name): void
    {
        $notice = _x('Update %s to v%s or higher to enable the integration with Site Reviews.', 'admin-text', 'site-reviews');
        $version = glsr(Sanitizer::class)->sanitizeVersion($this->supportedVersion());
        glsr(Notice::class)->addWarning(sprintf($notice, $name, $version));
    }

    protected function supportedVersion(): string
    {
        return '';
    }

    protected function version(): string
    {
        return '';
    }
}