GLSR.parseFormData - Code Metrics - Inspection of "[site_reviews] finished" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f566f3...fdd3db )

by Paul

created 2018-06-03 20:01 UTC

GLSR.parseFormData B

↳ Parent: +/scripts/public/helper-functions.js

Complexity

Conditions	6
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
nc	8
nop	2
dl	0
loc	55
rs	8.7752
c	1
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
C		0	38	12

How to fix Long Method

var GLSR = {};

GLSR.convertValue = function( value ) {
	if( GLSR.isNumeric( value )) {
		return parseFloat( value );
	}
	else if( value === 'true') {
		return true;
	}
	else if( value === 'false' ) {
		return false;
	}
	else if( value === '' || value === null ) {
		return undefined;
	}
	return value;
};

GLSR.getAjax = function( url, success ) {
	var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );

	xhr.open( 'GET', url );
	xhr.onreadystatechange = function() {
		if( xhr.readyState > 3 && xhr.status === 200 ) {
			success( xhr.responseText );
		}
	};
	xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
	xhr.send();
	return xhr;
};

GLSR.isNumeric = function( value ) {
	return !( isNaN( parseFloat( value )) || !isFinite( value ));
};

GLSR.isString = function( str ) {
	return Object.prototype.toString.call( str ) === '[object String]';
};

GLSR.on = function( type, el, handler ) {
	if( GLSR.isString( el )) {
		el = document.querySelectorAll( el );
	}
	[].forEach.call( el, function( node ) {
		node.addEventListener( type, handler );
	});
};

GLSR.off = function( type, el, handler ) {
	if( GLSR.isString( el )) {
		el = document.querySelectorAll( el );
	}
	[].forEach.call( el, function( node ) {
		node.removeEventListener( type, handler );
	});
};

/**
 * Adapted from https://github.com/bitovi/jquerypp/blob/master/dom/form_params/form_params.js
 */
GLSR.parseFormData = function( form, convert ) {
	convert = !!convert || false;
	var keyBreaker = /[^\[\]]+/g; // used to parse bracket notation
	var data = {};
	var seen = {}; // used to uniquely track seen values
	var nestData = function( field, data, parts, seenName )
	{
		var name = parts.shift();
		// Keep track of the dot separated fullname
		seenName = seenName ? seenName + '.' + name : name;
		if( parts.length ) {
			if( !data[ name ] ) {
				data[ name ] = {};
			}
			// Recursive call
			nestData( field, data[ name ], parts, seenName );
		}
		else {
			// Convert the value
			var value = convert ? GLSR.convertValue( field.value ) : field.value;
			// Handle same name case, as well as "last checkbox checked" case
			if( seenName in seen && field.type !== 'radio' && !data[ name ].isArray()) {
				if( name in data ) {
					data[ name ] = [ data[name] ];
				}
				else {
					data[ name ] = [];
				}
			}
			else {
				seen[ seenName ] = true;
			}
			// Finally, assign data
			if( ['radio','checkbox'].indexOf( field.type ) !== -1 && !field.checked )return;

			if( !data[ name ] ) {
				data[ name ] = value;
			}
			else {
				data[ name ].push( value );
			}
		}
	};

	for( var i = 0; i < form.length; i++ ) {
		var field = form[i];
		if( !field.name || field.disabled || ['file','reset','submit','button'].indexOf( field.type ) !== -1 )continue;
		var parts = field.name.match( keyBreaker );
		if( !parts.length ) {
			parts = [ field.name ];
		}
		nestData( field, data, parts );
	}
	return data;
};

GLSR.postAjax = function( url, data, success ) {
	var params = typeof data !== 'string' ? GLSR.serialize( data ) : data;
	var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );

	xhr.open( 'POST', url ); // asynchronously
	xhr.onreadystatechange = function() {
		if( xhr.readyState > 3 && xhr.status === 200 ) {
			success( JSON.parse( xhr.responseText ));
		}
	};
	xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
	xhr.setRequestHeader( 'Content-Type', 'application/x-www-form-urlencoded; charset=UTF-8' );
	xhr.send( params );
	return xhr;
};

GLSR.ready = function( fn ) {
	if( typeof fn !== 'function' )return;
	// in case the document is already rendered
	if( document.readyState !== 'loading' ) {
		fn();
	}
	// modern browsers
	else if( document.addEventListener ) {
		document.addEventListener( 'DOMContentLoaded', fn );
	}
	// IE <= 8
	else {
		document.attachEvent( 'onreadystatechange', function() {
			if( document.readyState === 'complete' ) {
				fn();
			}
		});
	}
};

GLSR.serialize = function( obj, prefix ) {
	var str = [];

	for( var property in obj ) {
		if( !obj.hasOwnProperty( property ))continue;
		var key = prefix ? prefix + '[' + property + ']' : property;
		var value = obj[ property ];
		str.push( typeof value === 'object' ?
			GLSR.serialize( value, key ) :
			encodeURIComponent( key ) + '=' + encodeURIComponent( value )
		);
	}
	return str.join( '&' );
};

GLSR.insertAfter = function( el, tag, attributes ) {
	var newEl = GLSR.createEl( tag, attributes );
	el.parentNode.insertBefore( newEl, el.nextSibling );
	return newEl;
};

GLSR.appendTo = function( el, tag, attributes ) {
	var newEl = GLSR.createEl( tag, attributes );
	el.appendChild( newEl );
	return newEl;
};

GLSR.createEl = function( tag, attributes ) {
	var el = ( typeof tag === 'string' ) ? document.createElement( tag ) : tag;
	attributes = attributes || {};
	for( var key in attributes ) {
		if( !attributes.hasOwnProperty( key ) )continue;
		el.setAttribute( key, attributes[ key ] );
	}
	return el;
};


1			var GLSR = {};
2
3			GLSR.convertValue = function( value ) {
4			if( GLSR.isNumeric( value )) {
5			return parseFloat( value );
6			}
7			else if( value === 'true') {
8			return true;
9			}
10			else if( value === 'false' ) {
11			return false;
12			}
13			else if( value === '' \|\| value === null ) {
14			return undefined;
15			}
16			return value;
17			};
18
19			GLSR.getAjax = function( url, success ) {
20			var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );
			0 ignored issues – show Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `XMLHttpRequest` seems to be never declared. If this is a global, consider adding a `/** global: XMLHttpRequest /` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `ActiveXObject` seems to be never declared. If this is a global, consider adding a `/* global: ActiveXObject */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
21			xhr.open( 'GET', url );
22			xhr.onreadystatechange = function() {
23			if( xhr.readyState > 3 && xhr.status === 200 ) {
24			success( xhr.responseText );
25			}
26			};
27			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
28			xhr.send();
29			return xhr;
30			};
31
32			GLSR.isNumeric = function( value ) {
33			return !( isNaN( parseFloat( value )) \|\| !isFinite( value ));
34			};
35
36			GLSR.isString = function( str ) {
37			return Object.prototype.toString.call( str ) === '[object String]';
38			};
39
40			GLSR.on = function( type, el, handler ) {
41			if( GLSR.isString( el )) {
42			el = document.querySelectorAll( el );
43			}
44			[].forEach.call( el, function( node ) {
45			node.addEventListener( type, handler );
46			});
47			};
48
49			GLSR.off = function( type, el, handler ) {
50			if( GLSR.isString( el )) {
51			el = document.querySelectorAll( el );
52			}
53			[].forEach.call( el, function( node ) {
54			node.removeEventListener( type, handler );
55			});
56			};
57
58			/**
59			* Adapted from https://github.com/bitovi/jquerypp/blob/master/dom/form_params/form_params.js
60			*/
61			GLSR.parseFormData = function( form, convert ) {
62			convert = !!convert \|\| false;
63			var keyBreaker = /[^\[\]]+/g; // used to parse bracket notation
64			var data = {};
65			var seen = {}; // used to uniquely track seen values
66			var nestData = function( field, data, parts, seenName )
67			{
68			var name = parts.shift();
69			// Keep track of the dot separated fullname
70			seenName = seenName ? seenName + '.' + name : name;
71			if( parts.length ) {
72			if( !data[ name ] ) {
73			data[ name ] = {};
74			}
75			// Recursive call
76			nestData( field, data[ name ], parts, seenName );
77			}
78			else {
79			// Convert the value
80			var value = convert ? GLSR.convertValue( field.value ) : field.value;
81			// Handle same name case, as well as "last checkbox checked" case
82			if( seenName in seen && field.type !== 'radio' && !data[ name ].isArray()) {
83			if( name in data ) {
84			data[ name ] = [ data[name] ];
85			}
86			else {
87			data[ name ] = [];
88			}
89			}
90			else {
91			seen[ seenName ] = true;
92			}
93			// Finally, assign data
94			if( ['radio','checkbox'].indexOf( field.type ) !== -1 && !field.checked )return;
95
96			if( !data[ name ] ) {
97			data[ name ] = value;
98			}
99			else {
100			data[ name ].push( value );
101			}
102			}
103			};
104
105			for( var i = 0; i < form.length; i++ ) {
106			var field = form[i];
107			if( !field.name \|\| field.disabled \|\| ['file','reset','submit','button'].indexOf( field.type ) !== -1 )continue;
108			var parts = field.name.match( keyBreaker );
109			if( !parts.length ) {
110			parts = [ field.name ];
111			}
112			nestData( field, data, parts );
113			}
114			return data;
115			};
116
117			GLSR.postAjax = function( url, data, success ) {
118			var params = typeof data !== 'string' ? GLSR.serialize( data ) : data;
119			var xhr = window.XMLHttpRequest ? new XMLHttpRequest() : new ActiveXObject( 'Microsoft.XMLHTTP' );
			0 ignored issues – show Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `ActiveXObject` seems to be never declared. If this is a global, consider adding a `/** global: ActiveXObject /` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2018-05-18 15:45 UTC by Report Bug Copy Issue Report The variable `XMLHttpRequest` seems to be never declared. If this is a global, consider adding a `/* global: XMLHttpRequest */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
120			xhr.open( 'POST', url ); // asynchronously
121			xhr.onreadystatechange = function() {
122			if( xhr.readyState > 3 && xhr.status === 200 ) {
123			success( JSON.parse( xhr.responseText ));
124			}
125			};
126			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
127			xhr.setRequestHeader( 'Content-Type', 'application/x-www-form-urlencoded; charset=UTF-8' );
128			xhr.send( params );
129			return xhr;
130			};
131
132			GLSR.ready = function( fn ) {
133			if( typeof fn !== 'function' )return;
134			// in case the document is already rendered
135			if( document.readyState !== 'loading' ) {
136			fn();
137			}
138			// modern browsers
139			else if( document.addEventListener ) {
140			document.addEventListener( 'DOMContentLoaded', fn );
141			}
142			// IE <= 8
143			else {
144			document.attachEvent( 'onreadystatechange', function() {
145			if( document.readyState === 'complete' ) {
146			fn();
147			}
148			});
149			}
150			};
151
152			GLSR.serialize = function( obj, prefix ) {
153			var str = [];
154
155			for( var property in obj ) {
156			if( !obj.hasOwnProperty( property ))continue;
157			var key = prefix ? prefix + '[' + property + ']' : property;
158			var value = obj[ property ];
159			str.push( typeof value === 'object' ?
160			GLSR.serialize( value, key ) :
161			encodeURIComponent( key ) + '=' + encodeURIComponent( value )
162			);
163			}
164			return str.join( '&' );
165			};
166
167			GLSR.insertAfter = function( el, tag, attributes ) {
168			var newEl = GLSR.createEl( tag, attributes );
169			el.parentNode.insertBefore( newEl, el.nextSibling );
170			return newEl;
171			};
172
173			GLSR.appendTo = function( el, tag, attributes ) {
174			var newEl = GLSR.createEl( tag, attributes );
175			el.appendChild( newEl );
176			return newEl;
177			};
178
179			GLSR.createEl = function( tag, attributes ) {
180			var el = ( typeof tag === 'string' ) ? document.createElement( tag ) : tag;
181			attributes = attributes \|\| {};
182			for( var key in attributes ) {
183			if( !attributes.hasOwnProperty( key ) )continue;
184			el.setAttribute( key, attributes[ key ] );
185			}
186			return el;
187			};
188

pryley / site-reviews

Push — master ( f566f3...fdd3db )

GLSR.parseFormData B

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like