View GitHub Repository site-reviews

Schedule Inspection
Subscribe
Test Setup Failed
Push — master ( 51607c...6b8ca8 )
by Paul
03:43
created

T_VAR   A

↳ Parent: recaptcha.js ➔ glsr_render_recaptcha

Complexity

Total Complexity 5
Complexity/F 1.25

Size

Lines of Code 1
Function Count 4

Duplication

Duplicated Lines 1
Ratio 100 %

Importance

Changes 0
Metric Value
wmc 5
dl 1
loc 1
rs 10
c 0
b 0
f 0
cc 0
nc 1
mnd 1
bc 4
fnc 4
bpm 1
cpm 1.25
noi 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1 
// jshint unused:false
2 
var glsr_render_recaptcha = function() {
3 
	var id;
4 
	var recaptchaEl;
5 
	[].forEach.call( document.querySelectorAll( '.glsr-submit-review-form' ), function( formEl ) {
6 
		formEl.onsubmit = null;
7 
		recaptchaEl = formEl.querySelector( '.glsr-recaptcha-holder' );
8 
		if( !recaptchaEl )return;
0 ignored issues
– show
Coding Style Best Practice introduced by
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.

Consider:

if (a > 0)
    b = 42;

If you or someone else later decides to put another statement in, only the first statement will be executed.

if (a > 0)
    console.log("a > 0");
    b = 42;

In this case the statement b = 42 will always be executed, while the logging statement will be executed conditionally.

if (a > 0) {
    console.log("a > 0");
    b = 42;
}

ensures that the proper code will be executed conditionally no matter how many statements are added or removed.

Loading history...
9 
		recaptchaEl.innerHTML = '';
10 
		id = grecaptcha.render( recaptchaEl, {
0 ignored issues
– show
Bug introduced by
The variable grecaptcha seems to be never declared. If this is a global, consider adding a /** global: grecaptcha */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
11 
			callback: function( token ) {
12 
				GLSR.submitForm( token );
0 ignored issues
– show
Bug introduced by
The variable GLSR seems to be never declared. If this is a global, consider adding a /** global: GLSR */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
13 
			},
14 
			'expired-callback': function() {
15 
				grecaptcha.reset( id );
0 ignored issues
– show
Bug introduced by
The variable grecaptcha seems to be never declared. If this is a global, consider adding a /** global: grecaptcha */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
16 
			},
17 
		}, true );
18 
		// recaptchaEl.setAttribute( 'data-id', id );
19 
	});
20 
};
21