GeminiLabs\SiteReviews\Controllers\Api\Version1\RestShortcodeController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	get_items_permissions_check()	0	14	3
A	get_items()	0	5	1
A	register_routes()	0	7	1
A	__construct()	0	4	1

<?php

namespace GeminiLabs\SiteReviews\Controllers\Api\Version1;

use GeminiLabs\SiteReviews\Contracts\ShortcodeContract;

class RestShortcodeController extends \WP_REST_Controller
{
    public function __construct()
    {
        $this->namespace = glsr()->id.'/v1';
        $this->rest_base = 'shortcode';
    }

    /**
     * @param \WP_REST_Request $request
     *
     * @return \WP_REST_Response|\WP_Error
     */
    public function get_items($request)
    {
        $shortcode = glsr()->shortcode($request['shortcode']);

It seems like $request['shortcode'] can also be of type null; however, parameter $shortcode of GeminiLabs\SiteReviews\Application::shortcode() does only seem to accept string, maybe add an additional type check?

        return rest_ensure_response(
            $shortcode->apiFetchResponse($request)

The method apiFetchResponse() does not exist on GeminiLabs\SiteReviews\Contracts\ShortcodeContract. Since it exists in all sub-types, consider adding an abstract or default implementation to GeminiLabs\SiteReviews\Contracts\ShortcodeContract.

        );
    }

    /**
     * @param \WP_REST_Request $request
     *
     * @return true|\WP_Error
     */
    public function get_items_permissions_check($request)
    {
        if (!is_user_logged_in()) {
            $error = _x('Sorry, you are not allowed to do that.', 'admin-text', 'site-reviews');
            return new \WP_Error('rest_forbidden_context', $error, [
                'status' => rest_authorization_required_code(),
            ]);
        }
        if (!glsr()->shortcode($request['shortcode'])) {

It seems like $request['shortcode'] can also be of type null; however, parameter $shortcode of GeminiLabs\SiteReviews\Application::shortcode() does only seem to accept string, maybe add an additional type check?

            return new \WP_Error('rest_invalid_shortcode', 'Invalid shortcode', [
                'status' => 400,
            ]);
        }
        return true;
    }

    /**
     * @return void
     */
    public function register_routes()
    {
        register_rest_route($this->namespace, "/{$this->rest_base}/(?P<shortcode>[a-z_]+)", [
            [
                'callback' => [$this, 'get_items'],
                'methods' => \WP_REST_Server::READABLE,
                'permission_callback' => [$this, 'get_items_permissions_check'],
            ],
        ]);
    }
}