GeminiLabs\SiteReviews\Integrations\WPBakery\VcShortcode

Complexity

Total Complexity

5

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	vcRegister()	0	11	1
A	vcShortcodeSettings()	0	3	1
A	vcTypeOptions()	0	12	2
A	vcShortcode()	0	3	1

<?php

namespace GeminiLabs\SiteReviews\Integrations\WPBakery;

use GeminiLabs\SiteReviews\Contracts\ShortcodeContract;

abstract class VcShortcode extends \WPBakeryShortCode

The type WPBakeryShortCode was not found. Maybe you did not declare it correctly or list all dependencies?

{
    /**
     * Override the "vc_map" data with the
     * "vc_element_settings_filter" ($settings, $shortcode) filter hook.
     */
    public static function vcRegister(array $args = []): void
    {
        vc_map(wp_parse_args($args, [

The function vc_map was not found. Maybe you did not declare it correctly or list all dependencies?

            'base' => static::vcShortcode()->shortcode,
            'category' => glsr()->name,
            'description' => static::vcShortcode()->description,

Accessing description on the interface GeminiLabs\SiteReviews\Contracts\ShortcodeContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            'icon' => static::vcShortcodeIcon(),
            'name' => static::vcShortcode()->name,

Accessing name on the interface GeminiLabs\SiteReviews\Contracts\ShortcodeContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            'params' => array_values(array_filter(static::vcShortcodeSettings())),
            'php_class_name' => static::class,
            'show_settings_on_create' => false,
        ]));
    }

    public static function vcShortcode(): ShortcodeContract
    {
        return glsr(static::vcShortcodeClass());

The expression return glsr(static::vcShortcodeClass()) could return the type callable which is incompatible with the type-hinted return GeminiLabs\SiteReviews\Contracts\ShortcodeContract. Consider adding an additional type-check to rule them out.

    }

    abstract public static function vcShortcodeClass(): string;

    abstract public static function vcShortcodeIcon(): string;

    /**
     * Override attributes for a setting with the 
     * "vc_mapper_attribute" ($setting, $shortcode) filter hook.
     */
    public static function vcShortcodeSettings(): array
    {
        return [];
    }

    public static function vcTypeOptions(): array
    {
        $types = glsr()->retrieveAs('array', 'review_types', []);
        if (2 > count($types)) {
            return [];
        }
        return [
            'type' => 'dropdown',
            'heading' => esc_html_x('Limit Reviews by Type', 'admin-text', 'site-reviews'),
            'param_name' => 'type',
            'std' => 'local',
            'value' => array_flip($types),
        ];
    }
}