Test Failed
Push — hotfix/fix-counts ( 216f0e...509562 )
by Paul
05:23
created
activate.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,9 @@
 block discarded – undo
60 60
 	 */
61 61
 	public function deactivate( $plugin )
62 62
 	{
63
-		if( $this->isValid() )return;
63
+		if( $this->isValid() ) {
64
+			return;
65
+		}
64 66
 		$pluginSlug = plugin_basename( $this->file );
65 67
 		if( $plugin == $pluginSlug ) {
66 68
 			$this->redirect(); //exit
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 		$this->versions = wp_parse_args( $versions, array(
31 31
 			'php' => static::MIN_PHP_VERSION,
32 32
 			'wordpress' => static::MIN_WORDPRESS_VERSION,
33
-		));
33
+		) );
34 34
 	}
35 35
 
36 36
 	/**
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 		if( $this->isValid() ) {
42 42
 			return true;
43 43
 		}
44
-		add_action( 'activated_plugin', array( $this, 'deactivate' ));
45
-		add_action( 'admin_notices', array( $this, 'deactivate' ));
44
+		add_action( 'activated_plugin', array( $this, 'deactivate' ) );
45
+		add_action( 'admin_notices', array( $this, 'deactivate' ) );
46 46
 		return false;
47 47
 	}
48 48
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 			filter_input( INPUT_GET, 'plugin_status' ),
138 138
 			filter_input( INPUT_GET, 'paged' ),
139 139
 			filter_input( INPUT_GET, 's' )
140
-		)));
140
+		) ) );
141 141
 		exit;
142 142
 	}
143 143
 }
Please login to merge, or discard this patch.
uninstall.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,9 @@
 block discarded – undo
3 3
 defined( 'WP_UNINSTALL_PLUGIN' ) || die;
4 4
 
5 5
 require_once __DIR__.'/site-reviews.php';
6
-if( !(new GL_Plugin_Check_v3( __FILE__ ))->isValid() )return;
6
+if( !(new GL_Plugin_Check_v3( __FILE__ ))->isValid() ) {
7
+	return;
8
+}
7 9
 
8 10
 delete_option( GeminiLabs\SiteReviews\Database\OptionManager::databaseKey() );
9 11
 delete_option( 'widget_'.glsr()->id.'_site-reviews' );
Please login to merge, or discard this patch.
plugin/Modules/Rating.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,9 @@
 block discarded – undo
90 90
 	{
91 91
 		$total = array_sum( $ratingCounts );
92 92
 		foreach( $ratingCounts as $index => $count ) {
93
-			if( empty( $count ))continue;
93
+			if( empty( $count )) {
94
+				continue;
95
+			}
94 96
 			$ratingCounts[$index] = $count / $total * 100;
95 97
 		}
96 98
 		return $this->getRoundedPercentages( $ratingCounts );
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -49,9 +49,9 @@  discard block
 block discarded – undo
49 49
 	{
50 50
 		$average = array_sum( $ratingCounts );
51 51
 		if( $average > 0 ) {
52
-			$average = round( $this->getTotalSum( $ratingCounts ) / $average, intval( $roundBy ));
52
+			$average = round( $this->getTotalSum( $ratingCounts ) / $average, intval( $roundBy ) );
53 53
 		}
54
-		return floatval( apply_filters( 'site-reviews/rating/average', $average, $ratingCounts ));
54
+		return floatval( apply_filters( 'site-reviews/rating/average', $average, $ratingCounts ) );
55 55
 	}
56 56
 
57 57
 	/**
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 		}
73 73
 		$z = static::CONFIDENCE_LEVEL_Z_SCORES[$confidencePercentage];
74 74
 		$phat = 1 * $upDownCounts[1] / $numRatings;
75
-		return ( $phat + $z * $z / ( 2 * $numRatings ) - $z * sqrt(( $phat * ( 1 - $phat ) + $z * $z / ( 4 * $numRatings )) / $numRatings )) / ( 1 + $z * $z / $numRatings );
75
+		return ($phat + $z * $z / (2 * $numRatings) - $z * sqrt( ($phat * (1 - $phat) + $z * $z / (4 * $numRatings)) / $numRatings )) / (1 + $z * $z / $numRatings);
76 76
 	}
77 77
 
78 78
 	/**
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	{
91 91
 		$total = array_sum( $ratingCounts );
92 92
 		foreach( $ratingCounts as $index => $count ) {
93
-			if( empty( $count ))continue;
93
+			if( empty($count) )continue;
94 94
 			$ratingCounts[$index] = $count / $total * 100;
95 95
 		}
96 96
 		return $this->getRoundedPercentages( $ratingCounts );
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 			$this->getRankingUsingImdb( $ratingCounts ),
106 106
 			$ratingCounts,
107 107
 			$this
108
-		));
108
+		) );
109 109
 	}
110 110
 
111 111
 	/**
@@ -123,12 +123,12 @@  discard block
 block discarded – undo
123 123
 		$avgRating = $this->getAverage( $ratingCounts );
124 124
 		// Represents a prior (your prior opinion without data) for the average star rating. A higher prior also means a higher margin for error.
125 125
 		// This could also be the average score of all items instead of a fixed value.
126
-		$bayesMean = ( $confidencePercentage / 100 ) * glsr()->constant( 'MAX_RATING' ); // prior, 70% = 3.5
126
+		$bayesMean = ($confidencePercentage / 100) * glsr()->constant( 'MAX_RATING' ); // prior, 70% = 3.5
127 127
 		// Represents the number of ratings expected to begin observing a pattern that would put confidence in the prior.
128 128
 		$bayesMinimal = 10; // confidence
129 129
 		$numOfReviews = array_sum( $ratingCounts );
130 130
 		return $avgRating > 0
131
-			? (( $bayesMinimal * $bayesMean ) + ( $avgRating * $numOfReviews )) / ( $bayesMinimal + $numOfReviews )
131
+			? (($bayesMinimal * $bayesMean) + ($avgRating * $numOfReviews)) / ($bayesMinimal + $numOfReviews)
132 132
 			: 0;
133 133
 	}
134 134
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 		$weight = $this->getWeight( $ratingCounts, $ratingCountsSum );
149 149
 		$weightPow2 = $this->getWeight( $ratingCounts, $ratingCountsSum, true );
150 150
 		$zScore = static::CONFIDENCE_LEVEL_Z_SCORES[$confidencePercentage];
151
-		return $weight - $zScore * sqrt(( $weightPow2 - pow( $weight, 2 )) / ( $ratingCountsSum + 1 ));
151
+		return $weight - $zScore * sqrt( ($weightPow2 - pow( $weight, 2 )) / ($ratingCountsSum + 1) );
152 152
 	}
153 153
 
154 154
 	/**
@@ -168,14 +168,14 @@  discard block
 block discarded – undo
168 168
 		$remainders = glsr_array_column( $percentages, 'remainder' );
169 169
 		array_multisort( $remainders, SORT_DESC, SORT_STRING, $indexes, SORT_DESC, $percentages );
170 170
 		$i = 0;
171
-		if( array_sum( glsr_array_column( $percentages, 'percent' )) > 0 ) {
172
-			while( array_sum( glsr_array_column( $percentages, 'percent' )) < $totalPercent ) {
171
+		if( array_sum( glsr_array_column( $percentages, 'percent' ) ) > 0 ) {
172
+			while( array_sum( glsr_array_column( $percentages, 'percent' ) ) < $totalPercent ) {
173 173
 				$percentages[$i]['percent']++;
174 174
 				$i++;
175 175
 			}
176 176
 		}
177 177
 		array_multisort( $indexes, SORT_DESC, $percentages );
178
-		return array_combine( $indexes, glsr_array_column( $percentages, 'percent' ));
178
+		return array_combine( $indexes, glsr_array_column( $percentages, 'percent' ) );
179 179
 	}
180 180
 
181 181
 	/**
@@ -183,8 +183,8 @@  discard block
 block discarded – undo
183 183
 	 */
184 184
 	protected function getTotalSum( array $ratingCounts )
185 185
 	{
186
-		return array_reduce( array_keys( $ratingCounts ), function( $carry, $index ) use( $ratingCounts ) {
187
-			return $carry + ( $index * $ratingCounts[$index] );
186
+		return array_reduce( array_keys( $ratingCounts ), function( $carry, $index ) use($ratingCounts) {
187
+			return $carry + ($index * $ratingCounts[$index]);
188 188
 		});
189 189
 	}
190 190
 
@@ -196,11 +196,11 @@  discard block
 block discarded – undo
196 196
 	protected function getWeight( array $ratingCounts, $ratingCountsSum, $powerOf2 = false )
197 197
 	{
198 198
 		return array_reduce( array_keys( $ratingCounts ),
199
-			function( $count, $rating ) use( $ratingCounts, $ratingCountsSum, $powerOf2 ) {
199
+			function( $count, $rating ) use($ratingCounts, $ratingCountsSum, $powerOf2) {
200 200
 				$ratingLevel = $powerOf2
201 201
 					? pow( $rating, 2 )
202 202
 					: $rating;
203
-				return $count + ( $ratingLevel * ( $ratingCounts[$rating] + 1 )) / $ratingCountsSum;
203
+				return $count + ($ratingLevel * ($ratingCounts[$rating] + 1)) / $ratingCountsSum;
204 204
 			}
205 205
 		);
206 206
 	}
Please login to merge, or discard this patch.
plugin/Modules/Html/Builder.php 2 patches
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,7 +81,9 @@  discard block
 block discarded – undo
81 81
 		];
82 82
 		if( !isset( $properties[$property] )
83 83
 			|| empty( array_filter( [$value], $properties[$property] ))
84
-		)return;
84
+		) {
85
+			return;
86
+		}
85 87
 		$this->$property = $value;
86 88
 	}
87 89
 
@@ -90,7 +92,9 @@  discard block
 block discarded – undo
90 92
 	 */
91 93
 	public function getClosingTag()
92 94
 	{
93
-		if( empty( $this->tag ))return;
95
+		if( empty( $this->tag )) {
96
+			return;
97
+		}
94 98
 		return '</'.$this->tag.'>';
95 99
 	}
96 100
 
@@ -99,7 +103,9 @@  discard block
 block discarded – undo
99 103
 	 */
100 104
 	public function getOpeningTag()
101 105
 	{
102
-		if( empty( $this->tag ))return;
106
+		if( empty( $this->tag )) {
107
+			return;
108
+		}
103 109
 		$attributes = glsr( Attributes::class )->{$this->tag}( $this->args )->toString();
104 110
 		return '<'.trim( $this->tag.' '.$attributes ).'>';
105 111
 	}
@@ -141,7 +147,9 @@  discard block
 block discarded – undo
141 147
 	 */
142 148
 	protected function buildFieldDescription()
143 149
 	{
144
-		if( empty( $this->args['description'] ))return;
150
+		if( empty( $this->args['description'] )) {
151
+			return;
152
+		}
145 153
 		if( $this->args['is_widget'] ) {
146 154
 			return $this->small( $this->args['description'] );
147 155
 		}
@@ -207,7 +215,9 @@  discard block
 block discarded – undo
207 215
 	 */
208 216
 	protected function buildFormLabel( array $customArgs = [] )
209 217
 	{
210
-		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' )return;
218
+		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' ) {
219
+			return;
220
+		}
211 221
 		return $this->label( wp_parse_args( $customArgs, [
212 222
 			'for' => $this->args['id'],
213 223
 			'is_public' => $this->args['is_public'],
Please login to merge, or discard this patch.
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	{
67 67
 		$instance = new static;
68 68
 		$instance->setTagFromMethod( $method );
69
-		call_user_func_array( [$instance, 'normalize'], $args += ['',''] );
69
+		call_user_func_array( [$instance, 'normalize'], $args += ['', ''] );
70 70
 		$tags = array_merge( static::TAGS_FORM, static::TAGS_SINGLE, static::TAGS_STRUCTURE, static::TAGS_TEXT );
71 71
 		do_action_ref_array( 'site-reviews/builder', [$instance] );
72 72
 		$generatedTag = in_array( $instance->tag, $tags )
@@ -91,8 +91,8 @@  discard block
 block discarded – undo
91 91
 			'render' => 'is_bool',
92 92
 			'tag' => 'is_string',
93 93
 		];
94
-		if( !isset( $properties[$property] )
95
-			|| empty( array_filter( [$value], $properties[$property] ))
94
+		if( !isset($properties[$property])
95
+			|| empty(array_filter( [$value], $properties[$property] ))
96 96
 		)return;
97 97
 		$this->$property = $value;
98 98
 	}
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	public function getClosingTag()
104 104
 	{
105
-		if( empty( $this->tag ))return;
105
+		if( empty($this->tag) )return;
106 106
 		return '</'.$this->tag.'>';
107 107
 	}
108 108
 
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
 	 */
112 112
 	public function getOpeningTag()
113 113
 	{
114
-		if( empty( $this->tag ))return;
115
-		$attributes = glsr( Attributes::class )->{$this->tag}( $this->args )->toString();
114
+		if( empty($this->tag) )return;
115
+		$attributes = glsr( Attributes::class )->{$this->tag}($this->args)->toString();
116 116
 		return '<'.trim( $this->tag.' '.$attributes ).'>';
117 117
 	}
118 118
 
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 	 */
122 122
 	public function getTag()
123 123
 	{
124
-		if( in_array( $this->tag, static::TAGS_SINGLE )) {
124
+		if( in_array( $this->tag, static::TAGS_SINGLE ) ) {
125 125
 			return $this->getOpeningTag();
126 126
 		}
127
-		if( !in_array( $this->tag, static::TAGS_FORM )) {
127
+		if( !in_array( $this->tag, static::TAGS_FORM ) ) {
128 128
 			return $this->buildDefaultTag();
129 129
 		}
130 130
 		return call_user_func( [$this, 'buildForm'.ucfirst( $this->tag )] ).$this->buildFieldDescription();
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
135 135
 	 */
136 136
 	public function raw( array $field )
137 137
 	{
138
-		unset( $field['label'] );
139
-		return $this->{$field['type']}( $field );
138
+		unset($field['label']);
139
+		return $this->{$field['type']}($field);
140 140
 	}
141 141
 
142 142
 	/**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	protected function buildCustomField()
146 146
 	{
147 147
 		$className = $this->getCustomFieldClassName();
148
-		if( class_exists( $className )) {
148
+		if( class_exists( $className ) ) {
149 149
 			return (new $className( $this ))->build();
150 150
 		}
151 151
 		glsr_log()->error( 'Field missing: '.$className );
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 	 */
157 157
 	protected function buildDefaultTag( $text = '' )
158 158
 	{
159
-		if( empty( $text )) {
159
+		if( empty($text) ) {
160 160
 			$text = $this->args['text'];
161 161
 		}
162 162
 		return $this->getOpeningTag().$text.$this->getClosingTag();
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	protected function buildFieldDescription()
169 169
 	{
170
-		if( empty( $this->args['description'] ))return;
170
+		if( empty($this->args['description']) )return;
171 171
 		if( $this->args['is_widget'] ) {
172 172
 			return $this->small( $this->args['description'] );
173 173
 		}
@@ -179,13 +179,13 @@  discard block
 block discarded – undo
179 179
 	 */
180 180
 	protected function buildFormInput()
181 181
 	{
182
-		if( !in_array( $this->args['type'], ['checkbox', 'radio'] )) {
183
-			if( isset( $this->args['multiple'] )) {
184
-				$this->args['name'].= '[]';
182
+		if( !in_array( $this->args['type'], ['checkbox', 'radio'] ) ) {
183
+			if( isset($this->args['multiple']) ) {
184
+				$this->args['name'] .= '[]';
185 185
 			}
186 186
 			return $this->buildFormLabel().$this->getOpeningTag();
187 187
 		}
188
-		return empty( $this->args['options'] )
188
+		return empty($this->args['options'])
189 189
 			? $this->buildFormInputChoice()
190 190
 			: $this->buildFormInputMultiChoice();
191 191
 	}
@@ -195,19 +195,19 @@  discard block
 block discarded – undo
195 195
 	 */
196 196
 	protected function buildFormInputChoice()
197 197
 	{
198
-		if( !empty( $this->args['text'] )) {
198
+		if( !empty($this->args['text']) ) {
199 199
 			$this->args['label'] = $this->args['text'];
200 200
 		}
201 201
 		if( !$this->args['is_public'] ) {
202
-			return $this->buildFormLabel([
202
+			return $this->buildFormLabel( [
203 203
 				'class' => 'glsr-'.$this->args['type'].'-label',
204 204
 				'text' => $this->getOpeningTag().' '.$this->args['label'].'<span></span>',
205
-			]);
205
+			] );
206 206
 		}
207
-		return $this->getOpeningTag().$this->buildFormLabel([
207
+		return $this->getOpeningTag().$this->buildFormLabel( [
208 208
 			'class' => 'glsr-'.$this->args['type'].'-label',
209 209
 			'text' => $this->args['label'].'<span></span>',
210
-		]);
210
+		] );
211 211
 	}
212 212
 
213 213
 	/**
@@ -216,22 +216,22 @@  discard block
 block discarded – undo
216 216
 	protected function buildFormInputMultiChoice()
217 217
 	{
218 218
 		if( $this->args['type'] == 'checkbox' ) {
219
-			$this->args['name'].= '[]';
219
+			$this->args['name'] .= '[]';
220 220
 		}
221 221
 		$index = 0;
222
-		$options = array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) use( &$index ) {
222
+		$options = array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) use(&$index) {
223 223
 			return $carry.$this->li( $this->{$this->args['type']}([
224 224
 				'checked' => in_array( $key, (array)$this->args['value'] ),
225 225
 				'id' => $this->args['id'].'-'.$index++,
226 226
 				'name' => $this->args['name'],
227 227
 				'text' => $this->args['options'][$key],
228 228
 				'value' => $key,
229
-			]));
229
+			]) );
230 230
 		});
231 231
 		return $this->ul( $options, [
232 232
 			'class' => $this->args['class'],
233 233
 			'id' => $this->args['id'],
234
-		]);
234
+		] );
235 235
 	}
236 236
 
237 237
 	/**
@@ -239,13 +239,13 @@  discard block
 block discarded – undo
239 239
 	 */
240 240
 	protected function buildFormLabel( array $customArgs = [] )
241 241
 	{
242
-		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' )return;
242
+		if( empty($this->args['label']) || $this->args['type'] == 'hidden' )return;
243 243
 		return $this->label( wp_parse_args( $customArgs, [
244 244
 			'for' => $this->args['id'],
245 245
 			'is_public' => $this->args['is_public'],
246 246
 			'text' => $this->args['label'],
247 247
 			'type' => $this->args['type'],
248
-		]));
248
+		] ) );
249 249
 	}
250 250
 
251 251
 	/**
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
262 262
 	protected function buildFormSelectOptions()
263 263
 	{
264 264
 		return array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) {
265
-			return $carry.$this->option([
265
+			return $carry.$this->option( [
266 266
 				'selected' => $this->args['value'] == $key,
267 267
 				'text' => $this->args['options'][$key],
268 268
 				'value' => $key,
269
-			]);
269
+			] );
270 270
 		});
271 271
 	}
272 272
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	protected function mergeArgsWithRequiredDefaults()
303 303
 	{
304 304
 		$className = $this->getCustomFieldClassName();
305
-		if( class_exists( $className )) {
305
+		if( class_exists( $className ) ) {
306 306
 			$this->args = $className::merge( $this->args );
307 307
 		}
308 308
 		$this->args = glsr( BuilderDefaults::class )->merge( $this->args );
@@ -314,16 +314,16 @@  discard block
 block discarded – undo
314 314
 	 */
315 315
 	protected function normalize( ...$params )
316 316
 	{
317
-		if( is_string( $params[0] ) || is_numeric( $params[0] )) {
317
+		if( is_string( $params[0] ) || is_numeric( $params[0] ) ) {
318 318
 			$this->setNameOrTextAttributeForTag( $params[0] );
319 319
 		}
320
-		if( is_array( $params[0] )) {
320
+		if( is_array( $params[0] ) ) {
321 321
 			$this->args += $params[0];
322 322
 		}
323
-		else if( is_array( $params[1] )) {
323
+		else if( is_array( $params[1] ) ) {
324 324
 			$this->args += $params[1];
325 325
 		}
326
-		if( !isset( $this->args['is_public'] )) {
326
+		if( !isset($this->args['is_public']) ) {
327 327
 			$this->args['is_public'] = false;
328 328
 		}
329 329
 	}
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 	protected function setTagFromMethod( $method )
348 348
 	{
349 349
 		$this->tag = strtolower( $method );
350
-		if( in_array( $this->tag, static::INPUT_TYPES )) {
350
+		if( in_array( $this->tag, static::INPUT_TYPES ) ) {
351 351
 			$this->args['type'] = $this->tag;
352 352
 			$this->tag = 'input';
353 353
 		}
Please login to merge, or discard this patch.
plugin/Modules/Validator.php 2 patches
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -93,7 +93,9 @@  discard block
 block discarded – undo
93 93
 		foreach( $this->rules as $attribute => $rules ) {
94 94
 			foreach( $rules as $rule ) {
95 95
 				$this->validateAttribute( $attribute, $rule );
96
-				if( $this->shouldStopValidating( $attribute ))break;
96
+				if( $this->shouldStopValidating( $attribute )) {
97
+					break;
98
+				}
97 99
 			}
98 100
 		}
99 101
 		return $this->errors;
@@ -109,7 +111,9 @@  discard block
 block discarded – undo
109 111
 	public function validateAttribute( $attribute, $rule )
110 112
 	{
111 113
 		list( $rule, $parameters ) = $this->parseRule( $rule );
112
-		if( $rule == '' )return;
114
+		if( $rule == '' ) {
115
+			return;
116
+		}
113 117
 		$value = $this->getValue( $attribute );
114 118
 		if( !method_exists( $this, $method = 'validate'.$rule )) {
115 119
 			throw new BadMethodCallException( "Method [$method] does not exist." );
@@ -178,7 +182,9 @@  discard block
 block discarded – undo
178 182
 	 */
179 183
 	protected function getRule( $attribute, $rules )
180 184
 	{
181
-		if( !array_key_exists( $attribute, $this->rules ))return;
185
+		if( !array_key_exists( $attribute, $this->rules )) {
186
+			return;
187
+		}
182 188
 		$rules = (array)$rules;
183 189
 		foreach( $this->rules[$attribute] as $rule ) {
184 190
 			list( $rule, $parameters ) = $this->parseRule( $rule );
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 		foreach( $this->rules as $attribute => $rules ) {
75 75
 			foreach( $rules as $rule ) {
76 76
 				$this->validateAttribute( $attribute, $rule );
77
-				if( $this->shouldStopValidating( $attribute ))break;
77
+				if( $this->shouldStopValidating( $attribute ) )break;
78 78
 			}
79 79
 		}
80 80
 		return $this->errors;
@@ -89,13 +89,13 @@  discard block
 block discarded – undo
89 89
 	 */
90 90
 	public function validateAttribute( $attribute, $rule )
91 91
 	{
92
-		list( $rule, $parameters ) = $this->parseRule( $rule );
92
+		list($rule, $parameters) = $this->parseRule( $rule );
93 93
 		if( $rule == '' )return;
94 94
 		$value = $this->getValue( $attribute );
95
-		if( !method_exists( $this, $method = 'validate'.$rule )) {
95
+		if( !method_exists( $this, $method = 'validate'.$rule ) ) {
96 96
 			throw new BadMethodCallException( "Method [$method] does not exist." );
97 97
 		}
98
-		if( !$this->$method( $value, $attribute, $parameters )) {
98
+		if( !$this->$method( $value, $attribute, $parameters ) ) {
99 99
 			$this->addFailure( $attribute, $rule, $parameters );
100 100
 		}
101 101
 	}
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	protected function getMessage( $attribute, $rule, array $parameters )
146 146
 	{
147
-		if( in_array( $rule, $this->sizeRules )) {
147
+		if( in_array( $rule, $this->sizeRules ) ) {
148 148
 			return $this->getSizeMessage( $attribute, $rule, $parameters );
149 149
 		}
150 150
 		$lowerRule = glsr( Helper::class )->snakeCase( $rule );
@@ -159,11 +159,11 @@  discard block
 block discarded – undo
159 159
 	 */
160 160
 	protected function getRule( $attribute, $rules )
161 161
 	{
162
-		if( !array_key_exists( $attribute, $this->rules ))return;
162
+		if( !array_key_exists( $attribute, $this->rules ) )return;
163 163
 		$rules = (array)$rules;
164 164
 		foreach( $this->rules[$attribute] as $rule ) {
165
-			list( $rule, $parameters ) = $this->parseRule( $rule );
166
-			if( in_array( $rule, $rules )) {
165
+			list($rule, $parameters) = $this->parseRule( $rule );
166
+			if( in_array( $rule, $rules ) ) {
167 167
 				return [$rule, $parameters];
168 168
 			}
169 169
 		}
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 		if( is_numeric( $value ) && $hasNumeric ) {
182 182
 			return $value;
183 183
 		}
184
-		else if( is_array( $value )) {
184
+		else if( is_array( $value ) ) {
185 185
 			return count( $value );
186 186
 		}
187 187
 		return function_exists( 'mb_strlen' )
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 	 */
210 210
 	protected function getValue( $attribute )
211 211
 	{
212
-		if( isset( $this->data[$attribute] )) {
212
+		if( isset($this->data[$attribute]) ) {
213 213
 			return $this->data[$attribute];
214 214
 		}
215 215
 	}
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	 */
223 223
 	protected function hasRule( $attribute, $rules )
224 224
 	{
225
-		return !is_null( $this->getRule( $attribute, $rules ));
225
+		return !is_null( $this->getRule( $attribute, $rules ) );
226 226
 	}
227 227
 
228 228
 	/**
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
 	{
261 261
 		$parameters = [];
262 262
 		if( strpos( $rule, ':' ) !== false ) {
263
-			list( $rule, $parameter ) = explode( ':', $rule, 2 );
263
+			list($rule, $parameter) = explode( ':', $rule, 2 );
264 264
 			$parameters = $this->parseParameters( $rule, $parameter );
265 265
 		}
266 266
 		$rule = glsr( Helper::class )->camelCase( $rule );
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
 	protected function shouldStopValidating( $attribute )
290 290
 	{
291 291
 		return $this->hasRule( $attribute, $this->implicitRules )
292
-			&& isset( $this->failedRules[$attribute] )
292
+			&& isset($this->failedRules[$attribute])
293 293
 			&& array_intersect( array_keys( $this->failedRules[$attribute] ), $this->implicitRules );
294 294
 	}
295 295
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	protected function translator( $key, array $parameters )
303 303
 	{
304 304
 		$strings = glsr( ValidationStringsDefaults::class )->defaults();
305
-		if( isset( $strings[$key] )) {
305
+		if( isset($strings[$key]) ) {
306 306
 			return $this->replace( $strings[$key], $parameters );
307 307
 		}
308 308
 		return "error";
Please login to merge, or discard this patch.
plugin/Modules/Validator/ValidationRules.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 		if( strpos( $message, '%s' ) === false ) {
29 29
 			return $message;
30 30
 		}
31
-		return preg_replace_callback( '/(%s)/', function() use( &$parameters ) {
31
+		return preg_replace_callback( '/(%s)/', function() use(&$parameters) {
32 32
 			foreach( $parameters as $key => $value ) {
33 33
 				return array_shift( $parameters );
34 34
 			}
@@ -113,8 +113,8 @@  discard block
 block discarded – undo
113 113
 	public function validateRequired( $value )
114 114
 	{
115 115
 		return is_null( $value )
116
-			|| ( is_string( $value ) && trim( $value ) === '' )
117
-			|| ( is_array( $value ) && count( $value ) < 1 )
116
+			|| (is_string( $value ) && trim( $value ) === '')
117
+			|| (is_array( $value ) && count( $value ) < 1)
118 118
 			? false
119 119
 			: true;
120 120
 	}
Please login to merge, or discard this patch.
plugin/Modules/Blacklist.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
 	 */
12 12
 	public function isBlacklisted( array $review )
13 13
 	{
14
-		$target = implode( "\n", array_filter([
14
+		$target = implode( "\n", array_filter( [
15 15
 			$review['name'],
16 16
 			$review['content'],
17 17
 			$review['email'],
18 18
 			$review['ip_address'],
19 19
 			$review['title'],
20
-		]));
20
+		] ) );
21 21
 		return (bool)apply_filters( 'site-reviews/blacklist/is-blacklisted',
22 22
 			$this->check( $target ),
23 23
 			$review
@@ -30,16 +30,16 @@  discard block
 block discarded – undo
30 30
 	 */
31 31
 	protected function check( $target )
32 32
 	{
33
-		$blacklist = trim( glsr( OptionManager::class )->get( 'settings.submissions.blacklist.entries' ));
34
-		if( empty( $blacklist )) {
33
+		$blacklist = trim( glsr( OptionManager::class )->get( 'settings.submissions.blacklist.entries' ) );
34
+		if( empty($blacklist) ) {
35 35
 			return false;
36 36
 		}
37 37
 		$lines = explode( "\n", $blacklist );
38 38
 		foreach( (array)$lines as $line ) {
39 39
 			$line = trim( $line );
40
-			if( empty( $line ) || 256 < strlen( $line ))continue;
41
-			$pattern = sprintf( '#%s#i', preg_quote( $line, '#' ));
42
-			if( preg_match( $pattern, $target )) {
40
+			if( empty($line) || 256 < strlen( $line ) )continue;
41
+			$pattern = sprintf( '#%s#i', preg_quote( $line, '#' ) );
42
+			if( preg_match( $pattern, $target ) ) {
43 43
 				return true;
44 44
 			}
45 45
 		}
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,9 @@
 block discarded – undo
37 37
 		$lines = explode( "\n", $blacklist );
38 38
 		foreach( (array)$lines as $line ) {
39 39
 			$line = trim( $line );
40
-			if( empty( $line ) || 256 < strlen( $line ))continue;
40
+			if( empty( $line ) || 256 < strlen( $line )) {
41
+				continue;
42
+			}
41 43
 			$pattern = sprintf( '#%s#i', preg_quote( $line, '#' ));
42 44
 			if( preg_match( $pattern, $target )) {
43 45
 				return true;
Please login to merge, or discard this patch.
plugin/Defaults/DefaultsAbstract.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,9 @@
 block discarded – undo
13 13
 	 */
14 14
 	public function __call( $name, array $args = [] )
15 15
 	{
16
-		if( !method_exists( $this, $name ))return;
16
+		if( !method_exists( $this, $name )) {
17
+			return;
18
+		}
17 19
 		$defaults = call_user_func_array( [$this, $name], $args );
18 20
 		$hookName = (new ReflectionClass( $this ))->getShortName();
19 21
 		$hookName = str_replace( 'Defaults', '', $hookName );
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 	 */
14 14
 	public function __call( $name, array $args = [] )
15 15
 	{
16
-		if( !method_exists( $this, $name ))return;
16
+		if( !method_exists( $this, $name ) )return;
17 17
 		$defaults = call_user_func_array( [$this, $name], $args );
18 18
 		$hookName = (new ReflectionClass( $this ))->getShortName();
19 19
 		$hookName = str_replace( 'Defaults', '', $hookName );
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	 */
32 32
 	protected function filter( array $values = [] )
33 33
 	{
34
-		return $this->merge( array_filter( $values ));
34
+		return $this->merge( array_filter( $values ) );
35 35
 	}
36 36
 
37 37
 	/**
Please login to merge, or discard this patch.
plugin/Database/QueryBuilder.php 2 patches
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -17,9 +17,13 @@  discard block
 block discarded – undo
17 17
 	{
18 18
 		$queries = [];
19 19
 		foreach( $keys as $key ) {
20
-			if( !array_key_exists( $key, $values ))continue;
20
+			if( !array_key_exists( $key, $values )) {
21
+				continue;
22
+			}
21 23
 			$methodName = glsr( Helper::class )->buildMethodName( $key, __FUNCTION__ );
22
-			if( !method_exists( $this, $methodName ))continue;
24
+			if( !method_exists( $this, $methodName )) {
25
+				continue;
26
+			}
23 27
 			$query = call_user_func( [$this, $methodName], $values[$key] );
24 28
 			if( is_array( $query )) {
25 29
 				$queries[] = $query;
@@ -36,7 +40,9 @@  discard block
 block discarded – undo
36 40
 		$string = '';
37 41
 		$values = array_filter( $values );
38 42
 		foreach( $conditions as $key => $value ) {
39
-			if( !isset( $values[$key] ))continue;
43
+			if( !isset( $values[$key] )) {
44
+				continue;
45
+			}
40 46
 			$values[$key] = implode( ',', (array)$values[$key] );
41 47
 			$string .= strpos( $value, '%s' ) !== false
42 48
 				? sprintf( $value, strval( $values[$key] ))
@@ -110,7 +116,9 @@  discard block
 block discarded – undo
110 116
 	 */
111 117
 	protected function buildQueryAssignedTo( $value )
112 118
 	{
113
-		if( empty( $value ))return;
119
+		if( empty( $value )) {
120
+			return;
121
+		}
114 122
 		$postIds = glsr( Helper::class )->convertStringToArray( $value, 'is_numeric' );
115 123
 		return [
116 124
 			'compare' => 'IN',
@@ -125,7 +133,9 @@  discard block
 block discarded – undo
125 133
 	 */
126 134
 	protected function buildQueryCategory( $value )
127 135
 	{
128
-		if( empty( $value ))return;
136
+		if( empty( $value )) {
137
+			return;
138
+		}
129 139
 		return [
130 140
 			'field' => 'term_id',
131 141
 			'taxonomy' => Application::TAXONOMY,
@@ -139,7 +149,9 @@  discard block
 block discarded – undo
139 149
 	 */
140 150
 	protected function buildQueryRating( $value )
141 151
 	{
142
-		if( !is_numeric( $value ) || !in_array( intval( $value ), range( 1, 5 )))return;
152
+		if( !is_numeric( $value ) || !in_array( intval( $value ), range( 1, 5 ))) {
153
+			return;
154
+		}
143 155
 		return [
144 156
 			'compare' => '>=',
145 157
 			'key' => 'rating',
@@ -153,7 +165,9 @@  discard block
 block discarded – undo
153 165
 	 */
154 166
 	protected function buildQueryType( $value )
155 167
 	{
156
-		if( in_array( $value, ['','all'] ))return;
168
+		if( in_array( $value, ['','all'] )) {
169
+			return;
170
+		}
157 171
 		return [
158 172
 			'key' => 'review_type',
159 173
 			'value' => $value,
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -17,11 +17,11 @@  discard block
 block discarded – undo
17 17
 	{
18 18
 		$queries = [];
19 19
 		foreach( $keys as $key ) {
20
-			if( !array_key_exists( $key, $values ))continue;
20
+			if( !array_key_exists( $key, $values ) )continue;
21 21
 			$methodName = glsr( Helper::class )->buildMethodName( $key, __FUNCTION__ );
22
-			if( !method_exists( $this, $methodName ))continue;
22
+			if( !method_exists( $this, $methodName ) )continue;
23 23
 			$query = call_user_func( [$this, $methodName], $values[$key] );
24
-			if( is_array( $query )) {
24
+			if( is_array( $query ) ) {
25 25
 				$queries[] = $query;
26 26
 			}
27 27
 		}
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
 		$string = '';
37 37
 		$values = array_filter( $values );
38 38
 		foreach( $conditions as $key => $value ) {
39
-			if( !isset( $values[$key] ))continue;
39
+			if( !isset($values[$key]) )continue;
40 40
 			$values[$key] = implode( ',', (array)$values[$key] );
41 41
 			$string .= strpos( $value, '%s' ) !== false
42
-				? sprintf( $value, strval( $values[$key] ))
42
+				? sprintf( $value, strval( $values[$key] ) )
43 43
 				: $value;
44 44
 		}
45 45
 		return $string;
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
53 53
 	 */
54 54
 	public function buildSqlOr( $values, $sprintfFormat )
55 55
 	{
56
-		if( !is_array( $values )) {
56
+		if( !is_array( $values ) ) {
57 57
 			$values = explode( ',', $values );
58 58
 		}
59
-		$values = array_filter( array_map( 'trim', (array)$values ));
60
-		$values = array_map( function( $value ) use( $sprintfFormat ) {
59
+		$values = array_filter( array_map( 'trim', (array)$values ) );
60
+		$values = array_map( function( $value ) use($sprintfFormat) {
61 61
 			return sprintf( $sprintfFormat, $value );
62 62
 		}, $values );
63 63
 		return implode( ' OR ', $values );
@@ -72,11 +72,11 @@  discard block
 block discarded – undo
72 72
 	 */
73 73
 	public function filterSearchByTitle( $search, WP_Query $query )
74 74
 	{
75
-		if( empty( $search ) || empty( $query->get( 'search_terms' ))) {
75
+		if( empty($search) || empty($query->get( 'search_terms' )) ) {
76 76
 			return $search;
77 77
 		}
78 78
 		global $wpdb;
79
-		$n = empty( $query->get( 'exact' ))
79
+		$n = empty($query->get( 'exact' ))
80 80
 			? '%'
81 81
 			: '';
82 82
 		$search = [];
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 			? glsr()->constant( 'PAGED_QUERY_VAR' )
101 101
 			: 'page';
102 102
 		return $isEnabled
103
-			? max( 1, intval( get_query_var( $pagedQuery )))
103
+			? max( 1, intval( get_query_var( $pagedQuery ) ) )
104 104
 			: 1;
105 105
 	}
106 106
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	 */
111 111
 	protected function buildQueryAssignedTo( $value )
112 112
 	{
113
-		if( empty( $value ))return;
113
+		if( empty($value) )return;
114 114
 		$postIds = glsr( Helper::class )->convertStringToArray( $value, 'is_numeric' );
115 115
 		return [
116 116
 			'compare' => 'IN',
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 	 */
126 126
 	protected function buildQueryCategory( $value )
127 127
 	{
128
-		if( empty( $value ))return;
128
+		if( empty($value) )return;
129 129
 		return [
130 130
 			'field' => 'term_id',
131 131
 			'taxonomy' => Application::TAXONOMY,
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	 */
140 140
 	protected function buildQueryRating( $value )
141 141
 	{
142
-		if( !is_numeric( $value ) || !in_array( intval( $value ), range( 1, 5 )))return;
142
+		if( !is_numeric( $value ) || !in_array( intval( $value ), range( 1, 5 ) ) )return;
143 143
 		return [
144 144
 			'compare' => '>=',
145 145
 			'key' => 'rating',
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 */
154 154
 	protected function buildQueryType( $value )
155 155
 	{
156
-		if( in_array( $value, ['','all'] ))return;
156
+		if( in_array( $value, ['', 'all'] ) )return;
157 157
 		return [
158 158
 			'key' => 'review_type',
159 159
 			'value' => $value,
Please login to merge, or discard this patch.