Passed
Push — hotfix/fix-counts ( bd8a94 )
by Paul
05:00
created
plugin/Shortcodes/TinymcePopupGenerator.php 2 patches
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -56,9 +56,13 @@  discard block
 block discarded – undo
56 56
 	protected function generateFields( array $fields )
57 57
 	{
58 58
 		$generatedFields = array_map( function( $field ) {
59
-			if( empty( $field ))return;
59
+			if( empty( $field )) {
60
+				return;
61
+			}
60 62
 			$field = $this->normalize( $field );
61
-			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] )))return;
63
+			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] ))) {
64
+				return;
65
+			}
62 66
 			return $this->$method( $field );
63 67
 		}, $fields );
64 68
 		return array_values( array_filter( $generatedFields ));
@@ -73,7 +77,9 @@  discard block
 block discarded – undo
73 77
 		if( !empty( $this->errors )) {
74 78
 			$errors = [];
75 79
 			foreach( $this->required as $name => $alert ) {
76
-				if( false !== array_search( $name, glsr_array_column( $fields, 'name' )))continue;
80
+				if( false !== array_search( $name, glsr_array_column( $fields, 'name' ))) {
81
+					continue;
82
+				}
77 83
 				$errors[] = $this->errors[$name];
78 84
 			}
79 85
 			$this->errors = $errors;
@@ -117,7 +123,9 @@  discard block
 block discarded – undo
117 123
 	 */
118 124
 	protected function normalizeContainer( array $field )
119 125
 	{
120
-		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ))return;
126
+		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field )) {
127
+			return;
128
+		}
121 129
 		$field['items'] = $this->generateFields( $field['items'] );
122 130
 		return $field;
123 131
 	}
@@ -127,7 +135,9 @@  discard block
 block discarded – undo
127 135
 	 */
128 136
 	protected function normalizeField( array $field, array $defaults )
129 137
 	{
130
-		if( !$this->validate( $field ))return;
138
+		if( !$this->validate( $field )) {
139
+			return;
140
+		}
131 141
 		return array_filter( shortcode_atts( $defaults, $field ), function( $value ) {
132 142
 			return $value !== '';
133 143
 		});
@@ -148,7 +158,9 @@  discard block
 block discarded – undo
148 158
 			'type' => '',
149 159
 			'value' => '',
150 160
 		]);
151
-		if( !is_array( $listbox ))return;
161
+		if( !is_array( $listbox )) {
162
+			return;
163
+		}
152 164
 		if( !array_key_exists( '', $listbox['options'] )) {
153 165
 			$listbox['options'] = ['' => $listbox['placeholder']] + $listbox['options'];
154 166
 		}
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 			'label' => '['.$tag.']',
49 49
 			'required' => $this->required,
50 50
 			'title' => esc_html__( 'Shortcode', 'site-reviews' ),
51
-		]);
51
+		] );
52 52
 		return $this;
53 53
 	}
54 54
 
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
 	protected function generateFields( array $fields )
59 59
 	{
60 60
 		$generatedFields = array_map( function( $field ) {
61
-			if( empty( $field ))return;
61
+			if( empty($field) )return;
62 62
 			$field = $this->normalize( $field );
63
-			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] )))return;
63
+			if( !method_exists( $this, $method = 'normalize'.ucfirst( $field['type'] ) ) )return;
64 64
 			return $this->$method( $field );
65 65
 		}, $fields );
66
-		return array_values( array_filter( $generatedFields ));
66
+		return array_values( array_filter( $generatedFields ) );
67 67
 	}
68 68
 
69 69
 	/**
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	protected function getCategories( $tooltip = '' )
74 74
 	{
75 75
 		$terms = glsr( Database::class )->getTerms();
76
-		if( empty( $terms )) {
76
+		if( empty($terms) ) {
77 77
 			return [];
78 78
 		}
79 79
 		return [
@@ -91,15 +91,15 @@  discard block
 block discarded – undo
91 91
 	protected function getFields()
92 92
 	{
93 93
 		$fields = $this->generateFields( $this->fields() );
94
-		if( !empty( $this->errors )) {
94
+		if( !empty($this->errors) ) {
95 95
 			$errors = [];
96 96
 			foreach( $this->required as $name => $alert ) {
97
-				if( false !== array_search( $name, glsr_array_column( $fields, 'name' )))continue;
97
+				if( false !== array_search( $name, glsr_array_column( $fields, 'name' ) ) )continue;
98 98
 				$errors[] = $this->errors[$name];
99 99
 			}
100 100
 			$this->errors = $errors;
101 101
 		}
102
-		return empty( $this->errors )
102
+		return empty($this->errors)
103 103
 			? $fields
104 104
 			: $this->errors;
105 105
 	}
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 */
110 110
 	protected function getHideOptions()
111 111
 	{
112
-		$classname = str_replace( 'Popup', 'Shortcode', get_class( $this ));
112
+		$classname = str_replace( 'Popup', 'Shortcode', get_class( $this ) );
113 113
 		$hideOptions = glsr( $classname )->getHideOptions();
114 114
 		$options = [];
115 115
 		foreach( $hideOptions as $name => $tooltip ) {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 		return wp_parse_args( $field, [
150 150
 			'items' => [],
151 151
 			'type' => '',
152
-		]);
152
+		] );
153 153
 	}
154 154
 
155 155
 	/**
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 			'tooltip' => '',
168 168
 			'type' => '',
169 169
 			'value' => '',
170
-		]);
170
+		] );
171 171
 	}
172 172
 
173 173
 	/**
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 */
176 176
 	protected function normalizeContainer( array $field )
177 177
 	{
178
-		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ))return;
178
+		if( !array_key_exists( 'html', $field ) && !array_key_exists( 'items', $field ) )return;
179 179
 		$field['items'] = $this->generateFields( $field['items'] );
180 180
 		return $field;
181 181
 	}
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	 */
186 186
 	protected function normalizeField( array $field, array $defaults )
187 187
 	{
188
-		if( !$this->validate( $field ))return;
188
+		if( !$this->validate( $field ) )return;
189 189
 		return array_filter( shortcode_atts( $defaults, $field ), function( $value ) {
190 190
 			return $value !== '';
191 191
 		});
@@ -205,9 +205,9 @@  discard block
 block discarded – undo
205 205
 			'tooltip' => '',
206 206
 			'type' => '',
207 207
 			'value' => '',
208
-		]);
209
-		if( !is_array( $listbox ))return;
210
-		if( !array_key_exists( '', $listbox['options'] )) {
208
+		] );
209
+		if( !is_array( $listbox ) )return;
210
+		if( !array_key_exists( '', $listbox['options'] ) ) {
211 211
 			$listbox['options'] = ['' => $listbox['placeholder']] + $listbox['options'];
212 212
 		}
213 213
 		foreach( $listbox['options'] as $value => $text ) {
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	protected function normalizePost( array $field )
226 226
 	{
227
-		if( !is_array( $field['query_args'] )) {
227
+		if( !is_array( $field['query_args'] ) ) {
228 228
 			$field['query_args'] = [];
229 229
 		}
230 230
 		$posts = get_posts( wp_parse_args( $field['query_args'], [
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
 			'orderby' => 'title',
233 233
 			'post_type' => 'post',
234 234
 			'posts_per_page' => 30,
235
-		]));
236
-		if( !empty( $posts )) {
235
+		] ) );
236
+		if( !empty($posts) ) {
237 237
 			$options = [];
238 238
 			foreach( $posts as $post ) {
239 239
 				$options[$post->ID] = esc_html( $post->post_title );
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 			'tooltip' => '',
264 264
 			'type' => '',
265 265
 			'value' => '',
266
-		]);
266
+		] );
267 267
 	}
268 268
 
269 269
 	/**
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 	 */
272 272
 	protected function validate( array $field )
273 273
 	{
274
-		$args = shortcode_atts([
274
+		$args = shortcode_atts( [
275 275
 			'label' => '',
276 276
 			'name' => false,
277 277
 			'required' => false,
@@ -287,13 +287,13 @@  discard block
 block discarded – undo
287 287
 	 */
288 288
 	protected function validateErrors( array $args )
289 289
 	{
290
-		if( !isset( $args['required']['error'] )) {
290
+		if( !isset($args['required']['error']) ) {
291 291
 			return true;
292 292
 		}
293
-		$this->errors[$args['name']] = $this->normalizeContainer([
293
+		$this->errors[$args['name']] = $this->normalizeContainer( [
294 294
 			'html' => $args['required']['error'],
295 295
 			'type' => 'container',
296
-		]);
296
+		] );
297 297
 		return false;
298 298
 	}
299 299
 
@@ -306,10 +306,10 @@  discard block
 block discarded – undo
306 306
 			return true;
307 307
 		}
308 308
 		$alert = esc_html__( 'Some of the shortcode options are required.', 'site-reviews' );
309
-		if( isset( $args['required']['alert'] )) {
309
+		if( isset($args['required']['alert']) ) {
310 310
 			$alert = $args['required']['alert'];
311 311
 		}
312
-		else if( !empty( $args['label'] )) {
312
+		else if( !empty($args['label']) ) {
313 313
 			$alert = sprintf(
314 314
 				esc_html_x( 'The "%s" option is required.', 'the option label', 'site-reviews' ),
315 315
 				str_replace( ':', '', $args['label'] )
Please login to merge, or discard this patch.
plugin/Controllers/ReviewController.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -26,15 +26,15 @@  discard block
 block discarded – undo
26 26
 	{
27 27
 		sort( $termTaxonomyIds );
28 28
 		sort( $oldTermTaxonomyIds );
29
-		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId ))return;
30
-		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
29
+		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId ) )return;
30
+		$review = glsr( ReviewManager::class )->single( get_post( $postId ) );
31 31
 		$ignoredIds = array_intersect( $oldTermTaxonomyIds, $termTaxonomyIds );
32 32
 		$decreasedIds = array_diff( $oldTermTaxonomyIds, $ignoredIds );
33 33
 		$increasedIds = array_diff( $termTaxonomyIds, $ignoredIds );
34
-		if( $review->term_ids = glsr( Database::class )->getTermIds( $decreasedIds, 'term_taxonomy_id' )) {
34
+		if( $review->term_ids = glsr( Database::class )->getTermIds( $decreasedIds, 'term_taxonomy_id' ) ) {
35 35
 			glsr( CountsManager::class )->decreaseTermCounts( $review );
36 36
 		}
37
-		if( $review->term_ids = glsr( Database::class )->getTermIds( $increasedIds, 'term_taxonomy_id' )) {
37
+		if( $review->term_ids = glsr( Database::class )->getTermIds( $increasedIds, 'term_taxonomy_id' ) ) {
38 38
 			glsr( CountsManager::class )->increaseTermCounts( $review );
39 39
 		}
40 40
 	}
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	 */
48 48
 	public function onAfterChangeStatus( $newStatus, $oldStatus, WP_Post $post )
49 49
 	{
50
-		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
51
-		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ));
50
+		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ) )return;
51
+		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ) );
52 52
 		if( $post->post_status == 'publish' ) {
53 53
 			glsr( CountsManager::class )->increase( $review );
54 54
 		}
@@ -74,8 +74,8 @@  discard block
 block discarded – undo
74 74
 	 */
75 75
 	public function onBeforeDelete( $postId )
76 76
 	{
77
-		if( !$this->isReviewPostId( $postId ))return;
78
-		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
77
+		if( !$this->isReviewPostId( $postId ) )return;
78
+		$review = glsr( ReviewManager::class )->single( get_post( $postId ) );
79 79
 		glsr( CountsManager::class )->decrease( $review );
80 80
 	}
81 81
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 		if( !$this->isReviewPostId( $postId )
93 93
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
94 94
 		)return;
95
-		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
95
+		$review = glsr( ReviewManager::class )->single( get_post( $postId ) );
96 96
 		if( $review->$metaKey == $metaValue )return;
97 97
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
98 98
 		call_user_func( [$this, $method], $review, $metaValue );
Please login to merge, or discard this patch.
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,7 +26,9 @@  discard block
 block discarded – undo
26 26
 	{
27 27
 		sort( $termTaxonomyIds );
28 28
 		sort( $oldTermTaxonomyIds );
29
-		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId ))return;
29
+		if( $termTaxonomyIds === $oldTermTaxonomyIds || !$this->isReviewPostId( $postId )) {
30
+			return;
31
+		}
30 32
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
31 33
 		$ignoredIds = array_intersect( $oldTermTaxonomyIds, $termTaxonomyIds );
32 34
 		$decreasedIds = array_diff( $oldTermTaxonomyIds, $ignoredIds );
@@ -47,7 +49,9 @@  discard block
 block discarded – undo
47 49
 	 */
48 50
 	public function onAfterChangeStatus( $newStatus, $oldStatus, WP_Post $post )
49 51
 	{
50
-		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
52
+		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] )) {
53
+			return;
54
+		}
51 55
 		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ));
52 56
 		if( $post->post_status == 'publish' ) {
53 57
 			glsr( CountsManager::class )->increase( $review );
@@ -63,7 +67,9 @@  discard block
 block discarded – undo
63 67
 	 */
64 68
 	public function onAfterCreate( Review $review )
65 69
 	{
66
-		if( $review->status !== 'publish' )return;
70
+		if( $review->status !== 'publish' ) {
71
+			return;
72
+		}
67 73
 		glsr( CountsManager::class )->increase( $review );
68 74
 	}
69 75
 
@@ -74,7 +80,9 @@  discard block
 block discarded – undo
74 80
 	 */
75 81
 	public function onBeforeDelete( $postId )
76 82
 	{
77
-		if( !$this->isReviewPostId( $postId ))return;
83
+		if( !$this->isReviewPostId( $postId )) {
84
+			return;
85
+		}
78 86
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
79 87
 		glsr( CountsManager::class )->decrease( $review );
80 88
 	}
@@ -91,9 +99,13 @@  discard block
 block discarded – undo
91 99
 	{
92 100
 		if( !$this->isReviewPostId( $postId )
93 101
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
94
-		)return;
102
+		) {
103
+			return;
104
+		}
95 105
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
96
-		if( $review->$metaKey == $metaValue )return;
106
+		if( $review->$metaKey == $metaValue ) {
107
+			return;
108
+		}
97 109
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
98 110
 		call_user_func( [$this, $method], $review, $metaValue );
99 111
 	}
Please login to merge, or discard this patch.
plugin/Database/CountsManager.php 2 patches
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -74,7 +74,9 @@  discard block
 block discarded – undo
74 74
 	 */
75 75
 	public function decreasePostCounts( Review $review )
76 76
 	{
77
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
77
+		if( empty( $counts = $this->getPostCounts( $review->assigned_to ))) {
78
+			return;
79
+		}
78 80
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
79 81
 		$this->setPostCounts( $review->assigned_to, $counts );
80 82
 	}
@@ -85,7 +87,9 @@  discard block
 block discarded – undo
85 87
 	public function decreaseTermCounts( Review $review )
86 88
 	{
87 89
 		foreach( $review->term_ids as $termId ) {
88
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
90
+			if( empty( $counts = $this->getTermCounts( $termId ))) {
91
+				continue;
92
+			}
89 93
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
90 94
 			$this->setTermCounts( $termId, $counts );
91 95
 		}
@@ -107,7 +111,9 @@  discard block
 block discarded – undo
107 111
 			'min' => Rating::MIN_RATING,
108 112
 		]);
109 113
 		foreach( $counts as $index => &$num ) {
110
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
114
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] )) {
115
+				continue;
116
+			}
111 117
 			$num = 0;
112 118
 		}
113 119
 		return $counts;
@@ -199,7 +205,9 @@  discard block
 block discarded – undo
199 205
 	 */
200 206
 	public function increasePostCounts( Review $review )
201 207
 	{
202
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
208
+		if( !( get_post( $review->assigned_to ) instanceof WP_Post )) {
209
+			return;
210
+		}
203 211
 		$counts = $this->getPostCounts( $review->assigned_to );
204 212
 		$counts = empty( $counts )
205 213
 			? $this->buildPostCounts( $review->assigned_to )
@@ -249,7 +257,9 @@  discard block
 block discarded – undo
249 257
 	public function setTermCounts( $termId, array $reviewCounts )
250 258
 	{
251 259
 		$term = get_term( $termId, Application::TAXONOMY );
252
-		if( !isset( $term->term_id ))return;
260
+		if( !isset( $term->term_id )) {
261
+			return;
262
+		}
253 263
 		$ratingCounts = $this->flatten( $reviewCounts );
254 264
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
255 265
 		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
@@ -270,7 +280,9 @@  discard block
 block discarded – undo
270 280
 			$types = array_unique( array_merge( ['local'], $types ));
271 281
 			foreach( $types as $type ) {
272 282
 				$type = $this->normalizeType( $type );
273
-				if( isset( $counts[$type] ))continue;
283
+				if( isset( $counts[$type] )) {
284
+					continue;
285
+				}
274 286
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
275 287
 			}
276 288
 			foreach( $reviews as $review ) {
@@ -323,7 +335,9 @@  discard block
 block discarded – undo
323 335
 		}
324 336
 		foreach( $reviewCounts as &$counts ) {
325 337
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
326
-				if( isset( $counts[$index] ))continue;
338
+				if( isset( $counts[$index] )) {
339
+					continue;
340
+				}
327 341
 				$counts[$index] = 0;
328 342
 			}
329 343
 			ksort( $counts );
Please login to merge, or discard this patch.
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 			$this->getCounts(),
65 65
 			$review->review_type,
66 66
 			$review->rating
67
-		));
67
+		) );
68 68
 	}
69 69
 
70 70
 	/**
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 */
73 73
 	public function decreasePostCounts( Review $review )
74 74
 	{
75
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
75
+		if( empty($counts = $this->getPostCounts( $review->assigned_to )) )return;
76 76
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
77 77
 		$this->setPostCounts( $review->assigned_to, $counts );
78 78
 	}
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 	public function decreaseTermCounts( Review $review )
84 84
 	{
85 85
 		foreach( $review->term_ids as $termId ) {
86
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
86
+			if( empty($counts = $this->getTermCounts( $termId )) )continue;
87 87
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
88 88
 			$this->setTermCounts( $termId, $counts );
89 89
 		}
@@ -95,15 +95,15 @@  discard block
 block discarded – undo
95 95
 	public function flatten( array $reviewCounts, array $args = [] )
96 96
 	{
97 97
 		$counts = [];
98
-		array_walk_recursive( $reviewCounts, function( $num, $index ) use( &$counts ) {
99
-			$counts[$index] = $num + intval( glsr_get( $counts, $index, 0 ));
98
+		array_walk_recursive( $reviewCounts, function( $num, $index ) use(&$counts) {
99
+			$counts[$index] = $num + intval( glsr_get( $counts, $index, 0 ) );
100 100
 		});
101 101
 		$args = wp_parse_args( $args, [
102 102
 			'max' => Rating::MAX_RATING,
103 103
 			'min' => Rating::MIN_RATING,
104
-		]);
104
+		] );
105 105
 		foreach( $counts as $index => &$num ) {
106
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
106
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ) )continue;
107 107
 			$num = 0;
108 108
 		}
109 109
 		return $counts;
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 	{
117 117
 		$args = $this->normalizeArgs( $args );
118 118
 
119
-		if( !empty( $args['post_ids'] ) && !empty( $args['term_ids'] )) {
119
+		if( !empty($args['post_ids']) && !empty($args['term_ids']) ) {
120 120
 			$counts = [$this->build( $args )];
121 121
 		}
122 122
 		else {
@@ -130,13 +130,13 @@  discard block
 block discarded – undo
130 130
 				// @todo if multiple ids are provided, a query must be used!
131 131
 				$counts[] = $this->getTermCounts( $termId );
132 132
 			}
133
-			if( empty( $counts )) {
133
+			if( empty($counts) ) {
134 134
 				$counts[] = $this->getCounts();
135 135
 			}
136 136
 		}
137 137
 		return in_array( $args['type'], ['', 'all'] )
138 138
 			? $this->normalize( [$this->flatten( $counts )] )
139
-			: $this->normalize( glsr_array_column( $counts, $args['type'] ));
139
+			: $this->normalize( glsr_array_column( $counts, $args['type'] ) );
140 140
 	}
141 141
 
142 142
 	/**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	public function getCounts()
146 146
 	{
147 147
 		$counts = glsr( OptionManager::class )->get( 'counts', [] );
148
-		if( !is_array( $counts )) {
148
+		if( !is_array( $counts ) ) {
149 149
 			glsr_log()->error( '$counts is not an array' )->debug( $counts );
150 150
 			return [];
151 151
 		}
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	 */
159 159
 	public function getPostCounts( $postId )
160 160
 	{
161
-		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ));
161
+		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ) );
162 162
 	}
163 163
 
164 164
 	/**
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	public function getTermCounts( $termId )
169 169
 	{
170
-		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ));
170
+		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ) );
171 171
 	}
172 172
 
173 173
 	/**
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
185 185
 	 */
186 186
 	public function increaseCounts( Review $review )
187 187
 	{
188
-		if( empty( $counts = $this->getCounts() )) {
188
+		if( empty($counts = $this->getCounts()) ) {
189 189
 			$counts = $this->buildCounts();
190 190
 		}
191
-		$this->setCounts( $this->increaseRating( $counts, $review->review_type, $review->rating ));
191
+		$this->setCounts( $this->increaseRating( $counts, $review->review_type, $review->rating ) );
192 192
 	}
193 193
 
194 194
 	/**
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 	 */
197 197
 	public function increasePostCounts( Review $review )
198 198
 	{
199
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
199
+		if( !(get_post( $review->assigned_to ) instanceof WP_Post) )return;
200 200
 		$counts = $this->getPostCounts( $review->assigned_to );
201
-		$counts = empty( $counts )
201
+		$counts = empty($counts)
202 202
 			? $this->buildPostCounts( $review->assigned_to )
203 203
 			: $this->increaseRating( $counts, $review->review_type, $review->rating );
204 204
 		$this->setPostCounts( $review->assigned_to, $counts );
@@ -209,10 +209,10 @@  discard block
 block discarded – undo
209 209
 	 */
210 210
 	public function increaseTermCounts( Review $review )
211 211
 	{
212
-		$terms = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ));
212
+		$terms = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ) );
213 213
 		foreach( $terms as $term ) {
214 214
 			$counts = $this->getTermCounts( $term['term_id'] );
215
-			$counts = empty( $counts )
215
+			$counts = empty($counts)
216 216
 				? $this->buildTermCounts( $term['term_taxonomy_id'] )
217 217
 				: $this->increaseRating( $counts, $review->review_type, $review->rating );
218 218
 			$this->setTermCounts( $term['term_id'], $counts );
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
 	{
236 236
 		$ratingCounts = $this->flatten( $reviewCounts );
237 237
 		update_post_meta( $postId, static::META_COUNT, $reviewCounts );
238
-		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
239
-		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
238
+		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
239
+		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
240 240
 	}
241 241
 
242 242
 	/**
@@ -246,11 +246,11 @@  discard block
 block discarded – undo
246 246
 	public function setTermCounts( $termId, array $reviewCounts )
247 247
 	{
248 248
 		$term = get_term( $termId, Application::TAXONOMY );
249
-		if( !isset( $term->term_id ))return;
249
+		if( !isset($term->term_id) )return;
250 250
 		$ratingCounts = $this->flatten( $reviewCounts );
251 251
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
252
-		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
253
-		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
252
+		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
253
+		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
254 254
 	}
255 255
 
256 256
 	/**
@@ -262,12 +262,12 @@  discard block
 block discarded – undo
262 262
 	{
263 263
 		$counts = [];
264 264
 		$lastPostId = 0;
265
-		while( $reviews = $this->queryReviews( $args, $lastPostId )) {
266
-			$types = array_keys( array_flip( glsr_array_column( $reviews, 'type' )));
267
-			$types = array_unique( array_merge( ['local'], $types ));
265
+		while( $reviews = $this->queryReviews( $args, $lastPostId ) ) {
266
+			$types = array_keys( array_flip( glsr_array_column( $reviews, 'type' ) ) );
267
+			$types = array_unique( array_merge( ['local'], $types ) );
268 268
 			foreach( $types as $type ) {
269 269
 				$type = $this->normalizeType( $type );
270
-				if( isset( $counts[$type] ))continue;
270
+				if( isset($counts[$type]) )continue;
271 271
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
272 272
 			}
273 273
 			foreach( $reviews as $review ) {
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 	 */
287 287
 	protected function decreaseRating( array $reviewCounts, $type, $rating )
288 288
 	{
289
-		if( isset( $reviewCounts[$type][$rating] )) {
289
+		if( isset($reviewCounts[$type][$rating]) ) {
290 290
 			$reviewCounts[$type][$rating] = max( 0, $reviewCounts[$type][$rating] - 1 );
291 291
 		}
292 292
 		return $reviewCounts;
@@ -299,10 +299,10 @@  discard block
 block discarded – undo
299 299
 	 */
300 300
 	protected function increaseRating( array $reviewCounts, $type, $rating )
301 301
 	{
302
-		if( !array_key_exists( $type, glsr()->reviewTypes )) {
302
+		if( !array_key_exists( $type, glsr()->reviewTypes ) ) {
303 303
 			return $reviewCounts;
304 304
 		}
305
-		if( !array_key_exists( $type, $reviewCounts )) {
305
+		if( !array_key_exists( $type, $reviewCounts ) ) {
306 306
 			$reviewCounts[$type] = [];
307 307
 		}
308 308
 		$reviewCounts = $this->normalize( $reviewCounts );
@@ -315,12 +315,12 @@  discard block
 block discarded – undo
315 315
 	 */
316 316
 	protected function normalize( array $reviewCounts )
317 317
 	{
318
-		if( empty( $reviewCounts )) {
318
+		if( empty($reviewCounts) ) {
319 319
 			$reviewCounts = [[]];
320 320
 		}
321 321
 		foreach( $reviewCounts as &$counts ) {
322 322
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
323
-				if( isset( $counts[$index] ))continue;
323
+				if( isset($counts[$index]) )continue;
324 324
 				$counts[$index] = 0;
325 325
 			}
326 326
 			ksort( $counts );
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
 			'post_ids' => [],
338 338
 			'term_ids' => [],
339 339
 			'type' => 'local',
340
-		]);
340
+		] );
341 341
 		$args['post_ids'] = glsr( Polylang::class )->getPostIds( $args['post_ids'] );
342 342
 		$args['type'] = $this->normalizeType( $args['type'] );
343 343
 		return $args;
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
 	 */
350 350
 	protected function normalizeType( $type )
351 351
 	{
352
-		return empty( $type ) || !is_string( $type )
352
+		return empty($type) || !is_string( $type )
353 353
 			? 'local'
354 354
 			: $type;
355 355
 	}
Please login to merge, or discard this patch.
plugin/Database.php 2 patches
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,9 @@  discard block
 block discarded – undo
23 23
 		if( empty( $assignedTo )) {
24 24
 			$assignedTo = get_post_meta( $postId, 'assigned_to', true );
25 25
 		}
26
-		if( empty( $assignedTo ))return;
26
+		if( empty( $assignedTo )) {
27
+			return;
28
+		}
27 29
 		$assignedPost = get_post( $assignedTo );
28 30
 		if( $assignedPost instanceof WP_Post && $assignedPost->ID != $postId ) {
29 31
 			return $assignedPost;
@@ -80,7 +82,9 @@  discard block
 block discarded – undo
80 82
 		$termIds = [];
81 83
 		foreach( $values as $value ) {
82 84
 			$term = get_term_by( $field, $value, Application::TAXONOMY );
83
-			if( !isset( $term->term_id ))continue;
85
+			if( !isset( $term->term_id )) {
86
+				continue;
87
+			}
84 88
 			$termIds[] = $term->term_id;
85 89
 		}
86 90
 		return $termIds;
@@ -127,7 +131,9 @@  discard block
 block discarded – undo
127 131
 		add_filter( 'posts_search', [$queryBuilder, 'filterSearchByTitle'], 500, 2 );
128 132
 		$search = new WP_Query( $args );
129 133
 		remove_filter( 'posts_search', [$queryBuilder, 'filterSearchByTitle'], 500 );
130
-		if( !$search->have_posts() )return;
134
+		if( !$search->have_posts() ) {
135
+			return;
136
+		}
131 137
 		$results = '';
132 138
 		while( $search->have_posts() ) {
133 139
 			$search->the_post();
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -20,10 +20,10 @@  discard block
 block discarded – undo
20 20
 	 */
21 21
 	public function getAssignedToPost( $postId, $assignedTo = '' )
22 22
 	{
23
-		if( empty( $assignedTo )) {
23
+		if( empty($assignedTo) ) {
24 24
 			$assignedTo = get_post_meta( $postId, 'assigned_to', true );
25 25
 		}
26
-		if( empty( $assignedTo ))return;
26
+		if( empty($assignedTo) )return;
27 27
 		$assignedPost = get_post( $assignedTo );
28 28
 		if( $assignedPost instanceof WP_Post && $assignedPost->ID != $postId ) {
29 29
 			return $assignedPost;
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 */
64 64
 	public function getReviewsMeta( $key, $status = 'publish' )
65 65
 	{
66
-		if( $status == 'all' || empty( $status )) {
66
+		if( $status == 'all' || empty($status) ) {
67 67
 			$status = get_post_stati( ['exclude_from_search' => false] );
68 68
 		}
69 69
 		return glsr( SqlQueries::class )->getReviewsMeta( $key, $status );
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 		$termIds = [];
79 79
 		foreach( $values as $value ) {
80 80
 			$term = get_term_by( $field, $value, Application::TAXONOMY );
81
-			if( !isset( $term->term_id ))continue;
81
+			if( !isset($term->term_id) )continue;
82 82
 			$termIds[] = $term->term_id;
83 83
 		}
84 84
 		return $termIds;
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
94 94
 			'fields' => 'id=>name',
95 95
 			'hide_empty' => false,
96 96
 			'taxonomy' => Application::TAXONOMY,
97
-		]);
97
+		] );
98 98
 		$terms = get_terms( $args );
99
-		if( is_wp_error( $terms )) {
99
+		if( is_wp_error( $terms ) ) {
100 100
 			glsr_log()->error( $terms->get_error_message() );
101 101
 			return [];
102 102
 		}
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 			'post_status' => 'publish',
114 114
 			'post_type' => 'any',
115 115
 		];
116
-		if( is_numeric( $searchTerm )) {
116
+		if( is_numeric( $searchTerm ) ) {
117 117
 			$args['post__in'] = [$searchTerm];
118 118
 		}
119 119
 		else {
@@ -132,9 +132,9 @@  discard block
 block discarded – undo
132 132
 			ob_start();
133 133
 			glsr()->render( 'partials/editor/search-result', [
134 134
 				'ID' => get_the_ID(),
135
-				'permalink' => esc_url( (string) get_permalink() ),
135
+				'permalink' => esc_url( (string)get_permalink() ),
136 136
 				'title' => esc_attr( get_the_title() ),
137
-			]);
137
+			] );
138 138
 			$results .= ob_get_clean();
139 139
 		}
140 140
 		wp_reset_postdata();
Please login to merge, or discard this patch.
plugin/Shortcodes/SiteReviewsSummaryShortcode.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,8 @@
 block discarded – undo
6 6
 
7 7
 class SiteReviewsSummaryShortcode extends Shortcode
8 8
 {
9
-	protected function hideOptions() {
9
+	protected function hideOptions()
10
+	{
10 11
 		return [
11 12
 			'rating' => __( 'Hide the rating', 'site-reviews' ),
12 13
 			'stars' => __( 'Hide the stars', 'site-reviews' ),
Please login to merge, or discard this patch.
plugin/Shortcodes/SiteReviewsShortcode.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,8 @@
 block discarded – undo
6 6
 
7 7
 class SiteReviewsShortcode extends Shortcode
8 8
 {
9
-	protected function hideOptions() {
9
+	protected function hideOptions()
10
+	{
10 11
 		return [
11 12
 			'title' => __( 'Hide the title', 'site-reviews' ),
12 13
 			'rating' => __( 'Hide the rating', 'site-reviews' ),
Please login to merge, or discard this patch.
plugin/Shortcodes/SiteReviewsFormPopup.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
 		return [[
16 16
 			'type' => 'container',
17 17
 			'html' => '<p class="strong">'.esc_html__( 'All settings are optional.', 'site-reviews' ).'</p>',
18
-		],[
18
+		], [
19 19
 			'label' => esc_html__( 'Title', 'site-reviews' ),
20 20
 			'name' => 'title',
21 21
 			'tooltip' => __( 'Enter a custom shortcode heading.', 'site-reviews' ),
22 22
 			'type' => 'textbox',
23
-		],[
23
+		], [
24 24
 			'label' => esc_html__( 'Description', 'site-reviews' ),
25 25
 			'minHeight' => 60,
26 26
 			'minWidth' => 240,
@@ -29,25 +29,25 @@  discard block
 block discarded – undo
29 29
 			'tooltip' => __( 'Enter a custom shortcode description.', 'site-reviews' ),
30 30
 			'type' => 'textbox',
31 31
 		],
32
-		$this->getCategories( __( 'Automatically assign a category to reviews submitted with this shortcode.', 'site-reviews' )),
32
+		$this->getCategories( __( 'Automatically assign a category to reviews submitted with this shortcode.', 'site-reviews' ) ),
33 33
 		[
34 34
 			'label' => esc_html__( 'Assign To', 'site-reviews' ),
35 35
 			'name' => 'assign_to',
36 36
 			'tooltip' => __( 'Assign submitted reviews to a custom page/post ID. You can also enter "post_id" to assign reviews to the ID of the current page.', 'site-reviews' ),
37 37
 			'type' => 'textbox',
38
-		],[
38
+		], [
39 39
 			'label' => esc_html__( 'Classes', 'site-reviews' ),
40 40
 			'name' => 'class',
41 41
 			'tooltip' => __( 'Add custom CSS classes to the shortcode.', 'site-reviews' ),
42 42
 			'type' => 'textbox',
43
-		],[
43
+		], [
44 44
 			'columns' => 2,
45 45
 			'items' => $this->getHideOptions(),
46 46
 			'label' => esc_html__( 'Hide', 'site-reviews' ),
47 47
 			'layout' => 'grid',
48 48
 			'spacing' => 5,
49 49
 			'type' => 'container',
50
-		],[
50
+		], [
51 51
 			'hidden' => true,
52 52
 			'name' => 'id',
53 53
 			'type' => 'textbox',
Please login to merge, or discard this patch.
plugin/Widgets/SiteReviewsWidget.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -20,14 +20,14 @@  discard block
 block discarded – undo
20 20
 			'class' => 'widefat',
21 21
 			'label' => __( 'Title', 'site-reviews' ),
22 22
 			'name' => 'title',
23
-		]);
23
+		] );
24 24
 		$this->renderField( 'number', [
25 25
 			'class' => 'small-text',
26 26
 			'default' => 5,
27 27
 			'label' => __( 'How many reviews would you like to display?', 'site-reviews' ),
28 28
 			'max' => 100,
29 29
 			'name' => 'count',
30
-		]);
30
+		] );
31 31
 		$this->renderField( 'select', [
32 32
 			'label' => __( 'What is the minimum rating to display?', 'site-reviews' ),
33 33
 			'name' => 'rating',
@@ -38,22 +38,22 @@  discard block
 block discarded – undo
38 38
 				'2' => sprintf( _n( '%s star', '%s stars', 2, 'site-reviews' ), 2 ),
39 39
 				'1' => sprintf( _n( '%s star', '%s stars', 1, 'site-reviews' ), 1 ),
40 40
 			],
41
-		]);
41
+		] );
42 42
 		if( count( glsr()->reviewTypes ) > 1 ) {
43 43
 			$this->renderField( 'select', [
44 44
 				'class' => 'widefat',
45 45
 				'label' => __( 'Which type of review would you like to display?', 'site-reviews' ),
46 46
 				'name' => 'type',
47 47
 				'options' => ['' => __( 'All Reviews', 'site-reviews' )] + glsr()->reviewTypes,
48
-			]);
48
+			] );
49 49
 		}
50
-		if( !empty( $terms )) {
50
+		if( !empty($terms) ) {
51 51
 			$this->renderField( 'select', [
52 52
 				'class' => 'widefat',
53 53
 				'label' => __( 'Limit reviews to this category', 'site-reviews' ),
54 54
 				'name' => 'category',
55 55
 				'options' => ['' => __( 'All Categories', 'site-reviews' )] + $terms,
56
-			]);
56
+			] );
57 57
 		}
58 58
 		$this->renderField( 'text', [
59 59
 			'class' => 'widefat',
@@ -61,16 +61,16 @@  discard block
 block discarded – undo
61 61
 			'description' => sprintf( __( "Separate multiple ID's with a comma. You may also enter %s to automatically represent the current page/post ID.", 'site-reviews' ), '<code>post_id</code>' ),
62 62
 			'label' => __( 'Limit reviews to those assigned to this page/post ID', 'site-reviews' ),
63 63
 			'name' => 'assigned_to',
64
-		]);
64
+		] );
65 65
 		$this->renderField( 'text', [
66 66
 			'class' => 'widefat',
67 67
 			'label' => __( 'Enter any custom CSS classes here', 'site-reviews' ),
68 68
 			'name' => 'class',
69
-		]);
69
+		] );
70 70
 		$this->renderField( 'checkbox', [
71 71
 			'name' => 'hide',
72 72
 			'options' => glsr( SiteReviewsShortcode::class )->getHideOptions(),
73
-		]);
73
+		] );
74 74
 	}
75 75
 
76 76
 	/**
@@ -80,10 +80,10 @@  discard block
 block discarded – undo
80 80
 	 */
81 81
 	public function update( $newInstance, $oldInstance )
82 82
 	{
83
-		if( !is_numeric( $newInstance['count'] )) {
83
+		if( !is_numeric( $newInstance['count'] ) ) {
84 84
 			$newInstance['count'] = 10;
85 85
 		}
86
-		$newInstance['count'] = min( 50, max( 0, intval( $newInstance['count'] )));
86
+		$newInstance['count'] = min( 50, max( 0, intval( $newInstance['count'] ) ) );
87 87
 		return parent::update( $newInstance, $oldInstance );
88 88
 	}
89 89
 
Please login to merge, or discard this patch.
plugin/Widgets/SiteReviewsFormWidget.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,34 +20,34 @@
 block discarded – undo
20 20
 			'class' => 'widefat',
21 21
 			'label' => __( 'Title', 'site-reviews' ),
22 22
 			'name' => 'title',
23
-		]);
23
+		] );
24 24
 		$this->renderField( 'textarea', [
25 25
 			'class' => 'widefat',
26 26
 			'label' => __( 'Description', 'site-reviews' ),
27 27
 			'name' => 'description',
28
-		]);
28
+		] );
29 29
 		$this->renderField( 'select', [
30 30
 			'class' => 'widefat',
31 31
 			'label' => __( 'Automatically assign a category', 'site-reviews' ),
32 32
 			'name' => 'category',
33 33
 			'options' => ['' => __( 'Do not assign a category', 'site-reviews' )] + $terms,
34
-		]);
34
+		] );
35 35
 		$this->renderField( 'text', [
36 36
 			'class' => 'widefat',
37 37
 			'default' => '',
38 38
 			'description' => sprintf( __( 'You may also enter %s to assign to the current post.', 'site-reviews' ), '<code>post_id</code>' ),
39 39
 			'label' => __( 'Assign reviews to a custom page/post ID', 'site-reviews' ),
40 40
 			'name' => 'assign_to',
41
-		]);
41
+		] );
42 42
 		$this->renderField( 'text', [
43 43
 			'class' => 'widefat',
44 44
 			'label' => __( 'Enter any custom CSS classes here', 'site-reviews' ),
45 45
 			'name' => 'class',
46
-		]);
46
+		] );
47 47
 		$this->renderField( 'checkbox', [
48 48
 			'name' => 'hide',
49 49
 			'options' => glsr( SiteReviewsFormShortcode::class )->getHideOptions(),
50
-		]);
50
+		] );
51 51
 	}
52 52
 
53 53
 	/**
Please login to merge, or discard this patch.