Passed
Push — master ( ecb0f6...008868 )
by Paul
04:35
created
plugin/Controllers/ReviewController.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,7 +25,9 @@  discard block
 block discarded – undo
25 25
 	{
26 26
 		sort( $termIds );
27 27
 		sort( $oldTermIds );
28
-		if( $termIds === $oldTermIds || !$this->isReviewPostId( $postId ))return;
28
+		if( $termIds === $oldTermIds || !$this->isReviewPostId( $postId )) {
29
+			return;
30
+		}
29 31
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
30 32
 		$ignoredTerms = array_intersect( $oldTermIds, $termIds );
31 33
 		if( $review->term_ids = array_diff( $oldTermIds, $ignoredTerms )) {
@@ -45,7 +47,9 @@  discard block
 block discarded – undo
45 47
 	 */
46 48
 	public function onAfterCreate( $postData, $meta, $postId )
47 49
 	{
48
-		if( !$this->isReviewPostId( $postId ))return;
50
+		if( !$this->isReviewPostId( $postId )) {
51
+			return;
52
+		}
49 53
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
50 54
 		glsr( CountsManager::class )->increase( $review );
51 55
 	}
@@ -57,7 +61,9 @@  discard block
 block discarded – undo
57 61
 	 */
58 62
 	public function onBeforeDelete( $postId )
59 63
 	{
60
-		if( !$this->isReviewPostId( $postId ))return;
64
+		if( !$this->isReviewPostId( $postId )) {
65
+			return;
66
+		}
61 67
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
62 68
 		glsr( CountsManager::class )->decrease( $review );
63 69
 	}
@@ -74,9 +80,13 @@  discard block
 block discarded – undo
74 80
 	{
75 81
 		if( !$this->isReviewPostId( $postId )
76 82
 			|| !in_array( $metaKey, ['assigned_to', 'rating', 'review_type'] )
77
-		)return;
83
+		) {
84
+			return;
85
+		}
78 86
 		$review = glsr( ReviewManager::class )->single( get_post( $postId ));
79
-		if( $review->$metaKey == $metaValue )return;
87
+		if( $review->$metaKey == $metaValue ) {
88
+			return;
89
+		}
80 90
 		$method = glsr( Helper::class )->buildMethodName( $metaKey, 'onBeforeChange' );
81 91
 		call_user_func( [$this, $method], $review, $metaValue );
82 92
 	}
@@ -122,7 +132,9 @@  discard block
 block discarded – undo
122 132
 	 */
123 133
 	public function onChangeStatus( $newStatus, $oldStatus, WP_Post $post )
124 134
 	{
125
-		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] ))return;
135
+		if( $post->post_type != Application::POST_TYPE || in_array( $oldStatus, ['new', $newStatus] )) {
136
+			return;
137
+		}
126 138
 		$review = glsr( ReviewManager::class )->single( get_post( $post->ID ));
127 139
 		if( $post->post_status == 'publish' ) {
128 140
 			glsr( CountsManager::class )->increase( $review );
Please login to merge, or discard this patch.
plugin/Modules/Validator.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -93,7 +93,9 @@  discard block
 block discarded – undo
93 93
 		foreach( $this->rules as $attribute => $rules ) {
94 94
 			foreach( $rules as $rule ) {
95 95
 				$this->validateAttribute( $attribute, $rule );
96
-				if( $this->shouldStopValidating( $attribute ))break;
96
+				if( $this->shouldStopValidating( $attribute )) {
97
+					break;
98
+				}
97 99
 			}
98 100
 		}
99 101
 		return $this->errors;
@@ -109,7 +111,9 @@  discard block
 block discarded – undo
109 111
 	public function validateAttribute( $attribute, $rule )
110 112
 	{
111 113
 		list( $rule, $parameters ) = $this->parseRule( $rule );
112
-		if( $rule == '' )return;
114
+		if( $rule == '' ) {
115
+			return;
116
+		}
113 117
 		$value = $this->getValue( $attribute );
114 118
 		if( !method_exists( $this, $method = 'validate'.$rule )) {
115 119
 			throw new BadMethodCallException( "Method [$method] does not exist." );
@@ -178,7 +182,9 @@  discard block
 block discarded – undo
178 182
 	 */
179 183
 	protected function getRule( $attribute, $rules )
180 184
 	{
181
-		if( !array_key_exists( $attribute, $this->rules ))return;
185
+		if( !array_key_exists( $attribute, $this->rules )) {
186
+			return;
187
+		}
182 188
 		$rules = (array)$rules;
183 189
 		foreach( $this->rules[$attribute] as $rule ) {
184 190
 			list( $rule, $parameters ) = $this->parseRule( $rule );
Please login to merge, or discard this patch.
plugin/Handlers/EnqueuePublicAssets.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,7 +55,9 @@  discard block
 block discarded – undo
55 55
 	 */
56 56
 	public function enqueuePolyfillService()
57 57
 	{
58
-		if( !apply_filters( 'site-reviews/assets/polyfill', true ))return;
58
+		if( !apply_filters( 'site-reviews/assets/polyfill', true )) {
59
+			return;
60
+		}
59 61
 		wp_enqueue_script( Application::ID.'/polyfill', add_query_arg([
60 62
 			'features' => 'CustomEvent,Element.prototype.closest,Element.prototype.dataset,Event',
61 63
 			'flags' => 'gated',
@@ -70,7 +72,9 @@  discard block
 block discarded – undo
70 72
 		// wpforms-recaptcha
71 73
 		// google-recaptcha
72 74
 		// nf-google-recaptcha
73
-		if( !glsr( OptionManager::class )->isRecaptchaEnabled() )return;
75
+		if( !glsr( OptionManager::class )->isRecaptchaEnabled() ) {
76
+			return;
77
+		}
74 78
 		$language = apply_filters( 'site-reviews/recaptcha/language', get_locale() );
75 79
 		wp_enqueue_script( Application::ID.'/google-recaptcha', add_query_arg([
76 80
 			'hl' => $language,
@@ -84,7 +88,9 @@  discard block
 block discarded – undo
84 88
 	public function inlineStyles()
85 89
 	{
86 90
 		$inlineStylesheetPath = glsr()->path( 'assets/styles/inline-styles.css' );
87
-		if( !apply_filters( 'site-reviews/assets/css', true ))return;
91
+		if( !apply_filters( 'site-reviews/assets/css', true )) {
92
+			return;
93
+		}
88 94
 		if( !file_exists( $inlineStylesheetPath )) {
89 95
 			glsr_log()->error( 'Inline stylesheet is missing: '.$inlineStylesheetPath );
90 96
 			return;
Please login to merge, or discard this patch.
plugin/Modules/Validator/ValidateReview.php 1 patch
Braces   +27 added lines, -9 removed lines patch added patch discarded remove patch
@@ -166,8 +166,12 @@  discard block
 block discarded – undo
166 166
 	 */
167 167
 	protected function validateAkismet()
168 168
 	{
169
-		if( !empty( $this->error ))return;
170
-		if( !glsr( Akismet::class )->isSpam( $this->request ))return;
169
+		if( !empty( $this->error )) {
170
+			return;
171
+		}
172
+		if( !glsr( Akismet::class )->isSpam( $this->request )) {
173
+			return;
174
+		}
171 175
 		$this->setSessionValues( 'errors', [], 'Akismet caught a spam submission:' );
172 176
 		$this->error = __( 'Your review cannot be submitted at this time. Please try again later.', 'site-reviews' );
173 177
 	}
@@ -177,8 +181,12 @@  discard block
 block discarded – undo
177 181
 	 */
178 182
 	protected function validateBlacklist()
179 183
 	{
180
-		if( !empty( $this->error ))return;
181
-		if( !glsr( Blacklist::class )->isBlacklisted( $this->request ))return;
184
+		if( !empty( $this->error )) {
185
+			return;
186
+		}
187
+		if( !glsr( Blacklist::class )->isBlacklisted( $this->request )) {
188
+			return;
189
+		}
182 190
 		$blacklistAction = $this->getOption( 'settings.submissions.blacklist.action' );
183 191
 		if( $blacklistAction == 'reject' ) {
184 192
 			$this->setSessionValues( 'errors', [], 'Blacklisted submission detected:' );
@@ -193,9 +201,13 @@  discard block
 block discarded – undo
193 201
 	 */
194 202
 	protected function validateCustom()
195 203
 	{
196
-		if( !empty( $this->error ))return;
204
+		if( !empty( $this->error )) {
205
+			return;
206
+		}
197 207
 		$validated = apply_filters( 'site-reviews/validate/review/submission', true, $this->request );
198
-		if( $validated === true )return;
208
+		if( $validated === true ) {
209
+			return;
210
+		}
199 211
 		$this->setSessionValues( 'errors', [] );
200 212
 		$this->setSessionValues( 'values', $this->request );
201 213
 		$this->error = is_string( $validated )
@@ -208,8 +220,12 @@  discard block
 block discarded – undo
208 220
 	 */
209 221
 	protected function validateHoneyPot()
210 222
 	{
211
-		if( !empty( $this->error ))return;
212
-		if( empty( $this->request['gotcha'] ))return;
223
+		if( !empty( $this->error )) {
224
+			return;
225
+		}
226
+		if( empty( $this->request['gotcha'] )) {
227
+			return;
228
+		}
213 229
 		$this->setSessionValues( 'errors', [], 'The Honeypot caught a bad submission:' );
214 230
 		$this->error = __( 'The review submission failed. Please notify the site administrator.', 'site-reviews' );
215 231
 	}
@@ -219,7 +235,9 @@  discard block
 block discarded – undo
219 235
 	 */
220 236
 	protected function validateRecaptcha()
221 237
 	{
222
-		if( !empty( $this->error ))return;
238
+		if( !empty( $this->error )) {
239
+			return;
240
+		}
223 241
 		$isValid = $this->isRecaptchaResponseValid();
224 242
 		if( is_null( $isValid )) {
225 243
 			$this->setSessionValues( 'recaptcha', 'unset' );
Please login to merge, or discard this patch.
plugin/Router.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -17,7 +17,9 @@  discard block
 block discarded – undo
17 17
 	public function routeAdminPostRequest()
18 18
 	{
19 19
 		$request = $this->getRequest();
20
-		if( !$this->isValidPostRequest( $request ))return;
20
+		if( !$this->isValidPostRequest( $request )) {
21
+			return;
22
+		}
21 23
 		check_admin_referer( $request['action'] );
22 24
 		$this->routeRequest( 'admin', $request['action'], $request );
23 25
 	}
@@ -39,10 +41,16 @@  discard block
 block discarded – undo
39 41
 	 */
40 42
 	public function routePublicPostRequest()
41 43
 	{
42
-		if( is_admin() )return;
44
+		if( is_admin() ) {
45
+			return;
46
+		}
43 47
 		$request = $this->getRequest();
44
-		if( !$this->isValidPostRequest( $request ))return;
45
-		if( !$this->isValidPublicNonce( $request ))return;
48
+		if( !$this->isValidPostRequest( $request )) {
49
+			return;
50
+		}
51
+		if( !$this->isValidPublicNonce( $request )) {
52
+			return;
53
+		}
46 54
 		$this->routeRequest( 'public', $request['action'], $request );
47 55
 	}
48 56
 
@@ -51,7 +59,9 @@  discard block
 block discarded – undo
51 59
 	 */
52 60
 	protected function checkAjaxNonce( array $request )
53 61
 	{
54
-		if( !is_user_logged_in() )return;
62
+		if( !is_user_logged_in() ) {
63
+			return;
64
+		}
55 65
 		if( !isset( $request['nonce'] )) {
56 66
 			$this->sendAjaxError( 'request is missing a nonce', $request );
57 67
 		}
Please login to merge, or discard this patch.
plugin/Modules/Slack.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,9 @@
 block discarded – undo
35 35
 	 */
36 36
 	public function compose( Review $review, array $notification )
37 37
 	{
38
-		if( empty( $this->endpoint ))return;
38
+		if( empty( $this->endpoint )) {
39
+			return;
40
+		}
39 41
 		$args = shortcode_atts( glsr( SlackDefaults::class )->defaults(), $notification );
40 42
 		$this->review = $review;
41 43
 		$notification = [
Please login to merge, or discard this patch.
plugin/Modules/Html/Partials/SiteReviewsForm.php 1 patch
Braces   +15 added lines, -5 removed lines patch added patch discarded remove patch
@@ -85,7 +85,9 @@  discard block
 block discarded – undo
85 85
 	 */
86 86
 	protected function buildRecaptcha()
87 87
 	{
88
-		if( !glsr( OptionManager::class )->isRecaptchaEnabled() )return;
88
+		if( !glsr( OptionManager::class )->isRecaptchaEnabled() ) {
89
+			return;
90
+		}
89 91
 		return glsr( Builder::class )->div([
90 92
 			'class' => 'glsr-recaptcha-holder',
91 93
 			'data-badge' => glsr( OptionManager::class )->get( 'settings.submissions.recaptcha.position' ),
@@ -161,7 +163,9 @@  discard block
 block discarded – undo
161 163
 	 */
162 164
 	protected function getRegisterText()
163 165
 	{
164
-		if( !get_option( 'users_can_register' ) || glsr( OptionManager::class )->get( 'settings.general.require.login' ) != 'yes' )return;
166
+		if( !get_option( 'users_can_register' ) || glsr( OptionManager::class )->get( 'settings.general.require.login' ) != 'yes' ) {
167
+			return;
168
+		}
165 169
 		$registerLink = glsr( Builder::class )->a([
166 170
 			'href' => wp_registration_url(),
167 171
 			'text' => __( 'register', 'site-reviews' ),
@@ -217,7 +221,9 @@  discard block
 block discarded – undo
217 221
 	 */
218 222
 	protected function normalizeFieldErrors( Field &$field )
219 223
 	{
220
-		if( !array_key_exists( $field->field['path'], $this->errors ))return;
224
+		if( !array_key_exists( $field->field['path'], $this->errors )) {
225
+			return;
226
+		}
221 227
 		$field->field['errors'] = $this->errors[$field->field['path']];
222 228
 	}
223 229
 
@@ -226,7 +232,9 @@  discard block
 block discarded – undo
226 232
 	 */
227 233
 	protected function normalizeFieldRequired( Field &$field )
228 234
 	{
229
-		if( !in_array( $field->field['path'], $this->required ))return;
235
+		if( !in_array( $field->field['path'], $this->required )) {
236
+			return;
237
+		}
230 238
 		$field->field['required'] = true;
231 239
 	}
232 240
 
@@ -249,7 +257,9 @@  discard block
 block discarded – undo
249 257
 	 */
250 258
 	protected function normalizeFieldValue( Field &$field )
251 259
 	{
252
-		if( !array_key_exists( $field->field['path'], $this->values ))return;
260
+		if( !array_key_exists( $field->field['path'], $this->values )) {
261
+			return;
262
+		}
253 263
 		if( in_array( $field->field['type'], ['radio', 'checkbox'] )) {
254 264
 			$field->field['checked'] = $field->field['value'] == $this->values[$field->field['path']];
255 265
 		}
Please login to merge, or discard this patch.
site-reviews.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,9 @@
 block discarded – undo
21 21
 if( !class_exists( 'GL_Plugin_Check_v3' )) {
22 22
 	require_once __DIR__.'/activate.php';
23 23
 }
24
-if( !(new GL_Plugin_Check_v3( __FILE__ ))->canProceed() )return;
24
+if( !(new GL_Plugin_Check_v3( __FILE__ ))->canProceed() ) {
25
+	return;
26
+}
25 27
 require_once __DIR__.'/autoload.php';
26 28
 require_once __DIR__.'/compatibility.php';
27 29
 require_once __DIR__.'/deprecated.php';
Please login to merge, or discard this patch.
plugin/Modules/Notification.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
 	 */
44 44
 	public function send( Review $review )
45 45
 	{
46
-		if( empty( $this->types ))return;
46
+		if( empty( $this->types )) {
47
+			return;
48
+		}
47 49
 		$this->review = $review;
48 50
 		$args = [
49 51
 			'link' => $this->getLink(),
@@ -146,7 +148,9 @@  discard block
 block discarded – undo
146 148
 	protected function sendToEmail( array $args )
147 149
 	{
148 150
 		$email = $this->buildEmail( $args );
149
-		if( !$this->email )return;
151
+		if( !$this->email ) {
152
+			return;
153
+		}
150 154
 		if( empty( $email->to )) {
151 155
 			glsr_log()->error( 'Email notification was not sent: missing email address' );
152 156
 			return;
@@ -161,7 +165,9 @@  discard block
 block discarded – undo
161 165
 	 */
162 166
 	protected function sendToSlack( array $args )
163 167
 	{
164
-		if( !$this->slack )return;
168
+		if( !$this->slack ) {
169
+			return;
170
+		}
165 171
 		$notification = $this->buildSlackNotification( $args );
166 172
 		$result = $notification->send();
167 173
 		if( is_wp_error( $result )) {
Please login to merge, or discard this patch.