GLSR.Ajax - Code Metrics - Inspection of "rewrite public scripts" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5cb715...24da2d )

by Paul

created 2018-06-10 18:32 UTC

GLSR.Ajax A

↳ Parent: GLSR.Ajax

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

/** global: GLSR, XMLHttpRequest */
;(function() {

	'use strict';

	GLSR.Ajax = function() {
		/** @return void */
		this.get = function( url, successCallback ) {
			var xhr = new XMLHttpRequest();
			xhr.open( 'GET', url );
			xhr.onreadystatechange = function() {
				if( xhr.readyState !== 4 )return;
				successCallback( xhr.responseText );
			};
			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
			xhr.send();
		};

		/** @return bool */
		this.isFileAPISupported = function() {
			var input = document.createElement( 'INPUT' );
			input.type = 'file';
			return 'files' in input;
		};

		/** @return bool */
		this.isFormDataSupported = function() {
			return !!window.FormData;
		};

		/** @return bool */
		this.isUploadSupported = function() {
			var xhr = new XMLHttpRequest();
			return !!( xhr && ( 'upload' in xhr ) && ( 'onprogress' in xhr.upload ));
		};

		/** @return void */
		this.post = function( data, successCallback, headers ) {
			var xhr = new XMLHttpRequest();
			this.setHeaders_( xhr, headers );
			xhr.open( 'POST', GLSR.ajaxurl );
			xhr.onreadystatechange = function() {
				if( xhr.readyState !== 4 )return;
				successCallback( JSON.parse( xhr.responseText ));
			};
			xhr.send({
				action: GLSR.action,
				request: data,
			});
		};

		/** @return void */
		this.setHeaders_ = function( xhr, headers ) {
			headers = headers || {};
			headers['X-Requested-With'] = 'XMLHttpRequest';
			for( var key in headers ) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
				xhr.setRequestHeader( key, headers[key] );
			}
		};
	};
})();


1			/** global: GLSR, XMLHttpRequest */
2			;(function() {
3
4			'use strict';
5
6			GLSR.Ajax = function() {
7			/** @return void */
8			this.get = function( url, successCallback ) {
9			var xhr = new XMLHttpRequest();
10			xhr.open( 'GET', url );
11			xhr.onreadystatechange = function() {
12			if( xhr.readyState !== 4 )return;
13			successCallback( xhr.responseText );
14			};
15			xhr.setRequestHeader( 'X-Requested-With', 'XMLHttpRequest' );
16			xhr.send();
17			};
18
19			/** @return bool */
20			this.isFileAPISupported = function() {
21			var input = document.createElement( 'INPUT' );
22			input.type = 'file';
23			return 'files' in input;
24			};
25
26			/** @return bool */
27			this.isFormDataSupported = function() {
28			return !!window.FormData;
29			};
30
31			/** @return bool */
32			this.isUploadSupported = function() {
33			var xhr = new XMLHttpRequest();
34			return !!( xhr && ( 'upload' in xhr ) && ( 'onprogress' in xhr.upload ));
35			};
36
37			/** @return void */
38			this.post = function( data, successCallback, headers ) {
39			var xhr = new XMLHttpRequest();
40			this.setHeaders_( xhr, headers );
41			xhr.open( 'POST', GLSR.ajaxurl );
42			xhr.onreadystatechange = function() {
43			if( xhr.readyState !== 4 )return;
44			successCallback( JSON.parse( xhr.responseText ));
45			};
46			xhr.send({
47			action: GLSR.action,
48			request: data,
49			});
50			};
51
52			/** @return void */
53			this.setHeaders_ = function( xhr, headers ) {
54			headers = headers \|\| {};
55			headers['X-Requested-With'] = 'XMLHttpRequest';
56			for( var key in headers ) {
			0 ignored issues – show Complexity introduced 2018-06-10 18:37 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
57			xhr.setRequestHeader( key, headers[key] );
58			}
59			};
60			};
61			})();
62

pryley / site-reviews

Push — master ( 5cb715...24da2d )

GLSR.Ajax A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like