+/scripts/admin/tabs.js - Code Metrics - Inspection of "begin forms and fields" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dc3967...a95317 )

by Paul

created 2018-05-29 09:53 UTC

+/scripts/admin/tabs.js A

↳ Parent: Project

Complexity

Total Complexity	18
Complexity/F	1.8

Size

Lines of Code	69
Function Count	10

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	0
nc	16
dl	0
loc	69
rs	10
c	1
b	0
f	0
wmc	18
mnd	1
bc	12
fnc	10
bpm	1.2
cpm	1.8
noi	4

6 Functions

Rating	Name	Size	Complexity
A	GLSR.tabs.setView	6	1
A	GLSR.tabs.init	10	1
A	GLSR.tabs.onClick	6	1
A	GLSR.tabs.getAction	3	2
A	GLSR.tabs.setTab	11	1
A	GLSR.tabs.setReferrer	4	1

GLSR.tabs = function( options ) {

	this.options = x.extend( {}, this.defaults, options );

	this.active = document.querySelector( 'input[name=_active_tab]' );
	this.referrer = document.querySelector( 'input[name=_wp_http_referer]' );
	this.tabs = document.querySelectorAll( this.options.tabSelector );
	this.views = document.querySelectorAll( this.options.viewSelector );
	if( !this.active || !this.referrer || !this.tabs || !this.views )return;
if (a > 0)
    b = 42;
	this.init();
};

GLSR.tabs.prototype = {


	defaults: {
		tabSelector: '.glsr-nav-tab',
		viewSelector: '.glsr-nav-view',
	},

	/** @return void */
	init: function() {
		[].forEach.call( this.tabs, function( tab, index ) {
			var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
			if( active ) {
				this.setTab( tab );
			}
			tab.addEventListener( 'click', this.onClick.bind( this ));
			tab.addEventListener( 'touchend', this.onClick.bind( this ));
		}.bind( this ));
	},

	/** @return string */
	getAction: function( bool ) {
		return bool ? 'add' : 'remove';
	},

	/** @return void */
	onClick: function( ev ) {
		ev.preventDefault();
		ev.target.blur();
		this.setTab( ev.target );
		location.hash = '!' + ev.target.getAttribute( 'href' ).slice(1);
	},

	/** @return void */
	setReferrer: function( index ) {
		var referrerUrl = this.referrer.value.split('#')[0] + '#!' + this.views[index].id;
		this.referrer.value = referrerUrl;
	},

	/** @return void */
	setTab: function( el ) {
		[].forEach.call( this.tabs, function( tab, index ) {
			var action = this.getAction( tab === el );
			if( action === 'add' ) {
				this.active.value = this.views[index].id;
				this.setReferrer( index );
				this.setView( index );
			}
			tab.classList[action]( 'nav-tab-active' );
		}.bind( this ));
	},

	/** @return void */
	setView: function( idx ) {
		[].forEach.call( this.views, function( view, index ) {
			var action = this.getAction( index !== idx );
			view.classList[action]( 'ui-tabs-hide' );
		}.bind( this ));
	},
};


1			GLSR.tabs = function( options ) {
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `GLSR` seems to be never declared. If this is a global, consider adding a `/** global: GLSR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
2			this.options = x.extend( {}, this.defaults, options );
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `x` seems to be never declared. If this is a global, consider adding a `/** global: x */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
3			this.active = document.querySelector( 'input[name=_active_tab]' );
4			this.referrer = document.querySelector( 'input[name=_wp_http_referer]' );
5			this.tabs = document.querySelectorAll( this.options.tabSelector );
6			this.views = document.querySelectorAll( this.options.viewSelector );
7			if( !this.active \|\| !this.referrer \|\| !this.tabs \|\| !this.views )return;
			1 ignored issue – show Coding Style Best Practice introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
8			this.init();
9			};
10
11			GLSR.tabs.prototype = {
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `GLSR` seems to be never declared. If this is a global, consider adding a `/** global: GLSR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
12
13			defaults: {
14			tabSelector: '.glsr-nav-tab',
15			viewSelector: '.glsr-nav-view',
16			},
17
18			/** @return void */
19			init: function() {
20			[].forEach.call( this.tabs, function( tab, index ) {
21			var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
22			if( active ) {
23			this.setTab( tab );
24			}
25			tab.addEventListener( 'click', this.onClick.bind( this ));
26			tab.addEventListener( 'touchend', this.onClick.bind( this ));
27			}.bind( this ));
28			},
29
30			/** @return string */
31			getAction: function( bool ) {
32			return bool ? 'add' : 'remove';
33			},
34
35			/** @return void */
36			onClick: function( ev ) {
37			ev.preventDefault();
38			ev.target.blur();
39			this.setTab( ev.target );
40			location.hash = '!' + ev.target.getAttribute( 'href' ).slice(1);
41			},
42
43			/** @return void */
44			setReferrer: function( index ) {
45			var referrerUrl = this.referrer.value.split('#')[0] + '#!' + this.views[index].id;
46			this.referrer.value = referrerUrl;
47			},
48
49			/** @return void */
50			setTab: function( el ) {
51			[].forEach.call( this.tabs, function( tab, index ) {
52			var action = this.getAction( tab === el );
53			if( action === 'add' ) {
54			this.active.value = this.views[index].id;
55			this.setReferrer( index );
56			this.setView( index );
57			}
58			tab.classList[action]( 'nav-tab-active' );
59			}.bind( this ));
60			},
61
62			/** @return void */
63			setView: function( idx ) {
64			[].forEach.call( this.views, function( view, index ) {
65			var action = this.getAction( index !== idx );
66			view.classList[action]( 'ui-tabs-hide' );
67			}.bind( this ));
68			},
69			};
70

pryley / site-reviews

Push — master ( dc3967...a95317 )

+/scripts/admin/tabs.js A

Complexity

Size

Duplication

Importance

6 Functions

Duplication Side-by-Side

Filter issues like