Passed
Push — master ( 742cf3...3c2230 )
by Paul
04:44
created
plugin/Router.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	public function routeAdminPostRequest()
17 17
 	{
18 18
 		$request = $this->getRequest();
19
-		if( !$this->isValidPostRequest( $request ))return;
19
+		if( !$this->isValidPostRequest( $request ) )return;
20 20
 		check_admin_referer( $request['action'] );
21 21
 		$this->routeRequest( 'admin', $request['action'], $request );
22 22
 	}
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	public function routeAjaxRequest()
30 30
 	{
31 31
 		$request = $this->getRequest();
32
-		if( !isset( $request['action'] )) {
32
+		if( !isset($request['action']) ) {
33 33
 			glsr_log()->error( 'The AJAX request must include an action' )->info( $request );
34 34
 			wp_die();
35 35
 		}
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	{
47 47
 		if( is_admin() )return;
48 48
 		$request = $this->getRequest();
49
-		if( !$this->isValidPostRequest( $request ))return;
50
-		if( !$this->isValidPublicNonce( $request ))return;
49
+		if( !$this->isValidPostRequest( $request ) )return;
50
+		if( !$this->isValidPublicNonce( $request ) )return;
51 51
 		$this->routeRequest( 'public', $request['action'], $request );
52 52
 	}
53 53
 
@@ -67,11 +67,11 @@  discard block
 block discarded – undo
67 67
 	protected function checkAjaxNonce( array $request )
68 68
 	{
69 69
 		if( !is_user_logged_in() )return;
70
-		if( !isset( $request['nonce'] )) {
70
+		if( !isset($request['nonce']) ) {
71 71
 			glsr_log()->error( 'The AJAX request must include a nonce' )->info( $request );
72 72
 			wp_die();
73 73
 		}
74
-		if( !wp_verify_nonce( $request['nonce'], $request['action'] )) {
74
+		if( !wp_verify_nonce( $request['nonce'], $request['action'] ) ) {
75 75
 			glsr_log()->error( 'Nonce check failed for ajax request' )->info( $request );
76 76
 			wp_die( -1, 403 );
77 77
 		}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	{
85 85
 		foreach( ['request', Application::ID] as $key ) {
86 86
 			$request = glsr( Helper::class )->filterInputArray( $key );
87
-			if( !empty( $request ))break;
87
+			if( !empty($request) )break;
88 88
 		}
89 89
 		return $this->normalizeRequest( $request );
90 90
 	}
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	protected function isValidPostRequest( array $request = [] )
96 96
 	{
97
-		return !empty( $request['action'] ) && empty( glsr( Helper::class )->filterInput( 'ajax_request' ));
97
+		return !empty($request['action']) && empty(glsr( Helper::class )->filterInput( 'ajax_request' ));
98 98
 	}
99 99
 
100 100
 	/**
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	protected function isValidPublicNonce( array $request )
104 104
 	{
105
-		if( is_user_logged_in() && !wp_verify_nonce( $request['_wpnonce'], $request['action'] )) {
105
+		if( is_user_logged_in() && !wp_verify_nonce( $request['_wpnonce'], $request['action'] ) ) {
106 106
 			glsr_log()->error( 'Nonce check failed for public request' )->info( $request );
107 107
 			return false;
108 108
 		}
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	protected function normalizeRequest( array $request )
116 116
 	{
117
-		if( isset( $request[Application::ID]['action'] )) {
117
+		if( isset($request[Application::ID]['action']) ) {
118 118
 			$request = $request[Application::ID];
119 119
 		}
120 120
 		if( glsr( Helper::class )->filterInput( 'action', $request ) == 'submit-review' ) {
@@ -131,11 +131,11 @@  discard block
 block discarded – undo
131 131
 	protected function routeRequest( $type, $action, array $request = [] )
132 132
 	{
133 133
 		$actionHook = 'site-reviews/route/'.$type.'/request';
134
-		$controller = glsr( glsr( Helper::class )->buildClassName( $type.'-controller', 'Controllers' ));
134
+		$controller = glsr( glsr( Helper::class )->buildClassName( $type.'-controller', 'Controllers' ) );
135 135
 		$method = glsr( Helper::class )->buildMethodName( $action, 'router' );
136 136
 		$request = apply_filters( 'site-reviews/route/request', $request, $action, $type );
137 137
 		do_action( $actionHook, $action, $request );
138
-		if( is_callable( [$controller, $method] )) {
138
+		if( is_callable( [$controller, $method] ) ) {
139 139
 			call_user_func( [$controller, $method], $request );
140 140
 			return;
141 141
 		}
Please login to merge, or discard this patch.
Braces   +21 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,9 @@  discard block
 block discarded – undo
16 16
 	public function routeAdminPostRequest()
17 17
 	{
18 18
 		$request = $this->getRequest();
19
-		if( !$this->isValidPostRequest( $request ))return;
19
+		if( !$this->isValidPostRequest( $request )) {
20
+			return;
21
+		}
20 22
 		check_admin_referer( $request['action'] );
21 23
 		$this->routeRequest( 'admin', $request['action'], $request );
22 24
 	}
@@ -44,10 +46,16 @@  discard block
 block discarded – undo
44 46
 	 */
45 47
 	public function routePublicPostRequest()
46 48
 	{
47
-		if( is_admin() )return;
49
+		if( is_admin() ) {
50
+			return;
51
+		}
48 52
 		$request = $this->getRequest();
49
-		if( !$this->isValidPostRequest( $request ))return;
50
-		if( !$this->isValidPublicNonce( $request ))return;
53
+		if( !$this->isValidPostRequest( $request )) {
54
+			return;
55
+		}
56
+		if( !$this->isValidPublicNonce( $request )) {
57
+			return;
58
+		}
51 59
 		$this->routeRequest( 'public', $request['action'], $request );
52 60
 	}
53 61
 
@@ -57,7 +65,9 @@  discard block
 block discarded – undo
57 65
 	public function routeWebhookRequest()
58 66
 	{
59 67
 		$request = filter_input( INPUT_GET, Application::PREFIX.'hook' );
60
-		if( !$request )return;
68
+		if( !$request ) {
69
+			return;
70
+		}
61 71
 		// @todo manage webhook here
62 72
 	}
63 73
 
@@ -66,7 +76,9 @@  discard block
 block discarded – undo
66 76
 	 */
67 77
 	protected function checkAjaxNonce( array $request )
68 78
 	{
69
-		if( !is_user_logged_in() )return;
79
+		if( !is_user_logged_in() ) {
80
+			return;
81
+		}
70 82
 		if( !isset( $request['nonce'] )) {
71 83
 			glsr_log()->error( 'The AJAX request must include a nonce' )->info( $request );
72 84
 			wp_die();
@@ -84,7 +96,9 @@  discard block
 block discarded – undo
84 96
 	{
85 97
 		foreach( ['request', Application::ID] as $key ) {
86 98
 			$request = glsr( Helper::class )->filterInputArray( $key );
87
-			if( !empty( $request ))break;
99
+			if( !empty( $request )) {
100
+				break;
101
+			}
88 102
 		}
89 103
 		return $this->normalizeRequest( $request );
90 104
 	}
Please login to merge, or discard this patch.