pryley / site-reviews

activate.php

<?php

defined( 'WPINC' ) || die;

/**
 * Checks for minimum system requirments on plugin activation
 * @version 3.0.0
 */
class GL_Plugin_Check_v3
{
	const MIN_PHP_VERSION = '5.6.0';
	const MIN_WORDPRESS_VERSION = '4.7.0';

	/**
	 * @var string
	 */
	protected $file;

	/**
	 * @var array
	 */
	protected $versions;

	public function __construct( $file, array $versions = [] )
	{
		$this->file = realpath( $file );
		$this->versions = $this->normalize( $versions );

It seems like $this->normalize($versions) of type object is incompatible with the declared type array of property $versions.

	}

	/**
	 * @param string $version
	 * @return bool
	 */
	public function isPhpValid()
	{
		return !version_compare( PHP_VERSION, $this->versions['php'], '<' );
	}

	/**
	 * @return bool
	 */
	public function isValid()
	{
		return $this->isPhpValid() && $this->isWpValid();
	}

	/**
	 * @param string $version
	 * @return bool
	 */
	public function isWpValid()
	{
		global $wp_version;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		return !version_compare( $wp_version, $this->versions['wordpress'], '<' );
	}

	/**
	 * @param string $plugin
	 * @return void
	 */
	public function deactivate( $plugin )
	{
		if( $this->isValid() )return;
		$pluginSlug = plugin_basename( $this->file );
		if( $plugin == $pluginSlug ) {
			$this->redirect(); //exit
		}
		$pluginData = get_file_data( $this->file, array( 'name' => 'Plugin Name' ), 'plugin' );
		deactivate_plugins( $pluginSlug );
		$this->printNotice( $pluginData['name'] );
	}

	/**
	 * @return bool
	 */
	public function shouldDeactivate()
	{
		if( !$this->isValid() ) {
			add_action( 'activated_plugin', array( $this, 'deactivate' ));
			add_action( 'admin_notices', array( $this, 'deactivate' ));
			return true;
		}
		return false;
	}

	/**
	 * @return object
	 */
	protected function normalize( array $args = array() )
	{
		return wp_parse_args( $args, array(

The expression return wp_parse_args($args, array('php' => static::MIN_PHP_VERSION, 'wordpress' => static::MIN_WORDPRESS_VERSION)) returns the type array which is incompatible with the documented return type object.

			'php' => static::MIN_PHP_VERSION,
			'wordpress' => static::MIN_WORDPRESS_VERSION,
		));
	}

	/**
	 * @return array
	 */
	protected function getMessages()
	{
		return array(
			__( 'The %s plugin was deactivated.', 'site-reviews' ),
			__( 'This plugin requires %s or greater in order to work properly.', 'site-reviews' ),
			__( 'Please contact your hosting provider or server administrator to upgrade the version of PHP on your server (your server is running PHP version %s), or try to find an alternative plugin.', 'site-reviews' ),
			__( 'PHP version', 'site-reviews' ),
			__( 'WordPress version', 'site-reviews' ),
			__( 'Update WordPress', 'site-reviews' ),
			__( 'You can use the %s plugin to restore %s to the previous version.', 'site-reviews' ),
		);
	}

	/**
	 * @return void
	 */
	protected function redirect()
	{
		wp_safe_redirect( self_admin_url( sprintf( 'plugins.php?plugin_status=%s&paged=%s&s=%s',
			filter_input( INPUT_GET, 'plugin_status' ),
			filter_input( INPUT_GET, 'paged' ),
			filter_input( INPUT_GET, 's' )
		)));
		exit;
	}

	/**
	 * @param string $pluginName
	 * @return void
	 */
	protected function printNotice( $pluginName )
	{
		$noticeTemplate = '<div id="message" class="notice notice-error error is-dismissible"><p><strong>%s</strong></p><p>%s</p><p>%s</p></div>';
		$messages = $this->getMessages();
		if( !$this->isPhpValid() ) {
			$rollbackMessage = sprintf( '<strong>'.$messages[6].'</strong>', '<a href="https://wordpress.org/plugins/wp-rollback/">WP Rollback</a>', $pluginName );
			printf( $noticeTemplate,
				sprintf( $messages[0], $pluginName ),
				sprintf( $messages[1], $messages[3].' '.$this->versions['php'] ),
				sprintf( $messages[2], PHP_VERSION ).'</p><p>'.$rollbackMessage
			);
		}
		else if( !$this->isWpValid() ) {
			printf( $noticeTemplate,
				sprintf( $messages[0], $pluginName ),
				sprintf( $messages[1], $messages[4].' '.$this->versions['wordpress'] ),
				sprintf( '<a href="%s">%s</a>', admin_url( 'update-core.php' ), $messages[5] )
			);
		}
	}
}