Inspection of "fix scrutinizer issues" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 836c6f...66df2e )

by Paul

created 2018-05-18 22:51 UTC

Status

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@  discard block
 block discarded – undo
  */
 function glsr( $alias = null ) {
 	$app = \GeminiLabs\SiteReviews\Application::load();
-	return empty( $alias )
+	return empty($alias)
 		? $app
 		: $app->make( $alias );
 }
@@ -16,10 +16,10 @@  discard block
 block discarded – undo
  * @return \WP_Screen|object
  */
 function glsr_current_screen() {
-	if( function_exists( 'get_current_screen' )) {
+	if( function_exists( 'get_current_screen' ) ) {
 		$screen = get_current_screen();
 	}
-	return empty( $screen )
+	return empty($screen)
 		? (object)array_fill_keys( ['base', 'id', 'post_type'], null )
 		: $screen;
 }
@@ -54,11 +54,11 @@  discard block
 block discarded – undo
  */
 function glsr_log() {
 	$args = func_get_args();
-	$context = isset( $args[1] )
+	$context = isset($args[1])
 		? $args[1]
 		: [];
 	$logger = glsr( 'Modules\Logger' );
-	return empty( $args )
+	return empty($args)
 		? $logger
 		: $logger->log( 'debug', $args[0], $context );
 }

Please login to merge, or discard this patch.

Braces +16 added lines, -8 removed lines patch added patch discarded remove patch

@@ -4,7 +4,8 @@  discard block
 block discarded – undo
 /**
  * @return mixed
  */
-function glsr( $alias = null ) {
+function glsr( $alias = null )
+{
 	$app = \GeminiLabs\SiteReviews\Application::load();
 	return empty( $alias )
 		? $app
@@ -15,7 +16,8 @@  discard block
 block discarded – undo
  * get_current_screen() is unreliable because it is not defined on all admin pages
  * @return \WP_Screen|object
  */
-function glsr_current_screen() {
+function glsr_current_screen()
+{
 	if( function_exists( 'get_current_screen' )) {
 		$screen = get_current_screen();
 	}
@@ -27,7 +29,8 @@  discard block
 block discarded – undo
 /**
  * @return \GeminiLabs\SiteReviews\Database
  */
-function glsr_db() {
+function glsr_db()
+{
 	return glsr( 'Database' );
 }
 
@@ -35,7 +38,8 @@  discard block
 block discarded – undo
  * @param mixed ...$vars
  * @return void
  */
-function glsr_debug( ...$vars ) {
+function glsr_debug( ...$vars )
+{
 	if( count( $vars ) == 1 ) {
 		$value = htmlspecialchars( print_r( $vars[0], true ), ENT_QUOTES, 'UTF-8' );
 		printf( '<div class="glsr-debug"><pre>%s</pre></div>', $value );
@@ -52,7 +56,8 @@  discard block
 block discarded – undo
 /**
  * @return \GeminiLabs\SiteReviews\Modules\Logger
  */
-function glsr_log() {
+function glsr_log()
+{
 	$args = func_get_args();
 	$context = isset( $args[1] )
 		? $args[1]
@@ -68,7 +73,8 @@  discard block
 block discarded – undo
  * @return void
  * @callback register_taxonomy() "meta_box_cb"
  */
-function glsr_categories_meta_box( $post, $box ) {
+function glsr_categories_meta_box( $post, $box )
+{
 	glsr( 'Controllers\EditorController' )->renderTaxonomyMetabox( $post, $box );
 }
 
@@ -77,14 +83,16 @@  discard block
 block discarded – undo
  * @param mixed $fallback
  * @return string|array
  */
-function glsr_get_option( $option_path = '', $fallback = '' ) {
+function glsr_get_option( $option_path = '', $fallback = '' )
+{
 	return glsr( 'Database\OptionManager' )->get( 'settings.'.$option_path, $fallback );
 }
 
 /**
  * @return array
  */
-function glsr_get_options() {
+function glsr_get_options()
+{
 	return glsr( 'Database\OptionManager' )->get( 'settings' );
 }
 

Please login to merge, or discard this patch.

views/email/index.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@
 block discarded – undo
 <?php defined( 'WPINC' ) || die;
 
-include trailingslashit(__DIR__).'header.php';
-include trailingslashit(__DIR__).'body.php';
-include trailingslashit(__DIR__).'footer.php';
+include trailingslashit( __DIR__ ).'header.php';
+include trailingslashit( __DIR__ ).'body.php';
+include trailingslashit( __DIR__ ).'footer.php';

Please login to merge, or discard this patch.

views/email/header.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -4,6 +4,6 @@
 block discarded – undo
 <html>
 <head>
     <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
-    <title><?= wp_specialchars_decode( (string) get_option( 'blogname', '' ), ENT_QUOTES ); ?></title>
+    <title><?= wp_specialchars_decode( (string)get_option( 'blogname', '' ), ENT_QUOTES ); ?></title>
 </head>
 <body>

Please login to merge, or discard this patch.

views/pages/index.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -7,17 +7,17 @@
 block discarded – undo
 <?php
 
 	$html->renderNotices();
-	$html->renderPartial( 'tabs' , [
+	$html->renderPartial( 'tabs', [
 		'page' => $page,
 		'tab' => $currentTab,
 		'tabs' => $tabs,
-	]);
-	$html->renderPartial( 'sections' , [
+	] );
+	$html->renderPartial( 'sections', [
 		'page' => $page,
 		'section' => $currentSection,
 		'tab' => $currentTab,
 		'tabs' => $tabs,
-	]);
+	] );
 	$file = $currentSection ? $currentTab.'/'.$currentSection : $currentTab;
 	$file = trailingslashit( __DIR__ ).$page.'/'.$file.'.php';
 	$file = apply_filters( 'site-reviews/addon/views/file', $file, $view, $data );

Please login to merge, or discard this patch.

views/pages/addons/addons.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -8,12 +8,12 @@
 block discarded – undo
 	'link' => 'https://niftyplugins.com/addons/site-reviews-tripadvisor/',
 	'name' => 'tripadvisor',
 	'title' => 'Tripadvisor Reviews',
-]);
+] );
 glsr( 'Modules\Html' )->renderTemplate( 'addons/addon', [
 	'description' => __( 'Sync your Yelp reviews and display them on your site.', 'site-reviews' ),
 	'link' => 'https://niftyplugins.com/addons/site-reviews-yelp/',
 	'name' => 'yelp',
 	'title' => 'Yelp Reviews',
-]);
+] );
 ?>
 </div>

Please login to merge, or discard this patch.

views/translations/plural.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@
 block discarded – undo
 		<p>{{ data.s1 }}</p>
 		<p>{{ data.p1 }}</p>
 		<p class="row-actions">
-			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
+			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
 		</p>
 		<button type="button" class="toggle-row">
 			<span class="screen-reader-text"><?= __( 'Show custom translation', 'site-reviews' ); ?></span>

Please login to merge, or discard this patch.

views/translations/single.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@
 block discarded – undo
 	<td class="glsr-string-td1 column-primary">
 		<p>{{ data.s1 }}</p>
 		<p class="row-actions">
-			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
+			<span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
 		</p>
 		<button type="button" class="toggle-row">
 			<span class="screen-reader-text"><?= __( 'Show custom translation', 'site-reviews' ); ?></span>

Please login to merge, or discard this patch.

views/editor/metabox-categories.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
 		</ul>
 	</div>
 
-	<?php if( current_user_can( $taxonomy->cap->edit_terms )) : ?>
+	<?php if( current_user_can( $taxonomy->cap->edit_terms ) ) : ?>
 	<div id="<?= $tax_name; ?>-adder" class="wp-hidden-children">
 		<a id="<?= $tax_name; ?>-add-toggle" href="#<?= $tax_name; ?>-add" class="hide-if-no-js taxonomy-add-new">
 			<?= sprintf( '+ %s', $taxonomy->labels->add_new_item ); ?>
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 			<label class="screen-reader-text" for="new<?= $tax_name; ?>"><?= $taxonomy->labels->add_new_item; ?></label>
 			<input type="text" name="new<?= $tax_name; ?>" id="new<?= $tax_name; ?>" class="form-required form-input-tip" value="<?= esc_attr( $taxonomy->labels->new_item_name ); ?>" aria-required="true"/>
 			<input type="button" id="<?= $tax_name; ?>-add-submit" data-wp-lists="add:<?= $tax_name; ?>checklist:<?= $tax_name; ?>-add" class="button category-add-submit" value="<?= esc_attr( $taxonomy->labels->add_new_item ); ?>" />
-			<?php wp_nonce_field( 'add-' . $tax_name, '_ajax_nonce-add-' . $tax_name, false ); ?>
+			<?php wp_nonce_field( 'add-'.$tax_name, '_ajax_nonce-add-'.$tax_name, false ); ?>
 			<span id="<?= $tax_name; ?>-ajax-response"></span>
 		</div>
 	</div>

Please login to merge, or discard this patch.

views/index.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php defined( 'WPINC' ) || die;
 
 $file = sprintf( '%s/site-reviews/%s.php', get_stylesheet_directory(), $view );
-if( !file_exists( $file )) {
+if( !file_exists( $file ) ) {
 	$file = trailingslashit( __DIR__ )."{$view}.php";
 }
 $file = apply_filters( 'site-reviews/addon/views/file', $file, $view, $data );
 
-if( file_exists( $file )) {
+if( file_exists( $file ) ) {
 	include $file;
 }
 else {

Please login to merge, or discard this patch.

		@@ -6,7 +6,7 @@ discard block
		block discarded – undo
6	6	*/
7	7	function glsr( $alias = null ) {
8	8	$app = \GeminiLabs\SiteReviews\Application::load();
9		- return empty( $alias )
	9	+ return empty($alias)
10	10	? $app
11	11	: $app->make( $alias );
12	12	}
		@@ -16,10 +16,10 @@ discard block
		block discarded – undo
16	16	* @return \WP_Screen\|object
17	17	*/
18	18	function glsr_current_screen() {
19		- if( function_exists( 'get_current_screen' )) {
	19	+ if( function_exists( 'get_current_screen' ) ) {
20	20	$screen = get_current_screen();
21	21	}
22		- return empty( $screen )
	22	+ return empty($screen)
23	23	? (object)array_fill_keys( ['base', 'id', 'post_type'], null )
24	24	: $screen;
25	25	}
		@@ -54,11 +54,11 @@ discard block
		block discarded – undo
54	54	*/
55	55	function glsr_log() {
56	56	$args = func_get_args();
57		- $context = isset( $args[1] )
	57	+ $context = isset($args[1])
58	58	? $args[1]
59	59	: [];
60	60	$logger = glsr( 'Modules\Logger' );
61		- return empty( $args )
	61	+ return empty($args)
62	62	? $logger
63	63	: $logger->log( 'debug', $args[0], $context );
64	64	}

		@@ -4,7 +4,8 @@ discard block
		block discarded – undo
4	4	/**
5	5	* @return mixed
6	6	*/
7		-function glsr( $alias = null ) {
	7	+function glsr( $alias = null )
	8	+{
8	9	$app = \GeminiLabs\SiteReviews\Application::load();
9	10	return empty( $alias )
10	11	? $app
		@@ -15,7 +16,8 @@ discard block
		block discarded – undo
15	16	* get_current_screen() is unreliable because it is not defined on all admin pages
16	17	* @return \WP_Screen\|object
17	18	*/
18		-function glsr_current_screen() {
	19	+function glsr_current_screen()
	20	+{
19	21	if( function_exists( 'get_current_screen' )) {
20	22	$screen = get_current_screen();
21	23	}
		@@ -27,7 +29,8 @@ discard block
		block discarded – undo
27	29	/**
28	30	* @return \GeminiLabs\SiteReviews\Database
29	31	*/
30		-function glsr_db() {
	32	+function glsr_db()
	33	+{
31	34	return glsr( 'Database' );
32	35	}
33	36
		@@ -35,7 +38,8 @@ discard block
		block discarded – undo
35	38	* @param mixed ...$vars
36	39	* @return void
37	40	*/
38		-function glsr_debug( ...$vars ) {
	41	+function glsr_debug( ...$vars )
	42	+{
39	43	if( count( $vars ) == 1 ) {
40	44	$value = htmlspecialchars( print_r( $vars[0], true ), ENT_QUOTES, 'UTF-8' );
41	45	printf( '<div class="glsr-debug"><pre>%s</pre></div>', $value );
		@@ -52,7 +56,8 @@ discard block
		block discarded – undo
52	56	/**
53	57	* @return \GeminiLabs\SiteReviews\Modules\Logger
54	58	*/
55		-function glsr_log() {
	59	+function glsr_log()
	60	+{
56	61	$args = func_get_args();
57	62	$context = isset( $args[1] )
58	63	? $args[1]
		@@ -68,7 +73,8 @@ discard block
		block discarded – undo
68	73	* @return void
69	74	* @callback register_taxonomy() "meta_box_cb"
70	75	*/
71		-function glsr_categories_meta_box( $post, $box ) {
	76	+function glsr_categories_meta_box( $post, $box )
	77	+{
72	78	glsr( 'Controllers\EditorController' )->renderTaxonomyMetabox( $post, $box );
73	79	}
74	80
		@@ -77,14 +83,16 @@ discard block
		block discarded – undo
77	83	* @param mixed $fallback
78	84	* @return string\|array
79	85	*/
80		-function glsr_get_option( $option_path = '', $fallback = '' ) {
	86	+function glsr_get_option( $option_path = '', $fallback = '' )
	87	+{
81	88	return glsr( 'Database\OptionManager' )->get( 'settings.'.$option_path, $fallback );
82	89	}
83	90
84	91	/**
85	92	* @return array
86	93	*/
87		-function glsr_get_options() {
	94	+function glsr_get_options()
	95	+{
88	96	return glsr( 'Database\OptionManager' )->get( 'settings' );
89	97	}
90	98

		@@ -1,5 +1,5 @@
		block discarded – undo
1	1	<?php defined( 'WPINC' ) \|\| die;
2	2
3		-include trailingslashit(__DIR__).'header.php';
4		-include trailingslashit(__DIR__).'body.php';
5		-include trailingslashit(__DIR__).'footer.php';
	3	+include trailingslashit( __DIR__ ).'header.php';
	4	+include trailingslashit( __DIR__ ).'body.php';
	5	+include trailingslashit( __DIR__ ).'footer.php';

		@@ -4,6 +4,6 @@
		block discarded – undo
4	4	<html>
5	5	<head>
6	6	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
7		- <title><?= wp_specialchars_decode( (string) get_option( 'blogname', '' ), ENT_QUOTES ); ?></title>
	7	+ <title><?= wp_specialchars_decode( (string)get_option( 'blogname', '' ), ENT_QUOTES ); ?></title>
8	8	</head>
9	9	<body>

		@@ -7,17 +7,17 @@
		block discarded – undo
7	7	<?php
8	8
9	9	$html->renderNotices();
10		- $html->renderPartial( 'tabs' , [
	10	+ $html->renderPartial( 'tabs', [
11	11	'page' => $page,
12	12	'tab' => $currentTab,
13	13	'tabs' => $tabs,
14		- ]);
15		- $html->renderPartial( 'sections' , [
	14	+ ] );
	15	+ $html->renderPartial( 'sections', [
16	16	'page' => $page,
17	17	'section' => $currentSection,
18	18	'tab' => $currentTab,
19	19	'tabs' => $tabs,
20		- ]);
	20	+ ] );
21	21	$file = $currentSection ? $currentTab.'/'.$currentSection : $currentTab;
22	22	$file = trailingslashit( __DIR__ ).$page.'/'.$file.'.php';
23	23	$file = apply_filters( 'site-reviews/addon/views/file', $file, $view, $data );

		@@ -8,12 +8,12 @@
		block discarded – undo
8	8	'link' => 'https://niftyplugins.com/addons/site-reviews-tripadvisor/',
9	9	'name' => 'tripadvisor',
10	10	'title' => 'Tripadvisor Reviews',
11		-]);
	11	+] );
12	12	glsr( 'Modules\Html' )->renderTemplate( 'addons/addon', [
13	13	'description' => __( 'Sync your Yelp reviews and display them on your site.', 'site-reviews' ),
14	14	'link' => 'https://niftyplugins.com/addons/site-reviews-yelp/',
15	15	'name' => 'yelp',
16	16	'title' => 'Yelp Reviews',
17		-]);
	17	+] );
18	18	?>
19	19	</div>

		@@ -3,7 +3,7 @@
		block discarded – undo
3	3	<p>{{ data.s1 }}</p>
4	4	<p>{{ data.p1 }}</p>
5	5	<p class="row-actions">
6		- <span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
	6	+ <span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
7	7	</p>
8	8	<button type="button" class="toggle-row">
9	9	<span class="screen-reader-text"><?= __( 'Show custom translation', 'site-reviews' ); ?></span>

		@@ -2,7 +2,7 @@
		block discarded – undo
2	2	<td class="glsr-string-td1 column-primary">
3	3	<p>{{ data.s1 }}</p>
4	4	<p class="row-actions">
5		- <span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' );?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
	5	+ <span class="delete"><a href="#{{ data.index }}" class="delete" aria-label="<?= __( 'Delete translation string', 'site-reviews' ); ?>"><?= __( 'Delete', 'site-reviews' ); ?></a></span>
6	6	</p>
7	7	<button type="button" class="toggle-row">
8	8	<span class="screen-reader-text"><?= __( 'Show custom translation', 'site-reviews' ); ?></span>

		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	</ul>
21	21	</div>
22	22
23		- <?php if( current_user_can( $taxonomy->cap->edit_terms )) : ?>
	23	+ <?php if( current_user_can( $taxonomy->cap->edit_terms ) ) : ?>
24	24	<div id="<?= $tax_name; ?>-adder" class="wp-hidden-children">
25	25	<a id="<?= $tax_name; ?>-add-toggle" href="#<?= $tax_name; ?>-add" class="hide-if-no-js taxonomy-add-new">
26	26	<?= sprintf( '+ %s', $taxonomy->labels->add_new_item ); ?>
		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	<label class="screen-reader-text" for="new<?= $tax_name; ?>"><?= $taxonomy->labels->add_new_item; ?></label>
30	30	<input type="text" name="new<?= $tax_name; ?>" id="new<?= $tax_name; ?>" class="form-required form-input-tip" value="<?= esc_attr( $taxonomy->labels->new_item_name ); ?>" aria-required="true"/>
31	31	<input type="button" id="<?= $tax_name; ?>-add-submit" data-wp-lists="add:<?= $tax_name; ?>checklist:<?= $tax_name; ?>-add" class="button category-add-submit" value="<?= esc_attr( $taxonomy->labels->add_new_item ); ?>" />
32		- <?php wp_nonce_field( 'add-' . $tax_name, '_ajax_nonce-add-' . $tax_name, false ); ?>
	32	+ <?php wp_nonce_field( 'add-'.$tax_name, '_ajax_nonce-add-'.$tax_name, false ); ?>
33	33	<span id="<?= $tax_name; ?>-ajax-response"></span>
34	34	</div>
35	35	</div>

		@@ -1,12 +1,12 @@
		block discarded – undo
1	1	<?php defined( 'WPINC' ) \|\| die;
2	2
3	3	$file = sprintf( '%s/site-reviews/%s.php', get_stylesheet_directory(), $view );
4		-if( !file_exists( $file )) {
	4	+if( !file_exists( $file ) ) {
5	5	$file = trailingslashit( __DIR__ )."{$view}.php";
6	6	}
7	7	$file = apply_filters( 'site-reviews/addon/views/file', $file, $view, $data );
8	8
9		-if( file_exists( $file )) {
	9	+if( file_exists( $file ) ) {
10	10	include $file;
11	11	}
12	12	else {

pryley / site-reviews

Push — master ( 836c6f...66df2e )

Status

Category

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Braces +16 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch