+/scripts/public/recaptcha.js - Code Metrics - Inspection of "fix recaptcha" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 81c350...2e0505 )

by Paul

created 2018-06-24 19:14 UTC

+/scripts/public/recaptcha.js B

↳ Parent: Project

Complexity

Conditions	1
Paths	2

Size

Total Lines

113

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
nc	2
nop	0
dl	0
loc	113
rs	7
c	2
b	0
f	0

11 Functions

Rating	Name	Size	Complexity
A	GLSR.Recaptcha	3	1
A	GLSR.Recaptcha.render_	12	2
A	GLSR.Recaptcha.onKeyup_	5	2
A	GLSR.Recaptcha.getId_	8	1
A	GLSR.Recaptcha.getOverlay_	12	1
A	GLSR.Recaptcha.removeListeners_	4	1
A	GLSR.Recaptcha.execute_	9	2
A	GLSR.Recaptcha.search_	14	5
A	GLSR.Recaptcha.reset_	6	2
A	GLSR.Recaptcha.addListeners_	6	2
A	GLSR.Recaptcha.submitForm_	3	1

How to fix Long Method

/** global: GLSR, grecaptcha */
;(function() {

	'use strict';

	GLSR.Recaptcha = function( form ) { // Form object
		this.Form = form;
	};

	GLSR.Recaptcha.prototype = {
		config: {
			recaptchaSelector: '.glsr-recaptcha-holder',
		},

		/** @return void */
		addListeners_: function() {
			var overlayEl = this.getOverlay_();
			if( overlayEl === -1 )return;
			overlayEl.addEventListener( 'click', this.Form.enableButton_ );
			window.addEventListener( 'keyup', this.onKeyup_.bind( this, overlayEl ));
		},

		/** @return void */
		execute_: function() {
			var recaptchaId = this.getId_();
			if( recaptchaId !== -1 ) {
				grecaptcha.execute( recaptchaId );
				return;
			}
			// recaptcha ID not found so pass through an error
			this.Form.submitForm_( false );
		},

		/** @return string|int (-1) */
		getId_: function() {
			return this.search_( function( value, id ) {
				if( Object.prototype.toString.call( value ) !== '[object HTMLDivElement]' )return;
				if( value.closest( 'form' ) === this.Form.form ) {
					return id;
				}
			}.bind( this ));
		},

		/** @return HTMLDivElement|int (-1) */
		getOverlay_: function() {
			return this.search_( function( value ) {
				if( Object.prototype.toString.call( value ) !== '[object Object]' )return;
				for( var obj in value) {
					if( !value.hasOwnProperty( obj ) || Object.prototype.toString.call( value[obj] ) !== '[object HTMLDivElement]' )continue;
					if( value[obj].className === '' ) {
						return value[obj].firstChild;
					}
				}
				return false;
			}.bind( this ));

		},

		/** @return void */
		onKeyup_: function( ev ) { // KeyboardEvent
			if( ev.keyCode !== 27 )return;
			this.Form.enableButton_();
			this.removeListeners_( ev.target );
		},

		/** @return void */
		removeListeners_: function( overlayEl ) { // HTMLDivElement
			overlayEl.removeEventListener( 'click', this.Form.enableButton_ );
			window.removeEventListener( 'keyup', this.onKeyup_ );
		},

		/** @return void */
		render_: function() {
			this.Form.form.onsubmit = null;
			var recaptchaEl = this.Form.form.querySelector( this.config.recaptchaSelector );
			if( !recaptchaEl )return;
			recaptchaEl.innerHTML = '';
			var id = grecaptcha.render( recaptchaEl, {
				callback: this.submitForm_.bind( this ),
				'expired-callback': function() {
					grecaptcha.reset( id );
				},
			}, true );
		},

		/** @return void */
		reset_: function() {
			var recaptchaId = this.getId_();
			if( recaptchaId !== -1 ) {
				grecaptcha.reset( recaptchaId );
			}
		},

		/** @return mixed|int (-1) */
		search_: function( callback ) { // function
			var result = -1;
			if( window.hasOwnProperty( '___grecaptcha_cfg' )) {
				var clients = window.___grecaptcha_cfg.clients;
				var i, key;
				for( i in clients ) {
					for( key in clients[i] ) {
						if( !( result = callback( clients[i][key], i )))continue;
						return result;
					}
				}
			}
			return result;
		},

		/** @return void */
		submitForm_: function( token ) { // string
			this.Form.submitForm_( token );
		},
	};
})();


1			/** global: GLSR, grecaptcha */
2			;(function() {
3
4			'use strict';
5
6			GLSR.Recaptcha = function( form ) { // Form object
7			this.Form = form;
8			};
9
10			GLSR.Recaptcha.prototype = {
11			config: {
12			recaptchaSelector: '.glsr-recaptcha-holder',
13			},
14
15			/** @return void */
16			addListeners_: function() {
17			var overlayEl = this.getOverlay_();
18			if( overlayEl === -1 )return;
19			overlayEl.addEventListener( 'click', this.Form.enableButton_ );
20			window.addEventListener( 'keyup', this.onKeyup_.bind( this, overlayEl ));
21			},
22
23			/** @return void */
24			execute_: function() {
25			var recaptchaId = this.getId_();
26			if( recaptchaId !== -1 ) {
27			grecaptcha.execute( recaptchaId );
28			return;
29			}
30			// recaptcha ID not found so pass through an error
31			this.Form.submitForm_( false );
32			},
33
34			/** @return string\|int (-1) */
35			getId_: function() {
36			return this.search_( function( value, id ) {
37			if( Object.prototype.toString.call( value ) !== '[object HTMLDivElement]' )return;
38			if( value.closest( 'form' ) === this.Form.form ) {
39			return id;
40			}
41			}.bind( this ));
42			},
43
44			/** @return HTMLDivElement\|int (-1) */
45			getOverlay_: function() {
46			return this.search_( function( value ) {
47			if( Object.prototype.toString.call( value ) !== '[object Object]' )return;
48			for( var obj in value) {
49			if( !value.hasOwnProperty( obj ) \|\| Object.prototype.toString.call( value[obj] ) !== '[object HTMLDivElement]' )continue;
50			if( value[obj].className === '' ) {
51			return value[obj].firstChild;
52			}
53			}
54			return false;
55			}.bind( this ));
			0 ignored issues – show unused-code introduced 2018-06-24 19:19 UTC by Report Bug Copy Issue Report The call to `bind` does not seem necessary since the function does not use `this`. Consider calling it directly. Loading history...
56			},
57
58			/** @return void */
59			onKeyup_: function( ev ) { // KeyboardEvent
60			if( ev.keyCode !== 27 )return;
61			this.Form.enableButton_();
62			this.removeListeners_( ev.target );
63			},
64
65			/** @return void */
66			removeListeners_: function( overlayEl ) { // HTMLDivElement
67			overlayEl.removeEventListener( 'click', this.Form.enableButton_ );
68			window.removeEventListener( 'keyup', this.onKeyup_ );
69			},
70
71			/** @return void */
72			render_: function() {
73			this.Form.form.onsubmit = null;
74			var recaptchaEl = this.Form.form.querySelector( this.config.recaptchaSelector );
75			if( !recaptchaEl )return;
76			recaptchaEl.innerHTML = '';
77			var id = grecaptcha.render( recaptchaEl, {
78			callback: this.submitForm_.bind( this ),
79			'expired-callback': function() {
80			grecaptcha.reset( id );
81			},
82			}, true );
83			},
84
85			/** @return void */
86			reset_: function() {
87			var recaptchaId = this.getId_();
88			if( recaptchaId !== -1 ) {
89			grecaptcha.reset( recaptchaId );
90			}
91			},
92
93			/** @return mixed\|int (-1) */
94			search_: function( callback ) { // function
95			var result = -1;
96			if( window.hasOwnProperty( '___grecaptcha_cfg' )) {
97			var clients = window.___grecaptcha_cfg.clients;
98			var i, key;
99			for( i in clients ) {
100			for( key in clients[i] ) {
101			if( !( result = callback( clients[i][key], i )))continue;
102			return result;
103			}
104			}
105			}
106			return result;
107			},
108
109			/** @return void */
110			submitForm_: function( token ) { // string
111			this.Form.submitForm_( token );
112			},
113			};
114			})();
115

pryley / site-reviews

Push — master ( 81c350...2e0505 )

+/scripts/public/recaptcha.js B

Complexity

Size

Duplication

Importance

11 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like