Issues in RWMetaBox.php (develop) - Issues in develop - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Settings/RWMetaBox.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace GeminiLabs\Pollux\Settings;

use GeminiLabs\Pollux\Helper;
use RW_Meta_Box;
use RWMB_Helpers_Field;

class RWMetaBox extends RW_Meta_Box
{
	protected $pollux_caller;
	protected $pollux_id;

	public function __construct( $metabox, $id = null, $caller )
	{
		parent::__construct( $metabox );
		$this->meta_box = static::normalize( $this->meta_box );

		$this->pollux_caller = $caller;
		$this->pollux_id = $id;

		remove_action( 'add_meta_boxes', [$this, 'add_meta_boxes'] );
		remove_action( 'save_post_post', [$this, 'save_post'] );

		add_action( 'pollux/archives/init', [$this, 'add_meta_boxes'] );
		add_action( 'pollux/settings/init', [$this, 'add_meta_boxes'] );
		add_filter( 'rwmb_field_meta',      [$this, '_get_field_meta'], 10, 3 );
		add_filter( 'rwmb_normalize_field', [$this, '_normalize_field'] );
	}

	/**
	 * @param mixed $meta
	 * @param bool $meta
	 * @return mixed
	 * @filter rwmb_field_meta
	 */
	public function _get_field_meta( $meta, array $field, $saved )
	{
		if( !$this->is_edit_screen() || !empty( Helper::toArray( $meta )) || empty( $field['slug'] )) {
			return $meta;
		}
		$meta = call_user_func( [RWMB_Helpers_Field::get_class( $field ), 'esc_meta'], ( $saved
			? $this->pollux_caller->getMetaValue( $field['slug'], $meta, $this->meta_box['slug'] )
			: $field['std']
		));
		return $this->_normalize_field_meta( $meta, $field );
	}

	/**
	 * @return array
	 */
	public function _normalize_field( array $field )
	{
		if( !empty( $field['multiple'] ) && $field['id'] == substr( $field['field_name'], 0, -2 )) {
			$parts = array_filter( explode( '-', $field['id'] ));
			$first = array_shift( $parts );
			$field['field_name'] = array_reduce( $parts, function( $carry, $part ) {
				return sprintf( '%s[%s]', $carry, $part );
			}, $first ) . '[]';
		}
		return $field;
	}

	/**
	 * @param mixed $meta
	 * @return array
	 */
	public function _normalize_field_meta( $meta, array $field )
	{
		if( !empty( $meta ) && is_array( $meta )) {
			return $meta;
		}
		if( $field['clone'] ) {
			return [''];
		}
		if( $field['multiple'] ) {
			return [];
		}
		return $meta;
	}

	/**
	 * @return void
	 * @action pollux/archives/init
	 * @action pollux/settings/init
	 */
	public function add_meta_boxes()
	{
		add_meta_box(
			$this->meta_box['id'],
			$this->meta_box['title'],
			[$this, 'show'],
			null,
			$this->meta_box['context'],
			$this->meta_box['priority']
		);
	}

	/**
	 * @return bool
	 */
	public function is_edit_screen( $screen = null )
	{
		return get_current_screen()->id == $this->pollux_caller->hook;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	}

	/**
	 * @return bool
	 */
	public function is_saved()
	{
		foreach( array_column( $this->fields, 'slug' ) as $field ) {
			if( !is_null( $this->pollux_caller->getMetaValue( $field, null, $this->meta_box['slug'] ))) {
				return true;
			}
		}
		return false;
	}

	/**
	 * @param array $metabox
	 * @return array
	 */
	public static function normalize( $metabox )
	{
		$metabox = parent::normalize( $metabox );
		$metabox['post_types'] = [];
		return wp_parse_args( $metabox, ['slug' => ''] );
	}
}


1			<?php
2
3			namespace GeminiLabs\Pollux\Settings;
4
5			use GeminiLabs\Pollux\Helper;
6			use RW_Meta_Box;
7			use RWMB_Helpers_Field;
8
9			class RWMetaBox extends RW_Meta_Box
10			{
11			protected $pollux_caller;
12			protected $pollux_id;
13
14			public function __construct( $metabox, $id = null, $caller )
15			{
16			parent::__construct( $metabox );
17			$this->meta_box = static::normalize( $this->meta_box );
18
19			$this->pollux_caller = $caller;
20			$this->pollux_id = $id;
21
22			remove_action( 'add_meta_boxes', [$this, 'add_meta_boxes'] );
23			remove_action( 'save_post_post', [$this, 'save_post'] );
24
25			add_action( 'pollux/archives/init', [$this, 'add_meta_boxes'] );
26			add_action( 'pollux/settings/init', [$this, 'add_meta_boxes'] );
27			add_filter( 'rwmb_field_meta', [$this, '_get_field_meta'], 10, 3 );
28			add_filter( 'rwmb_normalize_field', [$this, '_normalize_field'] );
29			}
30
31			/**
32			* @param mixed $meta
33			* @param bool $meta
34			* @return mixed
35			* @filter rwmb_field_meta
36			*/
37			public function _get_field_meta( $meta, array $field, $saved )
38			{
39			if( !$this->is_edit_screen() \|\| !empty( Helper::toArray( $meta )) \|\| empty( $field['slug'] )) {
40			return $meta;
41			}
42			$meta = call_user_func( [RWMB_Helpers_Field::get_class( $field ), 'esc_meta'], ( $saved
43			? $this->pollux_caller->getMetaValue( $field['slug'], $meta, $this->meta_box['slug'] )
44			: $field['std']
45			));
46			return $this->_normalize_field_meta( $meta, $field );
47			}
48
49			/**
50			* @return array
51			*/
52			public function _normalize_field( array $field )
53			{
54			if( !empty( $field['multiple'] ) && $field['id'] == substr( $field['field_name'], 0, -2 )) {
55			$parts = array_filter( explode( '-', $field['id'] ));
56			$first = array_shift( $parts );
57			$field['field_name'] = array_reduce( $parts, function( $carry, $part ) {
58			return sprintf( '%s[%s]', $carry, $part );
59			}, $first ) . '[]';
60			}
61			return $field;
62			}
63
64			/**
65			* @param mixed $meta
66			* @return array
67			*/
68			public function _normalize_field_meta( $meta, array $field )
69			{
70			if( !empty( $meta ) && is_array( $meta )) {
71			return $meta;
72			}
73			if( $field['clone'] ) {
74			return [''];
75			}
76			if( $field['multiple'] ) {
77			return [];
78			}
79			return $meta;
80			}
81
82			/**
83			* @return void
84			* @action pollux/archives/init
85			* @action pollux/settings/init
86			*/
87			public function add_meta_boxes()
88			{
89			add_meta_box(
90			$this->meta_box['id'],
91			$this->meta_box['title'],
92			[$this, 'show'],
93			null,
94			$this->meta_box['context'],
95			$this->meta_box['priority']
96			);
97			}
98
99			/**
100			* @return bool
101			*/
102			public function is_edit_screen( $screen = null )
103			{
104			return get_current_screen()->id == $this->pollux_caller->hook;
			0 ignored issues – show Bug introduced 2019-01-28 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `get_current_screen()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
105			}
106
107			/**
108			* @return bool
109			*/
110			public function is_saved()
111			{
112			foreach( array_column( $this->fields, 'slug' ) as $field ) {
113			if( !is_null( $this->pollux_caller->getMetaValue( $field, null, $this->meta_box['slug'] ))) {
114			return true;
115			}
116			}
117			return false;
118			}
119
120			/**
121			* @param array $metabox
122			* @return array
123			*/
124			public static function normalize( $metabox )
125			{
126			$metabox = parent::normalize( $metabox );
127			$metabox['post_types'] = [];
128			return wp_parse_args( $metabox, ['slug' => ''] );
129			}
130			}
131

pryley / pollux

Issues (37)

Security Analysis not enabled

src/Settings/RWMetaBox.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like