Issues in SiteMetaManager.php (develop) - Issues in develop - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/MetaBox/SiteMetaManager.php (2 issues)

Severity

Unknown 2

<?php

namespace GeminiLabs\Pollux\MetaBox;

use GeminiLabs\Pollux\Settings\Settings;

/**
 * SiteMeta::all();
 * SiteMeta::group();
 * SiteMeta::group('option','fallback');
 * SiteMeta::get('group');
 * SiteMeta::get('group','option','fallback');
 *
 * @property object all
 */
class SiteMetaManager
{
	protected $options;

	public function __construct()
	{
		$this->options = get_option( Settings::id(), [] );
	}

	/**
	 * @param string $group
	 * @return object|array|null
	 */
	public function __call( $group, $args )
	{
		$args = array_pad( $args, 2, null );
		$group = $this->$group;
		if( is_object( $group )) {
			return $group;
		}
		return $this->get( $group, $args[0], $args[1] );
	}

	/**
	 * @param string $group
	 * @return object|array|null
	 */
	public function __get( $group )
	{
		if( $group == 'all' ) {
			return (object) $this->options;
		}
		if( empty( $group )) {
			$group = $this->getDefaultGroup();
		}
		if( is_array( $group )) {

			$group = reset( $group );
		}
		return isset( $this->options[$group] )
			? $this->options[$group]
			: null;
	}

	/**
	 * @param string $group
	 * @param string|null $key
	 * @param mixed $fallback
	 * @return mixed
	 */
	public function get( $group = '', $key = '', $fallback = null )
	{
		if( func_num_args() < 1 ) {
			return $this->all;
		}
		if( is_string( $group )) {

			$group = $this->$group;
		}
		if( !is_array( $group )) {
			return $fallback;
		}
		if( is_null( $key )) {
			return $group;
		}
		return $this->getValue( $group, $key, $fallback );
	}

	/**
	 * @return string
	 */
	protected function getDefaultGroup()
	{
		return '';
	}

	/**
	 * @param string $key
	 * @param mixed $fallback
	 * @return mixed
	 */
	protected function getValue( array $group, $key, $fallback )
	{
		if( !array_key_exists( $key, $group )) {
			return $fallback;
		}
		return empty( $group[$key] ) && !is_null( $fallback )
			? $fallback
			: $group[$key];
	}
}


1			<?php
2
3			namespace GeminiLabs\Pollux\MetaBox;
4
5			use GeminiLabs\Pollux\Settings\Settings;
6
7			/**
8			* SiteMeta::all();
9			* SiteMeta::group();
10			* SiteMeta::group('option','fallback');
11			* SiteMeta::get('group');
12			* SiteMeta::get('group','option','fallback');
13			*
14			* @property object all
15			*/
16			class SiteMetaManager
17			{
18			protected $options;
19
20			public function __construct()
21			{
22			$this->options = get_option( Settings::id(), [] );
23			}
24
25			/**
26			* @param string $group
27			* @return object\|array\|null
28			*/
29			public function __call( $group, $args )
30			{
31			$args = array_pad( $args, 2, null );
32			$group = $this->$group;
33			if( is_object( $group )) {
34			return $group;
35			}
36			return $this->get( $group, $args[0], $args[1] );
37			}
38
39			/**
40			* @param string $group
41			* @return object\|array\|null
42			*/
43			public function __get( $group )
44			{
45			if( $group == 'all' ) {
46			return (object) $this->options;
47			}
48			if( empty( $group )) {
49			$group = $this->getDefaultGroup();
50			}
51			if( is_array( $group )) {
			0 ignored issues – show introduced 2019-01-28 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `is_array($group)` is always `false`. Loading history...
52			$group = reset( $group );
53			}
54			return isset( $this->options[$group] )
55			? $this->options[$group]
56			: null;
57			}
58
59			/**
60			* @param string $group
61			* @param string\|null $key
62			* @param mixed $fallback
63			* @return mixed
64			*/
65			public function get( $group = '', $key = '', $fallback = null )
66			{
67			if( func_num_args() < 1 ) {
68			return $this->all;
69			}
70			if( is_string( $group )) {
			0 ignored issues – show introduced 2019-01-28 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `is_string($group)` is always `true`. Loading history...
71			$group = $this->$group;
72			}
73			if( !is_array( $group )) {
74			return $fallback;
75			}
76			if( is_null( $key )) {
77			return $group;
78			}
79			return $this->getValue( $group, $key, $fallback );
80			}
81
82			/**
83			* @return string
84			*/
85			protected function getDefaultGroup()
86			{
87			return '';
88			}
89
90			/**
91			* @param string $key
92			* @param mixed $fallback
93			* @return mixed
94			*/
95			protected function getValue( array $group, $key, $fallback )
96			{
97			if( !array_key_exists( $key, $group )) {
98			return $fallback;
99			}
100			return empty( $group[$key] ) && !is_null( $fallback )
101			? $fallback
102			: $group[$key];
103			}
104			}
105

pryley / pollux

Issues (37)

Security Analysis not enabled

src/MetaBox/SiteMetaManager.php (2 issues)

Severity

Introduced By

Duplication Side-by-Side

Filter issues like